From 1474b46ff01994ef539036e27af842404f5fd65d Mon Sep 17 00:00:00 2001 From: Aine Date: Fri, 6 Sep 2024 00:15:00 +0300 Subject: [PATCH] Put version into the manifest.json on CI builds (Docker, CDN, etc.) This commit fixes the https://github.com/Awesome-Technologies/synapse-admin/issues/507 issue. While it's a mere workaround, it may help until the https://github.com/Awesome-Technologies/synapse-admin/issues/507#issuecomment-2063845882 is implemented --- .github/workflows/workflow.yml | 4 +++- README.md | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index f6a8318..06a6784 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -4,7 +4,7 @@ on: branches: [ "main" ] env: upstream_version: v0.10.3 - etke_version: etke10 + etke_version: etke11 bunny_version: v0.1.0 base_path: ./ permissions: @@ -26,6 +26,8 @@ jobs: cache: yarn - name: Install dependencies run: yarn install --immutable --network-timeout=300000 + - name: Set version into manifest.json + run: sed -i 's|"icons"|"version": "${{ env.upstream_version }}-${{ env.etke_version }}",\n "icons"|g' public/manifest.json - name: Build run: yarn build --base=${{ env.base_path }} - uses: actions/upload-artifact@v4 diff --git a/README.md b/README.md index 25c36b5..43de180 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,7 @@ The following changes are already implemented: * [Fix redirect URL after user creation](https://github.com/etkecc/synapse-admin/pull/16) * [Display actual Synapse errors](https://github.com/etkecc/synapse-admin/pull/17) * [Fix base_url being undefined on unsuccessful login](https://github.com/etkecc/synapse-admin/pull/18) +* [Put the version into manifest.json](https://github.com/Awesome-Technologies/synapse-admin/issues/507) (CI only) _the list will be updated as new changes are added_