mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-20 09:19:54 +03:00
Code Issues Projects Releases Packages Wiki Activity

Migrated CrossDomainMiddlewareTest to use PHPUnit mocks

Browse source
This commit is contained in:
Alejandro Celaya 2022-10-23 22:47:34 +02:00
parent b2b424a4ed
commit dfc8e8d74e
1 changed files with 13 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
module/Rest/test/Middleware/CrossDomainMiddlewareTest.php
View file

@ -6,33 +6,29 @@ namespace ShlinkioTest\Shlink\Rest\Middleware;
use Laminas\Diactoros\Response; use Laminas\Diactoros\Response;
use Laminas\Diactoros\ServerRequest; use Laminas\Diactoros\ServerRequest;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Http\Server\RequestHandlerInterface; use Psr\Http\Server\RequestHandlerInterface;
use Shlinkio\Shlink\Rest\Middleware\CrossDomainMiddleware; use Shlinkio\Shlink\Rest\Middleware\CrossDomainMiddleware;
class CrossDomainMiddlewareTest extends TestCase class CrossDomainMiddlewareTest extends TestCase
{ {
use ProphecyTrait;
private CrossDomainMiddleware $middleware; private CrossDomainMiddleware $middleware;
private ObjectProphecy $handler; private MockObject $handler;
protected function setUp(): void protected function setUp(): void
{ {
$this->middleware = new CrossDomainMiddleware(['max_age' => 1000]); $this->middleware = new CrossDomainMiddleware(['max_age' => 1000]);
$this->handler = $this->prophesize(RequestHandlerInterface::class); $this->handler = $this->createMock(RequestHandlerInterface::class);
} }
/** @test */ /** @test */
public function nonCrossDomainRequestsAreNotAffected(): void public function nonCrossDomainRequestsAreNotAffected(): void
{ {
$originalResponse = (new Response())->withStatus(404); $originalResponse = (new Response())->withStatus(404);
$this->handler->handle(Argument::any())->willReturn($originalResponse)->shouldBeCalledOnce(); $this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
$response = $this->middleware->process(new ServerRequest(), $this->handler->reveal()); $response = $this->middleware->process(new ServerRequest(), $this->handler);
$headers = $response->getHeaders(); $headers = $response->getHeaders();
self::assertSame($originalResponse, $response); self::assertSame($originalResponse, $response);
@ -47,12 +43,9 @@ class CrossDomainMiddlewareTest extends TestCase
public function anyRequestIncludesTheAllowAccessHeader(): void public function anyRequestIncludesTheAllowAccessHeader(): void
{ {
$originalResponse = new Response(); $originalResponse = new Response();
$this->handler->handle(Argument::any())->willReturn($originalResponse)->shouldBeCalledOnce(); $this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
$response = $this->middleware->process( $response = $this->middleware->process((new ServerRequest())->withHeader('Origin', 'local'), $this->handler);
(new ServerRequest())->withHeader('Origin', 'local'),
$this->handler->reveal(),
);
self::assertNotSame($originalResponse, $response); self::assertNotSame($originalResponse, $response);
$headers = $response->getHeaders(); $headers = $response->getHeaders();
@ -71,9 +64,9 @@ class CrossDomainMiddlewareTest extends TestCase
->withMethod('OPTIONS') ->withMethod('OPTIONS')
->withHeader('Origin', 'local') ->withHeader('Origin', 'local')
->withHeader('Access-Control-Request-Headers', 'foo, bar, baz'); ->withHeader('Access-Control-Request-Headers', 'foo, bar, baz');
$this->handler->handle(Argument::any())->willReturn($originalResponse)->shouldBeCalledOnce(); $this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
$response = $this->middleware->process($request, $this->handler->reveal()); $response = $this->middleware->process($request, $this->handler);
self::assertNotSame($originalResponse, $response); self::assertNotSame($originalResponse, $response);
$headers = $response->getHeaders(); $headers = $response->getHeaders();
@ -99,9 +92,9 @@ class CrossDomainMiddlewareTest extends TestCase
} }
$request = (new ServerRequest())->withHeader('Origin', 'local') $request = (new ServerRequest())->withHeader('Origin', 'local')
->withMethod('OPTIONS'); ->withMethod('OPTIONS');
$this->handler->handle(Argument::any())->willReturn($originalResponse)->shouldBeCalledOnce(); $this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
$response = $this->middleware->process($request, $this->handler->reveal()); $response = $this->middleware->process($request, $this->handler);
self::assertEquals($response->getHeaderLine('Access-Control-Allow-Methods'), $expectedAllowedMethods); self::assertEquals($response->getHeaderLine('Access-Control-Allow-Methods'), $expectedAllowedMethods);
self::assertEquals(204, $response->getStatusCode()); self::assertEquals(204, $response->getStatusCode());
@ -126,9 +119,9 @@ class CrossDomainMiddlewareTest extends TestCase
$originalResponse = (new Response())->withStatus($status); $originalResponse = (new Response())->withStatus($status);
$request = (new ServerRequest())->withMethod($method) $request = (new ServerRequest())->withMethod($method)
->withHeader('Origin', 'local'); ->withHeader('Origin', 'local');
$this->handler->handle(Argument::any())->willReturn($originalResponse)->shouldBeCalledOnce(); $this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
$response = $this->middleware->process($request, $this->handler->reveal()); $response = $this->middleware->process($request, $this->handler);
self::assertEquals($expectedStatus, $response->getStatusCode()); self::assertEquals($expectedStatus, $response->getStatusCode());
} }