mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-03-30 21:35:18 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add API test for short URL creation with device long URLs

Browse source
This commit is contained in:
Alejandro Celaya 2023-01-22 11:36:00 +01:00
parent 39adef8ab8
commit d3590234a3
1 changed files with 43 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
module/Rest/test-api/Action/CreateShortUrlTest.php
View file

@ -118,7 +118,7 @@ class CreateShortUrlTest extends ApiTestCase
public function provideMaxVisits(): array public function provideMaxVisits(): array
{ {
return map(range(10, 15), fn (int $i) => [$i]); return map(range(10, 15), fn(int $i) => [$i]);
} }
/** @test */ /** @test */
@ -172,12 +172,14 @@ class CreateShortUrlTest extends ApiTestCase
yield 'only long URL' => [['longUrl' => $longUrl]]; yield 'only long URL' => [['longUrl' => $longUrl]];
yield 'long URL and tags' => [['longUrl' => $longUrl, 'tags' => ['boo', 'far']]]; yield 'long URL and tags' => [['longUrl' => $longUrl, 'tags' => ['boo', 'far']]];
yield 'long URL and custom slug' => [['longUrl' => $longUrl, 'customSlug' => 'my cool slug']]; yield 'long URL and custom slug' => [['longUrl' => $longUrl, 'customSlug' => 'my cool slug']];
yield 'several params' => [[ yield 'several params' => [
'longUrl' => $longUrl, [
'tags' => ['boo', 'far'], 'longUrl' => $longUrl,
'validSince' => Chronos::now()->toAtomString(), 'tags' => ['boo', 'far'],
'maxVisits' => 7, 'validSince' => Chronos::now()->toAtomString(),
]]; 'maxVisits' => 7,
]
];
} }
/** /**
@ -269,12 +271,12 @@ class CreateShortUrlTest extends ApiTestCase
* @test * @test
* @dataProvider provideInvalidArgumentApiVersions * @dataProvider provideInvalidArgumentApiVersions
*/ */
public function failsToCreateShortUrlWithoutLongUrl(string $version, string $expectedType): void public function failsToCreateShortUrlWithoutLongUrl(array $payload, string $version, string $expectedType): void
{ {
$resp = $this->callApiWithKey( $resp = $this->callApiWithKey(
self::METHOD_POST, self::METHOD_POST,
sprintf('/rest/v%s/short-urls', $version), sprintf('/rest/v%s/short-urls', $version),
[RequestOptions::JSON => []], [RequestOptions::JSON => $payload],
); );
$payload = $this->getJsonResponsePayload($resp); $payload = $this->getJsonResponsePayload($resp);
@ -287,8 +289,22 @@ class CreateShortUrlTest extends ApiTestCase
public function provideInvalidArgumentApiVersions(): iterable public function provideInvalidArgumentApiVersions(): iterable
{ {
yield ['2', 'INVALID_ARGUMENT']; yield 'missing long url v2' => [[], '2', 'INVALID_ARGUMENT'];
yield ['3', 'https://shlink.io/api/error/invalid-data']; yield 'missing long url v3' => [[], '3', 'https://shlink.io/api/error/invalid-data'];
yield 'empty long url v2' => [['longUrl' => null], '2', 'INVALID_ARGUMENT'];
yield 'empty long url v3' => [['longUrl' => ' '], '3', 'https://shlink.io/api/error/invalid-data'];
yield 'empty device long url v2' => [[
'longUrl' => 'foo',
'deviceLongUrls' => [
'android' => null,
],
], '2', 'INVALID_ARGUMENT'];
yield 'empty device long url v3' => [[
'longUrl' => 'foo',
'deviceLongUrls' => [
'ios' => ' ',
],
], '3', 'https://shlink.io/api/error/invalid-data'];
} }
/** @test */ /** @test */
@ -361,6 +377,22 @@ class CreateShortUrlTest extends ApiTestCase
self::assertEquals('http://s.test/🦣🦣🦣', $payload['shortUrl']); self::assertEquals('http://s.test/🦣🦣🦣', $payload['shortUrl']);
} }
/** @test */
public function canCreateShortUrlsWithDeviceLongUrls(): void
{
[$statusCode, $payload] = $this->createShortUrl([
'longUrl' => 'https://github.com/shlinkio/shlink/issues/1557',
'deviceLongUrls' => [
'ios' => 'https://github.com/shlinkio/shlink/ios',
'android' => 'https://github.com/shlinkio/shlink/android',
],
]);
self::assertEquals(self::STATUS_OK, $statusCode);
self::assertEquals('https://github.com/shlinkio/shlink/ios', $payload['deviceLongUrls']['ios'] ?? null);
self::assertEquals('https://github.com/shlinkio/shlink/android', $payload['deviceLongUrls']['android'] ?? null);
}
/** /**
* @return array{int, array} * @return array{int, array}
*/ */