Improved list domains api test to cover different API key cases

This commit is contained in:
Alejandro Celaya 2021-01-10 09:32:19 +01:00
parent 5283ee2c6b
commit c8eb956778

View file

@ -8,16 +8,26 @@ use Shlinkio\Shlink\TestUtils\ApiTest\ApiTestCase;
class ListDomainsTest extends ApiTestCase class ListDomainsTest extends ApiTestCase
{ {
/** @test */ /**
public function domainsAreProperlyListed(): void * @test
* @dataProvider provideApiKeysAndDomains
*/
public function domainsAreProperlyListed(string $apiKey, array $expectedDomains): void
{ {
$resp = $this->callApiWithKey(self::METHOD_GET, '/domains'); $resp = $this->callApiWithKey(self::METHOD_GET, '/domains', [], $apiKey);
$respPayload = $this->getJsonResponsePayload($resp); $respPayload = $this->getJsonResponsePayload($resp);
self::assertEquals(self::STATUS_OK, $resp->getStatusCode()); self::assertEquals(self::STATUS_OK, $resp->getStatusCode());
self::assertEquals([ self::assertEquals([
'domains' => [ 'domains' => [
'data' => [ 'data' => $expectedDomains,
],
], $respPayload);
}
public function provideApiKeysAndDomains(): iterable
{
yield 'admin API key' => ['valid_api_key', [
[ [
'domain' => 'doma.in', 'domain' => 'doma.in',
'isDefault' => true, 'isDefault' => true,
@ -30,8 +40,18 @@ class ListDomainsTest extends ApiTestCase
'domain' => 'some-domain.com', 'domain' => 'some-domain.com',
'isDefault' => false, 'isDefault' => false,
], ],
]];
yield 'author API key' => ['author_api_key', [
[
'domain' => 'doma.in',
'isDefault' => true,
], ],
]];
yield 'domain API key' => ['domain_api_key', [
[
'domain' => 'example.com',
'isDefault' => false,
], ],
], $respPayload); ]];
} }
} }