mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-11-24 05:38:06 +03:00
Code Issues Projects Releases Packages Wiki Activity

Hardcoded different creation dates for fixture short URLs to avoid random API test failures

Browse source
This commit is contained in:
Alejandro Celaya 2019-12-18 15:26:23 +01:00
parent 4334ea295d
commit 75b91dc26b
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
module/Rest/test-api/Action/ListShortUrlsTest.php
View file

@ -46,7 +46,7 @@ class ListShortUrlsTest extends ApiTestCase
'longUrl' =>
'https://blog.alejandrocelaya.com/2017/12/09'
. '/acmailer-7-0-the-most-important-release-in-a-long-time/',
'dateCreated' => '2019-01-01T00:00:00+00:00',
'dateCreated' => '2019-01-01T00:00:10+00:00',
'visitsCount' => 2,
'tags' => ['bar', 'foo'],
'meta' => [
@ -62,7 +62,7 @@ class ListShortUrlsTest extends ApiTestCase
'shortCode' => 'custom',
'shortUrl' => 'http://doma.in/custom',
'longUrl' => 'https://shlink.io',
'dateCreated' => '2019-01-01T00:00:00+00:00',
'dateCreated' => '2019-01-01T00:00:20+00:00',
'visitsCount' => 0,
'tags' => [],
'meta' => [
@ -78,7 +78,7 @@ class ListShortUrlsTest extends ApiTestCase
'longUrl' =>
'https://blog.alejandrocelaya.com/2019/04/27'
. '/considerations-to-properly-use-open-source-software-projects/',
'dateCreated' => '2019-01-01T00:00:00+00:00',
'dateCreated' => '2019-01-01T00:00:30+00:00',
'visitsCount' => 0,
'tags' => [],
'meta' => [

14
module/Rest/test-api/Fixtures/ShortUrlsFixture.php
View file

@ -22,32 +22,32 @@ class ShortUrlsFixture extends AbstractFixture
{
$abcShortUrl = $this->setShortUrlDate(
new ShortUrl('https://shlink.io', ShortUrlMeta::createFromRawData(['customSlug' => 'abc123'])),
Chronos::parse('2018-05-01')
'2018-05-01'
);
$manager->persist($abcShortUrl);
$defShortUrl = $this->setShortUrlDate(new ShortUrl(
'https://blog.alejandrocelaya.com/2017/12/09/acmailer-7-0-the-most-important-release-in-a-long-time/',
ShortUrlMeta::createFromParams(Chronos::parse('2020-05-01'), null, 'def456')
));
), '2019-01-01 00:00:10');
$manager->persist($defShortUrl);
$customShortUrl = $this->setShortUrlDate(new ShortUrl(
'https://shlink.io',
ShortUrlMeta::createFromParams(null, null, 'custom', 2)
));
), '2019-01-01 00:00:20');
$manager->persist($customShortUrl);
$withDomainShortUrl = $this->setShortUrlDate(new ShortUrl(
'https://blog.alejandrocelaya.com/2019/04/27/considerations-to-properly-use-open-source-software-projects/',
ShortUrlMeta::createFromRawData(['domain' => 'example.com', 'customSlug' => 'ghi789'])
));
), '2019-01-01 00:00:30');
$manager->persist($withDomainShortUrl);
$withDomainAndSlugShortUrl = $this->setShortUrlDate(new ShortUrl(
'https://google.com',
ShortUrlMeta::createFromRawData(['domain' => 'some-domain.com', 'customSlug' => 'custom-with-domain'])
), Chronos::parse('2018-10-20'));
), '2018-10-20');
$manager->persist($withDomainAndSlugShortUrl);
$manager->flush();
@ -56,12 +56,12 @@ class ShortUrlsFixture extends AbstractFixture
$this->addReference('def456_short_url', $defShortUrl);
}
private function setShortUrlDate(ShortUrl $shortUrl, ?Chronos $date = null): ShortUrl
private function setShortUrlDate(ShortUrl $shortUrl, string $date): ShortUrl
{
$ref = new ReflectionObject($shortUrl);
$dateProp = $ref->getProperty('dateCreated');
$dateProp->setAccessible(true);
$dateProp->setValue($shortUrl, $date ?? Chronos::parse('2019-01-01'));
$dateProp->setValue($shortUrl, Chronos::parse($date));
return $shortUrl;
}