mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-17 15:59:56 +03:00
Code Issues Projects Releases Packages Wiki Activity

Simplify logic to match order by for short URL lists

Browse source
This commit is contained in:
Alejandro Celaya 2024-03-21 08:56:13 +01:00
parent f678873e9f
commit 3c89d252d2
1 changed files with 8 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
module/Core/src/ShortUrl/Repository/ShortUrlListRepository.php
View file

@ -48,21 +48,16 @@ class ShortUrlListRepository extends EntitySpecificationRepository implements Sh
private function processOrderByForList(QueryBuilder $qb, ShortUrlsListFiltering $filtering): void
{
// With no explicit order by, fallback to dateCreated-DESC
$fieldName = $filtering->orderBy->field;
if ($fieldName === null) {
$qb->orderBy('s.dateCreated', 'DESC');
return;
}
$order = $filtering->orderBy->direction;
if (OrderableField::isBasicField($fieldName)) {
$qb->orderBy('s.' . $fieldName, $order);
} elseif (OrderableField::VISITS->value === $fieldName) {
$qb->orderBy('SUM(v.count)', $order);
} elseif (OrderableField::NON_BOT_VISITS->value === $fieldName) {
$qb->orderBy('SUM(v2.count)', $order);
}
match (true) {
// With no explicit order by, fallback to dateCreated-DESC
$fieldName === null => $qb->orderBy('s.dateCreated', 'DESC'),
$fieldName === OrderableField::VISITS->value => $qb->orderBy('SUM(v.count)', $order),
$fieldName === OrderableField::NON_BOT_VISITS->value => $qb->orderBy('SUM(v2.count)', $order),
default => $qb->orderBy('s.' . $fieldName, $order),
};
}
public function countList(ShortUrlsCountFiltering $filtering): int