mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-10-23 12:45:34 +03:00
Code Issues Projects Releases Packages Wiki Activity

Updated status returned in REST endpoints to be 404 when something is not found

Browse source
This commit is contained in:
Alejandro Celaya 2016-08-08 09:46:40 +02:00
parent 93713689d7
commit 3bd4f506e0
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
module/Rest/src/Action/GetVisitsAction.php
View file

@ -25,7 +25,7 @@ class GetVisitsAction extends AbstractRestAction
/** /**
* GetVisitsAction constructor. * GetVisitsAction constructor.
* @param VisitsTrackerInterface|VisitsTracker $visitsTracker * @param VisitsTrackerInterface $visitsTracker
* @param TranslatorInterface $translator * @param TranslatorInterface $translator
* *
* @Inject({VisitsTracker::class, "translator"}) * @Inject({VisitsTracker::class, "translator"})
@ -59,8 +59,11 @@ class GetVisitsAction extends AbstractRestAction
} catch (InvalidArgumentException $e) { } catch (InvalidArgumentException $e) {
return new JsonResponse([ return new JsonResponse([
'error' => RestUtils::getRestErrorCodeFromException($e), 'error' => RestUtils::getRestErrorCodeFromException($e),
'message' => sprintf($this->translator->translate('Provided short code "%s" is invalid'), $shortCode), 'message' => sprintf(
], 400); $this->translator->translate('Provided short code "%s" does not exist'),
$shortCode
),
], 404);
} catch (\Exception $e) { } catch (\Exception $e) {
return new JsonResponse([ return new JsonResponse([
'error' => RestUtils::UNKNOWN_ERROR, 'error' => RestUtils::UNKNOWN_ERROR,

4
module/Rest/src/Action/ResolveUrlAction.php
View file

@ -50,8 +50,8 @@ class ResolveUrlAction extends AbstractRestAction
if (! isset($longUrl)) { if (! isset($longUrl)) {
return new JsonResponse([ return new JsonResponse([
'error' => RestUtils::INVALID_ARGUMENT_ERROR, 'error' => RestUtils::INVALID_ARGUMENT_ERROR,
'message' => sprintf($this->translator->translate('No URL found for shortcode "%s"'), $shortCode), 'message' => sprintf($this->translator->translate('No URL found for short code "%s"'), $shortCode),
], 400); ], 404);
} }
return new JsonResponse([ return new JsonResponse([