mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-11-23 21:27:44 +03:00
Code Issues Projects Releases Packages Wiki Activity

Migrated CreateShortUrlContentNegotiationMiddlewareTest to use PHPUnit mocks

Browse source
This commit is contained in:
Alejandro Celaya 2022-10-23 22:53:48 +02:00
parent 674a4416cf
commit 23aa7a015c
1 changed files with 15 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
module/Rest/test/Middleware/ShortUrl/CreateShortUrlContentNegotiationMiddlewareTest.php
View file

@ -7,34 +7,32 @@ namespace ShlinkioTest\Shlink\Rest\Middleware\ShortUrl;
use Laminas\Diactoros\Response; use Laminas\Diactoros\Response;
use Laminas\Diactoros\Response\JsonResponse; use Laminas\Diactoros\Response\JsonResponse;
use Laminas\Diactoros\ServerRequest; use Laminas\Diactoros\ServerRequest;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\Argument;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Psr\Http\Message\ServerRequestInterface; use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\RequestHandlerInterface; use Psr\Http\Server\RequestHandlerInterface;
use Shlinkio\Shlink\Rest\Middleware\ShortUrl\CreateShortUrlContentNegotiationMiddleware; use Shlinkio\Shlink\Rest\Middleware\ShortUrl\CreateShortUrlContentNegotiationMiddleware;
class CreateShortUrlContentNegotiationMiddlewareTest extends TestCase class CreateShortUrlContentNegotiationMiddlewareTest extends TestCase
{ {
use ProphecyTrait;
private CreateShortUrlContentNegotiationMiddleware $middleware; private CreateShortUrlContentNegotiationMiddleware $middleware;
private ObjectProphecy $requestHandler; private MockObject $requestHandler;
protected function setUp(): void protected function setUp(): void
{ {
$this->middleware = new CreateShortUrlContentNegotiationMiddleware(); $this->middleware = new CreateShortUrlContentNegotiationMiddleware();
$this->requestHandler = $this->prophesize(RequestHandlerInterface::class); $this->requestHandler = $this->createMock(RequestHandlerInterface::class);
} }
/** @test */ /** @test */
public function whenNoJsonResponseIsReturnedNoFurtherOperationsArePerformed(): void public function whenNoJsonResponseIsReturnedNoFurtherOperationsArePerformed(): void
{ {
$expectedResp = new Response(); $expectedResp = new Response();
$this->requestHandler->handle(Argument::type(ServerRequestInterface::class))->willReturn($expectedResp); $this->requestHandler->method('handle')->with($this->isInstanceOf(ServerRequestInterface::class))->willReturn(
$expectedResp,
);
$resp = $this->middleware->process(new ServerRequest(), $this->requestHandler->reveal()); $resp = $this->middleware->process(new ServerRequest(), $this->requestHandler);
self::assertSame($expectedResp, $resp); self::assertSame($expectedResp, $resp);
} }
@ -51,14 +49,13 @@ class CreateShortUrlContentNegotiationMiddlewareTest extends TestCase
$request = $request->withHeader('Accept', $accept); $request = $request->withHeader('Accept', $accept);
} }
$handle = $this->requestHandler->handle(Argument::type(ServerRequestInterface::class))->willReturn( $this->requestHandler->expects($this->once())->method('handle')->with(
new JsonResponse(['shortUrl' => 'http://doma.in/foo']), $this->isInstanceOf(ServerRequestInterface::class),
); )->willReturn(new JsonResponse(['shortUrl' => 'http://doma.in/foo']));
$response = $this->middleware->process($request, $this->requestHandler->reveal()); $response = $this->middleware->process($request, $this->requestHandler);
self::assertEquals($expectedContentType, $response->getHeaderLine('Content-type')); self::assertEquals($expectedContentType, $response->getHeaderLine('Content-type'));
$handle->shouldHaveBeenCalled();
} }
public function provideData(): iterable public function provideData(): iterable
@ -82,14 +79,13 @@ class CreateShortUrlContentNegotiationMiddlewareTest extends TestCase
{ {
$request = (new ServerRequest())->withQueryParams(['format' => 'txt']); $request = (new ServerRequest())->withQueryParams(['format' => 'txt']);
$handle = $this->requestHandler->handle(Argument::type(ServerRequestInterface::class))->willReturn( $this->requestHandler->expects($this->once())->method('handle')->with(
new JsonResponse($json), $this->isInstanceOf(ServerRequestInterface::class),
); )->willReturn(new JsonResponse($json));
$response = $this->middleware->process($request, $this->requestHandler->reveal()); $response = $this->middleware->process($request, $this->requestHandler);
self::assertEquals($expectedBody, (string) $response->getBody()); self::assertEquals($expectedBody, (string) $response->getBody());
$handle->shouldHaveBeenCalled();
} }
public function provideTextBodies(): iterable public function provideTextBodies(): iterable