From 0f81c3ab92ec72fae00618560f8d80ae4ef7ceaf Mon Sep 17 00:00:00 2001 From: Alejandro Celaya Date: Tue, 5 Mar 2019 13:50:44 +0100 Subject: [PATCH] Fixed error when using postgres in a SELECT count query where a ORDER BY was added by mistake --- module/Core/src/Repository/VisitRepository.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/module/Core/src/Repository/VisitRepository.php b/module/Core/src/Repository/VisitRepository.php index 06c7f252..19d10c21 100644 --- a/module/Core/src/Repository/VisitRepository.php +++ b/module/Core/src/Repository/VisitRepository.php @@ -50,7 +50,8 @@ DQL; ?int $offset = null ): array { $qb = $this->createVisitsByShortCodeQueryBuilder($shortCode, $dateRange); - $qb->select('v'); + $qb->select('v') + ->orderBy('v.date', 'DESC'); if ($limit !== null) { $qb->setMaxResults($limit); @@ -76,8 +77,7 @@ DQL; $qb->from(Visit::class, 'v') ->join('v.shortUrl', 'su') ->where($qb->expr()->eq('su.shortCode', ':shortCode')) - ->setParameter('shortCode', $shortCode) - ->orderBy('v.date', 'DESC') ; + ->setParameter('shortCode', $shortCode); // Apply date range filtering if ($dateRange !== null && $dateRange->getStartDate() !== null) {