mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2024-11-28 00:38:46 +03:00
Code Issues Projects Releases Packages Wiki Activity

Allowed slashes on custom slugs during short URL creation

Browse source
This commit is contained in:
Alejandro Celaya 2022-08-01 10:12:08 +02:00
parent e0e511f56d
commit 0a220bbc7a
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
module/Core/src/Validation/ShortUrlInputFilter.php
View file

@ -13,6 +13,7 @@ use Shlinkio\Shlink\Common\Validation;
use Shlinkio\Shlink\Rest\Entity\ApiKey;
use function is_string;
use function ltrim;
use function str_replace;
use function substr;
@ -77,7 +78,7 @@ class ShortUrlInputFilter extends InputFilter
// empty, is by using the deprecated setContinueIfEmpty
$customSlug = $this->createInput(self::CUSTOM_SLUG, false)->setContinueIfEmpty(true);
$customSlug->getFilterChain()->attach(new Filter\Callback(
static fn (mixed $value) => is_string($value) ? str_replace([' ', '/'], '-', $value) : $value,
static fn (mixed $value) => is_string($value) ? ltrim(str_replace(' ', '-', $value), '/') : $value,
));
$customSlug->getValidatorChain()->attach(new Validator\NotEmpty([
Validator\NotEmpty::STRING,

3
module/Core/test/Model/ShortUrlMetaTest.php
View file

@ -103,7 +103,8 @@ class ShortUrlMetaTest extends TestCase
yield ['foo bar', 'foo-bar'];
yield ['foo bar baz', 'foo-bar-baz'];
yield ['foo bar-baz', 'foo-bar-baz'];
yield ['foo/bar/baz', 'foo-bar-baz'];
yield ['foo/bar/baz', 'foo/bar/baz'];
yield ['/foo/bar/baz', 'foo/bar/baz'];
yield ['wp-admin.php', 'wp-admin.php'];
yield ['UPPER_lower', 'UPPER_lower'];
yield ['more~url_special.chars', 'more~url_special.chars'];