mirrors/shlink
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-04-01 14:24:26 +03:00
Code Issues Projects Releases Packages Wiki Activity

Added one more case to cover import orphan visits when visits already exist

Browse source
This commit is contained in:
Alejandro Celaya 2022-12-05 14:48:24 +01:00
parent 739f5eb421
commit 05d55c4000
1 changed files with 14 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
module/Core/test/Importer/ImportedLinksProcessorTest.php
View file

@ -17,6 +17,7 @@ use Shlinkio\Shlink\Core\ShortUrl\Repository\ShortUrlRepositoryInterface;
use Shlinkio\Shlink\Core\ShortUrl\Resolver\SimpleShortUrlRelationResolver; use Shlinkio\Shlink\Core\ShortUrl\Resolver\SimpleShortUrlRelationResolver;
use Shlinkio\Shlink\Core\Util\DoctrineBatchHelperInterface; use Shlinkio\Shlink\Core\Util\DoctrineBatchHelperInterface;
use Shlinkio\Shlink\Core\Visit\Entity\Visit; use Shlinkio\Shlink\Core\Visit\Entity\Visit;
use Shlinkio\Shlink\Core\Visit\Model\Visitor;
use Shlinkio\Shlink\Core\Visit\Repository\VisitRepositoryInterface; use Shlinkio\Shlink\Core\Visit\Repository\VisitRepositoryInterface;
use Shlinkio\Shlink\Importer\Model\ImportedShlinkOrphanVisit; use Shlinkio\Shlink\Importer\Model\ImportedShlinkOrphanVisit;
use Shlinkio\Shlink\Importer\Model\ImportedShlinkUrl; use Shlinkio\Shlink\Importer\Model\ImportedShlinkUrl;
@ -235,6 +236,7 @@ class ImportedLinksProcessorTest extends TestCase
public function properAmountOfOrphanVisitsIsImported( public function properAmountOfOrphanVisitsIsImported(
bool $importOrphanVisits, bool $importOrphanVisits,
iterable $visits, iterable $visits,
?Visit $lastOrphanVisit,
int $expectedImportedVisits, int $expectedImportedVisits,
): void { ): void {
$this->io->expects($this->exactly($importOrphanVisits ? 2 : 1))->method('title'); $this->io->expects($this->exactly($importOrphanVisits ? 2 : 1))->method('title');
@ -245,7 +247,7 @@ class ImportedLinksProcessorTest extends TestCase
$visitRepo = $this->createMock(VisitRepositoryInterface::class); $visitRepo = $this->createMock(VisitRepositoryInterface::class);
$visitRepo->expects($importOrphanVisits ? $this->once() : $this->never())->method( $visitRepo->expects($importOrphanVisits ? $this->once() : $this->never())->method(
'findMostRecentOrphanVisit', 'findMostRecentOrphanVisit',
)->willReturn(null); )->willReturn($lastOrphanVisit);
$this->em->expects($importOrphanVisits ? $this->once() : $this->never())->method('getRepository')->with( $this->em->expects($importOrphanVisits ? $this->once() : $this->never())->method('getRepository')->with(
Visit::class, Visit::class,
)->willReturn($visitRepo); )->willReturn($visitRepo);
@ -262,18 +264,25 @@ class ImportedLinksProcessorTest extends TestCase
public function provideOrphanVisits(): iterable public function provideOrphanVisits(): iterable
{ {
yield 'import orphan disable without visits' => [false, [], 0]; yield 'import orphan disable without visits' => [false, [], null, 0];
yield 'import orphan enabled without visits' => [true, [], 0]; yield 'import orphan enabled without visits' => [true, [], null, 0];
yield 'import orphan disabled with visits' => [false, [ yield 'import orphan disabled with visits' => [false, [
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
], 0]; ], null, 0];
yield 'import orphan enabled with visits' => [true, [ yield 'import orphan enabled with visits' => [true, [
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null), new ImportedShlinkOrphanVisit('', '', Chronos::now(), '', '', null),
], 5]; ], null, 5];
yield 'existing orphan visit' => [true, [
new ImportedShlinkOrphanVisit('', '', Chronos::now()->subDays(3), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now()->subDays(2), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now()->addDay(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now()->addDay(), '', '', null),
new ImportedShlinkOrphanVisit('', '', Chronos::now()->addDay(), '', '', null),
], Visit::forBasePath(Visitor::botInstance()), 3];
} }
private function buildParams(bool $importOrphanVisits = false): ImportParams private function buildParams(bool $importOrphanVisits = false): ImportParams