2018-09-15 18:57:12 +03:00
|
|
|
<?php
|
2019-10-05 18:26:10 +03:00
|
|
|
|
2018-09-15 18:57:12 +03:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2018-09-16 19:36:02 +03:00
|
|
|
namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;
|
2018-09-15 18:57:12 +03:00
|
|
|
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
use Prophecy\Argument;
|
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
2018-09-16 19:36:02 +03:00
|
|
|
use Shlinkio\Shlink\CLI\Command\ShortUrl\DeleteShortUrlCommand;
|
2018-09-15 18:57:12 +03:00
|
|
|
use Shlinkio\Shlink\Core\Exception;
|
2020-02-01 13:46:54 +03:00
|
|
|
use Shlinkio\Shlink\Core\Model\ShortUrlIdentifier;
|
2018-09-15 18:57:12 +03:00
|
|
|
use Shlinkio\Shlink\Core\Service\ShortUrl\DeleteShortUrlServiceInterface;
|
2021-04-08 14:42:56 +03:00
|
|
|
use ShlinkioTest\Shlink\CLI\CliTestUtilsTrait;
|
2018-09-15 18:57:12 +03:00
|
|
|
use Symfony\Component\Console\Tester\CommandTester;
|
2019-02-27 00:56:43 +03:00
|
|
|
|
2018-10-28 10:24:06 +03:00
|
|
|
use function array_pop;
|
|
|
|
use function sprintf;
|
2018-09-15 18:57:12 +03:00
|
|
|
|
2019-08-01 20:49:54 +03:00
|
|
|
use const PHP_EOL;
|
|
|
|
|
2019-02-16 23:24:32 +03:00
|
|
|
class DeleteShortUrlCommandTest extends TestCase
|
2018-09-15 18:57:12 +03:00
|
|
|
{
|
2021-04-08 14:42:56 +03:00
|
|
|
use CliTestUtilsTrait;
|
2020-11-02 13:50:19 +03:00
|
|
|
|
2019-12-30 00:27:00 +03:00
|
|
|
private CommandTester $commandTester;
|
|
|
|
private ObjectProphecy $service;
|
2018-09-15 18:57:12 +03:00
|
|
|
|
2019-02-16 12:53:45 +03:00
|
|
|
public function setUp(): void
|
2018-09-15 18:57:12 +03:00
|
|
|
{
|
|
|
|
$this->service = $this->prophesize(DeleteShortUrlServiceInterface::class);
|
2021-04-08 14:42:56 +03:00
|
|
|
$this->commandTester = $this->testerForCommand(new DeleteShortUrlCommand($this->service->reveal()));
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
|
|
|
|
2019-02-16 23:24:32 +03:00
|
|
|
/** @test */
|
|
|
|
public function successMessageIsPrintedIfUrlIsProperlyDeleted(): void
|
2018-09-15 18:57:12 +03:00
|
|
|
{
|
|
|
|
$shortCode = 'abc123';
|
2020-02-01 20:06:50 +03:00
|
|
|
$deleteByShortCode = $this->service->deleteByShortCode(new ShortUrlIdentifier($shortCode), false)->will(
|
|
|
|
function (): void {
|
|
|
|
},
|
|
|
|
);
|
2018-09-15 18:57:12 +03:00
|
|
|
|
|
|
|
$this->commandTester->execute(['shortCode' => $shortCode]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString(
|
2019-02-16 12:53:45 +03:00
|
|
|
sprintf('Short URL with short code "%s" successfully deleted.', $shortCode),
|
2020-01-01 22:48:31 +03:00
|
|
|
$output,
|
2019-02-16 12:53:45 +03:00
|
|
|
);
|
2018-11-11 15:18:21 +03:00
|
|
|
$deleteByShortCode->shouldHaveBeenCalledOnce();
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
|
|
|
|
2019-02-16 23:24:32 +03:00
|
|
|
/** @test */
|
|
|
|
public function invalidShortCodePrintsMessage(): void
|
2018-09-15 18:57:12 +03:00
|
|
|
{
|
|
|
|
$shortCode = 'abc123';
|
2020-02-01 20:06:50 +03:00
|
|
|
$identifier = new ShortUrlIdentifier($shortCode);
|
|
|
|
$deleteByShortCode = $this->service->deleteByShortCode($identifier, false)->willThrow(
|
|
|
|
Exception\ShortUrlNotFoundException::fromNotFound($identifier),
|
2018-09-15 18:57:12 +03:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->commandTester->execute(['shortCode' => $shortCode]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString(sprintf('No URL found with short code "%s"', $shortCode), $output);
|
2018-11-11 15:18:21 +03:00
|
|
|
$deleteByShortCode->shouldHaveBeenCalledOnce();
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
2019-02-16 23:24:32 +03:00
|
|
|
* @dataProvider provideRetryDeleteAnswers
|
2018-09-15 18:57:12 +03:00
|
|
|
*/
|
2019-02-16 23:24:32 +03:00
|
|
|
public function deleteIsRetriedWhenThresholdIsReachedAndQuestionIsAccepted(
|
|
|
|
array $retryAnswer,
|
|
|
|
int $expectedDeleteCalls,
|
2021-05-23 13:31:10 +03:00
|
|
|
string $expectedMessage,
|
2019-02-16 23:24:32 +03:00
|
|
|
): void {
|
2018-09-15 18:57:12 +03:00
|
|
|
$shortCode = 'abc123';
|
2020-02-01 20:06:50 +03:00
|
|
|
$identifier = new ShortUrlIdentifier($shortCode);
|
|
|
|
$deleteByShortCode = $this->service->deleteByShortCode($identifier, Argument::type('bool'))->will(
|
2020-01-01 22:48:31 +03:00
|
|
|
function (array $args) use ($shortCode): void {
|
2018-10-28 10:24:06 +03:00
|
|
|
$ignoreThreshold = array_pop($args);
|
2018-09-15 18:57:12 +03:00
|
|
|
|
|
|
|
if (!$ignoreThreshold) {
|
2019-11-28 20:42:27 +03:00
|
|
|
throw Exception\DeleteShortUrlException::fromVisitsThreshold(10, $shortCode);
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
2020-01-01 22:48:31 +03:00
|
|
|
},
|
2018-09-15 18:57:12 +03:00
|
|
|
);
|
2019-02-16 23:24:32 +03:00
|
|
|
$this->commandTester->setInputs($retryAnswer);
|
2018-09-15 18:57:12 +03:00
|
|
|
|
|
|
|
$this->commandTester->execute(['shortCode' => $shortCode]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString(sprintf(
|
2019-11-28 20:42:27 +03:00
|
|
|
'Impossible to delete short URL with short code "%s" since it has more than "10" visits.',
|
2020-01-01 22:48:31 +03:00
|
|
|
$shortCode,
|
2018-09-15 18:57:12 +03:00
|
|
|
), $output);
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString($expectedMessage, $output);
|
2019-02-16 23:24:32 +03:00
|
|
|
$deleteByShortCode->shouldHaveBeenCalledTimes($expectedDeleteCalls);
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
|
|
|
|
2019-02-16 23:24:32 +03:00
|
|
|
public function provideRetryDeleteAnswers(): iterable
|
|
|
|
{
|
|
|
|
yield 'answering yes to retry' => [['yes'], 2, 'Short URL with short code "abc123" successfully deleted.'];
|
|
|
|
yield 'answering no to retry' => [['no'], 1, 'Short URL was not deleted.'];
|
|
|
|
yield 'answering default to retry' => [[PHP_EOL], 1, 'Short URL was not deleted.'];
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function deleteIsNotRetriedWhenThresholdIsReachedAndQuestionIsDeclined(): void
|
2018-09-15 18:57:12 +03:00
|
|
|
{
|
|
|
|
$shortCode = 'abc123';
|
2020-02-01 20:06:50 +03:00
|
|
|
$deleteByShortCode = $this->service->deleteByShortCode(new ShortUrlIdentifier($shortCode), false)->willThrow(
|
2020-01-01 22:48:31 +03:00
|
|
|
Exception\DeleteShortUrlException::fromVisitsThreshold(10, $shortCode),
|
2018-09-15 18:57:12 +03:00
|
|
|
);
|
|
|
|
$this->commandTester->setInputs(['no']);
|
|
|
|
|
|
|
|
$this->commandTester->execute(['shortCode' => $shortCode]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString(sprintf(
|
2019-11-28 20:42:27 +03:00
|
|
|
'Impossible to delete short URL with short code "%s" since it has more than "10" visits.',
|
2020-01-01 22:48:31 +03:00
|
|
|
$shortCode,
|
2018-09-15 18:57:12 +03:00
|
|
|
), $output);
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString('Short URL was not deleted.', $output);
|
2018-11-11 15:18:21 +03:00
|
|
|
$deleteByShortCode->shouldHaveBeenCalledOnce();
|
2018-09-15 18:57:12 +03:00
|
|
|
}
|
|
|
|
}
|