2016-07-30 14:12:56 +02:00
|
|
|
<?php
|
2019-10-05 17:26:10 +02:00
|
|
|
|
2017-10-12 10:13:20 +02:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2018-09-16 18:36:02 +02:00
|
|
|
namespace ShlinkioTest\Shlink\CLI\Command\ShortUrl;
|
2016-07-30 14:12:56 +02:00
|
|
|
|
2018-11-17 18:06:06 +01:00
|
|
|
use PHPUnit\Framework\Assert;
|
2017-03-24 20:34:18 +01:00
|
|
|
use PHPUnit\Framework\TestCase;
|
2016-07-30 14:12:56 +02:00
|
|
|
use Prophecy\Argument;
|
2020-11-02 11:50:19 +01:00
|
|
|
use Prophecy\PhpUnit\ProphecyTrait;
|
2016-07-30 14:12:56 +02:00
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
2018-09-16 18:36:02 +02:00
|
|
|
use Shlinkio\Shlink\CLI\Command\ShortUrl\GenerateShortUrlCommand;
|
2019-10-02 20:22:42 +02:00
|
|
|
use Shlinkio\Shlink\CLI\Util\ExitCodes;
|
2018-09-12 20:32:58 +02:00
|
|
|
use Shlinkio\Shlink\Core\Entity\ShortUrl;
|
2016-07-30 14:12:56 +02:00
|
|
|
use Shlinkio\Shlink\Core\Exception\InvalidUrlException;
|
2019-10-02 20:22:42 +02:00
|
|
|
use Shlinkio\Shlink\Core\Exception\NonUniqueSlugException;
|
2020-09-24 21:54:03 +02:00
|
|
|
use Shlinkio\Shlink\Core\Model\ShortUrlMeta;
|
2016-07-30 14:12:56 +02:00
|
|
|
use Shlinkio\Shlink\Core\Service\UrlShortener;
|
|
|
|
use Symfony\Component\Console\Application;
|
|
|
|
use Symfony\Component\Console\Tester\CommandTester;
|
|
|
|
|
2018-11-17 18:06:06 +01:00
|
|
|
class GenerateShortUrlCommandTest extends TestCase
|
2016-07-30 14:12:56 +02:00
|
|
|
{
|
2020-11-02 11:50:19 +01:00
|
|
|
use ProphecyTrait;
|
|
|
|
|
2019-10-11 09:14:25 +02:00
|
|
|
private const DOMAIN_CONFIG = [
|
|
|
|
'schema' => 'http',
|
|
|
|
'hostname' => 'foo.com',
|
|
|
|
];
|
|
|
|
|
2019-12-29 22:27:00 +01:00
|
|
|
private CommandTester $commandTester;
|
|
|
|
private ObjectProphecy $urlShortener;
|
2016-07-30 14:12:56 +02:00
|
|
|
|
2019-02-16 10:53:45 +01:00
|
|
|
public function setUp(): void
|
2016-07-30 14:12:56 +02:00
|
|
|
{
|
|
|
|
$this->urlShortener = $this->prophesize(UrlShortener::class);
|
2020-02-18 20:34:48 +01:00
|
|
|
$command = new GenerateShortUrlCommand($this->urlShortener->reveal(), self::DOMAIN_CONFIG, 5);
|
2016-07-30 14:12:56 +02:00
|
|
|
$app = new Application();
|
|
|
|
$app->add($command);
|
|
|
|
$this->commandTester = new CommandTester($command);
|
|
|
|
}
|
|
|
|
|
2019-02-17 20:28:34 +01:00
|
|
|
/** @test */
|
2019-10-02 20:22:42 +02:00
|
|
|
public function properShortCodeIsCreatedIfLongUrlIsCorrect(): void
|
2016-07-30 14:12:56 +02:00
|
|
|
{
|
2019-10-11 09:14:25 +02:00
|
|
|
$shortUrl = new ShortUrl('');
|
2020-11-06 20:05:57 +01:00
|
|
|
$urlToShortCode = $this->urlShortener->shorten(Argument::cetera())->willReturn($shortUrl);
|
2016-07-30 14:12:56 +02:00
|
|
|
|
|
|
|
$this->commandTester->execute([
|
2017-10-12 10:13:20 +02:00
|
|
|
'longUrl' => 'http://domain.com/foo/bar',
|
2018-11-17 18:06:06 +01:00
|
|
|
'--maxVisits' => '3',
|
2016-07-30 14:12:56 +02:00
|
|
|
]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
2018-11-17 18:06:06 +01:00
|
|
|
|
2020-10-04 00:35:14 +02:00
|
|
|
self::assertEquals(ExitCodes::EXIT_SUCCESS, $this->commandTester->getStatusCode());
|
|
|
|
self::assertStringContainsString($shortUrl->toString(self::DOMAIN_CONFIG), $output);
|
2018-11-17 18:06:06 +01:00
|
|
|
$urlToShortCode->shouldHaveBeenCalledOnce();
|
2016-07-30 14:12:56 +02:00
|
|
|
}
|
|
|
|
|
2019-02-17 20:28:34 +01:00
|
|
|
/** @test */
|
2019-10-02 20:22:42 +02:00
|
|
|
public function exceptionWhileParsingLongUrlOutputsError(): void
|
2016-07-30 14:12:56 +02:00
|
|
|
{
|
2019-11-28 18:42:27 +01:00
|
|
|
$url = 'http://domain.com/invalid';
|
2020-11-06 20:05:57 +01:00
|
|
|
$this->urlShortener->shorten(Argument::cetera())->willThrow(InvalidUrlException::fromUrl($url))
|
2018-11-11 13:18:21 +01:00
|
|
|
->shouldBeCalledOnce();
|
2016-07-30 14:12:56 +02:00
|
|
|
|
2019-11-28 18:42:27 +01:00
|
|
|
$this->commandTester->execute(['longUrl' => $url]);
|
2016-07-30 14:12:56 +02:00
|
|
|
$output = $this->commandTester->getDisplay();
|
2019-10-02 20:22:42 +02:00
|
|
|
|
2020-10-04 00:35:14 +02:00
|
|
|
self::assertEquals(ExitCodes::EXIT_FAILURE, $this->commandTester->getStatusCode());
|
|
|
|
self::assertStringContainsString('Provided URL http://domain.com/invalid is invalid.', $output);
|
2019-10-02 20:22:42 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function providingNonUniqueSlugOutputsError(): void
|
|
|
|
{
|
2020-11-06 20:05:57 +01:00
|
|
|
$urlToShortCode = $this->urlShortener->shorten(Argument::cetera())->willThrow(
|
2020-01-01 20:48:31 +01:00
|
|
|
NonUniqueSlugException::fromSlug('my-slug'),
|
2016-07-30 14:12:56 +02:00
|
|
|
);
|
2019-10-02 20:22:42 +02:00
|
|
|
|
|
|
|
$this->commandTester->execute(['longUrl' => 'http://domain.com/invalid', '--customSlug' => 'my-slug']);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 00:35:14 +02:00
|
|
|
self::assertEquals(ExitCodes::EXIT_FAILURE, $this->commandTester->getStatusCode());
|
|
|
|
self::assertStringContainsString('Provided slug "my-slug" is already in use', $output);
|
2019-10-02 20:22:42 +02:00
|
|
|
$urlToShortCode->shouldHaveBeenCalledOnce();
|
2016-07-30 14:12:56 +02:00
|
|
|
}
|
2018-11-17 18:06:06 +01:00
|
|
|
|
2019-02-17 20:28:34 +01:00
|
|
|
/** @test */
|
2019-10-02 20:22:42 +02:00
|
|
|
public function properlyProcessesProvidedTags(): void
|
2018-11-17 18:06:06 +01:00
|
|
|
{
|
2019-10-11 09:14:25 +02:00
|
|
|
$shortUrl = new ShortUrl('');
|
2020-11-06 20:05:57 +01:00
|
|
|
$urlToShortCode = $this->urlShortener->shorten(
|
2020-06-27 11:09:56 +02:00
|
|
|
Argument::type('string'),
|
2018-11-17 18:06:06 +01:00
|
|
|
Argument::that(function (array $tags) {
|
|
|
|
Assert::assertEquals(['foo', 'bar', 'baz', 'boo', 'zar'], $tags);
|
|
|
|
return $tags;
|
|
|
|
}),
|
2020-01-01 20:48:31 +01:00
|
|
|
Argument::cetera(),
|
2019-10-11 09:14:25 +02:00
|
|
|
)->willReturn($shortUrl);
|
2018-11-17 18:06:06 +01:00
|
|
|
|
|
|
|
$this->commandTester->execute([
|
|
|
|
'longUrl' => 'http://domain.com/foo/bar',
|
2019-02-03 12:09:56 +01:00
|
|
|
'--tags' => ['foo,bar', 'baz', 'boo,zar,baz'],
|
2018-11-17 18:06:06 +01:00
|
|
|
]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 00:35:14 +02:00
|
|
|
self::assertEquals(ExitCodes::EXIT_SUCCESS, $this->commandTester->getStatusCode());
|
|
|
|
self::assertStringContainsString($shortUrl->toString(self::DOMAIN_CONFIG), $output);
|
2018-11-17 18:06:06 +01:00
|
|
|
$urlToShortCode->shouldHaveBeenCalledOnce();
|
|
|
|
}
|
2020-09-24 21:54:03 +02:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideFlags
|
|
|
|
*/
|
|
|
|
public function urlValidationHasExpectedValueBasedOnProvidedTags(array $options, ?bool $expectedValidateUrl): void
|
|
|
|
{
|
|
|
|
$shortUrl = new ShortUrl('');
|
2020-11-06 20:05:57 +01:00
|
|
|
$urlToShortCode = $this->urlShortener->shorten(
|
2020-09-24 21:54:03 +02:00
|
|
|
Argument::type('string'),
|
|
|
|
Argument::type('array'),
|
|
|
|
Argument::that(function (ShortUrlMeta $meta) use ($expectedValidateUrl) {
|
|
|
|
Assert::assertEquals($expectedValidateUrl, $meta->doValidateUrl());
|
|
|
|
return $meta;
|
|
|
|
}),
|
|
|
|
)->willReturn($shortUrl);
|
|
|
|
|
|
|
|
$options['longUrl'] = 'http://domain.com/foo/bar';
|
|
|
|
$this->commandTester->execute($options);
|
|
|
|
|
|
|
|
$urlToShortCode->shouldHaveBeenCalledOnce();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideFlags(): iterable
|
|
|
|
{
|
|
|
|
yield 'no flags' => [[], null];
|
|
|
|
yield 'no-validate-url only' => [['--no-validate-url' => true], false];
|
|
|
|
yield 'validate-url' => [['--validate-url' => true], true];
|
|
|
|
yield 'both flags' => [['--validate-url' => true, '--no-validate-url' => true], false];
|
|
|
|
}
|
2016-07-30 14:12:56 +02:00
|
|
|
}
|