2016-07-31 16:58:18 +03:00
|
|
|
<?php
|
2019-10-05 18:26:10 +03:00
|
|
|
|
2017-10-12 11:13:20 +03:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2018-09-20 20:55:24 +03:00
|
|
|
namespace ShlinkioTest\Shlink\Rest\Action\ShortUrl;
|
2016-07-31 16:58:18 +03:00
|
|
|
|
2019-12-01 14:26:31 +03:00
|
|
|
use Cake\Chronos\Chronos;
|
2020-01-01 23:11:53 +03:00
|
|
|
use Laminas\Diactoros\ServerRequest;
|
|
|
|
use Laminas\Diactoros\ServerRequestFactory;
|
2017-03-24 22:34:18 +03:00
|
|
|
use PHPUnit\Framework\TestCase;
|
2016-07-31 16:58:18 +03:00
|
|
|
use Prophecy\Argument;
|
2020-11-02 13:50:19 +03:00
|
|
|
use Prophecy\PhpUnit\ProphecyTrait;
|
2016-07-31 16:58:18 +03:00
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
2018-09-12 21:32:58 +03:00
|
|
|
use Shlinkio\Shlink\Core\Entity\ShortUrl;
|
2019-11-25 01:45:40 +03:00
|
|
|
use Shlinkio\Shlink\Core\Exception\ValidationException;
|
2019-12-01 14:26:31 +03:00
|
|
|
use Shlinkio\Shlink\Core\Model\ShortUrlMeta;
|
2016-07-31 16:58:18 +03:00
|
|
|
use Shlinkio\Shlink\Core\Service\UrlShortener;
|
2018-09-20 20:55:24 +03:00
|
|
|
use Shlinkio\Shlink\Rest\Action\ShortUrl\CreateShortUrlAction;
|
2020-11-08 13:28:27 +03:00
|
|
|
use Shlinkio\Shlink\Rest\Entity\ApiKey;
|
2019-02-27 00:56:43 +03:00
|
|
|
|
2018-10-28 10:34:02 +03:00
|
|
|
use function strpos;
|
2016-07-31 16:58:18 +03:00
|
|
|
|
2018-09-20 20:55:24 +03:00
|
|
|
class CreateShortUrlActionTest extends TestCase
|
2016-07-31 16:58:18 +03:00
|
|
|
{
|
2020-11-02 13:50:19 +03:00
|
|
|
use ProphecyTrait;
|
|
|
|
|
2019-10-11 10:14:25 +03:00
|
|
|
private const DOMAIN_CONFIG = [
|
|
|
|
'schema' => 'http',
|
|
|
|
'hostname' => 'foo.com',
|
|
|
|
];
|
|
|
|
|
2019-12-30 00:48:40 +03:00
|
|
|
private CreateShortUrlAction $action;
|
|
|
|
private ObjectProphecy $urlShortener;
|
2016-07-31 16:58:18 +03:00
|
|
|
|
2019-02-16 12:53:45 +03:00
|
|
|
public function setUp(): void
|
2016-07-31 16:58:18 +03:00
|
|
|
{
|
|
|
|
$this->urlShortener = $this->prophesize(UrlShortener::class);
|
2019-10-11 10:14:25 +03:00
|
|
|
$this->action = new CreateShortUrlAction($this->urlShortener->reveal(), self::DOMAIN_CONFIG);
|
2016-07-31 16:58:18 +03:00
|
|
|
}
|
|
|
|
|
2019-02-17 22:28:34 +03:00
|
|
|
/** @test */
|
2019-10-02 21:15:14 +03:00
|
|
|
public function missingLongUrlParamReturnsError(): void
|
2016-07-31 16:58:18 +03:00
|
|
|
{
|
2019-11-25 01:45:40 +03:00
|
|
|
$this->expectException(ValidationException::class);
|
|
|
|
$this->action->handle(new ServerRequest());
|
2016-07-31 16:58:18 +03:00
|
|
|
}
|
|
|
|
|
2019-12-01 14:26:31 +03:00
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideRequestBodies
|
|
|
|
*/
|
2020-11-08 13:28:27 +03:00
|
|
|
public function properShortcodeConversionReturnsData(array $body, array $expectedMeta): void
|
2016-07-31 16:58:18 +03:00
|
|
|
{
|
2020-11-08 13:28:27 +03:00
|
|
|
$apiKey = new ApiKey();
|
2019-10-11 10:14:25 +03:00
|
|
|
$shortUrl = new ShortUrl('');
|
2020-11-08 13:28:27 +03:00
|
|
|
$expectedMeta['apiKey'] = $apiKey->toString();
|
|
|
|
|
2020-11-06 22:05:57 +03:00
|
|
|
$shorten = $this->urlShortener->shorten(
|
2020-06-27 12:09:56 +03:00
|
|
|
Argument::type('string'),
|
2019-12-01 14:26:31 +03:00
|
|
|
Argument::type('array'),
|
2020-11-08 13:28:27 +03:00
|
|
|
ShortUrlMeta::fromRawData($expectedMeta),
|
2019-12-01 14:26:31 +03:00
|
|
|
)->willReturn($shortUrl);
|
2016-07-31 16:58:18 +03:00
|
|
|
|
2020-11-08 13:28:27 +03:00
|
|
|
$request = ServerRequestFactory::fromGlobals()->withParsedBody($body)->withAttribute(ApiKey::class, $apiKey);
|
2020-11-07 12:23:08 +03:00
|
|
|
|
2018-03-26 20:02:41 +03:00
|
|
|
$response = $this->action->handle($request);
|
2019-12-01 14:26:31 +03:00
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertEquals(200, $response->getStatusCode());
|
|
|
|
self::assertTrue(strpos($response->getBody()->getContents(), $shortUrl->toString(self::DOMAIN_CONFIG)) > 0);
|
2019-12-01 14:26:31 +03:00
|
|
|
$shorten->shouldHaveBeenCalledOnce();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideRequestBodies(): iterable
|
|
|
|
{
|
|
|
|
$fullMeta = [
|
|
|
|
'longUrl' => 'http://www.domain.com/foo/bar',
|
|
|
|
'validSince' => Chronos::now()->toAtomString(),
|
|
|
|
'validUntil' => Chronos::now()->toAtomString(),
|
|
|
|
'customSlug' => 'foo-bar-baz',
|
|
|
|
'maxVisits' => 50,
|
|
|
|
'findIfExists' => true,
|
|
|
|
'domain' => 'my-domain.com',
|
|
|
|
];
|
|
|
|
|
2020-11-08 13:28:27 +03:00
|
|
|
yield 'no data' => [['longUrl' => 'http://www.domain.com/foo/bar'], []];
|
|
|
|
yield 'all data' => [$fullMeta, $fullMeta];
|
2016-07-31 16:58:18 +03:00
|
|
|
}
|
|
|
|
|
2019-10-20 11:30:11 +03:00
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideInvalidDomains
|
|
|
|
*/
|
|
|
|
public function anInvalidDomainReturnsError(string $domain): void
|
|
|
|
{
|
|
|
|
$shortUrl = new ShortUrl('');
|
2020-11-06 22:05:57 +03:00
|
|
|
$urlToShortCode = $this->urlShortener->shorten(Argument::cetera())->willReturn($shortUrl);
|
2019-10-20 11:30:11 +03:00
|
|
|
|
|
|
|
$request = (new ServerRequest())->withParsedBody([
|
|
|
|
'longUrl' => 'http://www.domain.com/foo/bar',
|
|
|
|
'domain' => $domain,
|
2020-11-08 13:28:27 +03:00
|
|
|
])->withAttribute(ApiKey::class, new ApiKey());
|
2019-10-20 11:30:11 +03:00
|
|
|
|
2019-11-25 01:45:40 +03:00
|
|
|
$this->expectException(ValidationException::class);
|
|
|
|
$urlToShortCode->shouldNotBeCalled();
|
|
|
|
|
|
|
|
$this->action->handle($request);
|
2019-10-20 11:30:11 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
public function provideInvalidDomains(): iterable
|
|
|
|
{
|
|
|
|
yield ['localhost:80000'];
|
|
|
|
yield ['127.0.0.1'];
|
|
|
|
yield ['???/&%$&'];
|
|
|
|
}
|
2016-07-31 16:58:18 +03:00
|
|
|
}
|