2016-07-30 15:42:09 +03:00
|
|
|
<?php
|
2019-10-05 18:26:10 +03:00
|
|
|
|
2017-10-12 11:13:20 +03:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2016-08-15 12:01:55 +03:00
|
|
|
namespace ShlinkioTest\Shlink\CLI\Command\Visit;
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2022-10-22 13:46:16 +03:00
|
|
|
use PHPUnit\Framework\MockObject\MockObject;
|
2017-03-24 22:34:18 +03:00
|
|
|
use PHPUnit\Framework\TestCase;
|
2021-04-08 14:12:37 +03:00
|
|
|
use Shlinkio\Shlink\CLI\Command\Visit\DownloadGeoLiteDbCommand;
|
2019-04-14 10:10:00 +03:00
|
|
|
use Shlinkio\Shlink\CLI\Command\Visit\LocateVisitsCommand;
|
2021-04-08 14:12:37 +03:00
|
|
|
use Shlinkio\Shlink\CLI\Util\ExitCodes;
|
2022-09-18 20:21:59 +03:00
|
|
|
use Shlinkio\Shlink\Core\Exception\IpCannotBeLocatedException;
|
2022-09-23 20:03:32 +03:00
|
|
|
use Shlinkio\Shlink\Core\ShortUrl\Entity\ShortUrl;
|
|
|
|
use Shlinkio\Shlink\Core\Visit\Entity\Visit;
|
|
|
|
use Shlinkio\Shlink\Core\Visit\Entity\VisitLocation;
|
2022-09-23 15:50:26 +03:00
|
|
|
use Shlinkio\Shlink\Core\Visit\Geolocation\VisitGeolocationHelperInterface;
|
2022-10-24 20:53:13 +03:00
|
|
|
use Shlinkio\Shlink\Core\Visit\Geolocation\VisitLocatorInterface;
|
2022-09-23 15:50:26 +03:00
|
|
|
use Shlinkio\Shlink\Core\Visit\Geolocation\VisitToLocationHelperInterface;
|
2022-09-23 19:05:17 +03:00
|
|
|
use Shlinkio\Shlink\Core\Visit\Model\Visitor;
|
2019-08-11 00:26:39 +03:00
|
|
|
use Shlinkio\Shlink\IpGeolocation\Exception\WrongIpException;
|
2019-08-10 14:42:37 +03:00
|
|
|
use Shlinkio\Shlink\IpGeolocation\Model\Location;
|
2021-04-08 14:12:37 +03:00
|
|
|
use ShlinkioTest\Shlink\CLI\CliTestUtilsTrait;
|
2022-10-24 20:53:13 +03:00
|
|
|
use Symfony\Component\Console\Command\Command;
|
2020-03-28 12:23:34 +03:00
|
|
|
use Symfony\Component\Console\Exception\RuntimeException;
|
2018-10-18 20:19:42 +03:00
|
|
|
use Symfony\Component\Console\Output\OutputInterface;
|
2016-07-30 15:42:09 +03:00
|
|
|
use Symfony\Component\Console\Tester\CommandTester;
|
2018-11-17 16:10:38 +03:00
|
|
|
use Symfony\Component\Lock;
|
2019-02-27 00:56:43 +03:00
|
|
|
|
2018-11-17 16:10:38 +03:00
|
|
|
use function sprintf;
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
use const PHP_EOL;
|
|
|
|
|
2019-04-14 10:10:00 +03:00
|
|
|
class LocateVisitsCommandTest extends TestCase
|
2016-07-30 15:42:09 +03:00
|
|
|
{
|
2021-04-08 14:12:37 +03:00
|
|
|
use CliTestUtilsTrait;
|
2020-11-02 13:50:19 +03:00
|
|
|
|
2019-12-30 00:27:00 +03:00
|
|
|
private CommandTester $commandTester;
|
2022-10-24 20:53:13 +03:00
|
|
|
private MockObject & VisitLocatorInterface $visitService;
|
|
|
|
private MockObject & VisitToLocationHelperInterface $visitToLocation;
|
|
|
|
private MockObject & Lock\LockInterface $lock;
|
|
|
|
private MockObject & Command $downloadDbCommand;
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2022-09-11 13:02:49 +03:00
|
|
|
protected function setUp(): void
|
2016-07-30 15:42:09 +03:00
|
|
|
{
|
2022-10-24 20:53:13 +03:00
|
|
|
$this->visitService = $this->createMock(VisitLocatorInterface::class);
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->visitToLocation = $this->createMock(VisitToLocationHelperInterface::class);
|
|
|
|
|
|
|
|
$locker = $this->createMock(Lock\LockFactory::class);
|
|
|
|
$this->lock = $this->createMock(Lock\LockInterface::class);
|
|
|
|
$locker->method('createLock')->with($this->isType('string'), 600.0, false)->willReturn($this->lock);
|
|
|
|
|
|
|
|
$command = new LocateVisitsCommand($this->visitService, $this->visitToLocation, $locker);
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2021-04-08 14:12:37 +03:00
|
|
|
$this->downloadDbCommand = $this->createCommandMock(DownloadGeoLiteDbCommand::NAME);
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->commandTester = $this->testerForCommand($command, $this->downloadDbCommand);
|
2016-07-30 15:42:09 +03:00
|
|
|
}
|
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideArgs
|
|
|
|
*/
|
|
|
|
public function expectedSetOfVisitsIsProcessedBasedOnArgs(
|
|
|
|
int $expectedUnlocatedCalls,
|
|
|
|
int $expectedEmptyCalls,
|
|
|
|
int $expectedAllCalls,
|
|
|
|
bool $expectWarningPrint,
|
2021-05-23 13:31:10 +03:00
|
|
|
array $args,
|
2020-03-28 12:23:34 +03:00
|
|
|
): void {
|
2021-02-07 23:31:12 +03:00
|
|
|
$visit = Visit::forValidShortUrl(ShortUrl::createEmpty(), new Visitor('', '', '1.2.3.4', ''));
|
2021-04-11 00:24:01 +03:00
|
|
|
$location = VisitLocation::fromGeolocation(Location::emptyInstance());
|
2020-03-28 12:23:34 +03:00
|
|
|
$mockMethodBehavior = $this->invokeHelperMethods($visit, $location);
|
2018-10-28 18:20:10 +03:00
|
|
|
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(true);
|
|
|
|
$this->visitService->expects($this->exactly($expectedUnlocatedCalls))
|
|
|
|
->method('locateUnlocatedVisits')
|
|
|
|
->withAnyParameters()
|
|
|
|
->willReturnCallback($mockMethodBehavior);
|
|
|
|
$this->visitService->expects($this->exactly($expectedEmptyCalls))
|
|
|
|
->method('locateVisitsWithEmptyLocation')
|
|
|
|
->withAnyParameters()
|
|
|
|
->willReturnCallback($mockMethodBehavior);
|
|
|
|
$this->visitService->expects($this->exactly($expectedAllCalls))
|
|
|
|
->method('locateAllVisits')
|
|
|
|
->withAnyParameters()
|
|
|
|
->willReturnCallback($mockMethodBehavior);
|
|
|
|
$this->visitToLocation->expects(
|
|
|
|
$this->exactly($expectedUnlocatedCalls + $expectedEmptyCalls + $expectedAllCalls),
|
|
|
|
)->method('resolveVisitLocation')->withAnyParameters()->willReturn(Location::emptyInstance());
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
$this->commandTester->setInputs(['y']);
|
|
|
|
$this->commandTester->execute($args);
|
2016-07-30 15:42:09 +03:00
|
|
|
$output = $this->commandTester->getDisplay();
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString('Processing IP 1.2.3.0', $output);
|
2020-03-28 12:23:34 +03:00
|
|
|
if ($expectWarningPrint) {
|
2020-10-25 19:59:37 +03:00
|
|
|
self::assertStringContainsString('Continue at your own', $output);
|
2020-03-28 12:23:34 +03:00
|
|
|
} else {
|
2020-10-25 19:59:37 +03:00
|
|
|
self::assertStringNotContainsString('Continue at your own', $output);
|
2020-03-28 12:23:34 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideArgs(): iterable
|
|
|
|
{
|
|
|
|
yield 'no args' => [1, 0, 0, false, []];
|
|
|
|
yield 'retry' => [1, 1, 0, false, ['--retry' => true]];
|
|
|
|
yield 'all' => [0, 0, 1, true, ['--retry' => true, '--all' => true]];
|
2016-07-30 15:42:09 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
2018-11-17 11:42:15 +03:00
|
|
|
* @dataProvider provideIgnoredAddresses
|
2016-07-30 15:42:09 +03:00
|
|
|
*/
|
2022-09-18 20:21:59 +03:00
|
|
|
public function localhostAndEmptyAddressesAreIgnored(IpCannotBeLocatedException $e, string $message): void
|
2016-07-30 15:42:09 +03:00
|
|
|
{
|
2022-09-18 20:21:59 +03:00
|
|
|
$visit = Visit::forValidShortUrl(ShortUrl::createEmpty(), Visitor::emptyInstance());
|
2021-04-11 00:24:01 +03:00
|
|
|
$location = VisitLocation::fromGeolocation(Location::emptyInstance());
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(true);
|
|
|
|
$this->visitService->expects($this->once())
|
|
|
|
->method('locateUnlocatedVisits')
|
|
|
|
->withAnyParameters()
|
|
|
|
->willReturnCallback($this->invokeHelperMethods($visit, $location));
|
|
|
|
$this->visitToLocation->expects($this->once())->method('resolveVisitLocation')->willThrowException($e);
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2019-04-14 23:20:58 +03:00
|
|
|
$this->commandTester->execute([], ['verbosity' => OutputInterface::VERBOSITY_VERBOSE]);
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2019-02-17 14:59:55 +03:00
|
|
|
$output = $this->commandTester->getDisplay();
|
2022-09-18 20:21:59 +03:00
|
|
|
self::assertStringContainsString('Processing IP', $output);
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString($message, $output);
|
2018-11-17 11:42:15 +03:00
|
|
|
}
|
|
|
|
|
2019-02-17 14:59:55 +03:00
|
|
|
public function provideIgnoredAddresses(): iterable
|
2018-11-17 11:42:15 +03:00
|
|
|
{
|
2022-09-18 20:21:59 +03:00
|
|
|
yield 'empty address' => [IpCannotBeLocatedException::forEmptyAddress(), 'Ignored visit with no IP address'];
|
|
|
|
yield 'localhost address' => [IpCannotBeLocatedException::forLocalhost(), 'Ignored localhost address'];
|
2018-11-17 11:42:15 +03:00
|
|
|
}
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2019-02-17 14:59:55 +03:00
|
|
|
/** @test */
|
|
|
|
public function errorWhileLocatingIpIsDisplayed(): void
|
2018-11-17 11:42:15 +03:00
|
|
|
{
|
2021-02-07 23:31:12 +03:00
|
|
|
$visit = Visit::forValidShortUrl(ShortUrl::createEmpty(), new Visitor('', '', '1.2.3.4', ''));
|
2021-04-11 00:24:01 +03:00
|
|
|
$location = VisitLocation::fromGeolocation(Location::emptyInstance());
|
2016-07-30 15:42:09 +03:00
|
|
|
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(true);
|
|
|
|
$this->visitService->expects($this->once())
|
|
|
|
->method('locateUnlocatedVisits')
|
|
|
|
->withAnyParameters()
|
|
|
|
->willReturnCallback($this->invokeHelperMethods($visit, $location));
|
|
|
|
$this->visitToLocation->expects($this->once())->method('resolveVisitLocation')->willThrowException(
|
2022-09-18 20:21:59 +03:00
|
|
|
IpCannotBeLocatedException::forError(WrongIpException::fromIpAddress('1.2.3.4')),
|
|
|
|
);
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2019-04-14 23:20:58 +03:00
|
|
|
$this->commandTester->execute([], ['verbosity' => OutputInterface::VERBOSITY_VERBOSE]);
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2019-02-17 14:59:55 +03:00
|
|
|
$output = $this->commandTester->getDisplay();
|
2018-11-17 11:42:15 +03:00
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString('An error occurred while locating IP. Skipped', $output);
|
2016-07-30 15:42:09 +03:00
|
|
|
}
|
2018-11-17 16:10:38 +03:00
|
|
|
|
2020-03-28 10:05:15 +03:00
|
|
|
private function invokeHelperMethods(Visit $visit, VisitLocation $location): callable
|
|
|
|
{
|
2022-10-22 15:16:42 +03:00
|
|
|
return static function (VisitGeolocationHelperInterface $helper) use ($visit, $location): void {
|
2020-03-28 10:05:15 +03:00
|
|
|
$helper->geolocateVisit($visit);
|
|
|
|
$helper->onVisitLocated($location, $visit);
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
2019-02-17 22:28:34 +03:00
|
|
|
/** @test */
|
2019-08-04 12:16:46 +03:00
|
|
|
public function noActionIsPerformedIfLockIsAcquired(): void
|
2018-11-17 16:10:38 +03:00
|
|
|
{
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(false);
|
2018-11-17 16:10:38 +03:00
|
|
|
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->visitService->expects($this->never())->method('locateUnlocatedVisits');
|
|
|
|
$this->visitToLocation->expects($this->never())->method('resolveVisitLocation');
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
2018-11-17 16:10:38 +03:00
|
|
|
|
2019-04-14 23:20:58 +03:00
|
|
|
$this->commandTester->execute([], ['verbosity' => OutputInterface::VERBOSITY_VERBOSE]);
|
2018-11-17 16:10:38 +03:00
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString(
|
2019-08-04 12:16:46 +03:00
|
|
|
sprintf('Command "%s" is already in progress. Skipping.', LocateVisitsCommand::NAME),
|
2020-01-01 22:48:31 +03:00
|
|
|
$output,
|
2018-11-17 16:10:38 +03:00
|
|
|
);
|
|
|
|
}
|
2019-04-14 18:59:22 +03:00
|
|
|
|
2021-04-08 14:12:37 +03:00
|
|
|
/** @test */
|
|
|
|
public function showsProperMessageWhenGeoLiteUpdateFails(): void
|
2019-04-14 18:59:22 +03:00
|
|
|
{
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(true);
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_FAILURE);
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->visitService->expects($this->never())->method('locateUnlocatedVisits');
|
2019-04-14 18:59:22 +03:00
|
|
|
|
|
|
|
$this->commandTester->execute([]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2021-04-08 14:12:37 +03:00
|
|
|
self::assertStringContainsString('It is not possible to locate visits without a GeoLite2 db file.', $output);
|
2019-04-14 18:59:22 +03:00
|
|
|
}
|
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
/** @test */
|
|
|
|
public function providingAllFlagOnItsOwnDisplaysNotice(): void
|
|
|
|
{
|
2022-10-22 15:16:42 +03:00
|
|
|
$this->lock->method('acquire')->with($this->isFalse())->willReturn(true);
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
$this->commandTester->execute(['--all' => true]);
|
|
|
|
$output = $this->commandTester->getDisplay();
|
|
|
|
|
2020-10-04 01:35:14 +03:00
|
|
|
self::assertStringContainsString('The --all flag has no effect on its own', $output);
|
2020-03-28 12:23:34 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideAbortInputs
|
|
|
|
*/
|
|
|
|
public function processingAllCancelsCommandIfUserDoesNotActivelyAgreeToConfirmation(array $inputs): void
|
|
|
|
{
|
2022-10-22 13:46:16 +03:00
|
|
|
$this->downloadDbCommand->method('run')->withAnyParameters()->willReturn(ExitCodes::EXIT_SUCCESS);
|
|
|
|
|
2020-03-28 12:23:34 +03:00
|
|
|
$this->expectException(RuntimeException::class);
|
|
|
|
$this->expectExceptionMessage('Execution aborted');
|
|
|
|
|
|
|
|
$this->commandTester->setInputs($inputs);
|
|
|
|
$this->commandTester->execute(['--all' => true, '--retry' => true]);
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideAbortInputs(): iterable
|
|
|
|
{
|
|
|
|
yield 'n' => [['n']];
|
|
|
|
yield 'no' => [['no']];
|
|
|
|
yield 'default' => [[PHP_EOL]];
|
|
|
|
}
|
2016-07-30 15:42:09 +03:00
|
|
|
}
|