Refactored ServersDropdown into functional component

This commit is contained in:
Alejandro Celaya 2020-04-27 12:30:17 +02:00
parent bcf5dcf180
commit bdd7932e07

View file

@ -4,8 +4,7 @@ import { DropdownItem, DropdownMenu, DropdownToggle, UncontrolledDropdown } from
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import { serverType } from './prop-types'; import { serverType } from './prop-types';
const ServersDropdown = (serversExporter) => class ServersDropdown extends React.Component { const propTypes = {
static propTypes = {
servers: PropTypes.object, servers: PropTypes.object,
selectedServer: serverType, selectedServer: serverType,
history: PropTypes.shape({ history: PropTypes.shape({
@ -13,12 +12,12 @@ const ServersDropdown = (serversExporter) => class ServersDropdown extends React
}), }),
}; };
renderServers = () => { const ServersDropdown = (serversExporter) => {
const { servers, selectedServer } = this.props; const ServersDropdownComp = ({ servers, selectedServer, history }) => {
const serversList = values(servers); const serversList = values(servers);
const { push } = this.props.history; const loadServer = (id) => history.push(`/server/${id}/list-short-urls/1`);
const loadServer = (id) => push(`/server/${id}/list-short-urls/1`);
const renderServers = () => {
if (isEmpty(serversList)) { if (isEmpty(serversList)) {
return <DropdownItem disabled><i>Add a server first...</i></DropdownItem>; return <DropdownItem disabled><i>Add a server first...</i></DropdownItem>;
} }
@ -38,12 +37,17 @@ const ServersDropdown = (serversExporter) => class ServersDropdown extends React
); );
}; };
render = () => ( return (
<UncontrolledDropdown nav inNavbar> <UncontrolledDropdown nav inNavbar>
<DropdownToggle nav caret>Servers</DropdownToggle> <DropdownToggle nav caret>Servers</DropdownToggle>
<DropdownMenu right>{this.renderServers()}</DropdownMenu> <DropdownMenu right>{renderServers()}</DropdownMenu>
</UncontrolledDropdown> </UncontrolledDropdown>
); );
}; };
ServersDropdownComp.propTypes = propTypes;
return ServersDropdownComp;
};
export default ServersDropdown; export default ServersDropdown;