Enable react-hooks/exhaustive-deps linting rule

This commit is contained in:
Alejandro Celaya 2023-09-02 19:48:23 +02:00
parent 973f3e3c8b
commit a23d441dd3
3 changed files with 3 additions and 4 deletions

View file

@ -8,7 +8,6 @@
},
"ignorePatterns": ["src/service*.ts"],
"rules": {
"react-hooks/rules-of-hooks": "off",
"react-hooks/exhaustive-deps": "off"
"react-hooks/rules-of-hooks": "off"
}
}

View file

@ -18,7 +18,7 @@ export function withSelectedServer<T = {}>(WrappedComponent: FC<WithSelectedServ
useEffect(() => {
params.serverId && selectServer(params.serverId);
}, [params.serverId]);
}, [params.serverId, selectServer]);
if (!selectedServer) {
return (

View file

@ -10,7 +10,7 @@ export function withoutSelectedServer<T = {}>(WrappedComponent: FC<WithoutSelect
const { resetSelectedServer } = props;
useEffect(() => {
resetSelectedServer();
}, []);
}, [resetSelectedServer]);
return <WrappedComponent {...props} />;
};