Created shortUrlDeletion reducer test

src/short-urls/reducers/shortUrlDeletion.js

@@ -1,10 +1,10 @@
 import PropTypes from 'prop-types';
 
 /* eslint-disable padding-line-between-statements, newline-after-var */
-const DELETE_SHORT_URL_START = 'shlink/deleteShortUrl/DELETE_SHORT_URL_START';
+export const DELETE_SHORT_URL_START = 'shlink/deleteShortUrl/DELETE_SHORT_URL_START';
-const DELETE_SHORT_URL_ERROR = 'shlink/deleteShortUrl/DELETE_SHORT_URL_ERROR';
+export const DELETE_SHORT_URL_ERROR = 'shlink/deleteShortUrl/DELETE_SHORT_URL_ERROR';
-const DELETE_SHORT_URL = 'shlink/deleteShortUrl/DELETE_SHORT_URL';
+export const DELETE_SHORT_URL = 'shlink/deleteShortUrl/DELETE_SHORT_URL';
-const RESET_DELETE_SHORT_URL = 'shlink/deleteShortUrl/RESET_DELETE_SHORT_URL';
+export const RESET_DELETE_SHORT_URL = 'shlink/deleteShortUrl/RESET_DELETE_SHORT_URL';
 export const SHORT_URL_DELETED = 'shlink/deleteShortUrl/SHORT_URL_DELETED';
 /* eslint-enable padding-line-between-statements, newline-after-var */
 
@@ -58,10 +58,10 @@ export const deleteShortUrl = (buildShlinkApiClient) => (shortCode) => async (di
   dispatch({ type: DELETE_SHORT_URL_START });
 
   const { selectedServer } = getState();
-  const shlinkApiClient = buildShlinkApiClient(selectedServer);
+  const { deleteShortUrl } = buildShlinkApiClient(selectedServer);
 
   try {
-    await shlinkApiClient.deleteShortUrl(shortCode);
+    await deleteShortUrl(shortCode);
     dispatch({ type: DELETE_SHORT_URL, shortCode });
   } catch (e) {
     dispatch({ type: DELETE_SHORT_URL_ERROR, errorData: e.response.data });

test/short-urls/reducers/shortUrlDeleteion.test.js

@@ -0,0 +1,115 @@
+import * as sinon from 'sinon';
+import reducer, {
+  DELETE_SHORT_URL, DELETE_SHORT_URL_ERROR,
+  DELETE_SHORT_URL_START,
+  RESET_DELETE_SHORT_URL,
+  SHORT_URL_DELETED,
+  resetDeleteShortUrl,
+  shortUrlDeleted,
+  deleteShortUrl,
+} from '../../../src/short-urls/reducers/shortUrlDeletion';
+
+describe('shortUrlDeletionReducer', () => {
+  describe('reducer', () => {
+    it('returns loading on DELETE_SHORT_URL_START', () =>
+      expect(reducer(undefined, { type: DELETE_SHORT_URL_START })).toEqual({
+        shortCode: '',
+        loading: true,
+        error: false,
+        errorData: {},
+      }));
+
+    it('returns default on RESET_DELETE_SHORT_URL', () =>
+      expect(reducer(undefined, { type: RESET_DELETE_SHORT_URL })).toEqual({
+        shortCode: '',
+        loading: false,
+        error: false,
+        errorData: {},
+      }));
+
+    it('returns shortCode on DELETE_SHORT_URL', () =>
+      expect(reducer(undefined, { type: DELETE_SHORT_URL, shortCode: 'foo' })).toEqual({
+        shortCode: 'foo',
+        loading: false,
+        error: false,
+        errorData: {},
+      }));
+
+    it('returns errorData on DELETE_SHORT_URL_ERROR', () => {
+      const errorData = { foo: 'bar' };
+
+      expect(reducer(undefined, { type: DELETE_SHORT_URL_ERROR, errorData })).toEqual({
+        shortCode: '',
+        loading: false,
+        error: true,
+        errorData,
+      });
+    });
+
+    it('returns provided state as is on unknown action', () => {
+      const state = { foo: 'bar' };
+
+      expect(reducer(state, { type: 'unknown' })).toEqual(state);
+    });
+  });
+
+  describe('resetDeleteShortUrl', () => {
+    it('returns expected action', () =>
+      expect(resetDeleteShortUrl()).toEqual({ type: RESET_DELETE_SHORT_URL }));
+  });
+
+  describe('shortUrlDeleted', () => {
+    it('returns expected action', () =>
+      expect(shortUrlDeleted('abc123')).toEqual({ type: SHORT_URL_DELETED, shortCode: 'abc123' }));
+  });
+
+  describe('deleteShortUrl', () => {
+    const dispatch = sinon.spy();
+    const getState = sinon.fake.returns({ selectedServer: {} });
+
+    afterEach(() => {
+      dispatch.resetHistory();
+      getState.resetHistory();
+    });
+
+    it('dispatches proper actions if API client request succeeds', async () => {
+      const apiClientMock = {
+        deleteShortUrl: sinon.fake.resolves(''),
+      };
+      const shortCode = 'abc123';
+      const expectedDispatchCalls = 2;
+
+      await deleteShortUrl(() => apiClientMock)(shortCode)(dispatch, getState);
+
+      expect(dispatch.callCount).toEqual(expectedDispatchCalls);
+      expect(dispatch.getCall(0).args).toEqual([{ type: DELETE_SHORT_URL_START }]);
+      expect(dispatch.getCall(1).args).toEqual([{ type: DELETE_SHORT_URL, shortCode }]);
+
+      expect(apiClientMock.deleteShortUrl.callCount).toEqual(1);
+      expect(apiClientMock.deleteShortUrl.getCall(0).args).toEqual([ shortCode ]);
+    });
+
+    it('dispatches proper actions if API client request fails', async () => {
+      const data = { foo: 'bar' };
+      const error = { response: { data } };
+      const apiClientMock = {
+        deleteShortUrl: sinon.fake.returns(Promise.reject(error)),
+      };
+      const shortCode = 'abc123';
+      const expectedDispatchCalls = 2;
+
+      try {
+        await deleteShortUrl(() => apiClientMock)(shortCode)(dispatch, getState);
+      } catch (e) {
+        expect(e).toEqual(error);
+      }
+
+      expect(dispatch.callCount).toEqual(expectedDispatchCalls);
+      expect(dispatch.getCall(0).args).toEqual([{ type: DELETE_SHORT_URL_START }]);
+      expect(dispatch.getCall(1).args).toEqual([{ type: DELETE_SHORT_URL_ERROR, errorData: data }]);
+
+      expect(apiClientMock.deleteShortUrl.callCount).toEqual(1);
+      expect(apiClientMock.deleteShortUrl.getCall(0).args).toEqual([ shortCode ]);
+    });
+  });
+});