Normalized mocks

test/common/services/ImageDownloader.test.ts

@@ -1,7 +1,7 @@
 import { Mock } from 'ts-mockery';
 import { AxiosInstance } from 'axios';
 import { ImageDownloader } from '../../../src/common/services/ImageDownloader';
-import { windowMock } from '../../mocks/WindowMock';
+import { windowMock } from '../../__mocks__/Window.mock';
 
 describe('ImageDownloader', () => {
   const get = jest.fn();

test/common/services/ReportExporter.test.ts

@@ -1,6 +1,6 @@
 import { ReportExporter } from '../../../src/common/services/ReportExporter';
 import { NormalizedVisit } from '../../../src/visits/types';
-import { windowMock } from '../../mocks/WindowMock';
+import { windowMock } from '../../__mocks__/Window.mock';
 import { ExportableShortUrl } from '../../../src/short-urls/data';
 
 describe('ReportExporter', () => {

test/servers/services/ServersExporter.test.ts

@@ -1,7 +1,7 @@
 import { Mock } from 'ts-mockery';
 import ServersExporter from '../../../src/servers/services/ServersExporter';
 import { LocalStorage } from '../../../src/utils/services/LocalStorage';
-import { appendChild, removeChild, windowMock } from '../../mocks/WindowMock';
+import { appendChild, removeChild, windowMock } from '../../__mocks__/Window.mock';
 
 describe('ServersExporter', () => {
   const storageMock = Mock.of<LocalStorage>({

test/short-urls/helpers/ShortUrlsRow.test.tsx

@@ -2,22 +2,17 @@ import { screen } from '@testing-library/react';
 import { Mock } from 'ts-mockery';
 import { formatISO } from 'date-fns';
 import { ShortUrlsRow as createShortUrlsRow } from '../../../src/short-urls/helpers/ShortUrlsRow';
-import { ColorGenerator } from '../../../src/utils/services/ColorGenerator';
 import { TimeoutToggle } from '../../../src/utils/helpers/hooks';
 import { ShortUrl } from '../../../src/short-urls/data';
 import { ReachableServer } from '../../../src/servers/data';
 import { parseDate } from '../../../src/utils/helpers/date';
 import { renderWithEvents } from '../../__helpers__/setUpTest';
 import { OptionalString } from '../../../src/utils/utils';
+import { colorGeneratorMock } from '../../utils/services/__mocks__/ColorGenerator.mock';
 
 describe('<ShortUrlsRow />', () => {
   const timeoutToggle = jest.fn(() => true);
   const useTimeoutToggle = jest.fn(() => [false, timeoutToggle]) as TimeoutToggle;
-  const colorGenerator = Mock.of<ColorGenerator>({
-    getColorForKey: jest.fn(() => 'red'),
-    setColorForKey: jest.fn(),
-    isColorLightForKey: jest.fn(() => false),
-  });
   const server = Mock.of<ReachableServer>({ url: 'https://doma.in' });
   const shortUrl: ShortUrl = {
     shortCode: 'abc123',
@@ -33,7 +28,7 @@ describe('<ShortUrlsRow />', () => {
       maxVisits: null,
     },
   };
-  const ShortUrlsRow = createShortUrlsRow(() => <span>ShortUrlsRowMenu</span>, colorGenerator, useTimeoutToggle);
+  const ShortUrlsRow = createShortUrlsRow(() => <span>ShortUrlsRowMenu</span>, colorGeneratorMock, useTimeoutToggle);
   const setUp = (title?: OptionalString, tags: string[] = []) => renderWithEvents(
     <table>
       <tbody>

test/tags/TagsTableRow.test.tsx

@@ -1,16 +1,31 @@
+import { screen } from '@testing-library/react';
 import { shallow, ShallowWrapper } from 'enzyme';
 import { Mock } from 'ts-mockery';
-import { Link } from 'react-router-dom';
 import { DropdownItem } from 'reactstrap';
+import { MemoryRouter } from 'react-router-dom';
 import { TagsTableRow as createTagsTableRow } from '../../src/tags/TagsTableRow';
 import { ReachableServer } from '../../src/servers/data';
-import { ColorGenerator } from '../../src/utils/services/ColorGenerator';
 import { DropdownBtnMenu } from '../../src/utils/DropdownBtnMenu';
+import { renderWithEvents } from '../__helpers__/setUpTest';
+import { colorGeneratorMock } from '../utils/services/__mocks__/ColorGenerator.mock';
 
 describe('<TagsTableRow />', () => {
   const DeleteTagConfirmModal = () => null;
   const EditTagModal = () => null;
-  const TagsTableRow = createTagsTableRow(DeleteTagConfirmModal, EditTagModal, Mock.all<ColorGenerator>());
+  const TagsTableRow = createTagsTableRow(DeleteTagConfirmModal, EditTagModal, colorGeneratorMock);
+  const setUp = (tagStats?: { visits?: number; shortUrls?: number }) => renderWithEvents(
+    <MemoryRouter>
+      <table>
+        <tbody>
+          <TagsTableRow
+            tag={{ tag: 'foo&bar', visits: tagStats?.visits ?? 0, shortUrls: tagStats?.shortUrls ?? 0 }}
+            selectedServer={Mock.of<ReachableServer>({ id: 'abc123' })}
+          />
+        </tbody>
+      </table>
+    </MemoryRouter>,
+  );
+
   let wrapper: ShallowWrapper;
   const createWrapper = (tagStats?: { visits?: number; shortUrls?: number }) => {
     wrapper = shallow(
@@ -22,22 +37,23 @@ describe('<TagsTableRow />', () => {
 
     return wrapper;
   };
-
   afterEach(() => wrapper?.unmount());
 
   it.each([
     [undefined, '0', '0'],
     [{ shortUrls: 10, visits: 3480 }, '10', '3,480'],
   ])('shows expected tag stats', (stats, expectedShortUrls, expectedVisits) => {
-    const wrapper = createWrapper(stats);
+    setUp(stats);
-    const links = wrapper.find(Link);
-    const shortUrlsLink = links.first();
-    const visitsLink = links.last();
 
-    expect(shortUrlsLink.prop('children')).toEqual(expectedShortUrls);
+    const [shortUrlsLink, visitsLink] = screen.getAllByRole('link');
-    expect(shortUrlsLink.prop('to')).toEqual(`/server/abc123/list-short-urls/1?tags=${encodeURIComponent('foo&bar')}`);
+
-    expect(visitsLink.prop('children')).toEqual(expectedVisits);
+    expect(shortUrlsLink).toHaveTextContent(expectedShortUrls);
-    expect(visitsLink.prop('to')).toEqual('/server/abc123/tag/foo&bar/visits');
+    expect(shortUrlsLink).toHaveAttribute(
+      'href',
+      `/server/abc123/list-short-urls/1?tags=${encodeURIComponent('foo&bar')}`,
+    );
+    expect(visitsLink).toHaveTextContent(expectedVisits);
+    expect(visitsLink).toHaveAttribute('href', '/server/abc123/tag/foo&bar/visits');
   });
 
   it('allows toggling dropdown menu', () => {

test/utils/services/__mocks__/ColorGenerator.mock.ts

@@ -0,0 +1,8 @@
+import { Mock } from 'ts-mockery';
+import { ColorGenerator } from '../../../../src/utils/services/ColorGenerator';
+
+export const colorGeneratorMock = Mock.of<ColorGenerator>({
+  getColorForKey: jest.fn(() => 'red'),
+  setColorForKey: jest.fn(),
+  isColorLightForKey: jest.fn(() => false),
+});