mirrors/shlink-web-client
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink-web-client.git synced 2025-01-10 18:27:25 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #665 from acelaya-forks/feature/rtl-why-not

Browse source 
Feature/rtl why not
This commit is contained in:
Alejandro Celaya 2022-06-09 07:31:26 +02:00 committed by GitHub
commit 2acd0ec95d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 54 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/short-urls/CreateShortUrl.tsx
View file

@ -55,7 +55,6 @@ export const CreateShortUrl = (
mode={basicMode ? 'create-basic' : 'create'}
onSave={async (data: ShortUrlData) => {
resetCreateShortUrl();
return createShortUrl(data);
}}
/>

52
test/settings/VisitsSettings.test.tsx
View file

@ -1,41 +1,35 @@
import { shallow, ShallowWrapper } from 'enzyme';
import { render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import { Mock } from 'ts-mockery';
import { Settings } from '../../src/settings/reducers/settings';
import { VisitsSettings } from '../../src/settings/VisitsSettings';
import { SimpleCard } from '../../src/utils/SimpleCard';
import { DateIntervalSelector } from '../../src/utils/dates/DateIntervalSelector';
import { LabeledFormGroup } from '../../src/utils/forms/LabeledFormGroup';
describe('<VisitsSettings />', () => {
let wrapper: ShallowWrapper;
const setVisitsSettings = jest.fn();
const createWrapper = (settings: Partial<Settings> = {}) => {
wrapper = shallow(<VisitsSettings settings={Mock.of<Settings>(settings)} setVisitsSettings={setVisitsSettings} />);
return wrapper;
};
const setUp = (settings: Partial<Settings> = {}) => ({
user: userEvent.setup(),
...render(<VisitsSettings settings={Mock.of<Settings>(settings)} setVisitsSettings={setVisitsSettings} />),
});
afterEach(jest.clearAllMocks);
afterEach(() => wrapper?.unmount());
it('renders expected components', () => {
const wrapper = createWrapper();
setUp();
expect(wrapper.find(SimpleCard).prop('title')).toEqual('Visits');
expect(wrapper.find(LabeledFormGroup).prop('label')).toEqual('Default interval to load on visits sections:');
expect(wrapper.find(DateIntervalSelector)).toHaveLength(1);
expect(screen.getByRole('heading')).toHaveTextContent('Visits');
expect(screen.getByText('Default interval to load on visits sections:')).toBeInTheDocument();
});
it.each([
[Mock.all<Settings>(), 'last30Days'],
[Mock.of<Settings>({ visits: {} }), 'last30Days'],
[Mock.all<Settings>(), 'Last 30 days'],
[Mock.of<Settings>({ visits: {} }), 'Last 30 days'],
[
Mock.of<Settings>({
visits: {
defaultInterval: 'last7Days',
},
}),
'last7Days',
'Last 7 days',
],
[
Mock.of<Settings>({
@ -43,21 +37,23 @@ describe('<VisitsSettings />', () => {
defaultInterval: 'today',
},
}),
'today',
'Today',
],
])('sets expected interval as active', (settings, expectedInterval) => {
const wrapper = createWrapper(settings);
expect(wrapper.find(DateIntervalSelector).prop('active')).toEqual(expectedInterval);
setUp(settings);
expect(screen.getByRole('button')).toHaveTextContent(expectedInterval);
});
it('invokes setVisitsSettings when interval changes', () => {
const wrapper = createWrapper();
const selector = wrapper.find(DateIntervalSelector);
it('invokes setVisitsSettings when interval changes', async () => {
const { user } = setUp();
const selectOption = async (name: string) => {
await user.click(screen.getByRole('button'));
await user.click(screen.getByRole('menuitem', { name }));
};
selector.simulate('change', 'last7Days');
selector.simulate('change', 'last180Days');
selector.simulate('change', 'yesterday');
await selectOption('Last 7 days');
await selectOption('Last 180 days');
await selectOption('Yesterday');
expect(setVisitsSettings).toHaveBeenCalledTimes(3);
expect(setVisitsSettings).toHaveBeenNthCalledWith(1, { defaultInterval: 'last7Days' });

42
test/short-urls/CreateShortUrl.test.tsx
View file

@ -1,38 +1,30 @@
import { shallow, ShallowWrapper } from 'enzyme';
import { render, screen } from '@testing-library/react';
import { Mock } from 'ts-mockery';
import { CreateShortUrl as createShortUrlsCreator } from '../../src/short-urls/CreateShortUrl';
import { ShortUrlCreation } from '../../src/short-urls/reducers/shortUrlCreation';
import { Settings } from '../../src/settings/reducers/settings';
describe('<CreateShortUrl />', () => {
let wrapper: ShallowWrapper;
const ShortUrlForm = () => null;
const CreateShortUrlResult = () => null;
const ShortUrlForm = () => <span>ShortUrlForm</span>;
const CreateShortUrlResult = () => <span>CreateShortUrlResult</span>;
const shortUrlCreation = { validateUrls: true };
const shortUrlCreationResult = Mock.all<ShortUrlCreation>();
const createShortUrl = jest.fn(async () => Promise.resolve());
const CreateShortUrl = createShortUrlsCreator(ShortUrlForm, CreateShortUrlResult);
const setUp = () => render(
<CreateShortUrl
shortUrlCreationResult={shortUrlCreationResult}
createShortUrl={createShortUrl}
selectedServer={null}
resetCreateShortUrl={() => {}}
settings={Mock.of<Settings>({ shortUrlCreation })}
/>,
);
beforeEach(() => {
const CreateShortUrl = createShortUrlsCreator(ShortUrlForm, CreateShortUrlResult);
it('renders computed initial state', () => {
setUp();
wrapper = shallow(
<CreateShortUrl
shortUrlCreationResult={shortUrlCreationResult}
createShortUrl={createShortUrl}
selectedServer={null}
resetCreateShortUrl={() => {}}
settings={Mock.of<Settings>({ shortUrlCreation })}
/>,
);
});
afterEach(() => wrapper.unmount());
afterEach(jest.clearAllMocks);
it('renders a ShortUrlForm with a computed initial state', () => {
const form = wrapper.find(ShortUrlForm);
const result = wrapper.find(CreateShortUrlResult);
expect(form).toHaveLength(1);
expect(result).toHaveLength(1);
expect(screen.getByText('ShortUrlForm')).toBeInTheDocument();
expect(screen.getByText('CreateShortUrlResult')).toBeInTheDocument();
});
});