mirrors/shlink-web-client
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink-web-client.git synced 2024-12-23 09:30:31 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fixed visits normalization not converting empty strings into null

Browse source
This commit is contained in:
Alejandro Celaya 2020-09-19 10:31:23 +02:00
parent 2951d0d75e
commit 23046c149c
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/visits/services/VisitsParser.ts
View file

@ -72,8 +72,8 @@ export const normalizeVisits = map(({ userAgent, date, referer, visitLocation }:
date, date,
...parseUserAgent(userAgent), ...parseUserAgent(userAgent),
referer: extractDomain(referer), referer: extractDomain(referer),
country: visitLocation?.countryName ?? 'Unknown', country: visitLocation?.countryName || 'Unknown', // eslint-disable-line @typescript-eslint/prefer-nullish-coalescing
city: visitLocation?.cityName ?? 'Unknown', city: visitLocation?.cityName || 'Unknown', // eslint-disable-line @typescript-eslint/prefer-nullish-coalescing
latitude: visitLocation?.latitude, latitude: visitLocation?.latitude,
longitude: visitLocation?.longitude, longitude: visitLocation?.longitude,
})); }));

1
test/visits/services/VisitsParser.test.ts
View file

@ -28,6 +28,7 @@ describe('VisitsParser', () => {
userAgent: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36', userAgent: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36',
visitLocation: { visitLocation: {
countryName: 'Spain', countryName: 'Spain',
cityName: '',
}, },
}), }),
Mock.of<Visit>({ Mock.of<Visit>({