From 187fee46f4bd2c93fcd289305a30b5ee5dc4baae Mon Sep 17 00:00:00 2001
From: Alejandro Celaya <alejandrocelaya@gmail.com>
Date: Sun, 18 Dec 2022 13:17:49 +0100
Subject: [PATCH] Added extra info and new label to highlight disabled short
 URLs

---
 src/short-urls/helpers/DisabledLabel.tsx      | 21 ++++++++++
 .../helpers/ShortUrlVisitsCount.scss          |  4 ++
 .../helpers/ShortUrlVisitsCount.tsx           | 38 +++++++++++++------
 src/short-urls/helpers/ShortUrlsRow.scss      |  4 --
 src/short-urls/helpers/ShortUrlsRow.tsx       | 38 ++++++++-----------
 src/short-urls/helpers/ShortUrlsRowMenu.tsx   |  4 +-
 src/short-urls/helpers/Tags.tsx               | 30 +++++++++++++++
 src/short-urls/helpers/index.ts               | 10 +++++
 src/utils/helpers/date.ts                     |  2 +
 src/utils/table/ResponsiveTable.scss          |  5 ++-
 10 files changed, 117 insertions(+), 39 deletions(-)
 create mode 100644 src/short-urls/helpers/DisabledLabel.tsx
 create mode 100644 src/short-urls/helpers/Tags.tsx

diff --git a/src/short-urls/helpers/DisabledLabel.tsx b/src/short-urls/helpers/DisabledLabel.tsx
new file mode 100644
index 00000000..90f42597
--- /dev/null
+++ b/src/short-urls/helpers/DisabledLabel.tsx
@@ -0,0 +1,21 @@
+import { FC, useRef } from 'react';
+import { UncontrolledTooltip } from 'reactstrap';
+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
+import { faLinkSlash } from '@fortawesome/free-solid-svg-icons';
+import { mutableRefToElementRef } from '../../utils/helpers/components';
+
+export const DisabledLabel: FC = () => {
+  const tooltipRef = useRef<HTMLElement | undefined>();
+
+  return (
+    <>
+      <span style={{ cursor: 'help' }} ref={mutableRefToElementRef(tooltipRef)} className="badge text-bg-danger">
+        <FontAwesomeIcon icon={faLinkSlash} className="me-1" />
+        Disabled
+      </span>
+      <UncontrolledTooltip target={(() => tooltipRef.current) as any} placement="left">
+        This short URL cannot be currently visited because of some of its limits.
+      </UncontrolledTooltip>
+    </>
+  );
+};
diff --git a/src/short-urls/helpers/ShortUrlVisitsCount.scss b/src/short-urls/helpers/ShortUrlVisitsCount.scss
index 2910381a..7ae9b852 100644
--- a/src/short-urls/helpers/ShortUrlVisitsCount.scss
+++ b/src/short-urls/helpers/ShortUrlVisitsCount.scss
@@ -10,3 +10,7 @@
 .short-url-visits-count__amount--big {
   transform: scale(1.5);
 }
+
+.short-url-visits-count__tooltip-list-item:not(:last-child) {
+  margin-bottom: .5rem;
+}
diff --git a/src/short-urls/helpers/ShortUrlVisitsCount.tsx b/src/short-urls/helpers/ShortUrlVisitsCount.tsx
index 3b76bda4..dfa0acf3 100644
--- a/src/short-urls/helpers/ShortUrlVisitsCount.tsx
+++ b/src/short-urls/helpers/ShortUrlVisitsCount.tsx
@@ -7,8 +7,9 @@ import { prettify } from '../../utils/helpers/numbers';
 import { ShortUrl } from '../data';
 import { SelectedServer } from '../../servers/data';
 import { ShortUrlDetailLink } from './ShortUrlDetailLink';
-import './ShortUrlVisitsCount.scss';
 import { mutableRefToElementRef } from '../../utils/helpers/components';
+import { formatHumanFriendly, parseISO } from '../../utils/helpers/date';
+import './ShortUrlVisitsCount.scss';
 
 interface ShortUrlVisitsCountProps {
   shortUrl?: ShortUrl | null;
@@ -20,7 +21,8 @@ interface ShortUrlVisitsCountProps {
 export const ShortUrlVisitsCount = (
   { visitsCount, shortUrl, selectedServer, active = false }: ShortUrlVisitsCountProps,
 ) => {
-  const maxVisits = shortUrl?.meta?.maxVisits;
+  const { maxVisits, validSince, validUntil } = shortUrl?.meta ?? {};
+  const hasLimit = !!maxVisits || !!validSince || !!validUntil;
   const visitsLink = (
     <ShortUrlDetailLink selectedServer={selectedServer} shortUrl={shortUrl} suffix="visits">
       <strong
@@ -31,29 +33,43 @@ export const ShortUrlVisitsCount = (
     </ShortUrlDetailLink>
   );
 
-  if (!maxVisits) {
+  if (!hasLimit) {
     return visitsLink;
   }
 
-  const prettifiedMaxVisits = prettify(maxVisits);
   const tooltipRef = useRef<HTMLElement | undefined>();
 
   return (
     <>
       <span className="indivisible">
         {visitsLink}
-        <small
-          className="short-urls-visits-count__max-visits-control"
-          ref={mutableRefToElementRef(tooltipRef)}
-        >
-          {' '}/ {prettifiedMaxVisits}{' '}
-          <sup>
+        <small className="short-urls-visits-count__max-visits-control" ref={mutableRefToElementRef(tooltipRef)}>
+          {maxVisits && <> / {prettify(maxVisits)}</>}
+          <sup className="ms-1">
             <FontAwesomeIcon icon={infoIcon} />
           </sup>
         </small>
       </span>
       <UncontrolledTooltip target={(() => tooltipRef.current) as any} placement="bottom">
-        This short URL will not accept more than <b>{prettifiedMaxVisits}</b> visits.
+        <ul className="list-unstyled mb-0">
+          {maxVisits && (
+            <li className="short-url-visits-count__tooltip-list-item">
+              This short URL will not accept more than <b>{prettify(maxVisits)}</b> visit{maxVisits === 1 ? '' : 's'}.
+            </li>
+          )}
+          {validSince && (
+            <li className="short-url-visits-count__tooltip-list-item">
+              This short URL will not accept visits
+              before <b className="indivisible">{formatHumanFriendly(parseISO(validSince))}</b>.
+            </li>
+          )}
+          {validUntil && (
+            <li className="short-url-visits-count__tooltip-list-item">
+              This short URL will not accept visits
+              after <b className="indivisible">{formatHumanFriendly(parseISO(validUntil))}</b>.
+            </li>
+          )}
+        </ul>
       </UncontrolledTooltip>
     </>
   );
diff --git a/src/short-urls/helpers/ShortUrlsRow.scss b/src/short-urls/helpers/ShortUrlsRow.scss
index 4666be1a..64af7818 100644
--- a/src/short-urls/helpers/ShortUrlsRow.scss
+++ b/src/short-urls/helpers/ShortUrlsRow.scss
@@ -10,10 +10,6 @@
   word-break: break-all;
 }
 
-.short-urls-row__cell--relative {
-  position: relative;
-}
-
 .short-urls-row__cell--indivisible {
   @media (min-width: $lgMin) {
     white-space: nowrap;
diff --git a/src/short-urls/helpers/ShortUrlsRow.tsx b/src/short-urls/helpers/ShortUrlsRow.tsx
index 159c2b24..10f3e1a4 100644
--- a/src/short-urls/helpers/ShortUrlsRow.tsx
+++ b/src/short-urls/helpers/ShortUrlsRow.tsx
@@ -1,15 +1,16 @@
-import { FC, useEffect, useRef } from 'react';
-import { isEmpty } from 'ramda';
+import { useEffect, useRef } from 'react';
 import { ExternalLink } from 'react-external-link';
 import { ColorGenerator } from '../../utils/services/ColorGenerator';
 import { TimeoutToggle } from '../../utils/helpers/hooks';
-import { Tag } from '../../tags/helpers/Tag';
 import { SelectedServer } from '../../servers/data';
 import { CopyToClipboardIcon } from '../../utils/CopyToClipboardIcon';
 import { ShortUrl } from '../data';
 import { Time } from '../../utils/dates/Time';
 import { ShortUrlVisitsCount } from './ShortUrlVisitsCount';
-import { ShortUrlsRowMenuProps } from './ShortUrlsRowMenu';
+import { ShortUrlsRowMenuType } from './ShortUrlsRowMenu';
+import { Tags } from './Tags';
+import { shortUrlIsDisabled } from './index';
+import { DisabledLabel } from './DisabledLabel';
 import './ShortUrlsRow.scss';
 
 interface ShortUrlsRowProps {
@@ -19,28 +20,14 @@ interface ShortUrlsRowProps {
 }
 
 export const ShortUrlsRow = (
-  ShortUrlsRowMenu: FC<ShortUrlsRowMenuProps>,
+  ShortUrlsRowMenu: ShortUrlsRowMenuType,
   colorGenerator: ColorGenerator,
   useTimeoutToggle: TimeoutToggle,
 ) => ({ shortUrl, selectedServer, onTagClick }: ShortUrlsRowProps) => {
   const [copiedToClipboard, setCopiedToClipboard] = useTimeoutToggle();
   const [active, setActive] = useTimeoutToggle(false, 500);
   const isFirstRun = useRef(true);
-
-  const renderTags = (tags: string[]) => {
-    if (isEmpty(tags)) {
-      return <i className="indivisible"><small>No tags</small></i>;
-    }
-
-    return tags.map((tag) => (
-      <Tag
-        colorGenerator={colorGenerator}
-        key={tag}
-        text={tag}
-        onClick={() => onTagClick?.(tag)}
-      />
-    ));
-  };
+  const isDisabled = shortUrlIsDisabled(shortUrl);
 
   useEffect(() => {
     !isFirstRun.current && setActive();
@@ -53,7 +40,7 @@ export const ShortUrlsRow = (
         <Time date={shortUrl.dateCreated} />
       </td>
       <td className="responsive-table__cell short-urls-row__cell" data-th="Short URL">
-        <span className="short-urls-row__cell--relative short-urls-row__cell--indivisible">
+        <span className="position-relative short-urls-row__cell--indivisible">
           <span className="short-urls-row__short-url-wrapper">
             <ExternalLink href={shortUrl.shortUrl} />
           </span>
@@ -67,6 +54,11 @@ export const ShortUrlsRow = (
         className="responsive-table__cell short-urls-row__cell short-urls-row__cell--break"
         data-th={`${shortUrl.title ? 'Title' : 'Long URL'}`}
       >
+        {isDisabled && (
+          <div className="float-end ms-2">
+            <DisabledLabel />
+          </div>
+        )}
         <ExternalLink href={shortUrl.longUrl}>{shortUrl.title ?? shortUrl.longUrl}</ExternalLink>
       </td>
       {shortUrl.title && (
@@ -74,7 +66,9 @@ export const ShortUrlsRow = (
           <ExternalLink href={shortUrl.longUrl} />
         </td>
       )}
-      <td className="responsive-table__cell short-urls-row__cell" data-th="Tags">{renderTags(shortUrl.tags)}</td>
+      <td className="responsive-table__cell short-urls-row__cell" data-th="Tags">
+        <Tags tags={shortUrl.tags} colorGenerator={colorGenerator} onTagClick={onTagClick} disabled={isDisabled} />
+      </td>
       <td className="responsive-table__cell short-urls-row__cell text-lg-end" data-th="Visits">
         <ShortUrlVisitsCount
           visitsCount={shortUrl.visitsCount}
diff --git a/src/short-urls/helpers/ShortUrlsRowMenu.tsx b/src/short-urls/helpers/ShortUrlsRowMenu.tsx
index a4563a52..39d32075 100644
--- a/src/short-urls/helpers/ShortUrlsRowMenu.tsx
+++ b/src/short-urls/helpers/ShortUrlsRowMenu.tsx
@@ -13,7 +13,7 @@ import { SelectedServer } from '../../servers/data';
 import { DropdownBtnMenu } from '../../utils/DropdownBtnMenu';
 import { ShortUrlDetailLink } from './ShortUrlDetailLink';
 
-export interface ShortUrlsRowMenuProps {
+interface ShortUrlsRowMenuProps {
   selectedServer: SelectedServer;
   shortUrl: ShortUrl;
 }
@@ -51,3 +51,5 @@ export const ShortUrlsRowMenu = (
     </DropdownBtnMenu>
   );
 };
+
+export type ShortUrlsRowMenuType = ReturnType<typeof ShortUrlsRowMenu>;
diff --git a/src/short-urls/helpers/Tags.tsx b/src/short-urls/helpers/Tags.tsx
new file mode 100644
index 00000000..ee781a09
--- /dev/null
+++ b/src/short-urls/helpers/Tags.tsx
@@ -0,0 +1,30 @@
+import { FC } from 'react';
+import { isEmpty } from 'ramda';
+import { Tag } from '../../tags/helpers/Tag';
+import { ColorGenerator } from '../../utils/services/ColorGenerator';
+
+interface TagsProps {
+  tags: string[];
+  onTagClick?: (tag: string) => void;
+  colorGenerator: ColorGenerator;
+  disabled?: boolean;
+}
+
+export const Tags: FC<TagsProps> = ({ tags, onTagClick, colorGenerator, disabled = false }) => {
+  if (isEmpty(tags)) {
+    return disabled ? null : <i className="indivisible"><small>No tags</small></i>;
+  }
+
+  return (
+    <>
+      {tags.map((tag) => (
+        <Tag
+          key={tag}
+          text={tag}
+          colorGenerator={colorGenerator}
+          onClick={() => onTagClick?.(tag)}
+        />
+      ))}
+    </>
+  );
+};
diff --git a/src/short-urls/helpers/index.ts b/src/short-urls/helpers/index.ts
index e4dd1f09..b2348f52 100644
--- a/src/short-urls/helpers/index.ts
+++ b/src/short-urls/helpers/index.ts
@@ -3,6 +3,8 @@ import { ShortUrl, ShortUrlData } from '../data';
 import { OptionalString } from '../../utils/utils';
 import { DEFAULT_DOMAIN } from '../../visits/reducers/domainVisits';
 import { ShortUrlCreationSettings } from '../../settings/reducers/settings';
+import { isBefore, parseISO } from 'date-fns';
+import { now } from '../../utils/helpers/date';
 
 export const shortUrlMatches = (shortUrl: ShortUrl, shortCode: string, domain: OptionalString): boolean => {
   if (isNil(domain)) {
@@ -20,6 +22,14 @@ export const domainMatches = (shortUrl: ShortUrl, domain: string): boolean => {
   return shortUrl.domain === domain;
 };
 
+export const shortUrlIsDisabled = (shortUrl: ShortUrl): boolean => (
+  !!shortUrl.meta.maxVisits && shortUrl.visitsCount >= shortUrl.meta.maxVisits
+) || (
+  !!shortUrl.meta.validSince && isBefore(now(), parseISO(shortUrl.meta.validSince))
+) || (
+  !!shortUrl.meta.validUntil && isBefore(parseISO(shortUrl.meta.validUntil), now())
+);
+
 export const shortUrlDataFromShortUrl = (shortUrl?: ShortUrl, settings?: ShortUrlCreationSettings): ShortUrlData => {
   const validateUrl = settings?.validateUrls ?? false;
 
diff --git a/src/utils/helpers/date.ts b/src/utils/helpers/date.ts
index ee74e992..b766974c 100644
--- a/src/utils/helpers/date.ts
+++ b/src/utils/helpers/date.ts
@@ -30,6 +30,8 @@ export const formatIsoDate = (date?: NullableDate) => formatDateFromFormat(date,
 
 export const formatInternational = formatDate();
 
+export const formatHumanFriendly = formatDate(STANDARD_DATE_AND_TIME_FORMAT);
+
 export const parseDate = (date: string, theFormat: string) => parse(date, theFormat, now());
 
 export const parseISO = (date: DateOrString): Date => (isDateObject(date) ? date : stdParseISO(date));
diff --git a/src/utils/table/ResponsiveTable.scss b/src/utils/table/ResponsiveTable.scss
index 89b67a14..49ac01a9 100644
--- a/src/utils/table/ResponsiveTable.scss
+++ b/src/utils/table/ResponsiveTable.scss
@@ -15,10 +15,13 @@
 .responsive-table__row {
   @media (max-width: $responsiveTableBreakpoint) {
     display: block;
-    margin-bottom: 10px;
     border-bottom: 1px solid var(--border-color);
     border-top: 2px solid var(--border-color);
     position: relative;
+
+    &:not(:last-child) {
+      margin-bottom: 10px;
+    }
   }
 }