mirrors/shlink-web-client
1
0
Fork 0
mirror of https://github.com/shlinkio/shlink-web-client.git synced 2025-01-09 09:47:28 +03:00
Code Issues Projects Releases Packages Wiki Activity

Migrated ForServerVersion test from enzyme to react testing library

Browse source
This commit is contained in:
Alejandro Celaya 2022-05-02 18:58:57 +02:00
parent c00aaa9018
commit 0de8eb1568
3 changed files with 17 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/servers/helpers/ForServerVersion.tsx
View file

@ -8,7 +8,9 @@ interface ForServerVersionConnectProps extends ForServerVersionProps {
selectedServer: SelectedServer; selectedServer: SelectedServer;
} }
const ForServerVersion: FC<ForServerVersionConnectProps> = ({ minVersion, maxVersion, selectedServer, children }) => { export const ForServerVersion: FC<ForServerVersionConnectProps> = (
{ minVersion, maxVersion, selectedServer, children },
) => {
if (!isReachableServer(selectedServer)) { if (!isReachableServer(selectedServer)) {
return null; return null;
} }
@ -22,5 +24,3 @@ const ForServerVersion: FC<ForServerVersionConnectProps> = ({ minVersion, maxVer
return <>{children}</>; return <>{children}</>;
}; };
export default ForServerVersion;

2
src/servers/services/provideServices.ts
View file

@ -8,7 +8,7 @@ import ImportServersBtn from '../helpers/ImportServersBtn';
import { resetSelectedServer, selectServer } from '../reducers/selectedServer'; import { resetSelectedServer, selectServer } from '../reducers/selectedServer';
import { createServer, createServers, deleteServer, editServer, setAutoConnect } from '../reducers/servers'; import { createServer, createServers, deleteServer, editServer, setAutoConnect } from '../reducers/servers';
import { fetchServers } from '../reducers/remoteServers'; import { fetchServers } from '../reducers/remoteServers';
import ForServerVersion from '../helpers/ForServerVersion'; import { ForServerVersion } from '../helpers/ForServerVersion';
import { ServerError } from '../helpers/ServerError'; import { ServerError } from '../helpers/ServerError';
import { ConnectDecorator } from '../../container/types'; import { ConnectDecorator } from '../../container/types';
import { withoutSelectedServer } from '../helpers/withoutSelectedServer'; import { withoutSelectedServer } from '../helpers/withoutSelectedServer';

37
test/servers/helpers/ForServerVersion.test.tsx
View file

@ -1,28 +1,19 @@
import { mount, ReactWrapper } from 'enzyme'; import { render, screen } from '@testing-library/react';
import { Mock } from 'ts-mockery'; import { Mock } from 'ts-mockery';
import ForServerVersion from '../../../src/servers/helpers/ForServerVersion'; import { ForServerVersion } from '../../../src/servers/helpers/ForServerVersion';
import { ReachableServer, SelectedServer } from '../../../src/servers/data'; import { ReachableServer, SelectedServer } from '../../../src/servers/data';
import { SemVer, SemVerPattern } from '../../../src/utils/helpers/version'; import { SemVer, SemVerPattern } from '../../../src/utils/helpers/version';
describe('<ForServerVersion />', () => { describe('<ForServerVersion />', () => {
let wrapped: ReactWrapper; const setUp = (selectedServer: SelectedServer, minVersion?: SemVerPattern, maxVersion?: SemVerPattern) => render(
<ForServerVersion minVersion={minVersion} maxVersion={maxVersion} selectedServer={selectedServer}>
const renderComponent = (selectedServer: SelectedServer, minVersion?: SemVerPattern, maxVersion?: SemVerPattern) => { <span>Hello</span>
wrapped = mount( </ForServerVersion>,
<ForServerVersion minVersion={minVersion} maxVersion={maxVersion} selectedServer={selectedServer}> );
<span>Hello</span>
</ForServerVersion>,
);
return wrapped;
};
afterEach(() => wrapped?.unmount());
it('does not render children when current server is empty', () => { it('does not render children when current server is empty', () => {
const wrapped = renderComponent(null, '1.*.*'); setUp(null, '1.*.*');
expect(screen.queryByText('Hello')).not.toBeInTheDocument();
expect(wrapped.html()).toBeNull();
}); });
it.each([ it.each([
@ -30,9 +21,8 @@ describe('<ForServerVersion />', () => {
[undefined, '1.8.0' as SemVerPattern, '1.8.3' as SemVer], [undefined, '1.8.0' as SemVerPattern, '1.8.3' as SemVer],
['1.7.0' as SemVerPattern, '1.8.0' as SemVerPattern, '1.8.3' as SemVer], ['1.7.0' as SemVerPattern, '1.8.0' as SemVerPattern, '1.8.3' as SemVer],
])('does not render children when current version does not match requirements', (min, max, version) => { ])('does not render children when current version does not match requirements', (min, max, version) => {
const wrapped = renderComponent(Mock.of<ReachableServer>({ version, printableVersion: version }), min, max); setUp(Mock.of<ReachableServer>({ version, printableVersion: version }), min, max);
expect(screen.queryByText('Hello')).not.toBeInTheDocument();
expect(wrapped.html()).toBeNull();
}); });
it.each([ it.each([
@ -42,8 +32,7 @@ describe('<ForServerVersion />', () => {
[undefined, '1.8.0' as SemVerPattern, '1.7.1' as SemVer], [undefined, '1.8.0' as SemVerPattern, '1.7.1' as SemVer],
['1.7.0' as SemVerPattern, '1.8.0' as SemVerPattern, '1.7.3' as SemVer], ['1.7.0' as SemVerPattern, '1.8.0' as SemVerPattern, '1.7.3' as SemVer],
])('renders children when current version matches requirements', (min, max, version) => { ])('renders children when current version matches requirements', (min, max, version) => {
const wrapped = renderComponent(Mock.of<ReachableServer>({ version, printableVersion: version }), min, max); setUp(Mock.of<ReachableServer>({ version, printableVersion: version }), min, max);
expect(screen.queryByText('Hello')).toBeInTheDocument();
expect(wrapped.html()).toContain('<span>Hello</span>');
}); });
}); });