Extracted components in ShortUrlVisits to simplify maintainability

2024-12-23 01:20:24 +03:00 · 2018-09-01 11:08:27 +02:00 · 2018-09-01 11:08:27 +02:00 · 0d97c084c2
commit 0d97c084c2
parent b7ca32ff8f
4 changed files with 124 additions and 96 deletions
--- a/src/visits/GraphCard.js
+++ b/src/visits/GraphCard.js
@ -0,0 +1,48 @@
+import { Card, CardHeader, CardBody } from 'reactstrap';
+import { Doughnut, HorizontalBar } from 'react-chartjs-2';
+import PropTypes from 'prop-types';
+import React from 'react';
+
+const propTypes = {
+  title: PropTypes.string,
+  isBarChart: PropTypes.bool,
+  stats: PropTypes.object,
+};
+
+export function GraphCard({ title, isBarChart, stats }) {
+  const generateGraphData = (stats) => ({
+    labels: Object.keys(stats),
+    datasets: [
+      {
+        title,
+        data: Object.values(stats),
+        backgroundColor: isBarChart ? 'rgba(70, 150, 229, 0.4)' : [
+          '#97BBCD',
+          '#DCDCDC',
+          '#F7464A',
+          '#46BFBD',
+          '#FDB45C',
+          '#949FB1',
+          '#4D5360',
+        ],
+        borderColor: isBarChart ? 'rgba(70, 150, 229, 1)' : 'white',
+        borderWidth: 2,
+      },
+    ],
+  });
+  const renderGraph = () => {
+    const Component = isBarChart ? HorizontalBar : Doughnut;
+    const legend = isBarChart ? { display: false } : { position: 'right' };
+
+    return <Component data={generateGraphData(stats)} options={{ legend }} />;
+  };
+
+  return (
+    <Card className="mt-4">
+      <CardHeader>{title}</CardHeader>
+      <CardBody>{renderGraph()}</CardBody>
+    </Card>
+  );
+}
+
+GraphCard.propTypes = propTypes;
--- a/src/visits/ShortUrlVisits.js
+++ b/src/visits/ShortUrlVisits.js
@ -2,23 +2,22 @@ import preloader from '@fortawesome/fontawesome-free-solid/faCircleNotch';
 import FontAwesomeIcon from '@fortawesome/react-fontawesome';
 import { isEmpty, mapObjIndexed, pick } from 'ramda';
 import React from 'react';
-import { Doughnut, HorizontalBar } from 'react-chartjs-2';
-import Moment from 'react-moment';
 import { connect } from 'react-redux';
-import { Card, CardBody, CardHeader, UncontrolledTooltip } from 'reactstrap';
+import { Card } from 'reactstrap';
 import PropTypes from 'prop-types';
 import DateInput from '../common/DateInput';
 import MutedMessage from '../utils/MuttedMessage';
-import ExternalLink from '../utils/ExternalLink';
 import { serverType } from '../servers/prop-types/index';
 import { getShortUrlVisits, shortUrlVisitsType } from './reducers/shortUrlVisits';
 import {
-  processOsStats,
  processBrowserStats,
  processCountriesStats,
+  processOsStats,
  processReferrersStats,
 } from './services/VisitsParser';
 import './ShortUrlVisits.scss';
+import { VisitsHeader } from './VisitsHeader';
+import { GraphCard } from './GraphCard';

 export class ShortUrlsVisitsComponent extends React.Component {
  static propTypes = {
@ -60,59 +59,12 @@ export class ShortUrlsVisitsComponent extends React.Component {
      processBrowserStats,
      processCountriesStats,
      processReferrersStats,
-      shortUrlVisits: { visits, loading, error, shortUrl },
+      shortUrlVisits,
    } = this.props;
+    const { visits, loading, error } = shortUrlVisits;
    const serverUrl = selectedServer ? selectedServer.url : '';
    const shortLink = `${serverUrl}/${params.shortCode}`;
-    const generateGraphData = (stats, label, isBarChart) => ({
-      labels: Object.keys(stats),
-      datasets: [
-        {
-          label,
-          data: Object.values(stats),
-          backgroundColor: isBarChart ? 'rgba(70, 150, 229, 0.4)' : [
-            '#97BBCD',
-            '#DCDCDC',
-            '#F7464A',
-            '#46BFBD',
-            '#FDB45C',
-            '#949FB1',
-            '#4D5360',
-          ],
-          borderColor: isBarChart ? 'rgba(70, 150, 229, 1)' : 'white',
-          borderWidth: 2,
-        },
-      ],
-    });
-    const renderGraphCard = (title, stats, isBarChart, label) => (
-      <div className="col-md-6">
-        <Card className="mt-4">
-          <CardHeader>{title}</CardHeader>
-          <CardBody>
-            {!isBarChart && (
-              <Doughnut
-                data={generateGraphData(stats, label || title, isBarChart)}
-                options={{
-                  legend: {
-                    position: 'right',
-                  },
-                }}
-              />
-            )}
-            {isBarChart && (
-              <HorizontalBar
-                data={generateGraphData(stats, label || title, isBarChart)}
-                options={{
-                  legend: {
-                    display: false,
-                  },
-                }}
-              />
-            )}
-          </CardBody>
-        </Card>
-      </div>
-    );
+
    const renderContent = () => {
      if (loading) {
        return <MutedMessage><FontAwesomeIcon icon={preloader} spin /> Loading...</MutedMessage>;
@ -132,53 +84,25 @@ export class ShortUrlsVisitsComponent extends React.Component {

      return (
        <div className="row">
-          {renderGraphCard('Operating systems', processOsStats(visits), false)}
-          {renderGraphCard('Browsers', processBrowserStats(visits), false)}
-          {renderGraphCard('Countries', processCountriesStats(visits), true, 'Visits')}
-          {renderGraphCard('Referrers', processReferrersStats(visits), true, 'Visits')}
+          <div className="col-md-6">
+            <GraphCard title="Operating systems" stats={processOsStats(visits)} />
+          </div>
+          <div className="col-md-6">
+            <GraphCard title="Browsers" stats={processBrowserStats(visits)} />
+          </div>
+          <div className="col-md-6">
+            <GraphCard title="Countries" stats={processCountriesStats(visits)} isBarChart />
+          </div>
+          <div className="col-md-6">
+            <GraphCard title="Referrers" stats={processReferrersStats(visits)} isBarChart />
+          </div>
        </div>
      );
    };

-    const renderCreated = () => (
-      <span>
-        <b id="created"><Moment fromNow>{shortUrl.dateCreated}</Moment></b>
-        <UncontrolledTooltip placement="bottom" target="created">
-          <Moment format="YYYY-MM-DD HH:mm">{shortUrl.dateCreated}</Moment>
-        </UncontrolledTooltip>
-      </span>
-    );
-
    return (
      <div className="shlink-container">
-        <header>
-          <Card className="bg-light">
-            <CardBody>
-              <h2>
-                {
-                  shortUrl.visitsCount &&
-                  <span className="badge badge-main float-right">Visits: {shortUrl.visitsCount}</span>
-                }
-                Visit stats for <ExternalLink href={shortLink}>{shortLink}</ExternalLink>
-              </h2>
-              <hr />
-              {shortUrl.dateCreated && (
-                <div>
-                  Created:
-                  &nbsp;
-                  {loading && <small>Loading...</small>}
-                  {!loading && renderCreated()}
-                </div>
-              )}
-              <div>
-                Long URL:
-                &nbsp;
-                {loading && <small>Loading...</small>}
-                {!loading && <ExternalLink href={shortUrl.longUrl}>{shortUrl.longUrl}</ExternalLink>}
-              </div>
-            </CardBody>
-          </Card>
-        </header>
+        <VisitsHeader shortUrlVisits={shortUrlVisits} shortLink={shortLink} />

        <section className="mt-4">
          <div className="row">
--- a/src/visits/VisitsHeader.js
+++ b/src/visits/VisitsHeader.js
@ -0,0 +1,53 @@
+import { Card, UncontrolledTooltip } from 'reactstrap';
+import Moment from 'react-moment';
+import React from 'react';
+import PropTypes from 'prop-types';
+import ExternalLink from '../utils/ExternalLink';
+import { shortUrlVisitsType } from './reducers/shortUrlVisits';
+import './VisitsHeader.scss';
+
+const propTypes = {
+  shortUrlVisits: shortUrlVisitsType,
+  shortLink: PropTypes.string,
+};
+
+export function VisitsHeader({ shortUrlVisits, shortLink }) {
+  const { shortUrl, loading } = shortUrlVisits;
+  const renderDate = () => (
+    <span>
+      <b id="created" className="visits-header__created-at"><Moment fromNow>{shortUrl.dateCreated}</Moment></b>
+      <UncontrolledTooltip placement="bottom" target="created">
+        <Moment format="YYYY-MM-DD HH:mm">{shortUrl.dateCreated}</Moment>
+      </UncontrolledTooltip>
+    </span>
+  );
+
+  return (
+    <header>
+      <Card className="bg-light" body>
+        <h2>
+          {shortUrl.visitsCount &&
+          <span className="badge badge-main float-right">Visits: {shortUrl.visitsCount}</span>}
+          Visit stats for <ExternalLink href={shortLink}>{shortLink}</ExternalLink>
+        </h2>
+        <hr />
+        {shortUrl.dateCreated && (
+          <div>
+            Created:
+            &nbsp;
+            {loading && <small>Loading...</small>}
+            {!loading && renderDate()}
+          </div>
+        )}
+        <div>
+          Long URL:
+          &nbsp;
+          {loading && <small>Loading...</small>}
+          {!loading && <ExternalLink href={shortUrl.longUrl}>{shortUrl.longUrl}</ExternalLink>}
+        </div>
+      </Card>
+    </header>
+  );
+}
+
+VisitsHeader.propTypes = propTypes;
--- a/src/visits/VisitsHeader.scss
+++ b/src/visits/VisitsHeader.scss
@ -0,0 +1,3 @@
+.visits-header__created-at {
+  cursor: default;
+}