mirror of
https://github.com/RSS-Bridge/rss-bridge.git
synced 2024-10-22 19:05:45 +03:00
19ad2584da
With UTF-8 byte-order mark in the file, the `ListActionTest::testOutput`
would fail after converting tests to PSR-4 namespaces:
invalid JSON output: Syntax error
Failed asserting that null is not null.
This is because ListAction::execute tries to create the bridge objects
and, when the files containing the bridge classes are not loaded yet,
the autoloader starts including them. Since this happens after output
buffering has begun, any text in the PHP file before the `<?php` tag
such as the BOM will end up in the buffer to be parsed by `json_decode`.
Previously, it worked by chance thanks to some other test including the file
before `ListActionTest`. With the restructuring, `Actions\ListActionTest`
will run sooner and become responsible for triggering the autoloader.
To prevent this in the future, I also disallowed BOM in the coding style.
107 lines
4.8 KiB
XML
107 lines
4.8 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<ruleset name="RSS-Bridge Ruleset">
|
|
<description>Created with the PHP Coding Standard Generator. http://edorian.github.com/php-coding-standard-generator/</description>
|
|
<exclude-pattern>./static</exclude-pattern>
|
|
<exclude-pattern>./vendor</exclude-pattern>
|
|
<exclude-pattern>./config.default.ini.php</exclude-pattern>
|
|
<exclude-pattern>./config.ini.php</exclude-pattern>
|
|
<!-- Duplicate class names are not allowed -->
|
|
<rule ref="Generic.Classes.DuplicateClassName"/>
|
|
<!-- Statements must not be empty -->
|
|
<rule ref="Generic.CodeAnalysis.EmptyStatement"/>
|
|
<!-- Unconditional if-statements are not allowed -->
|
|
<rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
|
|
<!-- Do not use final statements inside final classes -->
|
|
<rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/>
|
|
<!-- Do not override methods to call their parent -->
|
|
<rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
|
|
<!-- Do not allow UTF-8 byte-order mark -->
|
|
<rule ref="Generic.Files.ByteOrderMark"/>
|
|
<!-- Make sure the concatenation operator has spaces around it -->
|
|
<rule ref="Squiz.Strings.ConcatenationSpacing">
|
|
<properties>
|
|
<property name="spacing" value="1"/>
|
|
<property name="ignoreNewlines" value="true"/>
|
|
</properties>
|
|
</rule>
|
|
<!-- One line should not have more than 80 characters -->
|
|
<!-- One line must never exceed 120 characters -->
|
|
<rule ref="Generic.Files.LineLength">
|
|
<properties>
|
|
<property name="lineLimit" value="80"/>
|
|
<property name="absoluteLineLimit" value="120"/>
|
|
<property name="ignoreComments" value="true"/>
|
|
</properties>
|
|
</rule>
|
|
<!-- When calling a function: -->
|
|
<!-- Do not add a space before the opening parenthesis -->
|
|
<!-- Do not add a space after the opening parenthesis -->
|
|
<!-- Do not add a space before the closing parenthesis -->
|
|
<!-- Do not add a space before a comma -->
|
|
<!-- Add a space after a comma -->
|
|
<rule ref="Generic.Functions.FunctionCallArgumentSpacing"/>
|
|
<!-- Use UPPERCARE for constants -->
|
|
<rule ref="Generic.NamingConventions.UpperCaseConstantName"/>
|
|
<!-- Use lowercase for 'true', 'false' and 'null' -->
|
|
<rule ref="Generic.PHP.LowerCaseConstant"/>
|
|
<!-- Use a single string instead of concating -->
|
|
<rule ref="Generic.Strings.UnnecessaryStringConcat"/>
|
|
<!-- Use tabs for indentation -->
|
|
<rule ref="Generic.WhiteSpace.DisallowSpaceIndent"/>
|
|
<!-- Parameters with default values must appear last in functions -->
|
|
<rule ref="PEAR.Functions.ValidDefaultValue"/>
|
|
<!-- Use PascalCase for class names -->
|
|
<rule ref="PEAR.NamingConventions.ValidClassName"/>
|
|
<!-- abstract and final declarations MUST precede the visibility declaration -->
|
|
<!-- static declaration MUST come after the visibility declaration -->
|
|
<rule ref="PSR2.Methods.MethodDeclaration" />
|
|
<!-- Use 'elseif' instead of 'else if' -->
|
|
<rule ref="PSR2.ControlStructures.ElseIfDeclaration"/>
|
|
<!-- Do not add spaces after opening or before closing bracket -->
|
|
<rule ref="PSR2.ControlStructures.ControlStructureSpacing"/>
|
|
<!-- Add a new line at the end of a file -->
|
|
<rule ref="PSR2.Files.EndFileNewline"/>
|
|
<!-- Add space after closing parenthesis -->
|
|
<!-- Add body into new line -->
|
|
<!-- Close body in new line -->
|
|
<rule ref="Squiz.ControlStructures.ControlSignature">
|
|
<!-- No space after keyword (before opening parenthesis) -->
|
|
<exclude name="Squiz.ControlStructures.ControlSignature.SpaceAfterKeyword"/>
|
|
</rule>
|
|
<!-- When declaring a function: -->
|
|
<!-- Do not add a space before a comma -->
|
|
<!-- Add a space after a comma -->
|
|
<!-- Add a space before and after an equal sign -->
|
|
<rule ref="Squiz.Functions.FunctionDeclarationArgumentSpacing">
|
|
<properties>
|
|
<property name="equalsSpacing" value="1"/>
|
|
</properties>
|
|
</rule>
|
|
<!-- Do not add spaces when casting -->
|
|
<rule ref="Squiz.WhiteSpace.CastSpacing"/>
|
|
<!-- Operators must have a space around them -->
|
|
<rule ref="Squiz.WhiteSpace.OperatorSpacing"/>
|
|
<!-- Do not add a whitespace before a semicolon -->
|
|
<rule ref="Squiz.WhiteSpace.SemicolonSpacing"/>
|
|
<!-- Do not add whitespace at start or end of a file or end of a line -->
|
|
<rule ref="Squiz.WhiteSpace.SuperfluousWhitespace">
|
|
<properties>
|
|
<!--
|
|
This fixes an issue in combination with PSR2
|
|
https://github.com/squizlabs/PHP_CodeSniffer/issues/600
|
|
-->
|
|
<property name="ignoreBlankLines" value="false"/>
|
|
</properties>
|
|
</rule>
|
|
<rule ref="Squiz.WhiteSpace.FunctionSpacing">
|
|
<properties>
|
|
<property name="spacing" value="1" />
|
|
<property name="spacingBeforeFirst" value="0" />
|
|
<property name="spacingAfterLast" value="0" />
|
|
</properties>
|
|
</rule>
|
|
<!-- Whenever possible use single quote strings -->
|
|
<rule ref="Squiz.Strings.DoubleQuoteUsage">
|
|
<exclude name="Squiz.Strings.DoubleQuoteUsage.ContainsVar" />
|
|
</rule>
|
|
</ruleset>
|