mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-04-01 22:35:21 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix: tweak caching logic (#4241)

Browse source
This commit is contained in:
Dag 2024-08-30 00:22:11 +02:00 • committed by GitHub
parent 39952c2d95
commit 9f48370eb0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
actions/DisplayAction.php
View file

@ -125,17 +125,16 @@ class DisplayAction implements ActionInterface
return new Response(render(__DIR__ . '/../templates/exception.html.php', ['e' => $e]), 429); return new Response(render(__DIR__ . '/../templates/exception.html.php', ['e' => $e]), 429);
} }
if ($e instanceof HttpException) { if ($e instanceof HttpException) {
// Reproduce (and log) these responses regardless of error output and report limit if (in_array($e->getCode(), [429, 503])) {
if ($e->getCode() === 429) { // Log with debug, immediately reproduce and return
$this->logger->info(sprintf('Exception in DisplayAction(%s): %s', $bridge->getShortName(), create_sane_exception_message($e))); $this->logger->debug(sprintf('Exception in DisplayAction(%s): %s', $bridge->getShortName(), create_sane_exception_message($e)));
return new Response(render(__DIR__ . '/../templates/exception.html.php', ['e' => $e]), 429); return new Response(render(__DIR__ . '/../templates/exception.html.php', ['e' => $e]), $e->getCode());
}
if ($e->getCode() === 503) {
$this->logger->info(sprintf('Exception in DisplayAction(%s): %s', $bridge->getShortName(), create_sane_exception_message($e)));
return new Response(render(__DIR__ . '/../templates/exception.html.php', ['e' => $e]), 503);
} }
// Some other status code which we let fail normally (but don't log it)
} else {
// Log error if it's not an HttpException
$this->logger->error(sprintf('Exception in DisplayAction(%s)', $bridge->getShortName()), ['e' => $e]);
} }
$this->logger->error(sprintf('Exception in DisplayAction(%s)', $bridge->getShortName()), ['e' => $e]);
$errorOutput = Configuration::getConfig('error', 'output'); $errorOutput = Configuration::getConfig('error', 'output');
$reportLimit = Configuration::getConfig('error', 'report_limit'); $reportLimit = Configuration::getConfig('error', 'report_limit');
$errorCount = 1; $errorCount = 1;