mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-02-16 23:29:56 +03:00
Code Issues Projects Releases Packages Wiki Activity

[core] Fix XPathAbstract while working around Simple HTML DOM bug (#3408)

Browse source
This commit is contained in:
mrnoname1000 2023-05-21 14:06:35 -05:00 • committed by GitHub
parent f803ffa79a
commit 87b9f2dd94
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
lib/html.php
View file

@ -187,13 +187,24 @@ function defaultLinkTo($dom, $url)
// Use long method names for compatibility with simple_html_dom and DOMDocument
// foreach ($dom->getElementsByTagName('img', null) as $image) {
// $image->setAttribute('src', urljoin($url, $image->getAttribute('src')));
// }
// Work around bug in simple_html_dom->getElementsByTagName
if ($dom instanceof simple_html_dom) {
$findByTag = function ($name) use ($dom) {
return $dom->getElementsByTagName($name, null);
};
} else {
$findByTag = function ($name) use ($dom) {
return $dom->getElementsByTagName($name);
};
}
// foreach ($dom->getElementsByTagName('a', null) as $anchor) {
// $anchor->setAttribute('href', urljoin($url, $anchor->getAttribute('href')));
// }
foreach ($findByTag('img') as $image) {
$image->setAttribute('src', urljoin($url, $image->getAttribute('src')));
}
foreach ($findByTag('a') as $anchor) {
$anchor->setAttribute('href', urljoin($url, $anchor->getAttribute('href')));
}
// Will never be true for DOMDocument
if ($string_convert) {