mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2024-11-22 01:25:28 +03:00
Code Issues Projects Releases Packages Wiki Activity

[PepperBridgeAbstract,DealabsBridge,HotUKDealsBridge,MydealsBridge] Fix search URL, No results handling fixed, Thread title and Message URL handling (#4053)

Browse source 
* [PepperBridgeAbstract,DealabsBridge,HotUKDealsBridge,MydealsBridge] Fix search URL, No results handling fixed, Thread title and Message URL handling

Search URL has been updated according to the website.

If a search doesn't return any results, the HTML won't contain any
specific text now : the HTML structure is slightly different, so the
bridge has been updated.

The unnneded 'no-results' text is now removed from the specific bridges.

The board thread title has been removed from the content, so now we use
the page <title> element.

In case a board message is empty, there was an exception during the
filtering of message without URL.

* [PepperBridgeAbstract,DealabsBridge,HotUKDealsBridge,MydealsBridge] Fix search URL, No results handling fixed, Thread title and Message URL handling

Coding policy fixes
This commit is contained in:
sysadminstory 2024-04-04 04:08:29 +02:00 committed by GitHub
parent 94292af51b
commit 82606a479a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
bridges/DealabsBridge.php
View file

@ -1913,7 +1913,6 @@ class DealabsBridge extends PepperBridgeAbstract
'uri-merchant' => 'search/bons-plans?merchant-id=', 'uri-merchant' => 'search/bons-plans?merchant-id=',
'request-error' => 'Impossible de joindre Dealabs', 'request-error' => 'Impossible de joindre Dealabs',
'thread-error' => 'Impossible de déterminer l\'ID de la discussion. Vérifiez l\'URL que vous avez entré', 'thread-error' => 'Impossible de déterminer l\'ID de la discussion. Vérifiez l\'URL que vous avez entré',
'no-results' => 'Aucun résultat',
'currency' => '€', 'currency' => '€',
'price' => 'Prix', 'price' => 'Prix',
'shipping' => 'Livraison', 'shipping' => 'Livraison',

1
bridges/HotUKDealsBridge.php
View file

@ -3277,7 +3277,6 @@ class HotUKDealsBridge extends PepperBridgeAbstract
'uri-merchant' => 'search/deals?merchant-id=', 'uri-merchant' => 'search/deals?merchant-id=',
'request-error' => 'Could not request HotUKDeals', 'request-error' => 'Could not request HotUKDeals',
'thread-error' => 'Unable to determine the thread ID. Check the URL you entered', 'thread-error' => 'Unable to determine the thread ID. Check the URL you entered',
'no-results' => 'no results',
'currency' => '£', 'currency' => '£',
'price' => 'Price', 'price' => 'Price',
'shipping' => 'Shipping', 'shipping' => 'Shipping',

1
bridges/MydealsBridge.php
View file

@ -2024,7 +2024,6 @@ class MydealsBridge extends PepperBridgeAbstract
'uri-merchant' => 'search/gutscheine?merchant-id=', 'uri-merchant' => 'search/gutscheine?merchant-id=',
'request-error' => 'Could not request mydeals', 'request-error' => 'Could not request mydeals',
'thread-error' => 'Die ID der Diskussion kann nicht ermittelt werden. Überprüfen Sie die eingegebene URL', 'thread-error' => 'Die ID der Diskussion kann nicht ermittelt werden. Überprüfen Sie die eingegebene URL',
'no-results' => 'keine Ergebnisse',
'currency' => '€', 'currency' => '€',
'price' => 'Preis', 'price' => 'Preis',
'shipping' => 'Versand', 'shipping' => 'Versand',

25
bridges/PepperBridgeAbstract.php
View file

@ -55,8 +55,8 @@ class PepperBridgeAbstract extends BridgeAbstract
); );
// If there is no results, we don't parse the content because it display some random deals // If there is no results, we don't parse the content because it display some random deals
$noresult = $html->find('h3[class*=text--b]', 0); $noresult = $html->find('section[class=subNav]', 0)->find('div[class*=page-center listLayout aGrid]', 0);
if ($noresult != null && strpos($noresult->plaintext, $this->i8n('no-results')) !== false) { if ($noresult === null) {
$this->items = []; $this->items = [];
} else { } else {
foreach ($list as $deal) { foreach ($list as $deal) {
@ -174,13 +174,16 @@ HEREDOC;
$item['uid'] = $comment->commentId; $item['uid'] = $comment->commentId;
// Timestamp handling needs a new parsing function // Timestamp handling needs a new parsing function
if ($onlyWithUrl == true) { if ($onlyWithUrl == true) {
// Count Links and Quote Links // Only parse the comment if it is not empry
$content = str_get_html($item['content']); if ($item['content'] != '') {
$countLinks = count($content->find('a[href]')); // Count Links and Quote Links
$countQuoteLinks = count($content->find('a[href][class=userHtml-quote-source]')); $content = str_get_html($item['content']);
// Only add element if there are Links ans more links tant Quote links $countLinks = count($content->find('a[href]'));
if ($countLinks > 0 && $countLinks > $countQuoteLinks) { $countQuoteLinks = count($content->find('a[href][class=userHtml-quote-source]'));
$this->items[] = $item; // Only add element if there are Links and more links tant Quote links
if ($countLinks > 0 && $countLinks > $countQuoteLinks) {
$this->items[] = $item;
}
} }
} else { } else {
$this->items[] = $item; $this->items[] = $item;
@ -264,7 +267,7 @@ HEREDOC;
private function getTalkTitle() private function getTalkTitle()
{ {
$html = getSimpleHTMLDOMCached($this->getInput('url')); $html = getSimpleHTMLDOMCached($this->getInput('url'));
$title = $html->find('.thread-title', 0)->plaintext; $title = $html->find('title', 0)->plaintext;
return $title; return $title;
} }
@ -472,7 +475,7 @@ HEREDOC;
$priceFrom = $this->getInput('priceFrom'); $priceFrom = $this->getInput('priceFrom');
$priceTo = $this->getInput('priceTo'); $priceTo = $this->getInput('priceTo');
$url = $this->i8n('bridge-uri') $url = $this->i8n('bridge-uri')
. 'search/advanced?q=' . 'search?q='
. urlencode($q) . urlencode($q)
. '&hide_expired=' . $hide_expired . '&hide_expired=' . $hide_expired
. '&hide_local=' . $hide_local . '&hide_local=' . $hide_local