mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2024-12-18 17:10:29 +03:00
Code Issues Projects Releases Packages Wiki Activity

fix(file_cache): if write failure, produce log record instead of exception (#4352)

Browse source
This commit is contained in:
Dag 2024-11-28 03:50:56 +01:00 committed by GitHub
parent 88ccc6067c
commit 6a81fc0f51
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
caches/FileCache.php
View file

@ -54,10 +54,13 @@ class FileCache implements CacheInterface
]; ];
$cacheFile = $this->createCacheFile($key); $cacheFile = $this->createCacheFile($key);
$bytes = file_put_contents($cacheFile, serialize($item)); $bytes = file_put_contents($cacheFile, serialize($item));
// todo: Consider tightening the permissions of the created file. It usually allow others to read, depending on umask
// TODO: Consider tightening the permissions of the created file.
// It usually allow others to read, depending on umask
if ($bytes === false) { if ($bytes === false) {
// Consider just logging the error here // Typically means no disk space remaining
throw new \Exception(sprintf('Failed to write to: %s', $cacheFile)); $this->logger->warning(sprintf('Failed to write to: %s', $cacheFile));
} }
} }