mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2025-02-16 23:29:56 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix: content.php: last-modified/if-unmodified-since (#3771) (#3772)

Browse source 
* Fix: content.php: last-modified/if-unmodified-since (#3771)

Fix exception if server sent invalid Last-Modified header
Add support for Unix time instead of standard date string
Send back standard RFC7231 date string instead of Unix time

* Fix: content.php: if-unmodified-since: cURL API

Use getTimestamp() as cURL expects that and will format the If-Modified-Since header appropriately.
This commit is contained in:
ORelio 2023-10-20 13:33:07 +02:00 • committed by GitHub
parent 8ff39f64f7
commit 4f7451895b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
lib/contents.php
View file

@ -63,8 +63,13 @@ function getContents(
if ($cachedResponse) { if ($cachedResponse) {
$cachedLastModified = $cachedResponse->getHeader('last-modified'); $cachedLastModified = $cachedResponse->getHeader('last-modified');
if ($cachedLastModified) { if ($cachedLastModified) {
$cachedLastModified = new \DateTimeImmutable($cachedLastModified); try {
// Some servers send Unix timestamp instead of RFC7231 date. Prepend it with @ to allow parsing as DateTime
$cachedLastModified = new \DateTimeImmutable((is_numeric($cachedLastModified) ? '@' : '') . $cachedLastModified);
$config['if_not_modified_since'] = $cachedLastModified->getTimestamp(); $config['if_not_modified_since'] = $cachedLastModified->getTimestamp();
} catch (Exception $dateTimeParseFailue) {
// Ignore invalid 'Last-Modified' HTTP header value
}
} }
} }