mirrors/rss-bridge
1
0
Fork 0
mirror of https://github.com/RSS-Bridge/rss-bridge.git synced 2024-11-24 02:16:08 +03:00
Code Issues Projects Releases Packages Wiki Activity

feat: improve sqlite cache robustness (#3715)

Browse source
This commit is contained in:
Dag 2023-09-28 22:21:56 +02:00 committed by GitHub
parent f9ec88fb45
commit 0de5180ded
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
caches/SQLiteCache.php
View file

@ -86,8 +86,13 @@ class SQLiteCache implements CacheInterface
$stmt->bindValue(':key', $cacheKey);
$stmt->bindValue(':value', $blob, \SQLITE3_BLOB);
$stmt->bindValue(':updated', $expiration);
$result = $stmt->execute();
// Unclear whether we should $result->finalize(); here?
try {
$result = $stmt->execute();
// Should $result->finalize() be called here?
} catch (\Exception $e) {
$this->logger->warning(create_sane_exception_message($e));
// Intentionally not rethrowing exception
}
}
public function delete(string $key): void