mirror of
https://github.com/qbittorrent/qBittorrent.git
synced 2024-11-29 05:48:47 +03:00
qBittorrent BitTorrent client
6dabf50781
This commit implements a map where qbittorrent store a state of current torrent movings. This commit speed up torrents moving a bit and also fix a bug when qbittorrent doesn't do cleanup action when a single torrent is moved several times without waiting for a previous move to complete. How it worked before. Libtorrent has a function torrent_handle::move_storage() that allows to move a torrent to a specific directory. This function is asynchorous. It means that this function quits instantaneously and when the actual operation completes the alert 'storage_moved_alert' or 'storage_moved_failed_alert' will be sent. The storage_moved_alert contains a torrent_handle and a new path to where the torrent is moved. During handling of storage_moved_alert, qbittorrent needs not only new path, but also an old path to perform some of cleanup actions (like removing an old folder if it is empty). This was achieved by storing a value named 'previous save path' in TorrentPersistentData. A previous save path is written when move_storage() is issued and is read when storage_moved_alert is received. Problems. This mechanism has two negative aspects: 1. TorrentPersistentData is very slow. As torrent_handle::move_storage() is asynchoronous, TorrentPersistentData is responsible for more that 99.8% of time QTorrentHandle::move_storage(). This percent could be higher when there are lots of torrents and lower when there are few of them. 2. TorrentPersistentData stores only one previous path. But many move_storage()'s could be issued without waiting for previous to complete. Subsequent move_storage()'s overwrites previous save path of a previous move. A fix. The fix is simple. Before issueing move_storage() the oldPath is stored in a special map called 'torrentMoveStates'. When a storage_moved_alert is received the map is consulted and an alert is handled. When user moves torrent when previous moving have not yet finished, the new location is saved in a field 'queuedPath' the same map. When torrent moving is completed (or failed) qbittorrent attemps to perform move again to the queued location. Future direction. This fix removes one slow read and one slow write to TorrentPersistentData on torrent moving, but there is still exists TorrentPersistentData::saveSavePath in handleStorageMovedAlert(), so overall time for UI hang should be reduced only threefold. A speeding up TorrentPersistentData should be addressed in a separate commit. I don't know if I should clean up torrentMoveStates when torrent is deleted. In any case, torrent could be deleted when corresponding alert is in alert queue. So if we decide to clean up torrentMoveStates, then we should not treat receiving alert from unknown torrent as a error. |
||
|---|---|---|
| .tx | ||
| build-aux | ||
| doc | ||
| m4 | ||
| src | ||
| .gitignore | ||
| .travis.yml | ||
| AUTHORS | ||
| bootstrap.sh | ||
| Changelog | ||
| conf.pri.in | ||
| configure | ||
| configure.ac | ||
| COPYING | ||
| INSTALL | ||
| install.os2 | ||
| macxconf.pri | ||
| NEWS | ||
| os2conf.pri | ||
| qbittorrent.pro | ||
| qbittorrent.qc | ||
| qm_gen.pri | ||
| README.md | ||
| README.os2 | ||
| TODO | ||
| unixconf.pri | ||
| version.pri | ||
| winconf-mingw.pri | ||
| winconf-msvc.pri | ||
| winconf.pri | ||
qBittorrent - A BitTorrent client in Qt
###Description: qBittorrent is a bittorrent client programmed in C++ / Qt that uses libtorrent (sometimes called libtorrent-rasterbar) by Arvid Norberg.
It aims to be a good alternative to all other bittorrent clients out there. qBittorrent is fast, stable and provides unicode support as well as many features.
This product includes GeoLite data created by MaxMind, available from http://maxmind.com/
Installation:
For installation, follow the instructions from INSTALL file, but simple:
./configure
make && make install
qbittorrent
will install and execute qBittorrent hopefully without any problem.
For more information please visit: http://www.qbittorrent.org
or our wiki here: http://wiki.qbittorrent.org
Please report any bug (or feature request) to: http://bugs.qbittorrent.org
You can also meet me (sledgehammer_999) on IRC:
#qbittorrent on irc.freenode.net
sledgehammer999 sledgehammer999@qbittorrent.org