mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-09 08:37:27 +03:00
Code Issues Projects Releases Packages Wiki Activity
11791 commits 16 branches 245 tags 256 MiB
Commit graph

1020 commits

Author SHA1 Message Date
Chocobo1
85b0a40a0e
Merge pull request #16587 from jagannatharjun/tracker-filter 
Optimize torrent filters in GUI
 2022-03-12 12:48:49 +08:00
Chocobo1
f0dd7b7dae
Use QString literals 
This patch covers src/app and src/base folders.
Follow up of ab64ee872b.
 2022-03-11 00:11:30 +08:00
Chocobo1
9f32e6e50d
Fix wrong parentheses 
Fix up 294ea17222.
 2022-03-08 13:58:02 +08:00
An0n
801cfdbc24
Allow setting the number of maximum active checking torrents 
This is to allow re-checking of multiple torrents simultaneously. This will benefit users who
have multiple disks or SSD.
Closes #15296.

Co-authored-by: Chocobo1 <Chocobo1@users.noreply.github.com>
 2022-03-08 13:24:12 +08:00
Prince Gupta
30319e51e5 Improve Status Filter 
replaces quadratic update operation with linear
 2022-03-08 01:12:06 +05:30
Chocobo1
294ea17222
Provide upstream documentation link for performance warning 2022-03-07 13:26:37 +08:00
Chocobo1
fad954df18
Add option for enable/disable performance warnings from libtorrent 2022-03-06 21:05:17 +08:00
Prince Gupta
cd9ed1706d Improve torrent event handling in TrackerFiltersList 2022-03-06 12:04:01 +05:30
Vladimir Golovnev (Glassez)
cbc0ef860b
Prevent loading resume data with inconsistent ID 2022-03-04 09:22:56 +03:00
Chocobo1
ab64ee872b
Use QString literals 
The plan is to define `QT_NO_CAST_FROM_ASCII` eventually.
PR #16561.
 2022-03-04 13:25:22 +08:00
Vladimir Golovnev
213b18e33b
Merge pull request #16531 from glassez/save-path 
Correctly handle changing of global save path
 2022-03-01 19:59:35 +03:00
Chocobo1
ac97ed685f
Add tuning options related to performance warnings 
Related: #16462.
PR #16538.
 2022-03-01 12:44:48 +08:00
Vladimir Golovnev (Glassez)
c5ff9b353c
Allow to disable Automatic mode when "temp" path changed 2022-02-28 09:41:44 +03:00
Vladimir Golovnev (Glassez)
04c1988665
Correctly handle changing of global save path 2022-02-28 09:04:37 +03:00
Chocobo1
b854c3b00e
Unify log messages format 
This improves readability and may allow users to match log message with
better accuracy.
Now log message is consisted of 2 parts:
The first part is a short sentence describing the event. It should avoid
writing out the specifics of the event as it will be described in the
next part of the message. The sentence should use correct tense of the
event.
The second part consist of `Name: Value` pairs which will provide
sufficient info for the event.

Note that none of the message parts is mandatory, one of them can be
omitted when the resulting log message is clear enough.

PR #16437.
 2022-02-21 13:07:04 +08:00
Vladimir Golovnev
70ec183fca
Merge pull request #16444 from glassez/path-has-ext 
Improve performance of checking path extension
 2022-02-19 07:08:54 +03:00
Vladimir Golovnev (Glassez)
1e45b7f50b
Add fast way of removing suggested extension 2022-02-18 11:37:51 +03:00
Vladimir Golovnev
b3f5bf1583
Try to recover missing categories 
PR #16430.
 2022-02-16 10:27:36 +03:00
Chocobo1
bc94de5626
Merge pull request #16428 from Chocobo1/path 
Improve Path constructor
 2022-02-14 14:02:50 +08:00
Vladimir Golovnev
c3a64b3d6c
Cache file priorities 
Speedup access to file priorities by avoiding extra blocking call to libtorrent thread.
Improve the Torrent interface by hiding the asynchrony of file priority changes behind the scenes.

PR #16425.
 2022-02-13 08:07:30 +03:00
Chocobo1
70eed10a34
Fix wrong size 
Fix up cf96e6c642.
 2022-02-12 16:54:38 +08:00
Chocobo1
2668a42f0c
Merge pull request #16408 from Chocobo1/vararray 
Use QVarLengthArray whenever applicable
 2022-02-10 12:44:41 +08:00
Vladimir Golovnev
4a7f1116ac
Improve tracker status handling 
PR #16383.
 2022-02-09 18:23:41 +03:00
Chocobo1
4cb075b168
Use "table look-up" method for reversing byte 
This method takes constant time and is less prone to (CPU) pipeline stalling due to less
computation. Also it is slightly faster than the previous method.
 2022-02-09 19:00:27 +08:00
Chocobo1
cf96e6c642
Use QVarLengthArray whenever applicable 2022-02-09 19:00:24 +08:00
Vladimir Golovnev
dd1bd8ad10
Implement class for handling filesystem paths 
PR #15915.
 2022-02-08 06:03:48 +03:00
Vladimir Golovnev
facfa26eed
Allow to use Category paths in "Manual" mode 
If the option is enabled any relative save path will be resolved against an appropriate Category path instead of Global default one.

PR #16330.
 2022-02-02 09:24:09 +03:00
Prince Gupta
0012a3ede7
Optimize completed files handling 
PR #16329.

Co-authored-by: Vladimir Golovnev (Glassez) <glassez@yandex.ru>
 2022-02-01 08:29:54 +03:00
Prince Gupta
414361a3db
Improve tracker error handling 
* Improve tracker error handling
* Fix typo in function name

PR  #16298.
 2022-01-30 08:56:31 +03:00
Prince Gupta
1d4071d6d8
Don't rename file because of difference in path separator 
PR #16317.
 2022-01-30 08:54:37 +03:00
Chocobo1
7a910a8cc1
Merge pull request #16256 from Chocobo1/bitarray 
Speed up bitfields conversion
 2022-01-28 11:59:57 +08:00
Vladimir Golovnev
ca9e5e8531
Change torrent moving state when it is cancelled 
PR #16267.
 2022-01-27 07:40:17 +03:00
Chocobo1
aafee60033
Allocate memory on stack whenever feasible 
The fast path gives another 20% speed up than the slower path.
 2022-01-27 03:36:06 +08:00
Vladimir Golovnev (Glassez)
7a539d9890
Store hybrid torrents using "torrent ID" as basename 2022-01-25 11:39:32 +03:00
Vladimir Golovnev (Glassez)
c40408b337
Make Digest32 implicitly shared class 2022-01-25 10:18:23 +03:00
Chocobo1
4e2daf117b
Speed up bitfields conversion 
The old code took 3~5 times longer than the newer version.
 2022-01-25 12:19:50 +08:00
Chocobo1
9553afc3c2
Merge pull request #16247 from Chocobo1/count_bits 
Speed up piece relevance calculation
 2022-01-25 12:11:36 +08:00
Vladimir Golovnev
26352c9eb4
Cache pieces info 
PR #16238.
 2022-01-25 06:05:16 +03:00
Chocobo1
53992bf0d5
Initialize class variable in initializer list 2022-01-24 13:47:34 +08:00
Chocobo1
ff99e5ac9a
Speed up piece relevance calculation 
For ~800 pieces, this roughly cuts the run time (of this function) in
half.
 2022-01-24 12:04:26 +08:00
Vladimir Golovnev
4d54fb675f
Correctly handle received metadata 
It did not work correctly, since it assumed that 'lt::torrent_plugin' is created at an earlier stage and is able to track all changes in the torrent state, but in reality it turned out that it was created after the torrent moved to the `downloading_metadata` state, so we had to additionally handle it in the constructor.

PR #16121.
 2022-01-16 16:06:15 +03:00
Chocobo1
e93de54eb5
Merge pull request #16099 from Chocobo1/errormsg 
Revise error message
 2022-01-15 12:01:55 +08:00
Vladimir Golovnev
43441d8291
Handle missing torrent alerts 
PR #16085.
 2022-01-14 15:18:18 +03:00
Chocobo1
5ebbed8160
Revise error message 
Remove the period mark at the end of error message since
`errc.message()` already contains one.
 2022-01-14 14:48:41 +08:00
Chocobo1
e4a67183bd
Update default value of "Type of service for peers" 
Upstream change:
3d701c7380
PR #16036.
 2022-01-12 11:53:07 +08:00
Vladimir Golovnev
a3be239a60
Keep "torrent info" alive while generating .torrent file 
PR #16018.
 2022-01-11 07:29:42 +03:00
Vladimir Golovnev
709a053c7c
Merge pull request #16009 from glassez/dont-move-into-itself 
Don't try to move storage into its current location
 2022-01-11 07:26:22 +03:00
Vladimir Golovnev
84a8158aa2
Correctly track the root folder name change 
PR #16004.
 2022-01-11 07:24:24 +03:00
Vladimir Golovnev (Glassez)
fbc85bed64
Move torrent immediately when "save path" is changed 2022-01-10 08:18:34 +03:00
Vladimir Golovnev (Glassez)
52b54fe154
Don't try to move storage into its current location 2022-01-09 21:14:49 +03:00
Vladimir Golovnev
f44341a8e2
Handle .!qB extension behind the scenes 
PR #15920.
 2022-01-08 08:45:50 +03:00
thalieht
d3bdeaab3f
Replace "seeding_duration" with "finished_duration" everywhere 
Closes #10223.
PR #13601.
 2022-01-07 15:22:51 +08:00
sledgehammer999
ac5a485651
Disambiguate the data type 2022-01-04 01:39:01 +02:00
sledgehammer999
0a1c61d9d3
Merge pull request #15922 from glassez/fix-paths 
Correctly concatenate path components
 2022-01-04 00:17:54 +02:00
Chocobo1
01a0fff4c2 Add missing field initial value 
Suppresses the following warning:
qBittorrent/src/base/bittorrent/categoryoptions.cpp: In static member function ‘static BitTorrent::CategoryOptions BitTorrent::CategoryOptions::fromJSON(const QJsonObject&)’:
qBittorrent/src/base/bittorrent/categoryoptions.cpp:44:59: warning: missing initializer for member ‘BitTorrent::CategoryOptions::DownloadPathOption::path’ [-Wmissing-field-initializers]
   44 |         options.downloadPath = {downloadPathValue.toBool()};
 2022-01-03 23:42:48 +02:00
Vladimir Golovnev (Glassez)
fdbf8cb0ee
Correctly concatenate path components 2022-01-03 19:44:47 +03:00
Vladimir Golovnev
61504ae3b1
Merge pull request #15793 from glassez/save-path 
Redesign "Incomplete folder" feature
 2022-01-02 22:25:00 +03:00
Vladimir Golovnev (Glassez)
1c0f8b4289
Redesign "Incomplete folder" feature 
Change "Incomplete/temp folder" term with "download folder".
Allow to set "download folder" per torrent (in manual mode) and per category (in automatic mode).
 2022-01-01 20:58:49 +03:00
Chocobo1
63043b4927
Replace min, max, clamp functions with std counterparts 2022-01-01 15:22:07 +08:00
Chocobo1
7a620c794d
Fix garbage message when reporting error 
PR #15883.
 2021-12-24 12:28:22 +08:00
Vladimir Golovnev (Glassez)
62b50d1475
Make TorrentInfo immutable 2021-12-19 16:16:16 +03:00
Vladimir Golovnev
3d7ff9765a
Make meaning of "torrent root path" consistent 
PR #15816.
 2021-12-09 06:12:47 +03:00
Chocobo1
e3fe66d3ec
Store enum type in settings directly 
Affected settings will be migrated to new keys so nothing should break.

PR #15800.
 2021-12-06 13:53:52 +08:00
Chocobo1
19d95ebd10
Add comment for qHash implementation requirements 
As clazy report false-positive on this.
 2021-11-29 01:28:49 +08:00
Chocobo1
c8b66b25e8
Avoid potential container detachment 
Suppress clazy warning:
warning: Don't call QList::operator[]() on temporary [-Wclazy-detaching-temporary]
 2021-11-29 00:31:03 +08:00
Chocobo1
e6f07a6fe4
Use implicit copy-constructor generated by compiler 
This also suppresses the following clang warning:
warning: definition of implicit copy assignment operator for 'Version<unsigned short, 2>' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
 2021-11-29 00:30:17 +08:00
Chocobo1
71270260bf
Reformat code 2021-11-08 13:34:21 +08:00
Chocobo1
32698fe0be
Migrate away from low-level SettingsStorage class 
Also add `QFlags<T>` support to `SettingsStorage`.
PR #15693.
 2021-11-08 13:23:33 +08:00
Vladimir Golovnev
cc61ad01b6
Explicitly set "added time" when adding new torrent 
Don't overwrite "added time" with possibly incorrect value.
Explicitly set "added time" when adding new torrent.

PR #15644.
 2021-10-31 12:08:19 +03:00
Chocobo1
e45e29b431
Avoid type specifier mismatch 
Qt5 uses `int` and Qt6 uses `qsizetype`, so use the stream version of
`qDebug()` to avoid specifying types.
 2021-10-14 00:24:41 +08:00
Vladimir Golovnev
5d5b0d572e
Merge pull request #15536 from glassez/expected 
Don't use output parameters for error handling
 2021-10-10 15:04:55 +03:00
Vladimir Golovnev (Glassez)
78459fcb31
Don't throw exception in TorrentInfo::saveToFile() 2021-10-09 08:54:20 +03:00
Vladimir Golovnev (Glassez)
41fc0fd084
Don't use output parameters for error handling 2021-10-09 08:54:03 +03:00
Chocobo1
4a11fab2b1
Add constexpr to Sample class functions 2021-10-08 01:04:58 +08:00
Vladimir Golovnev
bc71827c01
Improve torrent content handling 
Hide .pad files.

PR #15468.
 2021-10-02 21:42:58 +03:00
Chocobo1
ecd23d0abd
Merge pull request #15459 from Chocobo1/i18n 
Revise description wordings
 2021-09-19 13:29:08 +08:00
Chocobo1
010d1b5ff8
Merge pull request #15419 from Chocobo1/file 
Improve error detection when saving files
 2021-09-19 13:28:47 +08:00
Chocobo1
03012cc175
Revise description wordings 2021-09-18 12:59:07 +08:00
Chocobo1
21f72baae2
Use QSaveFile wherever applicable 
expected.hpp was fetched from:
b803e3c07b/include/nonstd/expected.hpp
 2021-09-15 21:54:44 +08:00
Chocobo1
2efd4f2a77
Prevent self-assignment in assignment operator 2021-09-09 21:42:46 +08:00
Vladimir Golovnev
b823d74ac3
Use "old file path" provided by libtorrent 
Until libtorrent provided an "old_name" field in `file_renamed_alert` we relied
on a workaround with storing old file names to remove empty leftover folders.
PR #15356.
 2021-08-23 07:29:50 +03:00
sledgehammer999
3e92e716b2
Merge pull request #15294 from sledgehammer999/accept_v2_infohash 
Accept v2 infohashes for download
 2021-08-08 12:29:04 +03:00
Chocobo1
138c911ef4
Add compile definition to indicate using of libtorrent 2.0 (#15297) 
The compile definition is temporary which will be removed when qbt
ditches libtorrent 1.x.
 2021-08-08 13:27:22 +08:00
sledgehammer999
e5fe6401a0
Accept v2 infohashes for download 
Partially fixes #15287
 2021-08-07 17:25:13 +03:00
Sylvain Finot
e87f8f5b93
Expose SSRF mitigation (#15247) 2021-08-04 11:28:36 +08:00
Chocobo1
ce554e6c77
Merge pull request #15229 from Chocobo1/port 
Use spinbox special value to represent "Use any available port"
 2021-07-30 15:19:08 +08:00
AbeniMatteo
e4730191db
Set default file priorities when not specified (#15190) 2021-07-29 12:20:03 +08:00
Chocobo1
49aab492e0
Use spinbox special value to represent "Use any available port" 
WebAPI functionality is preserved (deprecated) for now and should be
removed in the future.
 2021-07-29 11:50:52 +08:00
Chocobo1
09e558ae0b
Revise checkbox label for "Use any available ports" functionality 
Also reorder the checkboxes a bit.
 2021-07-27 13:35:18 +08:00
Vladimir Golovnev
1eb246c98b
Merge pull request #15181 from glassez/qt5 
Raise minimum Qt version to 5.15.2
 2021-07-23 06:22:57 +03:00
Chocobo1
96e0c0df20
Improve handling for magnet URI (#15209) 
This add support for magnets URI in v2 hash format.
 2021-07-22 13:05:59 +08:00
Vladimir Golovnev
ed4570cb4d
Store minimal metadata for "restore torrent" purposes (#15191) 
We can no longer save valid torrent files in the general case, because
for torrents of version 2, we need a full merkle tree to do it, but if
a torrent is added from magnet link, full merkle tree may not be available
even before the end of downloading all the data. Actually, we don't need
the full torrent file for the purposes of resuming the torrent, so we can
allow libtorrent to produce only a minimal part of the metadata as part
complete resume data, but we still want to store it in a separate file,
so we extract the resulting metadata from the complete resume data before
saving and merge it together before loading.
 2021-07-19 07:59:06 +03:00
AbeniMatteo
01d851440b
Add "Forced metadata downloading" state (#15185) 2021-07-17 21:33:14 +03:00
Vladimir Golovnev (Glassez)
399d3ad85a
Replace QStringRef with QStringView 2021-07-15 10:56:49 +03:00
Chocobo1
fd3d4d479a
Suppress type narrowing warning on MSVC 
Fix up 45e31a153c.
 2021-07-08 14:25:39 +08:00
Chocobo1
45e31a153c
Reserve space for vector 2021-07-07 14:20:27 +08:00
Chocobo1
7c23d800e6
Use underlying_type member directly 
`LTUnderlyingType` served as a intermediate type for libtorrent 1.1 and
1.2 and is obsoleted now.
Also add helper to convert to underlying type.
 2021-07-07 14:19:17 +08:00
Vladimir Golovnev
5d03917877
Use torrent info with hashes for creating .torrent file (#15138) 2021-07-04 09:29:34 +03:00
Chocobo1
eedd47860a
Merge pull request #15142 from Chocobo1/warning 
Use proper signed number type
 2021-07-01 11:35:04 +08:00
Chocobo1
365554d064
Use proper signed number type 
This also suppress the compiler warning:
src/base/bittorrent/torrentimpl.cpp:228:36: warning: comparison of integer expressions of different signedness: ‘int’ and ‘const size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
 2021-06-29 18:04:33 +08:00