Thomas Piccirello
5c74f374af
Re-order and rename stats
2018-02-23 14:54:24 -05:00
Thomas Piccirello
a8420a43f9
Format Read cache hits as percentage
2018-02-23 14:46:47 -05:00
Vladimir Golovnev
5c2f698cb4
Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach
...
Prevent possible c++11 range-loop container detach
2018-02-22 16:28:04 +03:00
Luís Pereira
1a913c502b
Prevent possible c++11 range-loop container detach
...
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.
In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.
For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.
Intended uses:
QString s = ...;
for (const auto &ch : qAsConst(s))
process(ch);
for (const auto &ch : copyAsConst(funcReturningQString()))
process(ch);
2018-02-20 19:28:51 +00:00
Vladimir Golovnev
3035184d25
Merge pull request #8445 from glassez/fix-webapi
...
Fix POST params handling. Closes #8443
2018-02-20 11:11:33 +03:00
Thomas Piccirello
e0c74c2d39
Remove conditionals
2018-02-20 02:22:40 -05:00
Thomas Piccirello
288f372914
Rename onClick property to onclick
2018-02-20 02:16:16 -05:00
Thomas Piccirello
ba331436fa
Add More Information link
2018-02-20 02:16:16 -05:00
Thomas Piccirello
afd4069eb4
Disable options when force proxy is enabled
2018-02-20 02:16:15 -05:00
Vladimir Golovnev
387f9b1230
Merge pull request #8438 from Piccirello/webui-proxy-only
...
Add "Use proxy only for torrents" option to webui
2018-02-20 09:06:30 +03:00
Mike Tzou
b87ca60c5a
Merge pull request #8134 from Piccirello/webui-show-status-bar
...
Add option to show/hide webui status bar
2018-02-20 00:09:09 +08:00
Mike Tzou
6d44075662
Merge pull request #8228 from Piccirello/webui-save-window-size
...
WebUI Save user's resized windows
2018-02-20 00:02:32 +08:00
Thomas Piccirello
69af205094
Use .each(). Refactor conditionals.
2018-02-18 23:54:48 -05:00
Thomas Piccirello
8a2e3f5d93
Add option to show/hide webui status bar
2018-02-18 23:46:27 -05:00
Thomas Piccirello
3f79726ab9
Make download + upload windows resizable
2018-02-18 22:50:21 -05:00
Thomas Piccirello
d1c4b1599a
WebUI Save user's resized window sizes
2018-02-18 22:50:21 -05:00
Vladimir Golovnev (Glassez)
29042e4841
Fix wrong WebAPI param name
2018-02-18 19:54:08 +03:00
Thomas Piccirello
0d55599e02
Add "Use proxy only for torrents" option to webui
2018-02-17 21:25:42 -05:00
Luís Pereira
ea1b0b26b1
Don't implicitly cast iterator to const_iterator
...
It prevents detachments:
To illustrate:
QMap<QString, QString> map;
/* code compiles and works fine but find() returns the non-const
QMap::iterator that detaches!
*/
QMap<QString, QString>::const_iterator it = map.find("girish");
but also some subtle bugs:
QHash<int, int> wrong;
if (wrong.find(1) == wrong.cend()) {
qDebug() << "Not found";
} else {
/* find() detached the container before cend() was called, so it
prints "Found"
*/
qDebug() << "Found";
}
QHash<int, int> right;
if (right.constFind(1) == right.cend()) {
qDebug() << "Not found"; // This is correct now !
} else {
qDebug() << "Found";
}
Enforced by QT_STRICT_ITERATORS definition.
2018-02-17 17:02:52 +00:00
Vladimir Golovnev (Glassez)
27d8dbf13b
Redesign Web API
...
Normalize Web API method names.
Allow to use alternative Web UI.
Switch Web API version to standard form (i.e. "2.0").
Improve Web UI translation code.
Retranslate changed files.
Add Web API for RSS subsystem.
2018-01-28 19:16:24 +03:00
Vladimir Golovnev (Glassez)
bb683bd393
Switch built-in Web UI html to HTML5
2018-01-23 11:08:37 +03:00
Vladimir Golovnev
56ccf28000
Merge pull request #8133 from Piccirello/webui-statistics-format
...
WebUI Statistics parity with GUI
2018-01-23 10:15:39 +03:00
Vladimir Golovnev
0a45fc9ffe
Merge pull request #7990 from Piccirello/subnet-whitelist-refactor
...
Refactor ip subnet whitelist
2018-01-23 10:03:00 +03:00
Tom Piccirello
ebea0d91af
Remove default case, fix #8302
2018-01-22 02:05:41 -05:00
Thomas Piccirello
65e0aa6b82
Add default case
2018-01-18 23:30:19 -05:00
Thomas Piccirello
6d0cceca83
Use switch statement
2018-01-18 00:15:13 -05:00
Thomas Piccirello
8e9b928b61
Match webui statuses to gui, closes #7516
2018-01-18 00:15:12 -05:00
sledgehammer999
95c32221a2
Update copyright year.
2018-01-06 02:23:09 +02:00
Thomas Piccirello
9b919b6c34
Add missing units
2018-01-05 02:48:41 -05:00
Thomas Piccirello
49d3b7bf30
Right-align stat values
2018-01-05 02:48:41 -05:00
Chocobo1
ec337a8a84
Sort filename lists in .pri files
2017-12-31 11:53:45 +08:00
Thomas Piccirello
ddd6c82dd7
Use https for www.qbittorrent.org
2017-12-26 18:22:03 -05:00
Vladimir Golovnev
155dc49c5a
Merge pull request #7914 from Piccirello/webui-columns
...
Webui add torrent columns to match gui
2017-12-26 22:03:07 +03:00
sledgehammer999
94b64884f8
Merge pull request #7997 from Piccirello/webui-content-columns
...
Add "Remaining" and "Availability" columns to webui Content tab
2017-12-23 20:32:46 +02:00
Chocobo1
fb6bdbefd5
WebUI: Only prepend scheme when it is not present. Closes #8057 .
2017-12-18 14:12:31 +08:00
Thomas Piccirello
0f6dff6315
Make value formatting consistent with GUI
2017-12-12 01:25:06 -05:00
Thomas Piccirello
97b4e4a3d3
Add "Remaining" and "Availability" columns to webui Content tab
2017-12-12 01:25:06 -05:00
Vladimir Golovnev (Glassez)
fcde1ba09c
Fix WebUI is not reachable via IPv6
2017-12-09 09:57:19 +03:00
Thomas Piccirello
d184bd8c82
Perform ip string validation inside setWebUiAuthSubnetWhitelist
2017-12-06 02:05:33 -05:00
Thomas Piccirello
a05562cdc5
Add Time Active column
2017-12-03 15:01:35 -05:00
Thomas Piccirello
ee37f1db3d
Add Tags columns
2017-12-03 15:01:35 -05:00
sledgehammer999
2124ef261a
Merge pull request #7964 from Chocobo1/typeError
...
[WebUI] Fix logout behavior
2017-12-02 14:23:38 +02:00
Chocobo1
b234fcec9c
[WebUI] Use POST for logout command
...
This is to avoid browser being smart to prefetch the link then logging
out the user.
2017-12-02 14:32:40 +08:00
Chocobo1
1a45145c1e
[WebUI] Add check to avoid type error after logout
2017-12-02 14:32:40 +08:00
Chocobo1
c1a282aa7b
Fix missing qbt logo on login page in webUI. Closes #7953 .
2017-12-02 14:31:48 +08:00
Thomas Piccirello
e1f8e6aa6f
Reposition Total Size column to match gui
2017-11-26 19:37:20 -05:00
sledgehammer999
4e96a1065e
Bump API_VERSION to 16.
2017-11-22 01:14:33 +02:00
Chocobo1
27090f0cfb
Remove superfluous QString::fromUtf8()
2017-11-21 22:48:00 +08:00
Chocobo1
77f66be493
[WebUI] Fix logo missing in login page
2017-11-21 03:41:07 +08:00
Vladimir Golovnev
f41cb8089d
Merge pull request #6779 from Piccirello/disable-web-auth
...
Add ip subnet whitelist for bypassing webui auth
2017-11-20 21:52:33 +03:00
sledgehammer999
af5a02d971
Merge pull request #7673 from sledgehammer999/webui_clean_exit
...
WebUI: Correctly exit depending if mainloop is running.
2017-11-19 19:12:30 +02:00
Vladimir Golovnev (Glassez)
71bb6538db
Fix WebUI error handling
2017-11-19 19:10:04 +02:00
Mike Tzou
d821bdc9f3
Merge pull request #7669 from Chocobo1/portCheck
...
[WebAPI] Improve error messages
2017-11-10 23:41:19 +08:00
Thomas Piccirello
95bf63330e
Add ip subnet whitelist for bypassing webui auth
2017-11-08 22:39:49 -05:00
sledgehammer999
ffa6f7ea34
Bump API_VERSION to 16.
2017-11-03 01:57:32 +02:00
Chocobo1
aa4107478e
[WebAPI] Improve error messages
...
Also refactor to use class methods
2017-11-02 23:01:14 +08:00
Chocobo1
fc0628d35b
Allow SMTP sender to be set. Closes #7575 .
2017-10-26 17:57:32 +08:00
Mike Tzou
acdb7a27dc
Merge pull request #7638 from Chocobo1/msg
...
[WebUI] Improve log messages
2017-10-24 20:19:12 +08:00
Mike Tzou
b6be5afb89
Merge pull request #7584 from Chocobo1/refactor
...
[WebAPI] Refactor
2017-10-23 19:36:28 +08:00
Chocobo1
157b809e21
[WebUI] Improve log messages
2017-10-23 16:45:41 +08:00
Mike Tzou
f74e2b0130
Merge pull request #7631 from Chocobo1/webUIaddr
...
Reinitialize webUI server when "IP address" setting changed
2017-10-23 14:11:50 +08:00
sledgehammer999
c887a162ba
Fix row height/width in webui for country flags.
...
Patch by Chocobo1.
2017-10-23 01:23:54 +03:00
sledgehammer999
52df71ad3a
Use svg icons for the country flags.
...
Closes #6223 .
2017-10-23 01:23:45 +03:00
Chocobo1
d6ddc90199
Reinitialize webUI server when "IP address" setting changed
...
An app restart won't be necessary from now on.
2017-10-22 14:42:51 +08:00
Mike Tzou
9600e7f5ad
Merge pull request #7573 from fmatthew5876/config_webui_ip
...
Add WebUi\Address config option
2017-10-22 14:18:08 +08:00
Matthew Fioravante
8cd243b06b
Add WebUi\Address config option
2017-10-21 09:32:30 -04:00
Chocobo1
ce362f0e5e
WebAPI refactor: utilize parseBool() function
...
Coding style cleanup
Rename variable
Return const reference
Add const
2017-10-18 22:27:59 +08:00
Chocobo1
4940a77d12
[WebUI]: Print error messages upon receiving invalid header fields
2017-10-18 20:11:53 +08:00
Mike Tzou
bd07cb91bb
Merge pull request #7571 from Chocobo1/webui_download
...
[WebAPI] Add parameters for /command/download & /command/upload
2017-10-15 20:32:14 +08:00
Mike Tzou
dc600d47ec
Merge pull request #7570 from Chocobo1/webui_fileIdx
...
[WebAPI] Add file-to-piece-index mappings in /query/propertiesFiles command
2017-10-14 01:05:00 +08:00
Chocobo1
e78d8b9fcc
Convert tab into whitespaces
2017-10-11 20:27:19 +08:00
Chocobo1
f350977cb4
WebUI: add optional parameters for /command/download & /command/upload
...
Specifically:
torrent name: string
download limit, upload limit: number in bytes, default: -1 (unlimited)
sequential download, first last piece prio: boolean true/false, default: false
2017-10-11 20:25:11 +08:00
Eugene Shalygin
7a652c0a8c
Merge pull request #7566 from evsh/themes-cbc
...
Themes part 1
2017-10-11 10:34:56 +02:00
Chocobo1
a652baadb5
Add file-to-piece-index mappings in /query/propertiesFiles command
...
Also do the following cleanups:
Use string constant QB_EXT
Remove redundant variable
Add const
2017-10-11 16:24:29 +08:00
Mike Tzou
e07501252c
Merge pull request #7549 from fmatthew5876/master
...
Report TCPServer errorString() if webui fails to listen to port
2017-10-11 16:22:52 +08:00
Eugene Shalygin
db35bb54e1
Make BitTorrent::TorrentState strongly-typed enum
...
This is needed to forward declare this type and pass it by value.
Conversion from/to QVariant are hanled via Q_DECLARE_METATYPE, while
TorrentState::toString() function was used in webui only and as such is
moved there.
2017-10-10 21:28:57 +02:00
Chocobo1
5185eeb7ef
Die gracefully when failed to initialize web server with qbt-nox
2017-10-09 13:50:01 +08:00
Vladimir Golovnev
083bc71315
Merge pull request #7396 from thalieht/updownratio
...
Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg
2017-10-08 21:06:55 +03:00
thalieht
525fdd6c2b
Coding style, use nullptr and other minor things
2017-10-08 10:20:54 +03:00
Matthew Fioravante
05c92e652c
Report TCPServer errorString() if webui fails to listen to port
2017-10-06 05:54:52 +00:00
Vladimir Golovnev
66a6674cbc
Merge pull request #7490 from glassez/category-path
...
Allow to set explicit save path for Category from GUI
2017-09-29 14:25:40 +03:00
Vladimir Golovnev (Glassez)
3ec992474d
Implement TorrentCategoryDialog class
2017-09-27 21:25:22 +03:00
Mike Tzou
2eb3ec1a6e
Merge pull request #7463 from Piccirello/fix-priority-context-menu-placement
...
Reposition "Priority" menu option in WebUI to match gui (closes #7072 )
2017-09-24 10:28:05 +08:00
Chocobo1
c5ddbcfb5b
WebAPI: fix addPaused wrong default behavior
...
Add helper function
Sort include header
2017-09-19 17:26:01 +08:00
Chocobo1
72b0ba36ae
Refactor
...
Merge statements
Use case-insensitive contains()
Add const
Use value(), this avoids inserting empty values.
Use range based for loop
2017-09-19 14:16:39 +08:00
Chocobo1
b107c0671d
WebAPI: fix root_folder default behavior
...
Bug was introduced in
6b33db3ae3
2017-09-19 13:07:50 +08:00
sledgehammer999
b9e233601d
Merge pull request #7446 from Chocobo1/utpOnly
...
Add uTP only mode option
2017-09-19 01:45:58 +03:00
Chocobo1
45a0c5558a
Add comboBox for selecting BitTorrent protocol. Closes #6316 .
...
Use unicode string C_UTP in place of "uTP"
2017-09-18 01:52:57 +08:00
Thomas Piccirello
b6596f9957
Reposition "Priority" menu option in WebUI to match gui ( closes #7072 )
2017-09-17 05:42:46 -04:00
thalieht
6b33db3ae3
Create root folder option when adding a torrent in WebUI
2017-09-11 16:56:33 +03:00
Allan Nordhøy
5c18db240c
Spelling: HTTP/HTTPS
2017-09-08 11:22:25 +02:00
Chocobo1
64d5e329c0
Sort the resource lists
...
Update RCC header
2017-08-29 13:39:02 +08:00
Chocobo1
9ef1e32327
WebAPI: fix validating wrong header field. Closes #7311 .
...
X-Forwarded-Host is a foreign proxy setting, it isn't the same as
qbt's local setting and thus it makes no sense to verify it.
2017-08-20 22:40:19 +08:00
Chocobo1
65ca490b64
Wrap class & functions in anonymous namespace
...
Rename vars
Cleanup class interfaces
Pass by reference whenever possible
2017-08-19 01:57:11 +08:00
Thomas Piccirello
4846b0ec28
Use single quotes for char.
...
Use case insensitive compare.
Swap conditionals
2017-08-14 23:15:03 +08:00
Thomas Piccirello
771033a449
Add auto torrent management to webui context menu (addresses #6815 )
2017-08-14 23:14:46 +08:00
Mike Tzou
0522db3f19
Merge pull request #7061 from Piccirello/webui-rename-torrent
...
Rename torrent from webui context menu (addresses #6815 )
2017-08-13 23:39:35 +08:00
Vladimir Golovnev (qlassez)
cff6a64e9f
Use qUtf8Printable() for logging strings
...
qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments
to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding.
Therefore qUtf8Printable() should be used for logging strings instead of
qPrintable().
2017-08-13 16:14:57 +03:00
Thomas Piccirello
798c230634
Add option to rename torrent from WebUI
...
Addresses #6815 .
2017-08-13 15:45:51 +03:00
Chocobo1
3e9311b096
Correctly handle translation
...
Fixup of 07a85a1018
2017-08-06 17:20:01 +08:00
