353 commits

Author	SHA1	Message	Date
Chocobo1	6a16fc1ca2	Prolong resume data save interval	2018-07-05 13:22:13 +08:00
thalieht	456270bbb1	Delete several unused #include	2018-07-03 08:38:32 +03:00
thalieht	eb508d67ef	Fix coding style	2018-07-03 08:38:32 +03:00
Vladimir Golovnev (Glassez)	d78414307e	Make TorrentInfo loading behavior uniform	2018-06-29 15:48:36 +03:00
Vladimir Golovnev (Glassez)	112a9bcfa2	Use new DownloadManager interface	2018-06-29 15:48:17 +03:00
thalieht	4022799881	Fix coding style	2018-06-12 07:17:05 +03:00
Chocobo1	09f759355f	Replace QRegExp with QRegularExpression ... Revise `static` keyword usage, static is added to frequently used instances.	2018-05-31 22:56:49 +08:00
Chocobo1	c22e6b4502	Cleanup header include order ... Add missing header. Cleanup license.	2018-05-31 22:56:25 +08:00
sledgehammer999	7c6a5afbff	Merge pull request #8962 from sledgehammer999/suppress_errors ... Suppress multiple I/O errors for the same torrent	2018-05-24 16:35:03 +03:00
Mike Tzou	cd21071c69	Merge pull request #8954 from Chocobo1/firstlast ... Relax behavior of "Download first and last piece first"	2018-05-23 13:26:02 +08:00
Mike Tzou	84df2794dc	Merge pull request #8944 from Chocobo1/literal ... Make use of QStringLiteral	2018-05-23 13:23:41 +08:00
sledgehammer999	b9546ccd4c	Suppress multiple I/O errors for the same torrent ... When a file error happens libtorrent spews a ton of `file_error_alert` which result in log floods and notification balloon floods. The later might render the program inaccessible because the constant notifications prevent the user from interacting with the tray icon. Closes #8934	2018-05-22 21:29:50 +03:00
Vladimir Golovnev (Glassez)	a54f57611c	Rename torrent if content was initially renamed ... Closes #8910.	2018-05-19 20:21:21 +03:00
Chocobo1	95b19ec303	Relax behavior of "Download first and last piece first" ... Now it applies the setting to all files in torrent, no matter whether the file is previewable or not. Torrent client shouldn't be smart by deciding which file this option will be applied to, i.e. it should just follow the user's decision.	2018-05-19 21:48:13 +08:00
Chocobo1	da75a010c7	Refactor code ... Add const to variables. Add Logger message. Simplify code logic.	2018-05-19 21:48:13 +08:00
Chocobo1	ceaf755ac6	Make use of QStringLiteral ... Only changed instances that are initialized at program start.	2018-05-18 02:14:49 +08:00
sledgehammer999	8a99e29122	Merge pull request #8716 from sledgehammer999/move_progress ... Move and recheck progress	2018-05-13 13:02:03 +03:00
sledgehammer999	375b15727d	Show rechecking progress ... When having big torrents, the rechecking might take a while to complete. Users need some sort of feedback that progress is being made. Also, I changed the float to qreal since that's the return type.	2018-05-13 12:32:17 +03:00
sledgehammer999	e5c73cee4a	Log successful torrent move	2018-05-12 20:49:33 +03:00
sledgehammer999	565ffa7d1e	Add 'Moving' state for torrents being relocated/moved ... This is another indication to the user that something is happening behind the scenes. Uses the same icon/color as "Checking" status. Torrents in the `Moving` state are considered as "Active". This should prevent accidental program exit from the user and inhibit system sleep.	2018-05-12 20:49:33 +03:00
Vladimir Golovnev (Glassez)	32e2791f56	Fix compilation with MinGW	2018-05-12 06:24:05 +03:00
thalieht	20ca90800d	Fix coding style	2018-05-09 17:06:22 +03:00
thalieht	6b4455e13d	Use qt5 connect() syntax	2018-05-09 16:08:22 +03:00
Mike Tzou	7af83ab704	Merge pull request #8807 from Chocobo1/tracker_msg ... Fix displayed tracker message	2018-05-09 14:38:17 +08:00
Mike Tzou	99a1343b9d	Merge pull request #8862 from Chocobo1/cleanup ... Code cleanups	2018-05-09 14:33:49 +08:00
Vladimir Golovnev	3a0e5e51df	Merge pull request #8761 from thalieht/nullptr ... Replace the zeroing of pointers with nullptr	2018-05-08 17:10:37 +03:00
Chocobo1	defba23d61	Refactor code ... Remove forward declarations of Qt types. Fix header include order.	2018-05-08 12:18:18 +08:00
Chocobo1	6d923f703a	Fix displayed tracker messages ... Before this change, we were displaying debug messages constructed by libtorrent, now we show messages returned by trackers. Closes #8739.	2018-05-07 21:49:31 +08:00
Chocobo1	90f42e6737	Refactor functions ... Add const to variables Remove debug messages	2018-05-07 21:49:31 +08:00
Chocobo1	58861c35b0	Fix compile warnings on gcc 8 ... The warning was: warning: catching polymorphic type ‘class std::exception’ by value [-Wcatch-value=]	2018-05-07 21:39:54 +08:00
Chocobo1	203bafc4c3	Revert commit ... Apparently the translations were working in previous state, but affected by lupdate issue: https://github.com/qbittorrent/qBittorrent/issues/8220#issuecomment-385712673 The reverts commit fb698896c9. Closes #8831.	2018-05-05 21:46:36 +08:00
Mike Tzou	d8c14ffe97	Merge pull request #8814 from Chocobo1/tr_fix ... Fix tr() related issues	2018-05-05 13:48:09 +08:00
Chocobo1	9fabe59b80	Fix usage of Q_DECLARE_TR_FUNCTIONS() ... The context parameter shouldn't be enclosed in double quotes.	2018-05-01 22:42:55 +08:00
sledgehammer999	6e94b03c13	Fix compilation against libtorrent 1.0.x ... Closes #8798	2018-05-01 10:39:53 +03:00
Chocobo1	970ad7cf28	Sort filenames when creating torrent ... First all dir paths are retrieved, then filenames in each path are retrieved and sorted, then concatenate the sorted filenames together.	2018-04-20 14:35:48 +03:00
toster	c4625f50a8	Pass isAlignmentOptimized flag to piece size calculation	2018-04-20 14:31:20 +03:00
thalieht	3e4099fe5b	Replace the zeroing of pointers with nullptr	2018-04-15 13:06:31 +03:00
toster	e538eae726	Make alignment optimization optional ... Disabling alignment optimization allows preserving file order in torrent files and closes #5652	2018-04-14 06:46:41 +03:00
Mike Tzou	38837db8de	Merge pull request #8699 from Chocobo1/linking ... Add helper for loading Windows system functions	2018-04-11 00:13:55 +08:00
sledgehammer999	747c70a58e	Avoid data corruption when rechecking paused torrents ... Libtorrent can recheck only unpaused torrents. We get around this by unpausing the torrent, issuing the recheck and pausing again after we get alerted by libtorrent that the recheck has finished. This alert is asyncronous. There is a small time frame where the program might start downloading and writing data to the file before we pause it. This can lead to data corruption if the file on disk is totally different that the one expected by the torrent AND the file on disk is a valid file on its own. OR in case the user points the new torrent to the wrong directory by mistake. To get around this the torrent is placed in upload_mode and out of automanagement.	2018-04-09 23:25:52 +03:00
Chocobo1	b0e3d77975	Add helper for loading Windows system functions	2018-04-09 21:18:04 +08:00
Chocobo1	37ea01bd44	Use lightweight printf instead of iostream ... Using iostream usually adds a lot of other operators (<<, endl), whereas *printf takes only 1 function call. Also use qUtf8Printable whenever possible.	2018-03-31 03:21:53 +08:00
Vladimir Golovnev	a5294e1e08	Merge pull request #8558 from luis-pereira/containter-anti-pattern ... Don't create temporary containers just to iterate over them	2018-03-19 13:06:01 +03:00
Luís Pereira	ac42ccb5e4	Don't create temporary containers just to iterate over them ... Stops temporary containers being created needlessly due to API misuse. For example, it’s common for developers to assume QHash::values() and QHash::keys() are free and abuse them, failing to realize their implementation internally actually iterates the whole container, allocates memory, and fills a new QList. Added a removeIf generic algorithm, similar to std ones. We can't use std algorithms with Qt dictionaries because Qt iterators have different behavior from the std ones. Found using clazy.	2018-03-18 16:22:12 +03:00
Chocobo1	fdb0d97b28	Remove unused function	2018-03-11 23:27:04 +08:00
Mike Tzou	7233274110	Merge pull request #8562 from Chocobo1/lint ... Fix warnings from clazy	2018-03-11 12:41:58 +08:00
Vladimir Golovnev	4f206f987a	Merge pull request #8561 from glassez/tracker ... Properly reply to announce request	2018-03-10 17:08:29 +03:00
Vladimir Golovnev (Glassez)	dfddda57b9	Properly reply to announce request	2018-03-09 17:41:06 +03:00
Chocobo1	ed310c2dac	Avoid temporary QString allocations ... Fix up 0457fd260e	2018-03-09 01:34:35 +08:00
Chocobo1	50167d40d7	Allow ADL lookup for helper function	2018-03-09 01:34:19 +08:00
Mike Tzou	5261d4375f	Merge pull request #8551 from Chocobo1/override ... Fix warnings from linters	2018-03-09 00:36:52 +08:00
Chocobo1	0457fd260e	Avoid temporary QString allocations ... This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]	2018-03-07 20:06:00 +08:00
Vladimir Golovnev (Glassez)	1aca3b0adc	Parse URL query string at application level	2018-03-04 17:08:48 +03:00
Mike Tzou	55c3db339b	Merge pull request #8455 from Chocobo1/large_torrent ... Fix loading very large torrents. Closes #8449	2018-03-01 13:22:43 +08:00
Vladimir Golovnev	6207855f3b	Merge pull request #8372 from thalieht/inactiverate ... Expose the libtorrent fields for "dont_count_slow_torrents" to GUI. Closes #5713.	2018-02-24 14:13:39 +03:00
thalieht	0e30659c26	Fix possible crash when using both share limits ... Avoid possible crash in "torrent->name()" when processing seeding time of the torrent that already reached the ratio limit.	2018-02-23 17:13:56 +02:00
Chocobo1	f5fc2d52b8	Fix loading very large torrents. Closes #8449. ... `torrent_info` constructor has default limits that can't be changed via parameters, so we handle the loading process manually and explicitly specifiy the limits to `bdecode()`. The token_limit is also changed to 10000000.	2018-02-22 18:52:10 +08:00
Mike Tzou	47048d8410	Merge pull request #8349 from Chocobo1/stats ... Improve stats dialog	2018-02-16 15:31:01 +08:00
Mike Tzou	882fa7ecd4	Merge pull request #8336 from Chocobo1/coalesce ... Add "Coalesce reads & writes" checkbox in advanced options	2018-02-16 15:30:17 +08:00
thalieht	f50b4724a6	Expose the libtorrent fields for "dont_count_slow_torrents" to GUI: ... inactive_down_rate inactive_up_rate auto_manage_startup	2018-02-08 14:14:39 +02:00
Chocobo1	b9ec216aa5	Redefine CacheStatus.readRatio field. ... Now it is defined as: CacheStatus.readRatio = (blocks read from cache) / (blocks read from disk + blocks read from cache) The 2 variables in denominator are counted separately and the formula before this change doesn't really make sense Add percentage sign to "Read cache hits" stats Also remove redundant header include	2018-02-02 23:41:42 +08:00
Chocobo1	543cbc6d1c	Add "Coalesce reads & writes" checkbox in advanced options ... The setting is defaulted to ON for Windows. Closes #8295.	2018-01-30 22:46:14 +08:00
Vladimir Golovnev (Glassez)	27d8dbf13b	Redesign Web API ... Normalize Web API method names. Allow to use alternative Web UI. Switch Web API version to standard form (i.e. "2.0"). Improve Web UI translation code. Retranslate changed files. Add Web API for RSS subsystem.	2018-01-28 19:16:24 +03:00
Vladimir Golovnev (Glassez)	69df8174b9	Allow to load TorrentInfo from data buffer	2018-01-23 11:08:32 +03:00
Chocobo1	fb698896c9	Fix translation context. ... Partially addresses #8220. Also sort include headers	2018-01-07 23:01:22 +08:00
sledgehammer999	b11c33b2d9	Merge pull request #8068 from thalieht/readableFlags ... Make peer information flags in peerlist more readable	2017-12-23 19:33:19 +02:00
sledgehammer999	cf9bad03aa	Fix application of speed limits on LAN and μTP connections. Closes #7745.	2017-12-23 19:19:08 +02:00
thalieht	5b52835377	Make peer information flags in peerlist more readable	2017-12-20 11:22:23 +02:00
Chocobo1	8dcf326576	Add source field in Torrent creator. Closes #7965. ... This field is often used for cross-seeding between (private) trackers.	2017-12-09 00:39:50 +08:00
Chocobo1	c405cb2f1c	Add struct TorrentCreatorParams for passing parameters ... Filter out continuous newlines in Trackers field Avoid adding empty url seed entries Cleanup: Replace boost::bind Add const Use nullptr Use QString::SkipEmptyParts Rename variables Throw proper exception type	2017-12-06 01:56:36 +08:00
sledgehammer999	a55be5e58f	Stop logging IP filter parsing errors after a while. ... When a lot of errors happen the resulting log lines introduce a huge slowdown of the GUI, due to writing each log line to disk. Closes #7755.	2017-11-29 15:49:59 +02:00
sledgehammer999	48c46dc79a	Fix crash on some systems when creating address object for 255.255.255.255 ... Closes #7735.	2017-11-27 19:06:37 +02:00
Chocobo1	534ed91d04	Change MixedModeAlgorithm default to TCP. Closes #7779. ... MixedModeAlgorithm::Proportional will throttle TCP connections when utp is in use and users is expecting maximum speed no matter what, so now disable the throttling.	2017-11-22 22:39:52 +08:00
Chocobo1	433b5a46cf	Fix crash when aborting a torrent creation process. Closes #7783. ... The wait time wasn't long enough causing the thread to terminate prematurely. Also, to avoid crashing qbt entirely when creating a torrent for a very big file, I decided to wait indefinitely here.	2017-11-21 18:33:47 +08:00
Chocobo1	034d71dce3	Wrap function into anonymous namespace	2017-11-21 18:23:39 +08:00
sledgehammer999	9f8e7917a8	Merge pull request #7657 from Chocobo1/upnp ... Disable upnp & nat-pmp on startup if disabled in options. Closes #7338.	2017-10-31 18:24:28 +02:00
Chocobo1	1b652c882e	Refactor ... Add const Use Qt5 connect syntax	2017-10-31 19:09:01 +08:00
Chocobo1	601234e492	Explicitly set UPnP state on start-up. Closes #7338. ... libtorrent 1.1 enables upnp by default.	2017-10-31 19:08:58 +08:00
sledgehammer999	6c804edadf	Change default settings for tracker/tier announces to mimick ìTorrent behavior.	2017-10-30 23:27:29 +02:00
sledgehammer999	3a5c0d9818	Allow to specify if announcing to all tiers is desired.	2017-10-30 23:27:28 +02:00
Mike Tzou	1f7391737e	Merge pull request #7445 from Chocobo1/fixAddTorrent ... Disable processing socket events in findIncompleteFiles()	2017-10-25 23:00:35 +08:00
sledgehammer999	50471ec8c8	String fixes and optimizations mentioned by translators on Transifex.	2017-10-24 03:32:56 +03:00
Chocobo1	f3603d05e7	Disable processing events when adding torrents. Closes #7436. ... webUI connection timeout & deletion might occur while doing processEvents() and will result in use-after-free segfault.	2017-10-22 13:54:03 +08:00
Mike Tzou	bd07cb91bb	Merge pull request #7571 from Chocobo1/webui_download ... [WebAPI] Add parameters for /command/download & /command/upload	2017-10-15 20:32:14 +08:00
Chocobo1	66b86888fc	Add uploadLimit, downloadLimit fields to AddTorrentData & AddTorrentParams	2017-10-11 16:23:58 +08:00
Eugene Shalygin	db35bb54e1	Make BitTorrent::TorrentState strongly-typed enum ... This is needed to forward declare this type and pass it by value. Conversion from/to QVariant are hanled via Q_DECLARE_METATYPE, while TorrentState::toString() function was used in webui only and as such is moved there.	2017-10-10 21:28:57 +02:00
Vladimir Golovnev	083bc71315	Merge pull request #7396 from thalieht/updownratio ... Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg	2017-10-08 21:06:55 +03:00
thalieht	0717f0d60c	Save ratio limits as int instead of string	2017-10-08 10:22:40 +03:00
thalieht	525fdd6c2b	Coding style, use nullptr and other minor things	2017-10-08 10:20:54 +03:00
thalieht	f27e75e8fa	Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg dialogs. Fixes #7352	2017-10-08 10:20:38 +03:00
Vladimir Golovnev	66a6674cbc	Merge pull request #7490 from glassez/category-path ... Allow to set explicit save path for Category from GUI	2017-09-29 14:25:40 +03:00
Vladimir Golovnev (Glassez)	3ec992474d	Implement TorrentCategoryDialog class	2017-09-27 21:25:22 +03:00
Mike Tzou	1fe9272a8f	Merge pull request #7480 from Chocobo1/lastAct ... Fix last activity calculation	2017-09-26 15:17:35 +08:00
Chocobo1	62493c672d	Fix last activity calculation. Closes #7461 ... `time_since_upload` & `time_since_download` can be -1, so filter them out	2017-09-24 21:06:34 +08:00
sledgehammer999	c7e35a1801	Merge pull request #7451 from sledgehammer999/report_delete_fail ... Better reporting of success/failure of torrent and file deletion.	2017-09-21 23:36:53 +03:00
sledgehammer999	b9e233601d	Merge pull request #7446 from Chocobo1/utpOnly ... Add uTP only mode option	2017-09-19 01:45:58 +03:00
sledgehammer999	8f16388915	Better reporting of success/failure of torrent and file deletion.	2017-09-17 23:04:12 +03:00
Chocobo1	45a0c5558a	Add comboBox for selecting BitTorrent protocol. Closes #6316. ... Use unicode string C_UTP in place of "uTP"	2017-09-18 01:52:57 +08:00
Chocobo1	a1d46a278b	Change default value of m_diskCacheSize. New default is 64 MB.	2017-09-14 20:32:04 +08:00
Chocobo1	855772ae5a	Fix dereferencing freed pointer. Closes #7420. ... The torrent is removed from session after `deleteTorrent()` yet we still invoke `torrent->name()`, thus result in crash.	2017-09-11 13:16:34 +08:00