mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-09 08:37:27 +03:00
Code Issues Projects Releases Packages Wiki Activity
9340 commits 16 branches 245 tags 256 MiB
Commit graph

1398 commits

Author SHA1 Message Date
Chocobo1
0b050e2a30
Remove duplicate private sections in class 
And group related methods & variables together.
 2018-06-05 12:22:32 +08:00
Mike Tzou
731865427e
Merge pull request #9008 from Chocobo1/changelog 
Add changelog URL link in updater
 2018-06-04 20:51:18 +08:00
Vladimir Golovnev
e61c882fee
Merge pull request #9015 from thalieht/style 
Fix coding style
 2018-06-03 14:48:04 +03:00
thalieht
356d6a6589 Fix coding style 2018-05-31 19:45:09 +03:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression 
Revise `static` keyword usage, static is added to frequently used
instances.
 2018-05-31 22:56:49 +08:00
Chocobo1
c22e6b4502
Cleanup header include order 
Add missing header.
Cleanup license.
 2018-05-31 22:56:25 +08:00
Chocobo1
68c6ddf05d
Add changelog link in program updater 
Closes #8997.
 2018-05-30 13:54:15 +08:00
Chocobo1
ee202b721d
Refactor function 2018-05-29 09:36:08 +08:00
Chocobo1
727800ef2c
Improve DownloadFromURL behavior 
URL should be considered case sensitive.
 2018-05-29 09:36:08 +08:00
Chocobo1
34ed0cba08
Move DownloadFromURLDialog to its own file 
Simplify code, no functionality changes.
Remove debug messages.
Capitalize dialog name.
Capitalize class name.
Update license text.
 2018-05-29 09:36:03 +08:00
Chocobo1
817b7bb4f2
Add missing header include 2018-05-29 02:07:55 +08:00
Mike Tzou
4a51f14328
Merge pull request #8967 from Chocobo1/protect 
Add options to control WebUI security measures
 2018-05-28 14:21:53 +08:00
sledgehammer999
a1a6a7ef56
Merge pull request #8868 from Chocobo1/macos 
Fix GUI scaling factor on macOS
 2018-05-27 17:39:00 +03:00
Chocobo1
4751b79f42
Initialize variables properly 
The warnings are emitted when compiling on msys2, mingw

The warning was:
gui/torrentcontentmodel.cpp:135:33: warning: missing initializer for
member '_SHFILEINFOW::iIcon' [-Wmissing-field-initializers]

..\..\qBittorrent\src\app\stacktrace_win.h:141:30: warning: missing
initializer for member '_IMAGEHLP_LINE64::Key'
[-Wmissing-field-initializers]
 2018-05-25 21:22:31 +08:00
Mike Tzou
84df2794dc
Merge pull request #8944 from Chocobo1/literal 
Make use of QStringLiteral
 2018-05-23 13:23:41 +08:00
sledgehammer999
9df6ecafd0
Merge pull request #8961 from sledgehammer999/stats_dialog 
Fix Stats dialog size
 2018-05-22 20:24:50 +03:00
Chocobo1
9eeef0be97
Add option to control CSRF protection 
Some users are using WebUI with simple port-forwarding from their router,
providing an option to control the protection will save them from setting up an
non-trival web proxy.
Closes #7274.
 2018-05-22 12:57:03 +08:00
Chocobo1
bad4d94f77
Add option to control WebUI clickjacking protection 
Some users actually want embedding WebUI into their custom build iframe.
Closes #7370.
 2018-05-22 01:07:25 +08:00
Vladimir Golovnev
0aee1cf7d0
Merge pull request #8945 from glassez/rss-rule 
Improve code of  RSS auto-downloading rule. Closes #8933
 2018-05-21 08:04:12 +03:00
sledgehammer999
b4c1a949cc
Fix Stats dialog size 
Partially reverts e31ec20ec4.
Closes #8870.
 2018-05-20 23:35:20 +03:00
Vladimir Golovnev (Glassez)
3be945a401
Add last used save path to the front of history 2018-05-19 19:43:01 +03:00
Chocobo1
eb72b9ca7d
Simplify the saving & loading of a setting 
Remove excessive usage of constexpr.
 2018-05-19 20:56:43 +08:00
Vladimir Golovnev (Glassez)
53b9bcaaac
Place "Use Smart Episode Filter" more correctly 2018-05-19 14:52:38 +03:00
Vladimir Golovnev (Glassez)
844f76c2ca
Make "Ignoring days" to behave like other filters 
This prevents confusing in GUI when it shows matched RSS
articles which be really ignored by the rule.
 2018-05-19 14:52:24 +03:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral 
Only changed instances that are initialized at program start.
 2018-05-18 02:14:49 +08:00
Vladimir Golovnev
e2da7928b1
Merge pull request #8922 from glassez/save-path 
Add option to remember last used save path. Closes #7323
 2018-05-15 19:30:09 +03:00
Vladimir Golovnev (Glassez)
71e5a40857
Add option to remember last used save path 
Replace in "Add new torrent" dialog confusing "Set as default save path" option
with "Remember last used save path" option that affects only selected value in
"Save path" combo box.
Closes #7323.
 2018-05-15 10:38:24 +03:00
Mike Tzou
a0f200be0d
Merge pull request #8894 from Chocobo1/tr 
Make strings translatable
 2018-05-14 12:53:40 +08:00
sledgehammer999
8a99e29122
Merge pull request #8716 from sledgehammer999/move_progress 
Move and recheck progress
 2018-05-13 13:02:03 +03:00
sledgehammer999
565ffa7d1e
Add 'Moving' state for torrents being relocated/moved 
This is another indication to the user that something is happening
behind the scenes.
Uses the same icon/color as "Checking" status.
Torrents in the `Moving` state are considered as "Active". This should
prevent accidental program exit from the user and inhibit system sleep.
 2018-05-12 20:49:33 +03:00
Chocobo1
c26ff40029
Make strings translatable 
Closes #8866.
 2018-05-11 19:29:02 +08:00
thalieht
4cfa163bbd Use qt5 syntax for a few remaining SLOT() 2018-05-11 08:19:41 +03:00
thalieht
20ca90800d Fix coding style 2018-05-09 17:06:22 +03:00
thalieht
586e1a0830 Move some connect() from propertieswidget to their corresponding widget 2018-05-09 16:08:22 +03:00
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
Chocobo1
4d04af4043
Replace raster qbt logo with vector version 
Add helper function for svg icons.
 2018-05-09 16:33:17 +08:00
Chocobo1
f934042a98
Fix GUI scaling factor on macOS 
macOS seems have an unique way to handle widget size, that is, it doesn't require
application to resize widgets manually, Qt will handle the resize job
automatically.

Closes #8841.
 2018-05-09 16:33:14 +08:00
Mike Tzou
99a1343b9d
Merge pull request #8862 from Chocobo1/cleanup 
Code cleanups
 2018-05-09 14:33:49 +08:00
Vladimir Golovnev
3a0e5e51df
Merge pull request #8761 from thalieht/nullptr 
Replace the zeroing of pointers with nullptr
 2018-05-08 17:10:37 +03:00
Chocobo1
defba23d61
Refactor code 
Remove forward declarations of Qt types.
Fix header include order.
 2018-05-08 12:18:18 +08:00
Chocobo1
9f809114f0
Really fix translation in fspathedit 
QT_TRANSLATE_NOOP3 is a macro, so we cannot use a runtime string for the context
argument.
Fix up 1d778676cd.
 2018-05-05 21:09:47 +08:00
Mike Tzou
d8c14ffe97
Merge pull request #8814 from Chocobo1/tr_fix 
Fix tr() related issues
 2018-05-05 13:48:09 +08:00
sledgehammer999
90bb67c654
Add RSS/Log widgets to the QTabWidget on macOS 
Fixes commit a468c84b30
 2018-05-04 19:56:42 +03:00
Chocobo1
e423314ac2
Work around false-positive warning from lupdate 
In short, lupdate will get confused when seeing `template <class T>`,
see: QTBUG-55478
 2018-05-01 23:28:34 +08:00
Chocobo1
c61f641613
Fix untranslated string 
Closes #8809.
 2018-05-01 11:49:10 +08:00
Chocobo1
8b575484e6
Fix path separator in log messages 2018-04-24 01:02:54 +08:00
Mike Tzou
0dec7b9f4f
Merge pull request #8742 from tostercx/master 
Add "Preserve file order" option to torrent creator. Closes #5652
 2018-04-22 23:33:25 +08:00
toster
c4625f50a8 Pass isAlignmentOptimized flag to piece size calculation 2018-04-20 14:31:20 +03:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
toster
e538eae726 Make alignment optimization optional 
Disabling alignment optimization allows preserving file order in torrent
files and closes #5652
 2018-04-14 06:46:41 +03:00
Chocobo1
898239a42e
Fix renaming completed files 
Check whether the file is already downloaded before appending QB_EXT to
filename.

Closes #8039.
 2018-04-12 14:13:59 +08:00
sledgehammer999
d997d887e5
Merge pull request #8650 from luis-pereira/fix-invalid-iterator-crash 
Fix crashes due to invalid iterator use
 2018-04-10 16:18:44 +03:00
Luís Pereira
758c70283f
Fix crashes due to invalid iterator use 
Although the iterators are constant we are indirectly changing them.
Introduced by commit ac42ccb5e4.
Closes #8633
 2018-04-09 23:40:08 +03:00
Chocobo1
59e6757242
Avoid showing an empty row in AdvancedSettings 
Fixup 543cbc6d1c.
 2018-04-05 21:34:07 +08:00
Chocobo1
37ea01bd44
Use lightweight printf instead of iostream 
Using iostream usually adds a lot of other operators (<<, endl), whereas
*printf takes only 1 function call.

Also use qUtf8Printable whenever possible.
 2018-03-31 03:21:53 +08:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern 
Don't create temporary containers just to iterate over them
 2018-03-19 13:06:01 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them 
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.

Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.

Found using clazy.
 2018-03-18 16:22:12 +03:00
Mike Tzou
68ca95faf0
Merge pull request #8603 from Chocobo1/typo 
Fix typo
 2018-03-17 00:49:41 +08:00
Mike Tzou
1f28122428
Merge pull request #8595 from Chocobo1/runExt 
Add Tags parameter to "Run External Program"
 2018-03-16 19:37:34 +08:00
Chocobo1
423511765a
Fix typo 2018-03-14 23:37:08 +08:00
Chocobo1
88881de8c6
Add Tags parameter to "Run External Program" 
Closes #8586.
Also sort headers.
 2018-03-14 10:12:32 +08:00
Chocobo1
690c439ae6
Properly align text label 2018-03-14 00:35:20 +08:00
Mike Tzou
e78b5202bc
Merge pull request #8585 from Chocobo1/lint 
Fix compiler/clazy warnings
 2018-03-13 22:36:10 +08:00
Vladimir Golovnev
c9be1d0a19
Merge pull request #8494 from paolo-sz/master 
Fix for "Content" panel messed up
 2018-03-13 16:54:05 +03:00
Vladimir Golovnev
3348eef423
Merge pull request #8488 from thalieht/fix 
Move suffix-labels inside the corresponding spinboxes
 2018-03-12 16:58:05 +03:00
Chocobo1
a468c84b30
Fix warnings from unused variables 2018-03-12 14:36:28 +08:00
Thomas Piccirello
7278625f53 Calculate supported categories based on selected plugin 2018-03-12 01:33:45 -04:00
Chocobo1
08a2439f46
Check directly if container is empty or not 2018-03-11 23:12:16 +08:00
Chocobo1
6767487e40
Remove unused variable 2018-03-11 22:31:17 +08:00
thalieht
2eea57e609 Use spinbox suffix to display time unit 2018-03-11 12:08:00 +02:00
thalieht
0b185e347b Use spinbox suffix to display rate unit 2018-03-11 12:07:38 +02:00
thalieht
1e1db31ab5 Use unique layout names 2018-03-11 12:07:24 +02:00
paolo-sz
d4e2b21534 Fix Content widget misbehavior 
Starting from QT 5.10.1 Content widget is messed up and its settings are
lost while restarting.
Setting StretchLastSection property to false seems to solve the issue.
(Closes #8439).
 2018-03-10 18:56:18 +01:00
Chocobo1
fdf3ebbb6c
Remove usage of deprecated functions 
Also use proper type for storing date/time data
 2018-03-09 19:20:58 +08:00
Chocobo1
a3d9e457a0
Add context parameter in connect() 2018-03-09 13:44:17 +08:00
Chocobo1
ffb5c0635e
Remove unused slot declaration for function 2018-03-09 01:50:23 +08:00
Chocobo1
0457fd260e
Avoid temporary QString allocations 
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
 2018-03-07 20:06:00 +08:00
Chocobo1
c60b7b213e
Add missing 'override' specifier 
This fixes clang warning:
'notify' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
 2018-03-07 20:05:52 +08:00
Chocobo1
20c4b0ee0c
Use original scheme when downloading favicons 
Previously was always using http, now we only drop back to http when
scheme is absent
 2018-03-03 12:53:27 +08:00
Chocobo1
3df4a7ac2e
Use https for documentation links 2018-03-03 12:43:59 +08:00
Mike Tzou
38dc6ab8cf
Merge pull request #8441 from Chocobo1/runExt 
Revert back to QLineEdit for "Run external program". Closes #7800.
 2018-03-01 13:23:42 +08:00
Vladimir Golovnev
b26eb3d146
Merge pull request #8373 from glassez/search 
Improve Search handling
 2018-02-28 10:46:33 +03:00
Mike Tzou
050af8a793
Merge pull request #7894 from Piccirello/auto-management 
Disable options when Force Proxy is enabled
 2018-02-25 01:44:58 +08:00
Vladimir Golovnev
6207855f3b
Merge pull request #8372 from thalieht/inactiverate 
Expose the libtorrent fields for "dont_count_slow_torrents" to GUI.
Closes #5713.
 2018-02-24 14:13:39 +03:00
Vladimir Golovnev (Glassez)
279bce2014
Make SearchManager singleton 2018-02-23 20:26:32 +03:00
Vladimir Golovnev (Glassez)
f3d370870d
Improve Search handling 
Legacy SearchEngine class really has three roles:
  1. Manage search plugins,
  2. Handle the search job, and
  3. Handle the download of the torrent file using the search plugin.
Now it is splitted into 3 classes: SearchManager, SearchHandler and
SearchDownloadHandler.
Search GUI is also improved.
 2018-02-23 20:15:25 +03:00
Vladimir Golovnev
5c2f698cb4
Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach 
Prevent possible c++11 range-loop container detach
 2018-02-22 16:28:04 +03:00
Chocobo1
aba23f67a0
Revert back to QLineEdit for "Run external program". Closes #7800 
1. Using FileSystemPathEdit is not entirely correct, as it only always
shows false warnings when parameters are present.
2. FileSystemPathEdit::selectedPath() modifies the path to unix format,
in this specific case, we need to faithfully execute what user inputted.
3. Given the above it is reasonable to revert back to QLineEdit, as it
is just sufficient in functionality and doesn't modifiy the inputs.
 2018-02-21 10:16:32 +08:00
Luís Pereira
1a913c502b Prevent possible c++11 range-loop container detach 
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.

In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.

For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.

Intended uses:

    QString s = ...;
    for (const auto &ch : qAsConst(s))
          process(ch);

    for (const auto &ch : copyAsConst(funcReturningQString()))
        process(ch);
 2018-02-20 19:28:51 +00:00
Thomas Piccirello
fccdc7ebdc Remove extra space 2018-02-20 02:22:40 -05:00
Thomas Piccirello
ba331436fa Add More Information link 2018-02-20 02:16:16 -05:00
Thomas Piccirello
afd4069eb4 Disable options when force proxy is enabled 2018-02-20 02:16:15 -05:00
vit9696
dac2ab5409
Fix compilation with Qt 5.11 on macOS 2018-02-19 22:39:25 +03:00
Luís Pereira
ea1b0b26b1 Don't implicitly cast iterator to const_iterator 
It prevents detachments:
To illustrate:

QMap<QString, QString> map;
/* code compiles and works fine but find() returns the non-const
   QMap::iterator that detaches!
*/
QMap<QString, QString>::const_iterator it = map.find("girish");

but also some subtle bugs:

QHash<int, int> wrong;
if (wrong.find(1) == wrong.cend()) {
    qDebug() << "Not found";
} else {
    /* find() detached the container before cend() was called, so it
       prints "Found"
    */
    qDebug() << "Found";
}

QHash<int, int> right;
if (right.constFind(1) == right.cend()) {
    qDebug() << "Not found"; // This is correct now !
} else {
    qDebug() << "Found";
}

Enforced by QT_STRICT_ITERATORS definition.
 2018-02-17 17:02:52 +00:00
Vladimir Golovnev
98a1c111b9
Merge pull request #5287 from elFarto/master 
Implement RSS Smart Filter
 2018-02-16 13:43:38 +03:00
Mike Tzou
47048d8410
Merge pull request #8349 from Chocobo1/stats 
Improve stats dialog
 2018-02-16 15:31:01 +08:00
Mike Tzou
882fa7ecd4
Merge pull request #8336 from Chocobo1/coalesce 
Add "Coalesce reads & writes" checkbox in advanced options
 2018-02-16 15:30:17 +08:00
Vladimir Golovnev
d07ece53e6
Merge pull request #7610 from glassez/webapi2 
Redesign Web API
 2018-02-16 10:09:35 +03:00
Vladimir Golovnev
afd2f6ba14
Merge pull request #8344 from FranciscoPombal/master 
Fixed typo in function name isSplashScreenDisabled()
 2018-02-16 09:55:37 +03:00
Luís Pereira
44e4b5d238 Don't use qDeleteAll() on temporaries 
qDeleteAll() is being used on an unnecessary temporary container created
by QHash::values().
Using qDeleteAll(mycontainer) instead.
 2018-02-12 16:36:03 +00:00
thalieht
f50b4724a6 Expose the libtorrent fields for "dont_count_slow_torrents" to GUI: 
inactive_down_rate
inactive_up_rate
auto_manage_startup
 2018-02-08 14:14:39 +02:00
Stephen Dawkins
48cbccff1e Made smart episode filter regular expression configurable 2018-02-05 19:23:11 +00:00
Chocobo1
e31ec20ec4
Clarify some terms in stats dialog 
Reorder list
 2018-02-02 23:41:42 +08:00
Chocobo1
b9ec216aa5
Redefine CacheStatus.readRatio field. 
Now it is defined as:
CacheStatus.readRatio = (blocks read from cache) / (blocks read from disk + blocks read from cache)
The 2 variables in denominator are counted separately and the formula before this change doesn't really make sense

Add percentage sign to "Read cache hits" stats
Also remove redundant header include
 2018-02-02 23:41:42 +08:00
FranciscoPombal
2ac3004762 Fixed typo in function name isSplashScreenDisabled() 2018-01-31 12:05:41 +00:00
Chocobo1
543cbc6d1c
Add "Coalesce reads & writes" checkbox in advanced options 
The setting is defaulted to ON for Windows. Closes #8295.
 2018-01-30 22:46:14 +08:00
Vladimir Golovnev (Glassez)
27d8dbf13b
Redesign Web API 
Normalize Web API method names.
Allow to use alternative Web UI.
Switch Web API version to standard form (i.e. "2.0").
Improve Web UI translation code.
Retranslate changed files.
Add Web API for RSS subsystem.
 2018-01-28 19:16:24 +03:00
sledgehammer999
e487b31877
Merge pull request #8319 from sledgehammer999/saner_log_settings 
Set default file log size to 65 KiB and delete backup logs older than…
 2018-01-27 15:26:03 +02:00
Stephen Dawkins
2845a791d0 Initial implementation of Smart Filter feature 2018-01-27 09:14:36 +00:00
sledgehammer999
024df8c53f
Set default file log size to 65 KiB and delete backup logs older than 1 month. 2018-01-27 01:17:50 +02:00
Vladimir Golovnev (Glassez)
69df8174b9
Allow to load TorrentInfo from data buffer 2018-01-23 11:08:32 +03:00
Vladimir Golovnev
0a45fc9ffe
Merge pull request #7990 from Piccirello/subnet-whitelist-refactor 
Refactor ip subnet whitelist
 2018-01-23 10:03:00 +03:00
sledgehammer999
53cc8e1115
Revert "Remove examples from gpl.html. Closes #7749." 
The GPL folks are a bit overzealous. See https://www.gnu.org/licenses/gpl-faq.html#GPLOmitPreamble

This reverts commit 5cf4f00824.
 2018-01-18 16:25:38 +02:00
Tom Piccirello
e6a1b72354 Only add search separators as needed 2018-01-16 00:22:51 -05:00
Mike Tzou
e48b97466c
Merge pull request #8199 from winneon/reannounce 
transferlist: added a force reannounce option
 2018-01-10 18:48:41 +08:00
Chocobo1
5c50dba9e1
Torrent creator: raise maximum piece size to 32 MiB 2018-01-09 13:04:44 +08:00
Chocobo1
fb698896c9
Fix translation context. 
Partially addresses #8220.

Also sort include headers
 2018-01-07 23:01:22 +08:00
sledgehammer999
95c32221a2
Update copyright year. 2018-01-06 02:23:09 +02:00
Chocobo1
1d778676cd
Fix translation context. Closes #8211. 2018-01-05 12:07:50 +08:00
Jesse Bryan
e887b3106f transferlist: added a force reannounce option. closes #6448. 2018-01-03 16:48:31 -06:00
Mike Tzou
a73c4d57b1
Merge pull request #8136 from Chocobo1/pri 
Sort filename lists in .pri files
 2018-01-03 23:53:50 +08:00
sledgehammer999
13f69a2245
Fix constant status of '[F] Downloading'. Closes #7628. 2018-01-02 18:09:48 +02:00
Chocobo1
ec337a8a84
Sort filename lists in .pri files 2017-12-31 11:53:45 +08:00
Mike Tzou
267362a7a0
Merge pull request #7876 from Chocobo1/optionIcons 
Fix gui issues on high DPI monitor
 2017-12-31 11:42:55 +08:00
Thomas Piccirello
ddd6c82dd7 Use https for www.qbittorrent.org 2017-12-26 18:22:03 -05:00
Chocobo1
c2c0dd2717
Fix column size too narrow on resize 
Instead of giving a value, just resize to the content size
 2017-12-24 21:54:56 +08:00
Chocobo1
27cf98a962
Resize dialog size on high DPI monitors 2017-12-24 21:54:56 +08:00
Chocobo1
aaaa67050c
Fix gui issues on high DPI monitor 
Fix LineEdit widget size issues
Up-scale the icons on statusbar
Up-scale the icons in options dialog. Closes #7729.
Fix small icons in cookie manager
Fix progress bar height
Fix small icons in confirm delete dialog
Fix small icons in options dialog
Fix small images in about dialog
 2017-12-24 21:47:46 +08:00
Chocobo1
52ae118e3c
Tweak spacing 2017-12-24 21:47:46 +08:00
Chocobo1
cb929f7e59
Cleanup 
Use Qt5 connect syntax
Reorder include headers
 2017-12-24 21:47:44 +08:00
sledgehammer999
0a35adbdba
Merge pull request #8087 from sledgehammer999/fix_flag_sorting 
Fix sorting of country flags column in Peers tab.
 2017-12-23 19:15:44 +02:00
sledgehammer999
38d68d9d97
Merge pull request #8103 from glassez/fix-8094 
Fix RSS rule updated when deleting. Closes #8094
 2017-12-23 19:09:59 +02:00
sledgehammer999
8494c6c5d4
Merge pull request #8003 from Chocobo1/fileicon 
Use standard folder icon for open file behavior on Windows
 2017-12-23 19:09:05 +02:00
sledgehammer999
cbfdb7df56
Merge pull request #8033 from vit9696/cmdw 
Fix CMD+W not closing the main window
 2017-12-23 19:07:51 +02:00
sledgehammer999
ea44923cce
Merge pull request #8032 from vit9696/fopen 
Fix torrent file selection in Finder on mac
 2017-12-23 19:03:33 +02:00
Vladimir Golovnev (Glassez)
e75f8603b0
Fix RSS rule updated when deleting 
Closes #8094
 2017-12-23 16:25:09 +03:00
sledgehammer999
99abc21dab
Simplify sorting code. 2017-12-21 15:26:38 +02:00
sledgehammer999
5156399c68
Fix sorting of country flags column in Peers tab. 2017-12-21 15:21:53 +02:00
Mike Tzou
c8a5ef8c5d
Merge pull request #7985 from Chocobo1/source 
Add source field in Torrent creator
 2017-12-21 20:26:38 +08:00
vit9696
ed154d35ba Fix Finder reveal in preview and torrent contents 2017-12-17 02:16:36 +03:00
vit9696
ff7e5da6de Fix cmd+w not closing the main window on macOS 2017-12-13 13:30:40 +03:00
vit9696
d7fa5b6b6b Put macOS specific functions to MacUtils namespace 2017-12-12 20:53:20 +03:00
vit9696
d57bd62add Fix torrent file selection in Finder on mac 2017-12-12 20:53:20 +03:00
Chocobo1
8dcf326576
Add source field in Torrent creator. Closes #7965. 
This field is often used for cross-seeding between (private) trackers.
 2017-12-09 00:39:50 +08:00
Chocobo1
c5d99a12f3
Use standard folder icon for open file behavior on Windows. Closes #7880. 2017-12-08 09:15:44 +08:00
Thomas Piccirello
d184bd8c82 Perform ip string validation inside setWebUiAuthSubnetWhitelist 2017-12-06 02:05:33 -05:00
Thomas Piccirello
98a2dedb32 Separate subnet whitelist options into two lines 2017-12-06 02:05:32 -05:00
Chocobo1
c405cb2f1c
Add struct TorrentCreatorParams for passing parameters 
Filter out continuous newlines in Trackers field
Avoid adding empty url seed entries

Cleanup:
  Replace boost::bind
  Add const
  Use nullptr
  Use QString::SkipEmptyParts
  Rename variables
  Throw proper exception type
 2017-12-06 01:56:36 +08:00
sledgehammer999
5ea100352e
Merge pull request #7958 from Chocobo1/fixsort 
Fix crash in #7952
 2017-12-04 22:58:22 +02:00
Chocobo1
86c5a8df75
Partial revert eac8838dc2. Fixes #7952. 
mapFromSource() didn't work as expected, when used in lessThan(), it sometimes
returns an invalid QModelIndex.
A crash is observed when filtering source model via filterAcceptsRow() in #7952,
the crash is due to endless recursive of filterAcceptsRow() & lessThan() calling
each other and mapFromSource() is the culprit of it.
 2017-12-04 17:40:44 +08:00
sledgehammer999
c9720cad81
Merge pull request #7915 from Chocobo1/dragndrop 
Allow to drag-n-drop URLs into mainwindow to initiate download
 2017-12-02 20:35:47 +02:00
Mike Tzou
eac8838dc2
[GUI] Implement stable sort (#7703) 
* NaturalCompare now returns compare result instead of "less than" result
* Change to stable sort in GUI components
* Add Utils::String::naturalLessThan() helper function
* Use Qt::CaseSensitivity type
 2017-11-30 17:10:30 +08:00
Mike Tzou
74d281526b
Merge pull request #7647 from thalieht/style 
Coding style for many files
 2017-11-30 17:09:18 +08:00
Chocobo1
b9339bb727
Allow to drag-n-drop URLs into mainwindow to initiate download 
Fix issue: https://github.com/qbittorrent/qBittorrent/issues/7785#issuecomment-347092418
Minor refactor
 2017-11-27 16:45:55 +08:00
Vladimir Golovnev
a7da714b13
Merge pull request #7832 from glassez/rss-import 
Implement Import/Export RSS rules. Closes #7721
 2017-11-25 10:35:24 +03:00
Vladimir Golovnev (Glassez)
916cfcdb03
Implement Import/Export RSS rules in JSON format 2017-11-24 21:20:44 +03:00
Vladimir Golovnev (Glassez)
b8fc415870
Implement Import/Export RSS rules in legacy format 2017-11-24 16:19:16 +03:00
sledgehammer999
99341409f4
Remove examples from gpl.html. Closes #7749. 2017-11-24 02:03:29 +02:00
sledgehammer999
a38730eb9e
Merge pull request #7792 from Chocobo1/creator2 
Fix crash when aborting a torrent creation process
 2017-11-22 00:41:26 +02:00
sledgehammer999
1a9e650936
Merge pull request #7782 from Chocobo1/utf8 
Remove superfluous QString::fromUtf8()
 2017-11-22 00:40:51 +02:00
Chocobo1
27090f0cfb
Remove superfluous QString::fromUtf8() 2017-11-21 22:48:00 +08:00
Chocobo1
c3de2310c5
Avoid double delete on close 2017-11-21 18:11:28 +08:00
Chocobo1
b9478e0f00
Use Qt5 connect syntax 2017-11-21 18:11:28 +08:00
Chocobo1
94aeac992c
Allow drag-n-drop magnet links to mainwindow. Closes #7742. 2017-11-21 14:19:34 +08:00
thalieht
ae1634623e Coding style for many files 2017-11-20 23:29:59 +02:00
Vladimir Golovnev
f41cb8089d
Merge pull request #6779 from Piccirello/disable-web-auth 
Add ip subnet whitelist for bypassing webui auth
 2017-11-20 21:52:33 +03:00
sledgehammer999
9db1f3baca
Merge pull request #6484 from sledgehammer999/new_logo 
Change qbittorrent logo. Issue #6467.
 2017-11-19 19:15:50 +02:00
Eugene Shalygin
08755a211b
Merge pull request #7596 from evsh/path-history-items 
Add option to tune download history list length. Closes #4043.
 2017-11-10 12:23:40 +01:00
Thomas Piccirello
0de2f1776e Remove duplicate header 2017-11-08 22:39:49 -05:00
Thomas Piccirello
da0db92b9f Enable preferences Apply button when ip banlist is modified 2017-11-08 22:39:49 -05:00
Thomas Piccirello
95bf63330e Add ip subnet whitelist for bypassing webui auth 2017-11-08 22:39:49 -05:00
sledgehammer999
3a5c0d9818
Allow to specify if announcing to all tiers is desired. 2017-10-30 23:27:28 +02:00
sledgehammer999
2194a05e60
Merge pull request #7652 from Chocobo1/aboutExtLink 
Open links in browser. Closes #7651.
 2017-10-30 18:06:34 +02:00
sledgehammer999
09cb95d3da
Use the SVG for the tray icon. 2017-10-30 02:41:23 +02:00
sledgehammer999
5157fc201c
Add Turkish translator in about page. 2017-10-30 00:32:44 +02:00
Chocobo1
492ea5bceb
Open links in browser. Closes #7651. 2017-10-28 14:51:20 +08:00
Chocobo1
fc0628d35b
Allow SMTP sender to be set. Closes #7575. 2017-10-26 17:57:32 +08:00
Eugene Shalygin
1fed324f91 Add option to tune download history list length. Closes #4043. 2017-10-24 12:56:05 +02:00
Eugene Shalygin
e4771ba508 Add maxVisibleItems combo box property to FileSystemPathComboEdit. 2017-10-24 12:56:04 +02:00
sledgehammer999
2956b28a32
Mention more translators in the about page after their request. 2017-10-24 03:32:57 +03:00
sledgehammer999
50471ec8c8
String fixes and optimizations mentioned by translators on Transifex. 2017-10-24 03:32:56 +03:00
sledgehammer999
52df71ad3a
Use svg icons for the country flags. 
Closes #6223.
 2017-10-23 01:23:45 +03:00
Mike Tzou
9600e7f5ad Merge pull request #7573 from fmatthew5876/config_webui_ip 
Add WebUi\Address config option
 2017-10-22 14:18:08 +08:00
Matthew Fioravante
8cd243b06b Add WebUi\Address config option 2017-10-21 09:32:30 -04:00
Vladimir Golovnev
c72fb92318 Merge pull request #7529 from dzmat/speedwidget_qtconcurrent_removal 
Excess QtConcurrent usage removal
 2017-10-20 10:32:27 +03:00
scootergrisen
8400d855de Add me for danish 2017-10-16 22:14:10 +02:00
dzmat
9d0ab0ae5f speedwidget class: excess QtConcurent usage removal 2017-10-12 20:59:13 +07:00
Eugene Shalygin
7a652c0a8c Merge pull request #7566 from evsh/themes-cbc 
Themes part 1
 2017-10-11 10:34:56 +02:00
Eugene Shalygin
db35bb54e1 Make BitTorrent::TorrentState strongly-typed enum 
This is needed to forward declare this type and pass it by value.

Conversion from/to QVariant are hanled via Q_DECLARE_METATYPE, while
TorrentState::toString() function was used in webui only and as such is
moved there.
 2017-10-10 21:28:57 +02:00
Tim Delaney
19bb6f5fe0 Follow project coding style. Issue #2192. 
--HG--
branch : magao-dev
 2017-10-10 21:28:56 +02:00
Chocobo1
aab752dd2e
Fix delete key has no effect due to "Ambiguous shortcut overload" 
We want to show the accelerator key in the menu but without hitting
the ambiguous overload error.
Fixup of 1378245a63
 2017-10-10 14:43:05 +08:00
sledgehammer999
16ac20b594
Remove unused image. Possibly leftover from dropping Qt4. 2017-10-09 18:15:39 +03:00
sledgehammer999
d93d0ab19e
Show new paths in native form. 2017-10-09 17:42:42 +03:00
Vladimir Golovnev
083bc71315 Merge pull request #7396 from thalieht/updownratio 
Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg
 2017-10-08 21:06:55 +03:00
thalieht
525fdd6c2b Coding style, use nullptr and other minor things 2017-10-08 10:20:54 +03:00
thalieht
f27e75e8fa Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg dialogs. Fixes #7352 2017-10-08 10:20:38 +03:00
Mike Tzou
7895afb8e9 Merge pull request #7542 from Chocobo1/wordbreak 
Set QTextOption::NoWrap property in "Download from URLs" dialog
 2017-10-07 13:40:41 +08:00
Mike Tzou
2626378dfd Merge pull request #7545 from Kolcha/del-shortcut 
added keyboard shortcut to delete torrent. closes #7508
 2017-10-07 13:38:05 +08:00
Nick Korotysh
1378245a63
show delete accelerator key in menu. closes #7508 2017-10-06 14:51:19 +03:00
Chocobo1
b3207b8144
Set QTextOption::NoWrap property in "Download from URLs" dialog 
This makes it easier to put each magnet link on its own line
 2017-10-03 22:45:18 +08:00
Nick Korotysh
4c8dd0ca9d allow search plugins sorting. closes #7526 2017-10-03 16:57:09 +03:00
Vladimir Golovnev
c5607f07c8 Merge pull request #7514 from dzmat/members_names_clarification 
members names clarification
 2017-09-30 09:36:24 +03:00
Mike Tzou
49802be7d4 Merge pull request #7499 from Chocobo1/fixTimeActive 
Fix "Time active" field in transfer list
 2017-09-30 11:36:57 +08:00
dzmat
3d932b1cce transferlistwidget class members names clarification 2017-09-29 19:55:30 +07:00
Vladimir Golovnev
66a6674cbc Merge pull request #7490 from glassez/category-path 
Allow to set explicit save path for Category from GUI
 2017-09-29 14:25:40 +03:00
Chocobo1
2d12c126eb
Fix "Time active" field in transfer list 
The "Time active" field was broken, displaying nothing when in
downloading state.
Also change type to int to match the return
types of TorrentHandle::activeTime() & TorrentHandle::seedingTime()
 2017-09-28 16:54:46 +08:00
Vladimir Golovnev (Glassez)
3ec992474d
Implement TorrentCategoryDialog class 2017-09-27 21:25:22 +03:00
Mike Tzou
15babe97ea Merge pull request #7500 from Chocobo1/mergeName 
Show torrent name in "add new torrent" dialog on merging trackers
 2017-09-27 21:04:51 +08:00
Mike Tzou
308fd3dcac Merge pull request #7477 from silverqx/options-dlg-persist-size 
Center Options dialog when showed
 2017-09-27 20:35:04 +08:00
Mike Tzou
e8250104c8 Merge pull request #7429 from silverqx/preview-modal-ux 
Improved ux in preview dialog
 2017-09-27 20:33:31 +08:00
Mike Tzou
796cd674d7 Merge pull request #7495 from silverqx/options-save-state-cancel 
Options dialog save windows state in destructor
 2017-09-26 15:30:17 +08:00
Mike Tzou
1fe9272a8f Merge pull request #7480 from Chocobo1/lastAct 
Fix last activity calculation
 2017-09-26 15:17:35 +08:00
sledgehammer999
c285de87d4
Don't use margins in FileSystemPathEdit widgets. 
Introduced in 30081e0.
 2017-09-26 04:06:32 +03:00
Chocobo1
058062d586
Show torrent name in "add new torrent" dialog on merging trackers 2017-09-26 01:34:24 +08:00
silver
3b4fd35dde
Persist size and treeview header state in preview dialog 
- renamed variable m_headerState
 - renamed PreviewSelect class to PreviewSelectDialog
 - renamed previewselect files to previewselectdialog
 2017-09-25 16:33:17 +02:00
silver
2a6bd5de35
Options dialog save windows state in destructor 2017-09-24 22:56:14 +02:00
silver
64e539fcfb
Center Options dialog when showed 2017-09-24 19:40:48 +02:00
Chocobo1
62493c672d
Fix last activity calculation. Closes #7461 
`time_since_upload` & `time_since_download` can be -1, so filter them out
 2017-09-24 21:06:34 +08:00
Vladimir Golovnev (Glassez)
8c58a69be6
Use Qt5 connect() style in CategoryFilterWidget 2017-09-24 16:01:39 +03:00
Mike Tzou
83c6b22d30 Merge pull request #7454 from Chocobo1/buttonbox 
Replace dialog ok-cancel buttons with QDialogButtonBox
 2017-09-21 22:45:45 +08:00
sledgehammer999
b9e233601d Merge pull request #7446 from Chocobo1/utpOnly 
Add uTP only mode option
 2017-09-19 01:45:58 +03:00
Chocobo1
45a0c5558a
Add comboBox for selecting BitTorrent protocol. Closes #6316. 
Use unicode string C_UTP in place of "uTP"
 2017-09-18 01:52:57 +08:00
Chocobo1
7059b947e8
Replace dialog ok-cancel buttons with QDialogButtonBox 
This PR will make button order follow the platform default.
For example: windows use: OK, Cancel; linux use: Cancel, OK.
 2017-09-15 18:52:21 +08:00
Chocobo1
a341b793e4
Rename option 
The previous "Disk write cache size" is not accurate since it is also being used
for read cache, so rename it to "Disk cache".
 2017-09-14 20:32:10 +08:00
Eugene Shalygin
4ec193042f Allow custom tray icons when system icon theme is used. Closes #7403. 2017-09-11 16:18:10 +02:00
sledgehammer999
7b5730723d
Fix file list expansion on singlefile torrent with folder. 2017-09-06 01:11:49 +03:00
Vladimir Golovnev
c6dfdf9135 Fix CategoryFilterWidget::sizeHint() 2017-09-01 16:11:21 +03:00
Chocobo1
64d5e329c0
Sort the resource lists 
Update RCC header
 2017-08-29 13:39:02 +08:00
Chocobo1
551ffb88ab
Define QT_USE_QSTRINGBUILDER. 
The old defines are deprecated.
QT_USE_QSTRINGBUILDER also supports QByteArray which we use extensively
in WebUI.
 2017-08-29 13:37:29 +08:00
Chocobo1
ccd3b305c2
Use Qt5 connect syntax 2017-08-24 20:15:25 +08:00
Chocobo1
b47c90f0e0
Setup parent ownership to avoid memory leak 2017-08-24 20:01:39 +08:00
Mike Tzou
1afd5f70dd Merge pull request #3235 from Chocobo1/session_option 
libtorrent session options
 2017-08-24 11:35:15 +08:00
Vladimir Golovnev
f2af308e6d Fix RSS Downloader fails to rename rule 
Closes #7333.
 2017-08-23 16:45:14 +03:00
Vladimir Golovnev
a6868e2b25 Merge pull request #7313 from glassez/sched 
Don't disable scheduler when manually switching speed limits. Closes #7306
 2017-08-23 17:05:28 +04:00
Vladimir Golovnev (qlassez)
93f5d4058d
Improve BandwidthScheduler 
Don't disable scheduler when manually switching speed limits.
Closes #7306.
 2017-08-23 09:48:31 +03:00
Evengard
ea7c1ace2a Disable skipping of loopback interfaces 
This fixes the absence of VPN tunnel interfaces under Windows and works around the QTBUG-32349
Fixes #7291
 2017-08-22 00:00:20 +03:00
Chocobo1
2da2054ccf
Use enums for settings 2017-08-21 20:30:26 +08:00
Chocobo1
f4be165767
Add send_buffer_watermark send_buffer_low_watermark 
send_buffer_watermark_factor knobs
 2017-08-21 16:50:14 +08:00
Chocobo1
55a1628a5e
Add suggest_mode knob 2017-08-21 16:50:14 +08:00
Chocobo1
6c32f6beff
Add choking_algorithm & seed_choking_algorithm knob 2017-08-21 16:49:45 +08:00
Chocobo1
21ec8fe53f
Add allow_multiple_connections_per_ip knob. Closes #5884. 2017-08-21 16:48:38 +08:00
Chocobo1
4185209036
Add mixed_mode_algorithm knob 2017-08-21 16:48:38 +08:00
Chocobo1
6150e0c56b
Add guided_read_cache knob 
cleanup header include order
 2017-08-21 16:48:37 +08:00
sledgehammer999
b649d61e8b
Options to better memory control by libtorrent. Closes #7029. 2017-08-18 20:21:37 +03:00
Eugene Shalygin
3331526865 Use pixmap cache for file icons on Mac OS and Windows. Closes #7264. 2017-08-15 22:25:03 +02:00
vit9696
eb8ff91c5d Fix notification display on macOS 2017-08-15 21:16:37 +03:00
sledgehammer999
f98edcab5c Merge pull request #7272 from vit9696/patch-1 
Fix macOS window restoration after using hide icon
 2017-08-15 21:13:58 +03:00
sledgehammer999
e5ea3bd707 Merge pull request #7253 from briankendall/fix_objc_errors 
Fixed mac specific compiler errors and cleaned up Objective C code. Closes #7252
 2017-08-15 21:06:09 +03:00
sledgehammer999
c87c1d2359
Use simpler ifdef style. 2017-08-15 21:01:55 +03:00
sledgehammer999
25eb2edb86 Merge pull request #7273 from vit9696/borders 
Unify preference window borders across the tabs
 2017-08-15 18:14:11 +03:00