303 commits

Author	SHA1	Message	Date
Mike Tzou	46bc1d12b9	Merge pull request #10314 from thalieht/const2 ... More const	2019-02-28 11:33:35 +08:00
thalieht	89dce36e98	Use uniform initialization on some default arguments	2019-02-25 17:05:15 +02:00
Chocobo1	e5dca50025	Convert to use private pointer for ui object	2019-02-25 01:22:40 +08:00
Chocobo1	5e3fddf456	Replace QScopedPointer with std::unqiue_ptr ... These 2 types are very similar and we should prefer the one from C++ standard library, this reduces the number of types in our code base. Also see: https://stackoverflow.com/questions/40346393/should-i-use-qscopedpointer-or-stdunique-ptr#comment67966940_40346991	2019-02-18 16:06:40 +08:00
thalieht	9959a901fe	Replace deprecated header 'signal.h' with 'csignal'	2019-02-16 18:54:17 +02:00
thalieht	d8cbc9266a	Use 'auto' to avoid duplicating the type name	2019-02-16 18:54:17 +02:00
thalieht	8a3f942385	Don't use 'else' after return/break	2019-02-13 18:23:25 +02:00
Mike Tzou	78ab0e4ba9	Merge pull request #10220 from thalieht/const ... Add const to many vars and arguments	2019-02-13 12:11:00 +08:00
thalieht	ca3ce87e06	Add const to many vars and arguments ... Also remove const in declarations' arguments that are passed by value	2019-02-11 20:19:41 +02:00
Chocobo1	52de31ac79	Add migration code for WebUI https related change	2019-01-29 12:52:42 +08:00
Chocobo1	48d358872f	Cleanup header inclusion	2019-01-28 14:34:13 +08:00
Chocobo1	04227f5a41	Add QBT_APP_64BIT define ... Now we use QT_POINTER_SIZE to detect CPU bitness, it has the advantage of applicable to all CPU architectures not limiting to x86 arch.	2019-01-19 10:14:10 +08:00
Chocobo1	6d7e5f82ae	Include the correct header ... And remove the unused ones	2019-01-19 10:06:33 +08:00
Chocobo1	cf4db1b418	Remove useless exception handling	2019-01-19 10:06:31 +08:00
sledgehammer999	6b2a382ab8	Merge pull request #10066 from sledgehammer999/drop_migration_code ... Drop upgrade code	2019-01-02 21:42:31 +02:00
sledgehammer999	d322e10a83	Merge pull request #10027 from glassez/compile-ts ... Compile translations at build time	2018-12-31 11:31:45 +02:00
sledgehammer999	1fff760722	Drop upgrade code	2018-12-31 00:41:17 +02:00
Chocobo1	2a84345835	Mark constructors as explicit	2018-12-26 12:04:40 +08:00
Vladimir Golovnev (Glassez)	7b3eed323b	QMake: Compile translations at build time	2018-12-22 16:02:17 +03:00
Vladimir Golovnev	fc08091765	Merge pull request #9940 from glassez/error-msg ... Show error message when Session failed to start	2018-12-09 11:16:17 +03:00
Chocobo1	f13bcbd772	Add OpenSSL version to GUI & stackdump	2018-12-08 12:46:50 +08:00
Mike Tzou	6bb4eb825b	Merge pull request #9942 from Chocobo1/pbkdf2 ... Do password hashing properly	2018-12-06 16:22:22 +08:00
Vladimir Golovnev (Glassez)	89deccd9b5	Show error message when Session failed to start	2018-12-05 19:57:44 +03:00
Chocobo1	593052dd93	Revise startup message in nox version ... Only print the WebUI username when password is still the default.	2018-12-05 13:28:43 +08:00
Chocobo1	05d6a29416	Apply PBKDF2 when storing passwords	2018-12-05 13:28:42 +08:00
thalieht	1f36b8b89f	Combine qAsConst() with copyAsConst() to asConst()	2018-11-28 23:41:23 +02:00
thalieht	6b1d26d555	Convert all foreach() to range-based for()	2018-11-28 23:40:12 +02:00
thalieht	d668a4fe6d	Fix coding style for various things	2018-11-28 23:37:35 +02:00
Thomas Piccirello	4885fe6b4c	Only instantiate SearchPluginManager as needed	2018-11-21 16:59:38 -05:00
Vladimir Golovnev	7e36cc746f	Merge pull request #8584 from Piccirello/new-search-api-2 ... WebUI search API. Closes #2495	2018-10-24 13:13:16 +03:00
Eugene Shalygin	e590fff2fe	cmake: restore out-of-source build ... Qt translations have to be compiled in a shared library or executable, and since we use static libraries for the components, webui translation files have to be compiled into the main executable.	2018-10-14 11:06:20 +02:00
Chocobo1	79dae55a61	Fix GUI scaling issue on Linux ... It seems `QT_AUTO_SCREEN_SCALE_FACTOR` doesn't work as expected. Closes #6935.	2018-09-05 12:17:30 +08:00
Chocobo1	0217d5b4c0	Replace single-character string with character literal ... Also remove unnecessary dynamic allocation.	2018-07-21 23:26:15 +08:00
Thomas Piccirello	b2ffd6e03b	Instantiate SearchPluginManager with other application components	2018-07-11 20:11:33 -04:00
sledgehammer999	de8050701d	Revert email address changes in copyright notices	2018-07-10 00:37:44 +03:00
thalieht	456270bbb1	Delete several unused #include	2018-07-03 08:38:32 +03:00
Mike Tzou	40f4223d02	Merge pull request #9083 from Chocobo1/qrc ... Move files to where it belongs	2018-06-18 00:51:19 +08:00
thalieht	d34ddb2e3c	Change file names and classes names to match them	2018-06-15 20:12:59 +03:00
thalieht	4022799881	Fix coding style	2018-06-12 07:17:05 +03:00
Chocobo1	5b7c089dd2	Move qm_gen.pri	2018-06-11 21:02:45 +08:00
Chocobo1	26a4703398	Move .qrc files into its own directory	2018-06-11 20:01:33 +08:00
Eugene Shalygin	04aea413ba	Merge pull request #9055 from zeule/cmake ... Update CMake build scripts	2018-06-07 21:31:09 +02:00
Eugene Shalygin	fa770871e9	Refactor CMake build scripts ... 1. Use FeatureSummary module to show configuration results. 2. Invert option()/find_package() relationship: instead of calling find_package(... REQUIRED) when option is set, rely on optional find package call and PackageName_FOUND variable. 3. Refactor handling options that result in simple preprocessor defines (actually copy the snippet from libtorrent) so that everything is done in a single function call. 4. Populate target properties in order to get rid of include_directories() calls.	2018-06-05 11:39:11 +02:00
Vladimir Golovnev	e61c882fee	Merge pull request #9015 from thalieht/style ... Fix coding style	2018-06-03 14:48:04 +03:00
thalieht	356d6a6589	Fix coding style	2018-05-31 19:45:09 +03:00
Chocobo1	09f759355f	Replace QRegExp with QRegularExpression ... Revise `static` keyword usage, static is added to frequently used instances.	2018-05-31 22:56:49 +08:00
Chocobo1	c22e6b4502	Cleanup header include order ... Add missing header. Cleanup license.	2018-05-31 22:56:25 +08:00
Chocobo1	4751b79f42	Initialize variables properly ... The warnings are emitted when compiling on msys2, mingw The warning was: gui/torrentcontentmodel.cpp:135:33: warning: missing initializer for member '_SHFILEINFOW::iIcon' [-Wmissing-field-initializers] ..\..\qBittorrent\src\app\stacktrace_win.h:141:30: warning: missing initializer for member '_IMAGEHLP_LINE64::Key' [-Wmissing-field-initializers]	2018-05-25 21:22:31 +08:00
Mike Tzou	84df2794dc	Merge pull request #8944 from Chocobo1/literal ... Make use of QStringLiteral	2018-05-23 13:23:41 +08:00
Mike Tzou	07c15127ba	Merge pull request #8915 from Chocobo1/runext4 ... Improve "Run External Program" behavior	2018-05-19 14:58:45 +08:00
Chocobo1	ceaf755ac6	Make use of QStringLiteral ... Only changed instances that are initialized at program start.	2018-05-18 02:14:49 +08:00
sledgehammer999	e3ce9b2645	Merge pull request #8903 from sledgehammer999/fix_upgrade_artifacts ... Delete non-commited fastresume files	2018-05-13 17:24:47 +03:00
sledgehammer999	35eee0b590	Don't migrate torrents that have newer fastresumes	2018-05-13 15:50:10 +03:00
sledgehammer999	7626ebe7a6	Delete non-commited fastresume files ... Old v3.3.x format had a number at the end indicating the queue position. The naming scheme was '<infohash>.fastresume.<queueposition>'. However, QSaveFile, which uses QTemporaryFile internally, might leave non-commited files behind eg after a crash. These files have the naming scheme '<infohash>.fastresume.XXXXXX' where each X is a random character. We try to detect the latter and remove it without "migrating" the fastresume to the new saving system.	2018-05-13 15:50:10 +03:00
sledgehammer999	bde736c18a	Merge pull request #8900 from sledgehammer999/fix_delete_logs ... Fix deletion of old logs	2018-05-13 15:00:39 +03:00
sledgehammer999	7484889836	Fix deletion of old logs	2018-05-13 12:11:19 +03:00
Chocobo1	263524e856	Improve "Run External Program" behavior ... This follows utorrent behavior: they don't append backslash character at the end of path variables. Closes #8836.	2018-05-13 15:21:27 +08:00
thalieht	4cfa163bbd	Use qt5 syntax for a few remaining SLOT()	2018-05-11 08:19:41 +03:00
thalieht	6b4455e13d	Use qt5 connect() syntax	2018-05-09 16:08:22 +03:00
Nick Korotysh	0b8c620fd3	Add missing "override"	2018-05-08 08:33:07 +03:00
Nick Korotysh	7712d0ada0	Allow to disable Stacktrace support ... Enable backtrace stuff only if GNU C library used, because current backtrace implementation based on <execinfo.h> , which is not a part of standard C library, it is a GNU extension. This will be usefull when building with custom POSIX-compilant C library (like musl) and no <execinfo.h> available. Note: configure script will detect presence of <execinfo.h> and enable/disable feature depending on it. Feature is enabled by default.	2018-04-10 20:51:11 +03:00
Chocobo1	b0e3d77975	Add helper for loading Windows system functions	2018-04-09 21:18:04 +08:00
Mike Tzou	e4fc8e4156	Merge pull request #8669 from Chocobo1/runext ... Split args manually in runExternalProgram()	2018-04-03 22:19:29 +08:00
Chocobo1	c07cd440cd	Split args manually in runExternalProgram() ... Need to split arguments manually because QProcess::startDetached(QString) will strip off empty parameters. E.g. `python.exe "1" "" "3"` will become `python.exe "1" "3"`. Closes #8454.	2018-04-01 18:42:42 +08:00
Chocobo1	37ea01bd44	Use lightweight printf instead of iostream ... Using iostream usually adds a lot of other operators (<<, endl), whereas *printf takes only 1 function call. Also use qUtf8Printable whenever possible.	2018-03-31 03:21:53 +08:00
Vladimir Golovnev	a5294e1e08	Merge pull request #8558 from luis-pereira/containter-anti-pattern ... Don't create temporary containers just to iterate over them	2018-03-19 13:06:01 +03:00
Luís Pereira	ac42ccb5e4	Don't create temporary containers just to iterate over them ... Stops temporary containers being created needlessly due to API misuse. For example, it’s common for developers to assume QHash::values() and QHash::keys() are free and abuse them, failing to realize their implementation internally actually iterates the whole container, allocates memory, and fills a new QList. Added a removeIf generic algorithm, similar to std ones. We can't use std algorithms with Qt dictionaries because Qt iterators have different behavior from the std ones. Found using clazy.	2018-03-18 16:22:12 +03:00
Mike Tzou	68ca95faf0	Merge pull request #8603 from Chocobo1/typo ... Fix typo	2018-03-17 00:49:41 +08:00
Chocobo1	423511765a	Fix typo	2018-03-14 23:37:08 +08:00
Chocobo1	88881de8c6	Add Tags parameter to "Run External Program" ... Closes #8586. Also sort headers.	2018-03-14 10:12:32 +08:00
Chocobo1	0457fd260e	Avoid temporary QString allocations ... This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]	2018-03-07 20:06:00 +08:00
Chocobo1	c60b7b213e	Add missing 'override' specifier ... This fixes clang warning: 'notify' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]	2018-03-07 20:05:52 +08:00
Vladimir Golovnev	7cb6100c9c	Merge pull request #8471 from luis-pereira/use-qstring-ref ... Don't create temporary substrings	2018-02-28 10:44:59 +03:00
Andrei Stepanov	817aadd52d	Fix typo in filelogger.cpp message	2018-02-27 02:00:43 +04:00
Luís Pereira	0e421ae415	Don't create temporary substrings ... Avoid temporary string allocations. They are only used to convert to something else. QString::xxxRef() returns a QStringRef. QStringRef avoids the memory allocation and reference counting overhead of a standard QString by simply referencing a part of the original string.	2018-02-26 11:39:36 +00:00
Luís Pereira	2114817890	Use qEnvironmentVariableIsEmpty ... Instead of qgetenv("QT_AUTO_SCREEN_SCALE_FACTOR").isEmpty(). It's faster (don't allocate memory) and don't throw exceptions.	2018-02-19 21:35:23 +00:00
sledgehammer999	e487b31877	Merge pull request #8319 from sledgehammer999/saner_log_settings ... Set default file log size to 65 KiB and delete backup logs older than…	2018-01-27 15:26:03 +02:00
sledgehammer999	024df8c53f	Set default file log size to 65 KiB and delete backup logs older than 1 month.	2018-01-27 01:17:50 +02:00
Luís Pereira	5154d431f6	Don't set application name twice ... It's an artifact introduced by commit b3c73b7868.	2018-01-25 16:30:11 +00:00
Mike Tzou	11f26bfefd	Merge pull request #7878 from Chocobo1/runExt ... Revert "Run external program" function	2017-12-28 21:26:53 +08:00
Chocobo1	22b0ebb5a8	Disable the "?" help button in all dialogs on Windows. Closes #7365.	2017-12-08 12:51:06 +08:00
Chocobo1	76c95d8c6c	Revert "Run external program" function ... This revert df95efe33e partially	2017-11-25 15:48:29 +08:00
Heiko Becker	af898e9117	Fix build with --disable-webui ... "app/application.cpp:108:7: error: class 'Application' does not have any field named 'm_webui'"	2017-11-23 01:52:38 +02:00
sledgehammer999	81f5fdda15	Correctly check if torrent passed during application start already exists.	2017-11-22 00:42:26 +02:00
Chocobo1	27090f0cfb	Remove superfluous QString::fromUtf8()	2017-11-21 22:48:00 +08:00
sledgehammer999	22add258ae	Merge pull request #7753 from luigino/master ... qtsingleapplication should always be built statically to avoid depend…	2017-11-20 22:31:46 +02:00
luigino	32a686a037	qtsingleapplication should always be built statically to avoid dependency problems	2017-11-20 17:23:22 +01:00
sledgehammer999	236abcf3f1	Fix crash on opening torrent/magnet (uninitialized pointer). Closes #7739 #7723.	2017-11-20 17:46:31 +02:00
sledgehammer999	af5a02d971	Merge pull request #7673 from sledgehammer999/webui_clean_exit ... WebUI: Correctly exit depending if mainloop is running.	2017-11-19 19:12:30 +02:00
Vladimir Golovnev (Glassez)	71bb6538db	Fix WebUI error handling	2017-11-19 19:10:04 +02:00
Mike Tzou	04cec39277	Merge pull request #7667 from Chocobo1/stackdump ... Include & print caught signal in stackdump	2017-11-04 11:10:49 +08:00
Chocobo1	21bc08d643	Include/print caught signal in stackdump	2017-11-03 14:13:17 +08:00
Chocobo1	fc0628d35b	Allow SMTP sender to be set. Closes #7575.	2017-10-26 17:57:32 +08:00
sledgehammer999	50471ec8c8	String fixes and optimizations mentioned by translators on Transifex.	2017-10-24 03:32:56 +03:00
thalieht	0717f0d60c	Save ratio limits as int instead of string	2017-10-08 10:22:40 +03:00
Chocobo1	e3da17caa8	Update qtsingleapplication ... To upstream version a8dda66d7738cde9042b87db27993f710ae3eeeb	2017-09-23 00:27:00 +08:00
Vladimir Golovnev (qlassez)	cff6a64e9f	Use qUtf8Printable() for logging strings ... qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding. Therefore qUtf8Printable() should be used for logging strings instead of qPrintable().	2017-08-13 16:14:57 +03:00
sledgehammer999	08aa827366	Fix some more strings.	2017-08-06 01:47:05 +03:00
Allan Nordhøy	af9c0cca23	display, URLs, esc '	2017-07-28 02:42:35 +02:00
vit9696	d25467d3e6	Various macOS UI improvements	2017-07-15 20:49:40 +03:00