mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-10 09:07:25 +03:00
Code Issues Projects Releases Packages Wiki Activity
10176 commits 16 branches 245 tags 256 MiB
Commit graph

1275 commits

Author SHA1 Message Date
Mike Tzou
7db2d1b8cf
Merge pull request #10492 from Chocobo1/server 
Remove closed connections immediately
 2019-04-16 12:25:40 +08:00
Mike Tzou
c7f89f55d0
Merge pull request #10473 from Chocobo1/warning 
Fix unsafe type narrowing (MSVC C4267 warning)
 2019-04-16 12:23:30 +08:00
Chocobo1
a2a669572c
Use QSet for tracking server connections 
We don't need to maintain order between connections so QSet would be more suitable.
 2019-04-15 21:35:35 +08:00
Chocobo1
a35b6cc8dd
Remove closed connections immediately 
Previously it relied on a timer to drop dead connections but that proved to
be too slow when there is an incoming burst of connections.

Fixes #10487.
 2019-04-15 21:35:10 +08:00
Chocobo1
41773a5465
Fix unsafe type narrowing 
Appending the warning below:
qBittorrent\src\base/utils/version.h(176): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
qBittorrent\src\base/utils/version.h(185): note: see reference to function template instantiation 'std::array<T,2> Utils::Version<T,2,2>::parseList<StringsList>(const StringsList &)' being compiled
        with
        [
            T=unsigned short,
            StringsList=QList<QByteArray>
        ]
 2019-04-15 20:23:26 +08:00
Mike Tzou
19dfec1e0a
Merge pull request #10464 from thalieht/torrent-size-limit 
Increase the download request size limit from 10 to 100 MiB
 2019-04-11 10:14:49 +08:00
thalieht
2f3b7642c2 Show user friendly size in error 2019-04-10 11:39:27 +03:00
thalieht
25102b9c5d Increase the download size limit to 100 MiB 2019-04-10 11:39:27 +03:00
Chocobo1
d86a984e25
Correctly handle '+' sign in x-www-form-urlencoded data 
Fixes #10451.
 2019-04-07 13:58:16 +08:00
Vladimir Golovnev (Glassez)
ead078a38e
Add preliminary support of libtorrent v1.2 
libtorrent v1.2 should be built with deprecated features enabled.
 2019-03-18 15:17:03 +03:00
Mike Tzou
d1b0c230ed
Merge pull request #10366 from Chocobo1/logger 
Avoid performance penalty when logger is full
 2019-03-17 15:04:53 +08:00
Chocobo1
04fd6e9d04
Avoid performance penalty when logger is full 2019-03-15 14:29:06 +08:00
thalieht
4c53447d35 Remove the max half-open connections option from GUI 
Its functionality was deprecated long ago.
 2019-03-13 21:08:40 +02:00
Vladimir Golovnev
928ce940c9
Merge pull request #10346 from glassez/download-manager 
Improve "Download manager"
 2019-03-10 09:13:07 +03:00
Vladimir Golovnev (Glassez)
4ee6a0ba29
Use Qt-provided HTTP redirection handling 2019-03-08 13:06:42 +03:00
Vladimir Golovnev (Glassez)
746916a963
Use DownloadHandler behind the scenes 2019-03-08 13:00:37 +03:00
sledgehammer999
c2d1af9853
Merge pull request #10338 from sledgehammer999/raise_qt5_ver 
Raise minimum Qt version to 5.9.0
 2019-03-08 00:42:26 +02:00
Vladimir Golovnev (Glassez)
6cb15706f5
Reduce number of DownloadManager signals 2019-03-05 11:28:29 +03:00
Chocobo1
adbd34c795
Move helper functions to Utils::Gui namespace 2019-03-05 14:55:22 +08:00
sledgehammer999
5c63ad3b95
Raise minimum Qt version to 5.9.0 2019-03-04 16:48:49 +02:00
Mike Tzou
0f1fc7be9d
Merge pull request #10302 from Chocobo1/uptr 
Replace QScopedPointer with std::unqiue_ptr
 2019-03-02 12:26:14 +08:00
Chocobo1
6dab93f7fd
Replace deprecated QDesktopWidget class 2019-02-28 12:02:03 +08:00
Chocobo1
c657134344
Replace deprecated QSslSocket::setDefaultCiphers() 2019-02-28 12:01:36 +08:00
Chocobo1
168d3fbdac
Replace deprecated trUtf8() 2019-02-28 12:01:36 +08:00
thalieht
77aea3c59e Add const to a few pointer arguments 2019-02-25 17:05:15 +02:00
thalieht
ce437817de Make various minor changes 2019-02-25 17:05:15 +02:00
thalieht
89dce36e98 Use uniform initialization on some default arguments 2019-02-25 17:05:15 +02:00
thalieht
8a19a0d4a0 Remove const in declarations' arguments that are passed by value 2019-02-25 17:05:15 +02:00
thalieht
70f1537d9f Add const to almost all remaining vars and arguments that qualify 2019-02-25 17:05:15 +02:00
Mike Tzou
1c14a08390
Merge pull request #10296 from thalieht/clang-tidy 
Some suggestions from Clang-tidy
 2019-02-21 23:17:29 +08:00
Chocobo1
5e3fddf456
Replace QScopedPointer with std::unqiue_ptr 
These 2 types are very similar and we should prefer the one from C++
standard library, this reduces the number of types in our code base.

Also see:
https://stackoverflow.com/questions/40346393/should-i-use-qscopedpointer-or-stdunique-ptr#comment67966940_40346991
 2019-02-18 16:06:40 +08:00
Chocobo1
8fe1ff87f1
Limit DownloadHandler max redirection to 20 
Closes #10219.
 2019-02-17 22:02:48 +08:00
thalieht
86df25a3e9 Remove some unused stuff 2019-02-16 18:54:18 +02:00
thalieht
8c944bd4e1 Avoid repeating the return type 2019-02-16 18:54:18 +02:00
thalieht
d8cbc9266a Use 'auto' to avoid duplicating the type name 2019-02-16 18:54:17 +02:00
Chocobo1
409557ef30
Clean up code 2019-02-15 19:47:06 +08:00
thalieht
8a3f942385 Don't use 'else' after return/break 2019-02-13 18:23:25 +02:00
Chocobo1
313a95bdd1
Log DownloadManager SSL errors 2019-02-13 20:09:08 +08:00
Mike Tzou
78ab0e4ba9
Merge pull request #10220 from thalieht/const 
Add const to many vars and arguments
 2019-02-13 12:11:00 +08:00
thalieht
445adb0ab4 Convert pass-by-value arguments to const refs where applicable 2019-02-12 02:45:55 +02:00
thalieht
ca3ce87e06 Add const to many vars and arguments 
Also remove const in declarations' arguments that are passed by value
 2019-02-11 20:19:41 +02:00
Mike Tzou
12aea82031
Merge pull request #10273 from Chocobo1/fix 
Fix wrong arg placeholder
 2019-02-10 13:31:09 +08:00
Chocobo1
79d7ba8205
Fix wrong arg placeholder 2019-02-09 21:26:45 +08:00
Vladimir Golovnev
0413a05246
Merge pull request #10242 from glassez/ordered-recheck 
Force recheck multiple torrents one by one. Closes #9120
 2019-02-08 08:19:30 +03:00
Mike Tzou
efed3fc78c
Merge pull request #10256 from Chocobo1/license 
Add license header
 2019-02-08 12:07:08 +08:00
Mike Tzou
c540e57f55
Merge pull request #10227 from Chocobo1/login 
Prevent login credential appearing in URL
 2019-02-07 13:16:24 +08:00
Chocobo1
364a837dbd
Revise comments about C++14 2019-02-05 13:35:54 +08:00
Chocobo1
6d29a3af60
Make use of std algorithms 2019-02-05 13:35:54 +08:00
Chocobo1
f789df7edf
Add license header 2019-02-04 17:28:55 +08:00
Vladimir Golovnev (Glassez)
61925f74fd
Force recheck multiple torrents one by one 
Closes #9120.
 2019-02-01 18:15:54 +03:00
Chocobo1
814eef1e56
Fix wrong arg placehoder 2019-02-01 13:38:14 +08:00
Chocobo1
5cdb3b6a2d
Load WebUI certificate & key from file path 
This allow users to update certificate & key more easily, i.e. without the need to import them
into qbt.

Closes #6675, #7547, #8315, #8564.
 2019-01-28 16:33:48 +08:00
Chocobo1
48d358872f
Cleanup header inclusion 2019-01-28 14:34:13 +08:00
Vladimir Golovnev
5b82b681cb
Merge pull request #10225 from glassez/http-request 
Separate URL components before percent-decoding. Closes #9116
 2019-01-28 08:46:41 +03:00
sledgehammer999
6fdc02f947
Merge pull request #10201 from sledgehammer999/dead_code 
Remove leftover tracker authentication code
 2019-01-27 22:19:21 +02:00
Vladimir Golovnev (Glassez)
b0446380c6
Separate URL components before percent-decoding 
Allow special characters in query string parameters.
Closes #9116.
 2019-01-27 15:33:19 +03:00
sledgehammer999
4a414d50f1
Remove leftover tracker authentication code 2019-01-23 02:38:46 +02:00
Chocobo1
04227f5a41
Add QBT_APP_64BIT define 
Now we use QT_POINTER_SIZE to detect CPU bitness, it has the advantage of applicable to all CPU
architectures not limiting to x86 arch.
 2019-01-19 10:14:10 +08:00
Vladimir Golovnev (Glassez)
302c99d7d5
Drop support of libtorrent < 1.1.10 2019-01-11 15:13:17 +03:00
Chocobo1
b7627db98c
Remove unused headers 2019-01-06 19:19:57 +08:00
Chocobo1
06e82d10f6
Replace boost::function with std::function 2019-01-06 19:19:57 +08:00
Chocobo1
d013e0922d
Use the proper Qt type 2019-01-06 18:32:01 +08:00
sledgehammer999
6b2a382ab8
Merge pull request #10066 from sledgehammer999/drop_migration_code 
Drop upgrade code
 2019-01-02 21:42:31 +02:00
Chocobo1
2b903fc3d1
Move Utils::Misc::isUrl() function 
All usage of this function gets to call Net::DownloadManager eventually.
 2018-12-31 20:00:15 +08:00
Chocobo1
6759446639
Cleanup code 
Also remove redundant code, it is already handled correctly in subsequent function calls.
 2018-12-31 20:00:15 +08:00
Chocobo1
19d6de795c
Drop support for "BC Link" format 
The format is marked obsolete on 2009.12.28 and has been replaced by magnet links.

http://wiki.bitcomet.com/inside_bitcomet#bc_link_format_obsoleted_as_of_v117
https://www.bitcomet.com/en/changelog
 2018-12-31 20:00:15 +08:00
sledgehammer999
1fff760722
Drop upgrade code 2018-12-31 00:41:17 +02:00
Chocobo1
a5c53ff756
Simplify InfoHash, TrackerEntry class internals 2018-12-26 12:04:41 +08:00
Chocobo1
2a84345835
Mark constructors as explicit 2018-12-26 12:04:40 +08:00
thalieht
d9416299f4 Fix regression on resuming torrents without metadata 2018-12-23 19:23:34 +02:00
sledgehammer999
6f638058d1
Merge pull request #10013 from sledgehammer999/revert_locale 
Use configured locale only for translating
 2018-12-18 16:28:05 +02:00
Stephen Dawkins
70435ab5bf Keep track of REPACK/PROPER downloads 
When using the smart episode filter, if the episode contains REPACK and/or
PROPER, these should be stored to prevent it from redownloading a duplicate
episodes.

Closes #9898.
 2018-12-17 09:52:12 +00:00
sledgehammer999
63cf216550
Use configured locale only for translating 
Don't use other aspects of it eg for date formatting. We should depend
on the system locale for all these. The user probably likes it that way,
otherwise he would have changed it.
 2018-12-17 00:13:28 +02:00
Mike Tzou
deed457764
Merge pull request #9993 from Chocobo1/referer 
Enforce referrer-policy in WebUI
 2018-12-14 13:23:04 +08:00
Thomas Piccirello
7f349732ee Send numeric status without translation 2018-12-11 01:37:33 -05:00
Mike Tzou
cf9d903ba9
Merge pull request #9541 from Piccirello/webui-file-priority 
Set priority for multiple files in one WebAPI request
 2018-12-11 13:32:53 +08:00
Thomas Piccirello
c5b8f62780 Set priority for multiple files in one WebAPI request 
Closes #6259.
 2018-12-10 23:21:09 -05:00
Thomas Piccirello
f27dc977e9 Replace prio namespace with FilePriority enum class 2018-12-10 23:21:09 -05:00
Chocobo1
7fd30fa90f
Enforce referrer-policy in WebUI 
This stops leaking private data to other websites via Referrer header.
 2018-12-10 22:17:04 +08:00
Mike Tzou
3ff7d16cfc
Merge pull request #9982 from Chocobo1/fixes 
Fix TravisCI linux builds
 2018-12-10 12:33:51 +08:00
Vladimir Golovnev
fc08091765
Merge pull request #9940 from glassez/error-msg 
Show error message when Session failed to start
 2018-12-09 11:16:17 +03:00
Chocobo1
f13bcbd772
Add OpenSSL version to GUI & stackdump 2018-12-08 12:46:50 +08:00
Chocobo1
a137f1493e
Use correct locale to display date 2018-12-08 12:19:56 +08:00
Chocobo1
de437b905b
Fix MSVC C4267 warning 
The warning was: "warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data"
 2018-12-08 12:19:56 +08:00
Mike Tzou
6bb4eb825b
Merge pull request #9942 from Chocobo1/pbkdf2 
Do password hashing properly
 2018-12-06 16:22:22 +08:00
Mike Tzou
1eef5b6876
Merge pull request #9373 from FranciscoPombal/checking_mem_usage_adv_settings 
Add checking_mem_usage option to AdvancedSettings
 2018-12-06 16:20:02 +08:00
Mike Tzou
0ab5b8fcba
Merge pull request #9824 from thalieht/style 
Convert all foreach() to range-based for()
 2018-12-06 16:19:17 +08:00
FranciscoPombal
74be5d9030
Add checking_mem_usage option to AdvancedSettings 2018-12-06 03:10:24 +08:00
Vladimir Golovnev (Glassez)
89deccd9b5
Show error message when Session failed to start 2018-12-05 19:57:44 +03:00
Chocobo1
2c8890bd06
Apply PBKDF2 to GUI lock 2018-12-05 13:28:42 +08:00
Chocobo1
05d6a29416
Apply PBKDF2 when storing passwords 2018-12-05 13:28:42 +08:00
Mike Tzou
eb957bb790
Merge pull request #9953 from Chocobo1/announce 
Use ip parameter from tracker request if provided
 2018-12-05 11:13:03 +08:00
Chocobo1
ede9b1a7c4
Fix typo 2018-12-03 12:06:32 +08:00
Chocobo1
b4564f5f4e
Use ip parameter from tracker request if provided 
Closes #9949.
 2018-12-03 00:14:15 +08:00
Chocobo1
b56937f5fa
Use QHostAddress for storing IP 2018-12-02 14:18:18 +08:00
Chocobo1
36429887dc
Fix wrong locale used in log message 2018-12-01 20:39:20 +08:00
thalieht
1f36b8b89f Combine qAsConst() with copyAsConst() to asConst() 2018-11-28 23:41:23 +02:00
thalieht
6b1d26d555 Convert all foreach() to range-based for() 2018-11-28 23:40:12 +02:00
thalieht
d668a4fe6d Fix coding style for various things 2018-11-28 23:37:35 +02:00
Mike Tzou
5efdd211cc
Merge pull request #9892 from Chocobo1/progress 
Code cleanup
 2018-11-29 01:16:07 +08:00
Chocobo1
0339e6ee35
Clean up code 2018-11-27 22:01:27 +08:00
Vladimir Golovnev (Glassez)
68508ba657
Save torrents queue in separate file 2018-11-27 16:55:45 +03:00
Vladimir Golovnev (Glassez)
e146c2f227
Fix signed/unsigned integers comparison warning 2018-11-27 16:55:44 +03:00
Thomas Piccirello
4885fe6b4c Only instantiate SearchPluginManager as needed 2018-11-21 16:59:38 -05:00
Chocobo1
344e47dcfb
Add option for WebUI Host header validation 
Closes #9743.
 2018-11-19 11:05:04 +08:00
Vladimir Golovnev (Glassez)
64d7cf4794
Improve RSS Feed updating 
Don't process "out-of-limit" articles.
Closes #9833.
 2018-11-16 10:30:24 +03:00
Mike Tzou
2ce57b97be
Merge pull request #9799 from Chocobo1/removeCheckbox 
Remove speed limit checkbox in Options dialog
 2018-11-07 13:40:43 +08:00
Vladimir Golovnev
54e4806e3d
Merge pull request #9817 from Piccirello/torrent-dl-success 
Handle downloading .torrent file as success
 2018-11-06 15:39:51 +03:00
Vladimir Golovnev
46ec72f688
Merge pull request #9580 from glassez/start_paused 
Improve handling of torrent startup/recheck
 2018-11-06 15:34:21 +03:00
Chocobo1
3fa5358c3f
Remove speed limit checkbox in Options dialog 
This unifies speed limit UI elements throughout the program.
 2018-11-05 11:07:52 +08:00
Tom Piccirello
1b81356a67 Handle downloading .torrent file as success 
We don't know whether the download will be successful, so default to success. Closes #9811.
 2018-11-04 14:43:33 -05:00
Chocobo1
c1c28ce195
Improve parser for search engine versions.txt 
The parse could fail when there is an extra empty line at the end of
file, this patch fixes it.
 2018-11-03 01:01:46 +08:00
Chocobo1
ee030cc4eb
Fix wrong type passed to arg() 2018-11-03 00:34:25 +08:00
Vladimir Golovnev (Glassez)
1214cf0fa1
Don't update torrent status unnecessarily 2018-11-02 19:25:39 +03:00
Vladimir Golovnev (Glassez)
9dadb919ef
Improve force recheck of paused torrent 2018-11-02 19:25:38 +03:00
Vladimir Golovnev (Glassez)
a8c00456e4
Restore torrent in two steps 
Add/restore all torrents in "paused" state and then resume those
that need to be really "resumed" (added/restored in "resumed" state).
Keep torrents with missing files paused.
Force recheck torrent with missing files when it's resumed by the user.
 2018-11-02 19:25:26 +03:00
Vladimir Golovnev
dea6b3d7e0
Merge pull request #9562 from dzmat/round_speed_labels 
Improve scaling of speed graphs
 2018-11-01 09:46:26 +03:00
Vladimir Golovnev (Glassez)
5712c05e68
Consider empty locale setting as not set 2018-10-27 20:59:08 +03:00
Mike Tzou
2fd4d50f3a
Merge pull request #9754 from silverqx/previewable-ts-ext 
Recognize TS files as previewable
 2018-10-25 12:56:02 +08:00
silver
0b20750cd5
Recognize *.ts files as previewable 2018-10-24 16:18:35 +02:00
Vladimir Golovnev
7e36cc746f
Merge pull request #8584 from Piccirello/new-search-api-2 
WebUI search API. Closes #2495
 2018-10-24 13:13:16 +03:00
dzmat
fabd7e34f5 Improve scaling of speed graphs 
Make Y axis scale to fix on predetermined nice looking positions
 2018-10-21 16:45:32 +07:00
Mike Tzou
18a64f109d
Merge pull request #9683 from Chocobo1/win_fs 
Add isNetworkFileSystem() detection on Windows
 2018-10-14 01:29:22 +08:00
Vladimir Golovnev
ff72be9c2d
Merge pull request #9481 from mj-p/master 
Don't recheck just checked torrent. Closes #8743, #9370
 2018-10-13 09:34:27 +03:00
Vladimir Golovnev
72e148e0f1
Merge pull request #9590 from dzmat/disable_graphs_collection 
Implement option for disabling speed graphs
 2018-10-12 08:24:33 +03:00
Chocobo1
acdf5363b2
Simplify #if conditions 2018-10-12 00:04:08 +08:00
Chocobo1
cff5af2e76
Add isNetworkFileSystem() detection on Windows 
This allows network mounts to be monitored correctly by polling timer.
 2018-10-12 00:03:12 +08:00
Mike Tzou
fb8fad3fa1
Merge pull request #9673 from Chocobo1/fs_watch 
Add SMB2 magic number
 2018-10-11 23:11:06 +08:00
Chocobo1
9b552c463f
Add FileSystemWatcher log messages 2018-10-11 11:01:22 +08:00
Chocobo1
25a0147f61
Add SMB2 magic number 
Closes #9671.
 2018-10-10 10:36:26 +08:00
Stephen Dawkins
d8054f9cb3
Allow to disable downloading REPACK/PROPER matches 2018-10-09 08:14:12 +03:00
dzmat
2d0f0cb372 Allow to disable speed graphs 2018-10-08 23:51:02 +07:00
sledgehammer999
2f1a0ffe5c
Use a more detailed alert mask where possible 
Closes #9547
 2018-10-02 02:42:06 +03:00
Thomas Piccirello
0b6ae68801 Add WebUI search API controller 
Closes #2495.
 2018-09-30 20:07:27 -04:00
Administrator account
f6ed605414
Don't recheck just checked torrent 
Closes #8743.
Closes #9370.
 2018-09-29 17:13:44 +03:00
Chocobo1
b8d87f641f
Avoid variable shadowing 2018-09-26 23:53:17 +08:00
Chocobo1
66ffb01629
Add include guard to headers 2018-09-26 23:49:33 +08:00
Chocobo1
f26a5c3581
Update Python URLs 2018-09-25 11:46:40 +08:00
Chocobo1
7d808cfc99
Fix asking to install Python 
The dialog asking users to install python is borked since the last refactor, this
commit fixes it.
 2018-09-25 11:46:39 +08:00
Chocobo1
60ecc4fe8f
Move python related functions 
Also the functions are slightly changed to return full path of the found
python executable.
 2018-09-25 11:46:39 +08:00
sledgehammer999
6c0af1b078
Merge pull request #9553 from sledgehammer999/misc_fixes 
Misc fixes
 2018-09-22 20:09:54 +03:00
sledgehammer999
06c8142826
Make strings actually translatable 2018-09-22 14:05:41 +03:00
sledgehammer999
e8213b2c6a
Remove unused variable 2018-09-22 14:05:40 +03:00
dzmat
fc93f2eb78 Replace magic number with system define 2018-09-21 22:33:43 +07:00
Vladimir Golovnev
fe9fb03e38
Merge pull request #9482 from proninyaroslav/patch-1 
Fix typo in variable name
 2018-09-13 19:45:14 +03:00
Vladimir Golovnev
28a6ac3197
Merge pull request #9228 from Piccirello/addCategory 
Add save path and category editing to WebUI
 2018-09-13 19:43:28 +03:00
sledgehammer999
c520e657ce
Save state change from queued to paused 2018-09-11 21:00:04 +03:00
Yaroslav Pronin
4e28033c9c
Fix typo in variable name 2018-09-11 17:56:55 +00:00
Vladimir Golovnev
d18de18128
Merge pull request #9461 from thalieht/tracker 
Show "N/A" if there is no scrape response
 2018-09-10 07:14:28 +03:00
thalieht
94613c2fa2 Fix some warnings 2018-09-07 19:40:08 +03:00
sledgehammer999
9ce619eac8
Decrease probability of missing important alerts 
During startup we can get above 1000 alerts at each pop even with only
30 torrents in the queue. This is because libtorrent will post
piece_finished_alert and file_completed_alert for each torrent. These
alerts push out of the way the ones we care about.
The alert queue will be grown to max only if needed. So we don't use
more memory. It will greatly depend on how many torrents a user has in
their session.

When getting fastresume_rejected_alert we need to act as fast as
possible in pausing it, otherwise there's a chance it will begin
downloading and writing to disk before we pause it.
 2018-09-06 02:06:44 +03:00
Thomas Piccirello
63c53766b4 Add save path and editing to WebUI new category dialog 2018-08-31 11:27:05 -04:00
Mike Tzou
846d8993a9
Merge pull request #9410 from Chocobo1/clazy 
Minor fixes
 2018-08-30 12:07:34 +08:00
Elias M. Mariani
33af699191 Support the OpenBSD filesystem 2018-08-28 13:58:09 -03:00
Chocobo1
254782def6
Avoid copy-construct QString in for loop 2018-08-28 14:13:59 +08:00
thalieht
ec9120adf0 Save torrents priorities on torrent finished 
Save fastresumes for all torrents that shifted in the queue when a torrent finished.
 2018-08-25 22:02:14 +03:00
thalieht
95b02bbb2e Save fastresumes when changing torrent priorities 2018-08-25 22:02:14 +03:00
Vladimir Golovnev (Glassez)
386d0565fe Always save actual queue position 2018-08-25 22:02:14 +03:00
Vladimir Golovnev
93f9b3de8b
Merge pull request #9314 from thalieht/searchregexfilter 
Add option to use regexps in the search job's search filter's context menu
 2018-08-22 17:15:37 +03:00
Thomas Piccirello
d89ef22d85 Require torrent category creation to be explicit 2018-08-18 22:04:21 -04:00
Chocobo1
262c3a75bd
Fix WebUI unreachable issue 
QVariant doesn't have constructor for plain char, by default it converts
a plain char into an integer, hence the WebUI issue.
Closes #9333.
 2018-08-19 03:33:08 +08:00
thalieht
400eafce2b Rename 2 methods to eliminate ambiguity 2018-08-14 13:40:00 +03:00
thalieht
4dcb0b922e Add regex option in the search filter's context menu 
In the search job widget.
 2018-08-14 13:38:34 +03:00
Chocobo1
71dcc76a64
Replace png icons with svg 2018-08-14 17:03:14 +08:00
Chocobo1
6f2b1823ad
Fix lupdate errors 
I suspect lupdate isn't smart enough to figure out what tr() is suppose
to do, so just make it a static function in class.
The error was: tr() cannot be called without context
 2018-08-13 01:24:34 +08:00
sledgehammer999
366239ca7b
Merge pull request #9244 from Couchy/inhibit_sleep_options 
Inhibit sleep for running downloads or uploads regardless of network activity
 2018-08-12 16:31:01 +03:00
sledgehammer999
a3172590d0
Merge pull request #9255 from thalieht/filterRegex 
Add option to use regexps in the transfer list's search filter's context menu
 2018-08-12 16:22:00 +03:00
Mike Tzou
f44ff63361
Merge pull request #9278 from Couchy/torrent_file_error_handling 
Improve error handling when loading torrent files
 2018-08-12 00:21:56 +08:00
sledgehammer999
9dd1049f24
Merge pull request #9274 from sledgehammer999/tray_close_notification 
Notify users on 1st time close/minimize to tray
 2018-08-11 00:13:41 +03:00
Couchy
3808b5df16
Avoid allocating large memory when loading a .torrent file 
`QIODevice::read(qint64 maxSize)` will allocate full `maxSize` of memory no matter
what the real file size was, this caused users to experience out-of-memory
exception on 32-bit qbt.
Also handle the OOM execption if it still fails.

Closes #9064, #9075, #9130, #9239, #9246, #9279.
 2018-08-11 00:48:35 +08:00
Mike Tzou
5f61ffa184
Merge pull request #9303 from Chocobo1/fix 
Fix I/O error after fetching magnet metadata
 2018-08-11 00:14:06 +08:00
thalieht
2485525896 Add option for regexps in the transferlist search filter's context menu 2018-08-10 12:44:10 +03:00
Chocobo1
63991cb58e
Fix I/O error after fetching magnet metadata 
It is caused by an extra path seperator, so removing it fixes it.
Fixup 9612a75faa.
 2018-08-10 12:48:04 +08:00
sledgehammer999
fd30bf7423
Notify users on 1st time close/minimize to tray 2018-08-09 16:48:34 +03:00
sledgehammer999
2befd2927a
Revert "Set "close to tray" to false as default" 
This reverts commit dc9ec0e408.
 2018-08-09 16:37:23 +03:00
Vladimir Golovnev
260b03de92
Merge pull request #9265 from glassez/dont-save-paused 
Never save resume data for already paused torrents
 2018-08-08 08:45:15 +03:00
Mike Tzou
89081d5365
Merge pull request #9268 from Chocobo1/clean 
Put temporary files in qbt own temp folder and cleanups
 2018-08-04 01:18:56 +08:00
Lukas Greib
48cd993c92 Inhibit sleep regardless of activity 
"Active torrents" is a somewhat unintuitive concept as a basis for
preventing sleep, as torrents can become active or inactive on the
network at any time. This brings some predictability to the inhibit
sleep option, and will inhibit sleep as long as there are unpaused
downloads or uploads, regardless of network activity.

Closes #1696, #4592, #4655, #7019, #7159, #7452
 2018-08-03 09:58:15 -04:00
Vladimir Golovnev
d106d908ef
Merge pull request #9273 from thalieht/closetotray 
Set "close to tray" to false as default
 2018-08-03 11:16:50 +03:00
thalieht
dc9ec0e408 Set "close to tray" to false as default 2018-08-02 17:11:41 +03:00
Chocobo1
9612a75faa
Put temporary files in qbt own temp folder 2018-08-02 17:44:06 +08:00
Vladimir Golovnev (Glassez)
2a6e38aa28
Never save resume data for already paused torrents 2018-08-01 21:29:32 +03:00
Vladimir Golovnev (Glassez)
7716a27d0d
Reorder resume data saving conditionals 
Having conditionals which can break saving of torrent resume data
in order from more likely to less likely is more effective.
 2018-08-01 21:29:01 +03:00
Chocobo1
9df67b52b8
Add const to function signature 2018-08-01 01:40:50 +08:00
Chocobo1
73b5efbb23
Avoid potentially setting the wrong piece priorities 
Updating file priorities is an async operation in libtorrent, when we
just updated it and immediately query it, we might get the
old/wrong values, so we rely on `updatedFilePrio` in this case.
 2018-07-30 13:22:05 +08:00
Chocobo1
a68cdc5225
Refactor code 
Make the code slightly easier to read.
 2018-07-30 02:43:23 +08:00
Chocobo1
9bd8587c68
Add const to function parameters 2018-07-30 02:23:51 +08:00
Chocobo1
650f585bf3
Remove static keyword overuse 2018-07-23 13:40:25 +08:00
Chocobo1
517fc39950
Remove unnecessary dynamic allocation 
Also remove unneeded `if ()` conditional.
 2018-07-23 13:40:25 +08:00
Chocobo1
56766dc08b
Avoid binding constant reference to returned object 
In such cases, it makes no sense doing so.
 2018-07-23 13:40:25 +08:00
Chocobo1
0217d5b4c0
Replace single-character string with character literal 
Also remove unnecessary dynamic allocation.
 2018-07-21 23:26:15 +08:00
Mike Tzou
aed971883d
Merge pull request #9192 from Chocobo1/msg 
Revise dialog messages
 2018-07-18 00:08:00 +08:00
Chocobo1
42eac2ee3c
Simplify code 
This avoids "deferencing null pointer" warning from static analyzers.
 2018-07-15 13:30:11 +08:00
Chocobo1
ec7dfee887
Fix typo 2018-07-15 10:19:24 +08:00
Vladimir Golovnev
11cd828e8a
Merge pull request #9186 from glassez/fix-dm 
Apply proxy settings on DownloadManager creation
 2018-07-14 12:01:28 +03:00
Vladimir Golovnev (Glassez)
f7c252886f
Apply proxy settings on DownloadManager creation 2018-07-13 13:18:57 +03:00
Vladimir Golovnev (Glassez)
cd44ab2fc6
Improve torrent initialization 
Don't post "torrent resumed" event when torrent starts in "resumed"
state.
Fix confusing names. Now "resumed torrent" means "unpaused torrent"
only. When we load previously added torrent it is called "restored
torrent".
 2018-07-12 21:03:36 +03:00
Vladimir Golovnev (Glassez)
7ebd63a60f
Save resume data on torrent change events 
Closes #9174.
 2018-07-10 17:45:09 +03:00
sledgehammer999
de8050701d
Revert email address changes in copyright notices 2018-07-10 00:37:44 +03:00
tjjh89017
670a8e27af
Add async io threads option to AdvancedSettings 2018-07-08 22:58:35 +08:00
Chocobo1
d61435e4bf
Allow save resume interval to be disabled 
Also raise the allowable upper limit
 2018-07-05 13:22:20 +08:00
Chocobo1
6a16fc1ca2
Prolong resume data save interval 2018-07-05 13:22:13 +08:00
thalieht
456270bbb1 Delete several unused #include 2018-07-03 08:38:32 +03:00
thalieht
eb508d67ef Fix coding style 2018-07-03 08:38:32 +03:00
Mike Tzou
ca68b86550
Merge pull request #9141 from Chocobo1/delay 
Omit removing python cache artifacts on qbt start
 2018-07-03 13:07:31 +08:00
Vladimir Golovnev
b0afa33e22
Merge pull request #9125 from glassez/downloader 
Implement "Sequential downloading" feature. Closes #6835
 2018-07-02 15:24:58 +03:00
Chocobo1
2528c6e39a
Fix python version detection 
Closes #9146.
 2018-07-02 00:57:08 +08:00
Chocobo1
8c32302377
Clear python cache conditionally 
Clear the cache artifacts on plugin install and plugin uninstall events.
 2018-07-01 20:57:39 +08:00
Vladimir Golovnev (Glassez)
d78414307e
Make TorrentInfo loading behavior uniform 2018-06-29 15:48:36 +03:00
Vladimir Golovnev (Glassez)
112a9bcfa2
Use new DownloadManager interface 2018-06-29 15:48:17 +03:00
Vladimir Golovnev (Glassez)
8d438e159c
Implement "Sequential downloading" feature 
Closes #6835.
 2018-06-29 15:48:02 +03:00
Vladimir Golovnev (Glassez)
a9a6b74416
Implement DownloadRequest helper 2018-06-29 12:18:56 +03:00
Chocobo1
77b71e392e
Refactor function 
In SearchPluginManager::updateNova(), omit removing __pycache__ folder and pyc
files, those files will be recreated anyway.
Add const to variables
 2018-06-28 17:21:13 +08:00
Chocobo1
f951bf678d
Rename function 2018-06-28 16:13:52 +08:00
Chocobo1
5c50c5b24d
Cache SearchPluginManager::engineLocation() result 
Also the folder is only created on first usage.
 2018-06-28 16:06:16 +08:00
Chocobo1
361afb401b
Replace less-efficient QProcess::setEnvironment 
Also small refactor
 2018-06-28 15:56:39 +08:00
Chocobo1
ad5c88be3d
Simplify function 2018-06-28 15:50:50 +08:00
Chocobo1
3e6c8a05dd
Reduce queries to python version 
Instead of doing at least 2 queries for python infos, now requires only
1 query (in ideal condition), and the result is cached.
 2018-06-24 19:41:44 +08:00
Chocobo1
51e82762c5
Move related functions to Utils::Python 2018-06-24 06:21:15 +08:00
Mike Tzou
8f6e066332
Merge pull request #9092 from hannsen/patch-1 
PEP 8 compliant version comments in search plugins
 2018-06-18 00:56:28 +08:00
thalieht
d34ddb2e3c Change file names and classes names to match them 2018-06-15 20:12:59 +03:00
hannsen
a162550d7f
Properly normalize version string before parsing it 
This allows python scripts to be formatted in PEP 8 style.
 2018-06-14 13:00:31 +08:00
thalieht
4022799881 Fix coding style 2018-06-12 07:17:05 +03:00
Mike Tzou
da87c2d9ae
Merge pull request #9060 from Chocobo1/preinc 
Replace post-increment with pre-increment
 2018-06-09 12:40:30 +08:00
Chocobo1
5ddbf9bba9
Replace post-increment with pre-increment 
And post-decrement with pre-decrement.
 2018-06-08 08:44:06 +08:00
Eugene Shalygin
04aea413ba
Merge pull request #9055 from zeule/cmake 
Update CMake build scripts
 2018-06-07 21:31:09 +02:00
Eugene Shalygin
fa770871e9 Refactor CMake build scripts 
1. Use FeatureSummary module to show configuration results.

2. Invert option()/find_package() relationship: instead of
calling find_package(... REQUIRED) when option is set, rely on optional
find package call and PackageName_FOUND variable.

3. Refactor handling options that result in simple preprocessor defines
(actually copy the snippet from libtorrent) so that everything is done
in a single function call.

4. Populate target properties in order to get rid of
include_directories() calls.
 2018-06-05 11:39:11 +02:00
Chocobo1
050b78f378
Send Cache-Control header in WebUI responses 
Tune the caching time to be shorter, in case there is a program
update.
Change the cacheability to private, as WebUI resources are not intended
to be cached at proxy.
For uncacheable responses, send out "no-store" explicitly to halt
browser caching.
 2018-06-04 20:50:08 +08:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression 
Revise `static` keyword usage, static is added to frequently used
instances.
 2018-05-31 22:56:49 +08:00
Chocobo1
c22e6b4502
Cleanup header include order 
Add missing header.
Cleanup license.
 2018-05-31 22:56:25 +08:00
Vladimir Golovnev
15153a4446
Merge pull request #8976 from glassez/feed-uid 
Don't use RSS feed URLs as base for file names. Closes #8399
 2018-05-29 14:30:23 +03:00
Mike Tzou
1d25d95740
Merge pull request #8953 from Chocobo1/constexpr 
Add constexpr to various classes
 2018-05-29 00:21:52 +08:00
Mike Tzou
4a51f14328
Merge pull request #8967 from Chocobo1/protect 
Add options to control WebUI security measures
 2018-05-28 14:21:53 +08:00
Vladimir Golovnev (Glassez)
200f4d0f07
Don't use RSS feed URLs as base for file names 
RSS feed URLs can be too long and exceed max path limit.
Add RSS feed UIDs and use UIDs as base for file names instead of URLs.
Closes #8399.
 2018-05-26 10:37:32 +03:00
sledgehammer999
80e93e23f9
Fix compilation without D-Bus support 
Closes #8977
 2018-05-24 17:40:23 +03:00
sledgehammer999
7c6a5afbff
Merge pull request #8962 from sledgehammer999/suppress_errors 
Suppress multiple I/O errors for the same torrent
 2018-05-24 16:35:03 +03:00
Vladimir Golovnev
935bb5bd1c
Merge pull request #8966 from glassez/rss-date 
Use RSS feed update time as a fallback. Closes #8959
 2018-05-23 17:20:46 +03:00
Chocobo1
e099f6ad33
Add constexpr to IndexInterval class 
Add const to IndexRange private members.
Remove redundant inline specifier.
Add missing parentheses.
 2018-05-23 14:30:56 +08:00
Chocobo1
9631a9c2ad
Add constexpr to TriStateBool class 2018-05-23 14:30:56 +08:00
Chocobo1
b38925413d
Improve Utils::Version class 
Add operator>=() and operator<=().
More methods are suitable to be constexpr.
Remove redundant boundary checking.
 2018-05-23 13:47:41 +08:00
Mike Tzou
cd21071c69
Merge pull request #8954 from Chocobo1/firstlast 
Relax behavior of "Download first and last piece first"
 2018-05-23 13:26:02 +08:00
Mike Tzou
84df2794dc
Merge pull request #8944 from Chocobo1/literal 
Make use of QStringLiteral
 2018-05-23 13:23:41 +08:00
sledgehammer999
b9546ccd4c
Suppress multiple I/O errors for the same torrent 
When a file error happens libtorrent spews a ton of `file_error_alert`
which result in log floods and notification balloon floods. The later
might render the program inaccessible because the constant
notifications prevent the user from interacting with the tray icon.

Closes #8934
 2018-05-22 21:29:50 +03:00
Chocobo1
9eeef0be97
Add option to control CSRF protection 
Some users are using WebUI with simple port-forwarding from their router,
providing an option to control the protection will save them from setting up an
non-trival web proxy.
Closes #7274.
 2018-05-22 12:57:03 +08:00
Vladimir Golovnev (Glassez)
4f8ed09183
Add missing 'return' statement 2018-05-21 21:24:02 +03:00
Chocobo1
bad4d94f77
Add option to control WebUI clickjacking protection 
Some users actually want embedding WebUI into their custom build iframe.
Closes #7370.
 2018-05-22 01:07:25 +08:00
Vladimir Golovnev (Glassez)
9b80c4f7eb
Use RSS feed update time as a fallback 
Some sites omit publication date in its RSS feed articles
that prevents "Ignore Subsequent Matches" to work properly.
Closes #8959.
 2018-05-21 15:47:14 +03:00
Vladimir Golovnev
1b14706b08
Merge pull request #8955 from glassez/initial-rename 
Rename torrent if content was initially renamed. Closes #8910
 2018-05-21 08:04:43 +03:00
Vladimir Golovnev
0aee1cf7d0
Merge pull request #8945 from glassez/rss-rule 
Improve code of  RSS auto-downloading rule. Closes #8933
 2018-05-21 08:04:12 +03:00
Vladimir Golovnev (Glassez)
a54f57611c
Rename torrent if content was initially renamed 
Closes #8910.
 2018-05-19 20:21:21 +03:00
Chocobo1
95b19ec303
Relax behavior of "Download first and last piece first" 
Now it applies the setting to all files in torrent, no matter whether
the file is previewable or not.

Torrent client shouldn't be smart by deciding which file this
option will be applied to, i.e. it should just follow the user's decision.
 2018-05-19 21:48:13 +08:00
Chocobo1
da75a010c7
Refactor code 
Add const to variables.
Add Logger message.
Simplify code logic.
 2018-05-19 21:48:13 +08:00
Vladimir Golovnev
c29e5c76dc
Merge pull request #8936 from surfernsk/master 
Fix open destination folder with Nautilus > 3.28. Closes #8923
 2018-05-19 15:06:03 +03:00
Vladimir Golovnev (Glassez)
844f76c2ca
Make "Ignoring days" to behave like other filters 
This prevents confusing in GUI when it shows matched RSS
articles which be really ignored by the rule.
 2018-05-19 14:52:24 +03:00
Evgeny Lensky
c7601d7a43 Fix open destination folder with Nautilus > 3.28 
Closes #8923.
 2018-05-19 18:45:26 +07:00
Vladimir Golovnev (Glassez)
256f6954c5
Improve code of RSS auto-downloading rule 
Closes #8933.
 2018-05-18 13:26:04 +03:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral 
Only changed instances that are initialized at program start.
 2018-05-18 02:14:49 +08:00
Chocobo1
fcbcf4039b
Use smaller type 2018-05-17 10:57:12 +08:00
Vladimir Golovnev (Glassez)
90f09e7570
Properly fill UploadedFile::filename field 
Closes #8928.
 2018-05-16 20:13:55 +03:00
Chocobo1
0a49f76c0a
Detect endianness at compile time 2018-05-15 21:02:00 +08:00
sledgehammer999
8a99e29122
Merge pull request #8716 from sledgehammer999/move_progress 
Move and recheck progress
 2018-05-13 13:02:03 +03:00
sledgehammer999
375b15727d
Show rechecking progress 
When having big torrents, the rechecking might take a while to
complete. Users need some sort of feedback that progress is being made.
Also, I changed the float to qreal since that's the return type.
 2018-05-13 12:32:17 +03:00
Mike Tzou
2230d96705
Merge pull request #8808 from Chocobo1/save 
Improve SettingsStorage behavior
 2018-05-13 14:24:14 +08:00
sledgehammer999
e5c73cee4a
Log successful torrent move 2018-05-12 20:49:33 +03:00
sledgehammer999
565ffa7d1e
Add 'Moving' state for torrents being relocated/moved 
This is another indication to the user that something is happening
behind the scenes.
Uses the same icon/color as "Checking" status.
Torrents in the `Moving` state are considered as "Active". This should
prevent accidental program exit from the user and inhibit system sleep.
 2018-05-12 20:49:33 +03:00
Vladimir Golovnev (Glassez)
32e2791f56
Fix compilation with MinGW 2018-05-12 06:24:05 +03:00
thalieht
4cfa163bbd Use qt5 syntax for a few remaining SLOT() 2018-05-11 08:19:41 +03:00
thalieht
20ca90800d Fix coding style 2018-05-09 17:06:22 +03:00
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
Mike Tzou
7af83ab704
Merge pull request #8807 from Chocobo1/tracker_msg 
Fix displayed tracker message
 2018-05-09 14:38:17 +08:00
Mike Tzou
99a1343b9d
Merge pull request #8862 from Chocobo1/cleanup 
Code cleanups
 2018-05-09 14:33:49 +08:00
Vladimir Golovnev
3a0e5e51df
Merge pull request #8761 from thalieht/nullptr 
Replace the zeroing of pointers with nullptr
 2018-05-08 17:10:37 +03:00
Chocobo1
defba23d61
Refactor code 
Remove forward declarations of Qt types.
Fix header include order.
 2018-05-08 12:18:18 +08:00
Chocobo1
6d923f703a
Fix displayed tracker messages 
Before this change, we were displaying debug messages constructed by
libtorrent, now we show messages returned by trackers.

Closes #8739.
 2018-05-07 21:49:31 +08:00
Chocobo1
90f42e6737
Refactor functions 
Add const to variables
Remove debug messages
 2018-05-07 21:49:31 +08:00
Chocobo1
58861c35b0
Fix compile warnings on gcc 8 
The warning was:
warning: catching polymorphic type ‘class std::exception’ by value
[-Wcatch-value=]
 2018-05-07 21:39:54 +08:00
Chocobo1
203bafc4c3
Revert commit 
Apparently the translations were working in previous state, but affected by
lupdate issue:
https://github.com/qbittorrent/qBittorrent/issues/8220#issuecomment-385712673

The reverts commit fb698896c9.
Closes #8831.
 2018-05-05 21:46:36 +08:00
Chocobo1
d20f40184f
Fix translation strings not found 
The translation context doesn't exist, so the translations were not found, fixed
now.
Closes #8829.
 2018-05-05 21:08:47 +08:00
Mike Tzou
d8c14ffe97
Merge pull request #8814 from Chocobo1/tr_fix 
Fix tr() related issues
 2018-05-05 13:48:09 +08:00
Chocobo1
9fabe59b80
Fix usage of Q_DECLARE_TR_FUNCTIONS() 
The context parameter shouldn't be enclosed in double quotes.
 2018-05-01 22:42:55 +08:00
sledgehammer999
6e94b03c13
Fix compilation against libtorrent 1.0.x 
Closes #8798
 2018-05-01 10:39:53 +03:00
Chocobo1
f6d74e3996
Retry saving settings when operation failed 2018-04-30 13:01:10 +08:00
Chocobo1
099314d17f
Make settings file recovery more robust 
We should not blindly remove the leftover settings file, as the following write()
operation could fail and the user would lost all settings.
We should try renaming it instead.
 2018-04-30 13:01:10 +08:00
Chocobo1
708b5a6904
Refactor SettingsStorage class 
Make use of (i.e. returning) QFile::rename operation status
Make log message more verbose
Add const
Remove empty lines
Inline typedef
 2018-04-30 13:01:10 +08:00
sledgehammer999
b78899cb9a
Merge pull request #8724 from Chocobo1/rand 
Use RNG provided by OS
 2018-04-22 22:33:16 +03:00
Mike Tzou
0dec7b9f4f
Merge pull request #8742 from tostercx/master 
Add "Preserve file order" option to torrent creator. Closes #5652
 2018-04-22 23:33:25 +08:00
Chocobo1
81a4f3ced0
Use RNG provided by OS 
The general consensus is to use random facility provided by OS instead
of using other software random generators.
 2018-04-20 23:34:46 +08:00
Chocobo1
970ad7cf28 Sort filenames when creating torrent 
First all dir paths are retrieved, then filenames in each path
are retrieved and sorted, then concatenate the sorted filenames together.
 2018-04-20 14:35:48 +03:00
toster
c4625f50a8 Pass isAlignmentOptimized flag to piece size calculation 2018-04-20 14:31:20 +03:00
Chocobo1
68c2d81072
Fix memory leak 2018-04-17 20:34:01 +08:00
Chocobo1
4dea03fc74
Remove unused constants 2018-04-17 20:29:43 +08:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
toster
e538eae726 Make alignment optimization optional 
Disabling alignment optimization allows preserving file order in torrent
files and closes #5652
 2018-04-14 06:46:41 +03:00
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash 
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
 2018-04-11 17:01:43 +03:00
Mike Tzou
38837db8de
Merge pull request #8699 from Chocobo1/linking 
Add helper for loading Windows system functions
 2018-04-11 00:13:55 +08:00
sledgehammer999
341a971cd3
Merge pull request #8711 from sledgehammer999/recheck_paused 
Avoid data corruption when rechecking paused torrents
 2018-04-10 16:18:12 +03:00
sledgehammer999
747c70a58e
Avoid data corruption when rechecking paused torrents 
Libtorrent can recheck only unpaused torrents. We get around this by
unpausing the torrent, issuing the recheck and pausing again after we
get alerted by libtorrent that the recheck has finished. This alert is
asyncronous. There is a small time frame where the program might start
downloading and writing data to the file before we pause it. This can
lead to data corruption if the file on disk is totally different that
the one expected by the torrent AND the file on disk is a valid file on
its own. OR in case the user points the new torrent to the wrong
directory by mistake.
To get around this the torrent is placed in upload_mode and out of
automanagement.
 2018-04-09 23:25:52 +03:00
Chocobo1
5819b6dd39
Use Unicode version of InitiateSystemShutdown 2018-04-09 21:18:07 +08:00
Chocobo1
644e7d0450
Use dynamic linking for SetSuspendState function 2018-04-09 21:18:07 +08:00
Chocobo1
b0e3d77975
Add helper for loading Windows system functions 2018-04-09 21:18:04 +08:00
Chocobo1
643a209812
Sort include headers 
Also add anonymous namespace.
 2018-04-09 21:16:00 +08:00
Chocobo1
6bbcf9b3d6
Stop creating Download folder on start 
The existence of this folder isn't required to run qbt and it can be
created when adding torrent.
Closes #8290.
 2018-04-05 14:12:47 +08:00
Chocobo1
37ea01bd44
Use lightweight printf instead of iostream 
Using iostream usually adds a lot of other operators (<<, endl), whereas
*printf takes only 1 function call.

Also use qUtf8Printable whenever possible.
 2018-03-31 03:21:53 +08:00
Chocobo1
65921eaf7b
Remove QPointer wrapper 2018-03-25 15:53:31 +08:00
Chocobo1
bfbd978d3f
Move helper function to Utils::Fs 2018-03-25 13:26:03 +08:00
Chocobo1
1876dbd523
Fix typo 2018-03-25 13:26:02 +08:00
Chocobo1
ea7eb7c0ec
Add delay before processing FS changes 
This prevents file renaming errors in monitored folder on linux, for
example: ABC.torrent.part -> ABC.torrent
 2018-03-25 13:26:02 +08:00
Chocobo1
19c733ce95
Use specific name for rejected files 2018-03-25 13:26:02 +08:00
Chocobo1
2ba5dd1344
Reduce debug messages 2018-03-25 13:26:02 +08:00
Chocobo1
61eddfce90
Refactor functions in FileSystemWatcher 
Use c++11 range-loop
Add const
Better ifdef placement
Inline functions
 2018-03-25 13:26:02 +08:00
Chocobo1
0840556f77
Do cleanups in FileSystemWatcher 
Use Qt5 connect syntax
Sort headers
Add license
Add anonymous namespace
Replace macro defines with const variables
 2018-03-25 13:25:28 +08:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern 
Don't create temporary containers just to iterate over them
 2018-03-19 13:06:01 +03:00
Vladimir Golovnev
a8dbff06a3
Merge pull request #8607 from glassez/rss 
Process loaded RSS articles in case of parsing error
 2018-03-19 09:35:30 +03:00
Vladimir Golovnev (Glassez)
d9cd5d4680
Resolve (X)HTML entities in RSS content 
Many sites include various HTML entities in the content of RSS feeds.
The most of these entities are not declared in the underlying XML,
so the documents are considered by parser to be malformed.
This patch allows you to successfully parse such soft-malformed
RSS feeds.
Closes #8527.
Closes #8569.
 2018-03-18 18:59:55 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them 
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.

Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.

Found using clazy.
 2018-03-18 16:22:12 +03:00
Vladimir Golovnev (Glassez)
8d285c66aa
Process loaded RSS articles in case of error 
For some reason, the RSS feed may contain malformed XML data and it may not be
successfully parsed by the XML parser. We are still trying to load as many articles
as possible until we encounter corrupted data. So we can have some articles even in
case of parsing error.
Closes #8527.
Closes #8569.
 2018-03-16 18:29:38 +03:00
Chocobo1
423511765a
Fix typo 2018-03-14 23:37:08 +08:00
Mike Tzou
e78b5202bc
Merge pull request #8585 from Chocobo1/lint 
Fix compiler/clazy warnings
 2018-03-13 22:36:10 +08:00
Vladimir Golovnev
931af6c97e
Merge pull request #8313 from Piccirello/search-categories 
Calculate search categories based on selected plugin
 2018-03-12 14:29:51 +03:00
Vladimir Golovnev
cea2948593
Merge pull request #8556 from Piccirello/compiler-warnings 
Fix missing initializer warning during build
 2018-03-12 14:28:38 +03:00
Thomas Piccirello
7278625f53 Calculate supported categories based on selected plugin 2018-03-12 01:33:45 -04:00
Thomas Piccirello
7b3e692f68 Fix missing initializer warning 
This issue occurs when using gcc versions < 5.
 2018-03-12 01:21:21 -04:00
Chocobo1
fdb0d97b28
Remove unused function 2018-03-11 23:27:04 +08:00
Chocobo1
141a2d2856
Prevent detach from containers 2018-03-11 22:25:07 +08:00
Mike Tzou
7233274110
Merge pull request #8562 from Chocobo1/lint 
Fix warnings from clazy
 2018-03-11 12:41:58 +08:00
Vladimir Golovnev
4f206f987a
Merge pull request #8561 from glassez/tracker 
Properly reply to announce request
 2018-03-10 17:08:29 +03:00
Vladimir Golovnev (Glassez)
dfddda57b9
Properly reply to announce request 2018-03-09 17:41:06 +03:00
Chocobo1
b4f23d8154
Use faster code path 
From Qt doc: Using this function is faster than using QFileInfo(file).exists() for
file system access.
 2018-03-09 01:34:35 +08:00
Chocobo1
ed310c2dac
Avoid temporary QString allocations 
Fix up 0457fd260e
 2018-03-09 01:34:35 +08:00
Chocobo1
50167d40d7
Allow ADL lookup for helper function 2018-03-09 01:34:19 +08:00
Mike Tzou
5261d4375f
Merge pull request #8551 from Chocobo1/override 
Fix warnings from linters
 2018-03-09 00:36:52 +08:00
Chocobo1
0457fd260e
Avoid temporary QString allocations 
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
 2018-03-07 20:06:00 +08:00
Vladimir Golovnev (Glassez)
1aca3b0adc
Parse URL query string at application level 2018-03-04 17:08:48 +03:00
Vladimir Golovnev (Glassez)
34295a78f2
Move ByteArray utils into Utils::ByteArray namespace 2018-03-02 17:23:21 +03:00
Mike Tzou
57163612ff
Merge pull request #8427 from Chocobo1/server2 
Rewrite RequestParser
 2018-03-02 16:07:12 +08:00
Mike Tzou
55c3db339b
Merge pull request #8455 from Chocobo1/large_torrent 
Fix loading very large torrents. Closes #8449
 2018-03-01 13:22:43 +08:00
Vladimir Golovnev
b26eb3d146
Merge pull request #8373 from glassez/search 
Improve Search handling
 2018-02-28 10:46:33 +03:00
Vladimir Golovnev
7cb6100c9c
Merge pull request #8471 from luis-pereira/use-qstring-ref 
Don't create temporary substrings
 2018-02-28 10:44:59 +03:00
Luís Pereira
0e421ae415 Don't create temporary substrings 
Avoid temporary string allocations. They are only used to convert to
something else.
QString::xxxRef() returns a QStringRef. QStringRef avoids the memory
allocation and reference counting overhead of a standard QString by simply
referencing a part of the original string.
 2018-02-26 11:39:36 +00:00
Vladimir Golovnev
6207855f3b
Merge pull request #8372 from thalieht/inactiverate 
Expose the libtorrent fields for "dont_count_slow_torrents" to GUI.
Closes #5713.
 2018-02-24 14:13:39 +03:00
Vladimir Golovnev
a65a70ab48
Merge pull request #8479 from thalieht/ratioLimitsCrash 
Fix possible crash when using both share limits
 2018-02-24 14:11:09 +03:00
Vladimir Golovnev (Glassez)
279bce2014
Make SearchManager singleton 2018-02-23 20:26:32 +03:00
Vladimir Golovnev (Glassez)
f3d370870d
Improve Search handling 
Legacy SearchEngine class really has three roles:
  1. Manage search plugins,
  2. Handle the search job, and
  3. Handle the download of the torrent file using the search plugin.
Now it is splitted into 3 classes: SearchManager, SearchHandler and
SearchDownloadHandler.
Search GUI is also improved.
 2018-02-23 20:15:25 +03:00
thalieht
0e30659c26 Fix possible crash when using both share limits 
Avoid possible crash in "torrent->name()" when processing seeding time of the torrent that already reached the ratio limit.
 2018-02-23 17:13:56 +02:00
Chocobo1
f34dfca5e6
Enable Http/1.1 persistence connection 
This enables reusing existing TCP connection instead of opening a new connection
for every request
 2018-02-23 14:46:22 +08:00
Chocobo1
cec68c3fd7
Rewrite RequestParser 
* Add more checks and also more strict checks for invalid conditions
* Add http version field
* Raise max request size to 64 MB
* Add author in license
* Use Qt5 new connect syntax
 2018-02-23 14:46:17 +08:00
Vladimir Golovnev
5c2f698cb4
Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach 
Prevent possible c++11 range-loop container detach
 2018-02-22 16:28:04 +03:00
Chocobo1
f5fc2d52b8
Fix loading very large torrents. Closes #8449. 
`torrent_info` constructor has default limits that can't be changed via
parameters, so we handle the loading process manually and explicitly
specifiy the limits to `bdecode()`.
The token_limit is also changed to 10000000.
 2018-02-22 18:52:10 +08:00
Luís Pereira
1a913c502b Prevent possible c++11 range-loop container detach 
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.

In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.

For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.

Intended uses:

    QString s = ...;
    for (const auto &ch : qAsConst(s))
          process(ch);

    for (const auto &ch : copyAsConst(funcReturningQString()))
        process(ch);
 2018-02-20 19:28:51 +00:00
Vladimir Golovnev
078982ada6
Merge pull request #8424 from glassez/fix-rss 
Disable Auto TMM when RSS rule has save path. Closes #8411
 2018-02-20 11:13:15 +03:00
Vladimir Golovnev (Glassez)
a0842a1e68
Don't convert POST parameter names to lower-case 2018-02-18 19:57:48 +03:00
Luís Pereira
ea1b0b26b1 Don't implicitly cast iterator to const_iterator 
It prevents detachments:
To illustrate:

QMap<QString, QString> map;
/* code compiles and works fine but find() returns the non-const
   QMap::iterator that detaches!
*/
QMap<QString, QString>::const_iterator it = map.find("girish");

but also some subtle bugs:

QHash<int, int> wrong;
if (wrong.find(1) == wrong.cend()) {
    qDebug() << "Not found";
} else {
    /* find() detached the container before cend() was called, so it
       prints "Found"
    */
    qDebug() << "Found";
}

QHash<int, int> right;
if (right.constFind(1) == right.cend()) {
    qDebug() << "Not found"; // This is correct now !
} else {
    qDebug() << "Found";
}

Enforced by QT_STRICT_ITERATORS definition.
 2018-02-17 17:02:52 +00:00
Vladimir Golovnev (Glassez)
176b2eb18b
Disable Auto TMM when RSS rule has save path 
Closes #8411.
 2018-02-16 14:02:01 +03:00
Vladimir Golovnev
98a1c111b9
Merge pull request #5287 from elFarto/master 
Implement RSS Smart Filter
 2018-02-16 13:43:38 +03:00
Mike Tzou
47048d8410
Merge pull request #8349 from Chocobo1/stats 
Improve stats dialog
 2018-02-16 15:31:01 +08:00
Mike Tzou
882fa7ecd4
Merge pull request #8336 from Chocobo1/coalesce 
Add "Coalesce reads & writes" checkbox in advanced options
 2018-02-16 15:30:17 +08:00
Vladimir Golovnev
d07ece53e6
Merge pull request #7610 from glassez/webapi2 
Redesign Web API
 2018-02-16 10:09:35 +03:00
Luís Pereira
44e4b5d238 Don't use qDeleteAll() on temporaries 
qDeleteAll() is being used on an unnecessary temporary container created
by QHash::values().
Using qDeleteAll(mycontainer) instead.
 2018-02-12 16:36:03 +00:00
thalieht
f50b4724a6 Expose the libtorrent fields for "dont_count_slow_torrents" to GUI: 
inactive_down_rate
inactive_up_rate
auto_manage_startup
 2018-02-08 14:14:39 +02:00
Stephen Dawkins
48cbccff1e Made smart episode filter regular expression configurable 2018-02-05 19:23:11 +00:00
Chocobo1
b9ec216aa5
Redefine CacheStatus.readRatio field. 
Now it is defined as:
CacheStatus.readRatio = (blocks read from cache) / (blocks read from disk + blocks read from cache)
The 2 variables in denominator are counted separately and the formula before this change doesn't really make sense

Add percentage sign to "Read cache hits" stats
Also remove redundant header include
 2018-02-02 23:41:42 +08:00
Chocobo1
543cbc6d1c
Add "Coalesce reads & writes" checkbox in advanced options 
The setting is defaulted to ON for Windows. Closes #8295.
 2018-01-30 22:46:14 +08:00
Vladimir Golovnev (Glassez)
27d8dbf13b
Redesign Web API 
Normalize Web API method names.
Allow to use alternative Web UI.
Switch Web API version to standard form (i.e. "2.0").
Improve Web UI translation code.
Retranslate changed files.
Add Web API for RSS subsystem.
 2018-01-28 19:16:24 +03:00
Stephen Dawkins
2845a791d0 Initial implementation of Smart Filter feature 2018-01-27 09:14:36 +00:00
Vladimir Golovnev (Glassez)
0fc1ad664f
Implement Qt wrapper for std::runtime_error 2018-01-23 11:08:41 +03:00
Vladimir Golovnev (Glassez)
bb683bd393
Switch built-in Web UI html to HTML5 2018-01-23 11:08:37 +03:00
Vladimir Golovnev (Glassez)
69df8174b9
Allow to load TorrentInfo from data buffer 2018-01-23 11:08:32 +03:00
Vladimir Golovnev
0a45fc9ffe
Merge pull request #7990 from Piccirello/subnet-whitelist-refactor 
Refactor ip subnet whitelist
 2018-01-23 10:03:00 +03:00
Vladimir Golovnev (Glassez)
1c18edac76
Remove legacy and corrupted RSS settings 2018-01-21 20:01:56 +03:00
Chocobo1
fb698896c9
Fix translation context. 
Partially addresses #8220.

Also sort include headers
 2018-01-07 23:01:22 +08:00
Chocobo1
ec337a8a84
Sort filename lists in .pri files 2017-12-31 11:53:45 +08:00
Mike Tzou
267362a7a0
Merge pull request #7876 from Chocobo1/optionIcons 
Fix gui issues on high DPI monitor
 2017-12-31 11:42:55 +08:00
Vladimir Golovnev (Glassez)
22bdf98617
Don't process new/updated RSS rules when disabled 2017-12-27 20:01:40 +03:00
Chocobo1
27cf98a962
Resize dialog size on high DPI monitors 2017-12-24 21:54:56 +08:00
Chocobo1
aaaa67050c
Fix gui issues on high DPI monitor 
Fix LineEdit widget size issues
Up-scale the icons on statusbar
Up-scale the icons in options dialog. Closes #7729.
Fix small icons in cookie manager
Fix progress bar height
Fix small icons in confirm delete dialog
Fix small icons in options dialog
Fix small images in about dialog
 2017-12-24 21:47:46 +08:00
sledgehammer999
b11c33b2d9
Merge pull request #8068 from thalieht/readableFlags 
Make peer information flags in peerlist more readable
 2017-12-23 19:33:19 +02:00
sledgehammer999
cf9bad03aa
Fix application of speed limits on LAN and μTP connections. Closes #7745. 2017-12-23 19:19:08 +02:00
sledgehammer999
c5127d2eec
Merge pull request #8091 from sledgehammer999/fix_natural_sort 
Fix natural sorting
 2017-12-23 19:16:29 +02:00
sledgehammer999
5437974b85
Fix natural sorting when the common part of 2 strings ends partially in a number which continues in the uncommon part. 
Closes #8080 #6732.
 2017-12-21 17:00:37 +02:00
thalieht
5b52835377 Make peer information flags in peerlist more readable 2017-12-20 11:22:23 +02:00
Chocobo1
8dcf326576
Add source field in Torrent creator. Closes #7965. 
This field is often used for cross-seeding between (private) trackers.
 2017-12-09 00:39:50 +08:00
Thomas Piccirello
240f5b6718 Remove invalid subnets directly from list 2017-12-06 20:32:50 -05:00
Thomas Piccirello
d184bd8c82 Perform ip string validation inside setWebUiAuthSubnetWhitelist 2017-12-06 02:05:33 -05:00
Chocobo1
c405cb2f1c
Add struct TorrentCreatorParams for passing parameters 
Filter out continuous newlines in Trackers field
Avoid adding empty url seed entries

Cleanup:
  Replace boost::bind
  Add const
  Use nullptr
  Use QString::SkipEmptyParts
  Rename variables
  Throw proper exception type
 2017-12-06 01:56:36 +08:00
Chocobo1
c1a282aa7b
Fix missing qbt logo on login page in webUI. Closes #7953. 2017-12-02 14:31:48 +08:00
Mike Tzou
eac8838dc2
[GUI] Implement stable sort (#7703) 
* NaturalCompare now returns compare result instead of "less than" result
* Change to stable sort in GUI components
* Add Utils::String::naturalLessThan() helper function
* Use Qt::CaseSensitivity type
 2017-11-30 17:10:30 +08:00
sledgehammer999
a55be5e58f
Stop logging IP filter parsing errors after a while. 
When a lot of errors happen the resulting log lines introduce
a huge slowdown of the GUI, due to writing each log line to disk.

Closes #7755.
 2017-11-29 15:49:59 +02:00
sledgehammer999
48c46dc79a
Fix crash on some systems when creating address object for 255.255.255.255 
Closes #7735.
 2017-11-27 19:06:37 +02:00
Vladimir Golovnev
a7da714b13
Merge pull request #7832 from glassez/rss-import 
Implement Import/Export RSS rules. Closes #7721
 2017-11-25 10:35:24 +03:00
Vladimir Golovnev (Glassez)
916cfcdb03
Implement Import/Export RSS rules in JSON format 2017-11-24 21:20:44 +03:00
Vladimir Golovnev (Glassez)
b8fc415870
Implement Import/Export RSS rules in legacy format 2017-11-24 16:19:16 +03:00
Vladimir Golovnev
342f5f1a09
Merge pull request #7821 from glassez/fix-rss 
Fix RSS Parser. Closes #7751, #7763, #7768, #7786
 2017-11-23 14:35:42 +03:00
sledgehammer999
d74efd839f
Merge pull request #7826 from Chocobo1/tcp 
Change MixedModeAlgorithm default to TCP. Closes #7779.
 2017-11-23 01:53:29 +02:00
Vladimir Golovnev (Glassez)
c0e48627ae
Fix RSS Parser 
Closes #7751
Closes #7763
Closes #7768
Closes #7786
 2017-11-22 19:11:37 +03:00
Chocobo1
534ed91d04
Change MixedModeAlgorithm default to TCP. Closes #7779. 
MixedModeAlgorithm::Proportional will throttle TCP connections when utp
is in use and users is expecting maximum speed no matter what, so now
disable the throttling.
 2017-11-22 22:39:52 +08:00
thoradia
ca5c1e8a15 Fix missing include in rss_feed.cpp 
Fixes #7805.
 2017-11-22 14:39:07 +01:00
Chocobo1
433b5a46cf
Fix crash when aborting a torrent creation process. Closes #7783. 
The wait time wasn't long enough causing the thread to
terminate prematurely.
Also, to avoid crashing qbt entirely when creating a torrent for a very
big file, I decided to wait indefinitely here.
 2017-11-21 18:33:47 +08:00
Chocobo1
034d71dce3
Wrap function into anonymous namespace 2017-11-21 18:23:39 +08:00
sledgehammer999
4927d26877
Fix english typo. 2017-11-21 02:14:44 +02:00
Vladimir Golovnev
f41cb8089d
Merge pull request #6779 from Piccirello/disable-web-auth 
Add ip subnet whitelist for bypassing webui auth
 2017-11-20 21:52:33 +03:00