mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-06 23:27:28 +03:00
Code Issues Projects Releases Packages Wiki Activity
9544 commits 16 branches 245 tags 255 MiB
Commit graph

1245 commits

Author SHA1 Message Date
Vladimir Golovnev (Glassez)
c1a4ef1377
Use independent translation for WebUI 2018-10-09 11:10:08 +03:00
Vladimir Golovnev (Glassez)
becb002d87
Create WebUI translation update tool 2018-10-09 11:10:07 +03:00
Thomas Piccirello
6d619e9491 Add categories WebAPI 
Closes #5330.
 2018-10-07 14:52:34 -04:00
Mike Tzou
5aaa51881e
Merge pull request #9614 from Piccirello/js-defects 
Fix minor JavaScript defects
 2018-10-02 10:19:47 +08:00
Thomas Piccirello
0b6ae68801 Add WebUI search API controller 
Closes #2495.
 2018-09-30 20:07:27 -04:00
Thomas Piccirello
1e6942e967 Fix minor JavaScript defects 2018-09-26 23:10:51 -04:00
Thomas Piccirello
65934a4c69 Add locale to js file path 
This reduces the likelihood of a cached file being used after the locale is changed.
 2018-09-23 16:27:47 -04:00
Thomas Piccirello
7b85473d2b Translate WebUI torrents Status column 
Closes #9554.
 2018-09-22 18:13:47 -04:00
sledgehammer999
bdc788c824
Bump Web API version 2018-09-16 09:37:32 +03:00
Vladimir Golovnev
28a6ac3197
Merge pull request #9228 from Piccirello/addCategory 
Add save path and category editing to WebUI
 2018-09-13 19:43:28 +03:00
Mike Tzou
5cb41c3c2d
Merge pull request #9387 from Piccirello/webui-pref-tweaks 
Minor WebUI visual changes
 2018-09-08 14:51:26 +08:00
Thomas Piccirello
fef1ad6083 Allow WebUI sidebar filters to be hidden 2018-09-05 02:40:33 -04:00
Thomas Piccirello
c10d237f7a Don't disable DHT when using force proxy 
Closes #9292
 2018-09-02 19:48:03 -04:00
Thomas Piccirello
adad883eb6 Increase WebUI Options initial height 2018-08-31 11:38:17 -04:00
Thomas Piccirello
b05a443cad Adjust WebUI Options form alignment 2018-08-31 11:38:10 -04:00
Thomas Piccirello
63c53766b4 Add save path and editing to WebUI new category dialog 2018-08-31 11:27:05 -04:00
Thomas Piccirello
a0e6007fc1 Include category save path in web api sync data 2018-08-18 22:04:21 -04:00
Thomas Piccirello
d89ef22d85 Require torrent category creation to be explicit 2018-08-18 22:04:21 -04:00
Chocobo1
71dcc76a64
Replace png icons with svg 2018-08-14 17:03:14 +08:00
sledgehammer999
ac1839fa6b
Bump Web API version 2018-08-12 21:08:42 +03:00
Mike Tzou
8dae7f4a87
Merge pull request #9229 from Piccirello/forceReannounce 
Add WebUI Force Reannounce option
 2018-07-31 00:19:34 +08:00
Thomas Piccirello
13075e5099 Send all rechecks in one request 2018-07-22 20:33:39 -04:00
Thomas Piccirello
cdad0dc7d3 Add WebUI Force Reannounce option 2018-07-22 20:33:17 -04:00
Chocobo1
0217d5b4c0
Replace single-character string with character literal 
Also remove unnecessary dynamic allocation.
 2018-07-21 23:26:15 +08:00
Chocobo1
e04aae686f
Cache more preference values 
These values from Preference class are frequently used.
Also group related variables together.
 2018-07-14 15:48:18 +08:00
thalieht
456270bbb1 Delete several unused #include 2018-07-03 08:38:32 +03:00
Goshik
1daadfc4ec Create non-existing path in setLocationAction() 
When using qbittorrent-nox it is not always possible to manually create
the target path for torrent moving. This commit allows automatic path
creation. It also allows to display error messages in the
'Set location' window.
 2018-06-19 14:10:11 +03:00
Mike Tzou
40f4223d02
Merge pull request #9083 from Chocobo1/qrc 
Move files to where it belongs
 2018-06-18 00:51:19 +08:00
Vladimir Golovnev
7d9cc04c88
Merge pull request #9090 from thalieht/renamefiles 
Rename files and classes to match them
 2018-06-16 13:08:38 +03:00
Mike Tzou
dc20fff6e4
Merge pull request #9059 from Piccirello/meta-key 
Add WebUI support for Mac ⌘ (Command) key
 2018-06-16 12:21:20 +08:00
thalieht
d34ddb2e3c Change file names and classes names to match them 2018-06-15 20:12:59 +03:00
Vladimir Golovnev
0433d5f074
Merge pull request #9042 from thalieht/codingstyle 
Fix coding style final
 2018-06-13 12:41:56 +03:00
Thomas Piccirello
232f0f4b0b Add WebUI support for Mac ⌘ (Command) key 
The Command key will now be recognized for WebUI Table multi-selection, as Ctrl is.
 2018-06-12 20:32:24 -04:00
Thomas Piccirello
091ad6103e Implement key functions in Class and refactor 2018-06-12 20:32:07 -04:00
Mike Tzou
c66738dc05
Merge pull request #9066 from AltruisticCompany/setlocation 
Show current save path in 'Set location' window
 2018-06-13 02:46:56 +08:00
thalieht
4022799881 Fix coding style 2018-06-12 07:17:05 +03:00
Chocobo1
26a4703398
Move .qrc files into its own directory 2018-06-11 20:01:33 +08:00
Mike Tzou
da87c2d9ae
Merge pull request #9060 from Chocobo1/preinc 
Replace post-increment with pre-increment
 2018-06-09 12:40:30 +08:00
Goshik
682ef9e2a8 Show current save path in 'Set location' window 
The feature is useful when the user needs to move their torrent to a
sub or parent folder. If more than one torrent is chosen, the path
of the first selected torrent is used. The window was made wider to
allow more convenient editing of long paths.
 2018-06-08 18:34:14 +03:00
Chocobo1
5ddbf9bba9
Replace post-increment with pre-increment 
And post-decrement with pre-decrement.
 2018-06-08 08:44:06 +08:00
Eugene Shalygin
04aea413ba
Merge pull request #9055 from zeule/cmake 
Update CMake build scripts
 2018-06-07 21:31:09 +02:00
Eugene Shalygin
fa770871e9 Refactor CMake build scripts 
1. Use FeatureSummary module to show configuration results.

2. Invert option()/find_package() relationship: instead of
calling find_package(... REQUIRED) when option is set, rely on optional
find package call and PackageName_FOUND variable.

3. Refactor handling options that result in simple preprocessor defines
(actually copy the snippet from libtorrent) so that everything is done
in a single function call.

4. Populate target properties in order to get rid of
include_directories() calls.
 2018-06-05 11:39:11 +02:00
Chocobo1
eaa276b284
Fix WebUI cache behavior for css files 
The style.css in public & private folders share the same URI, this
confuses the browser cache, so rename one of them.
 2018-06-04 20:50:09 +08:00
Chocobo1
050b78f378
Send Cache-Control header in WebUI responses 
Tune the caching time to be shorter, in case there is a program
update.
Change the cacheability to private, as WebUI resources are not intended
to be cached at proxy.
For uncacheable responses, send out "no-store" explicitly to halt
browser caching.
 2018-06-04 20:50:08 +08:00
Mike Tzou
5f8feec1c1
Merge pull request #9013 from Piccirello/strengthen-csp 
More restrictive Content Security Policy
 2018-06-03 21:43:39 +08:00
Mike Tzou
c4e4e7432d
Merge pull request #9009 from Chocobo1/login 
Add logging messages in WebUI login action
 2018-06-03 19:47:05 +08:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression 
Revise `static` keyword usage, static is added to frequently used
instances.
 2018-05-31 22:56:49 +08:00
Chocobo1
5c72a52ea2
Reset WebUI ban counter on login success 2018-05-31 22:55:54 +08:00
Chocobo1
d782d62b34
Add logging messages in WebUI login action 2018-05-31 22:55:54 +08:00
Thomas Piccirello
9b874b8941 Rename variables for clarity 2018-05-31 00:54:57 -04:00
Thomas Piccirello
43656aaa1e Add form-action to CSP 
This option restricts all form submissions to the WebUI's origin.
qBittorrent only ever submits forms to the origin, so this is intended as a security measure.
 2018-05-31 00:54:57 -04:00
Thomas Piccirello
8f98f87d12 Add upgrade-insecure-requests to CSP when HTTPS is enabled 
This option automatically upgrades all http connections to https.
It ensures http urls cannot be accessed when in https mode, and is intended as a security measure.
 2018-05-31 00:54:57 -04:00
Chocobo1
e8d378e167
Improve WebUI security measures 
CSP was erroneously disabled in bad4d94f77
when clickjacking protection is off, now it is back.
Also added CSP 'frame-ancestors' directive when clickjacking
protection is enabled.
 2018-05-29 13:40:52 +08:00
Mike Tzou
4a51f14328
Merge pull request #8967 from Chocobo1/protect 
Add options to control WebUI security measures
 2018-05-28 14:21:53 +08:00
sledgehammer999
6ad8d730cc
Bump Web API version 2018-05-27 19:23:25 +03:00
sledgehammer999
a1a6a7ef56
Merge pull request #8868 from Chocobo1/macos 
Fix GUI scaling factor on macOS
 2018-05-27 17:39:00 +03:00
Mike Tzou
84df2794dc
Merge pull request #8944 from Chocobo1/literal 
Make use of QStringLiteral
 2018-05-23 13:23:41 +08:00
Chocobo1
9eeef0be97
Add option to control CSRF protection 
Some users are using WebUI with simple port-forwarding from their router,
providing an option to control the protection will save them from setting up an
non-trival web proxy.
Closes #7274.
 2018-05-22 12:57:03 +08:00
Chocobo1
bad4d94f77
Add option to control WebUI clickjacking protection 
Some users actually want embedding WebUI into their custom build iframe.
Closes #7370.
 2018-05-22 01:07:25 +08:00
Chocobo1
e8a69dd60c
Update Options dialog layout in WebUI 2018-05-21 23:57:11 +08:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral 
Only changed instances that are initialized at program start.
 2018-05-18 02:14:49 +08:00
Vladimir Golovnev
e157ca2430
Merge pull request #8932 from glassez/rss-settings 
Properly set RSS settings via API. Closes #8925
 2018-05-17 06:07:25 +03:00
Vladimir Golovnev (Glassez)
98ca274169
Rename RSS properties to follow other names 2018-05-15 16:05:51 +03:00
Vladimir Golovnev (Glassez)
2a0b104e5e
Properly set RSS settings via API 
Closes #8925.
 2018-05-15 15:59:28 +03:00
Mike Tzou
3b1fa19ea8
Merge pull request #8895 from Chocobo1/locale 
Apply locale changes immediately in WebUI
 2018-05-15 00:29:45 +08:00
Mike Tzou
a0f200be0d
Merge pull request #8894 from Chocobo1/tr 
Make strings translatable
 2018-05-14 12:53:40 +08:00
Vladimir Golovnev
7afbc346d5
Merge pull request #8906 from glassez/fix-webui 
Fix WebUI bugs
 2018-05-13 17:02:24 +03:00
Chocobo1
61e61a1fd5
Rename variables 
Variable name should not start with underscore as C++ standard stated it
is reserved.
 2018-05-13 19:24:59 +08:00
Vladimir Golovnev
8906c47798
Merge pull request #8782 from mj-p/filterByHashes 
Filter torrent info endpoint by hashes
 2018-05-13 13:20:00 +03:00
sledgehammer999
375b15727d
Show rechecking progress 
When having big torrents, the rechecking might take a while to
complete. Users need some sort of feedback that progress is being made.
Also, I changed the float to qreal since that's the return type.
 2018-05-13 12:32:17 +03:00
Chocobo1
5ae926a376
Refactor code 
Add const to variables.
No functionality change.
 2018-05-13 15:05:30 +08:00
Chocobo1
92a4e73a22
Apply locale changes immediately in WebUI 2018-05-13 15:05:29 +08:00
sledgehammer999
565ffa7d1e
Add 'Moving' state for torrents being relocated/moved 
This is another indication to the user that something is happening
behind the scenes.
Uses the same icon/color as "Checking" status.
Torrents in the `Moving` state are considered as "Active". This should
prevent accidental program exit from the user and inhibit system sleep.
 2018-05-12 20:49:33 +03:00
Vladimir Golovnev (Glassez)
88f2a66aac
Fix params handling for some legacy API methods 
Closes #8880.
 2018-05-12 07:35:35 +03:00
Vladimir Golovnev (Glassez)
0fda49c060
Improve legacy API params handling 2018-05-12 07:35:31 +03:00
Vladimir Golovnev (Glassez)
afcf232bd8
Fix invalid API calls in WebUI 
Closes #8899.
 2018-05-12 07:35:27 +03:00
Chocobo1
b1304057ec
Fix i18n in WebUI 
Closes #8844.
 2018-05-11 20:20:51 +08:00
thalieht
20ca90800d Fix coding style 2018-05-09 17:06:22 +03:00
Chocobo1
0b63f35a54
Use 32px icons for favicon 
One less resource to manage and 16px size can be downsampled from 32px
on-the-fly anyway.
 2018-05-09 15:53:34 +08:00
Mike Tzou
99a1343b9d
Merge pull request #8862 from Chocobo1/cleanup 
Code cleanups
 2018-05-09 14:33:49 +08:00
Vladimir Golovnev
3a0e5e51df
Merge pull request #8761 from thalieht/nullptr 
Replace the zeroing of pointers with nullptr
 2018-05-08 17:10:37 +03:00
Chocobo1
c0df292567
Remove debug messages 2018-05-08 12:18:18 +08:00
Vladimir Golovnev (Glassez)
85dd446198
Fix wrong API method names 
Closes #8828.
 2018-05-07 17:46:01 +03:00
Marcel Petersen
fc58e8a0c6 Filter torrent info endpoint by hashes 
Added hashes parameter to info action.
Allows filtering seralized torrents by passing it into the TorrentFilter.
 2018-05-02 10:07:48 +02:00
Chocobo1
8b575484e6
Fix path separator in log messages 2018-04-24 01:02:54 +08:00
Vladimir Golovnev (Glassez)
001bd38557
Fix pauseAll/resumeAll legacy API methods 
Closes #8766.
 2018-04-20 14:30:25 +03:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
Mike Tzou
a70942ed53
Merge pull request #8598 from Piccirello/limit-share-ratio 
WebUI Add Limit Share Ratio context menu option
 2018-04-15 00:39:27 +08:00
Mike Tzou
1055cc0f45
Merge pull request #8691 from Chocobo1/js 
Partially revert "Remove unused JavaScript library"
 2018-04-12 00:07:37 +08:00
Thomas Piccirello
9f36b54b04
WebUI Add Limit Share Ratio context menu option 
Closes #6815, #7602.
 2018-04-11 23:45:54 +08:00
Thomas Piccirello
1f42ab8c4f
Remove unused/superfluous variables 2018-04-11 23:45:54 +08:00
Thomas Piccirello
3f0fbc0810
WebUI rename property to match its definition 2018-04-11 23:45:54 +08:00
Mike Tzou
fa380c8b2c
Merge pull request #8622 from Chocobo1/formatter 
Unify coding style for WebUI files
 2018-04-10 14:51:32 +08:00
Vladimir Golovnev (Glassez)
cb505a07fe
Fix setting preferences via WebAPI 
Closes #7335.
 2018-04-09 18:54:43 +03:00
Chocobo1
cf2c0bd47e
Apply formatting to Web UI files 2018-04-07 21:45:56 +08:00
Chocobo1
208d21ff73
Add js-beautify config 
Try to standardize coding style for HTML & JavaScript via this tool
 2018-04-05 12:19:54 +08:00
Chocobo1
2df71dbde5
Partially revert "Remove unused JavaScript library" 
This reverts commit 470e993c2d.
 2018-04-05 03:22:34 +08:00
Chocobo1
470e993c2d
Remove unused JavaScript library 2018-04-02 01:34:49 +08:00
Chocobo1
cbf10ebb7f
Update clipboard.js to v2.0.0 2018-04-02 01:34:49 +08:00
Chocobo1
89f06274bb
Move JavaScript libraries to its own folder 2018-04-02 01:34:43 +08:00
Chocobo1
ed03456999
Update WebUI to be more compliant with HTML5 standard 
Use modern and shorter "charset" attribute.
Remove "type", "charset" attributes in script/style tags, these are redundant in HTML5.
 2018-03-23 00:04:43 +08:00
Thomas Piccirello
a15cfae03a Fix spacing 2018-03-21 00:04:21 -04:00
Thomas Piccirello
c2a195360a Resolve JavaScript errors 2018-03-21 00:04:21 -04:00
Thomas Piccirello
a4f99995bb Consolidate CSS into style.css 2018-03-21 00:04:18 -04:00
Thomas Piccirello
16616f4e0e Remove unused CSS from WebUI login page 2018-03-20 15:25:04 -04:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern 
Don't create temporary containers just to iterate over them
 2018-03-19 13:06:01 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them 
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.

Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.

Found using clazy.
 2018-03-18 16:22:12 +03:00
Mike Tzou
68ca95faf0
Merge pull request #8603 from Chocobo1/typo 
Fix typo
 2018-03-17 00:49:41 +08:00
Mike Tzou
1f28122428
Merge pull request #8595 from Chocobo1/runExt 
Add Tags parameter to "Run External Program"
 2018-03-16 19:37:34 +08:00
Chocobo1
423511765a
Fix typo 2018-03-14 23:37:08 +08:00
Thomas Piccirello
4863078744 Use correct API method URL in WebUI 
Fix up 27d8dbf.
Closes #8596.
 2018-03-14 03:08:46 -04:00
Chocobo1
88881de8c6
Add Tags parameter to "Run External Program" 
Closes #8586.
Also sort headers.
 2018-03-14 10:12:32 +08:00
Chocobo1
141a2d2856
Prevent detach from containers 2018-03-11 22:25:07 +08:00
Mike Tzou
7233274110
Merge pull request #8562 from Chocobo1/lint 
Fix warnings from clazy
 2018-03-11 12:41:58 +08:00
Mike Tzou
0cacd71503
Merge pull request #8403 from Piccirello/webui-download-height 
Make WebUI iframe windows scrollable on iOS. Closes #8401, #7932.
 2018-03-09 19:46:29 +08:00
Chocobo1
fdf3ebbb6c
Remove usage of deprecated functions 
Also use proper type for storing date/time data
 2018-03-09 19:20:58 +08:00
Mike Tzou
5261d4375f
Merge pull request #8551 from Chocobo1/override 
Fix warnings from linters
 2018-03-09 00:36:52 +08:00
Thomas Piccirello
0b56cd5fa0 Make WebUI iframe windows scrollable on iOS 
Closes #8401, #7932.
 2018-03-08 01:30:13 -05:00
Vladimir Golovnev
e22946ef61
Merge pull request #8525 from glassez/url-query 
Parse URL query string at application level
 2018-03-07 17:16:21 +03:00
Chocobo1
0457fd260e
Avoid temporary QString allocations 
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
 2018-03-07 20:06:00 +08:00
Chocobo1
c60b7b213e
Add missing 'override' specifier 
This fixes clang warning:
'notify' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
 2018-03-07 20:05:52 +08:00
Chocobo1
307736e263
Fix broken WebUI 
Fix up c47e4efade.
Closes #8545.
 2018-03-06 14:03:01 +08:00
Mike Tzou
7aa5bc4bc1
Merge pull request #8484 from Piccirello/improve-webui-stats 
Improve WebUI stats dialog (addendum to #8349)
 2018-03-06 00:49:49 +08:00
Thomas Piccirello
c47e4efade Save WebUI Statistics window size 2018-03-05 01:40:21 -05:00
Vladimir Golovnev (Glassez)
1aca3b0adc
Parse URL query string at application level 2018-03-04 17:08:48 +03:00
Tom Piccirello
1a9b009951 Enable Statistics window to be scrolled and resized 
Text may go offscreen due to translations.
 2018-03-02 02:18:42 -05:00
Vladimir Golovnev (Glassez)
34456a7459
Fix Legacy Web API to be fully available 2018-02-28 18:25:48 +03:00
Mike Tzou
6f7f7d87c6
Merge pull request #8218 from Piccirello/webui-selection-bug 
Reselect webui torrents after full_update. Temporary fix for #8209.
 2018-02-27 13:33:39 +08:00
Thomas Piccirello
2227c3afc1 Reselect torrents in WebUI after full update 
Temp fix for #8209.
 2018-02-25 01:09:06 -05:00
Mike Tzou
050af8a793
Merge pull request #7894 from Piccirello/auto-management 
Disable options when Force Proxy is enabled
 2018-02-25 01:44:58 +08:00
Thomas Piccirello
4110bb874f Right align stat values 2018-02-23 14:54:31 -05:00
Thomas Piccirello
5c74f374af Re-order and rename stats 2018-02-23 14:54:24 -05:00
Thomas Piccirello
a8420a43f9 Format Read cache hits as percentage 2018-02-23 14:46:47 -05:00
Vladimir Golovnev
5c2f698cb4
Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach 
Prevent possible c++11 range-loop container detach
 2018-02-22 16:28:04 +03:00
Luís Pereira
1a913c502b Prevent possible c++11 range-loop container detach 
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.

In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.

For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.

Intended uses:

    QString s = ...;
    for (const auto &ch : qAsConst(s))
          process(ch);

    for (const auto &ch : copyAsConst(funcReturningQString()))
        process(ch);
 2018-02-20 19:28:51 +00:00
Vladimir Golovnev
3035184d25
Merge pull request #8445 from glassez/fix-webapi 
Fix POST params handling. Closes #8443
 2018-02-20 11:11:33 +03:00
Thomas Piccirello
e0c74c2d39 Remove conditionals 2018-02-20 02:22:40 -05:00
Thomas Piccirello
288f372914 Rename onClick property to onclick 2018-02-20 02:16:16 -05:00
Thomas Piccirello
ba331436fa Add More Information link 2018-02-20 02:16:16 -05:00
Thomas Piccirello
afd4069eb4 Disable options when force proxy is enabled 2018-02-20 02:16:15 -05:00
Vladimir Golovnev
387f9b1230
Merge pull request #8438 from Piccirello/webui-proxy-only 
Add "Use proxy only for torrents" option to webui
 2018-02-20 09:06:30 +03:00
Mike Tzou
b87ca60c5a
Merge pull request #8134 from Piccirello/webui-show-status-bar 
Add option to show/hide webui status bar
 2018-02-20 00:09:09 +08:00
Mike Tzou
6d44075662
Merge pull request #8228 from Piccirello/webui-save-window-size 
WebUI Save user's resized windows
 2018-02-20 00:02:32 +08:00
Thomas Piccirello
69af205094 Use .each(). Refactor conditionals. 2018-02-18 23:54:48 -05:00
Thomas Piccirello
8a2e3f5d93 Add option to show/hide webui status bar 2018-02-18 23:46:27 -05:00
Thomas Piccirello
3f79726ab9 Make download + upload windows resizable 2018-02-18 22:50:21 -05:00
Thomas Piccirello
d1c4b1599a WebUI Save user's resized window sizes 2018-02-18 22:50:21 -05:00
Vladimir Golovnev (Glassez)
29042e4841
Fix wrong WebAPI param name 2018-02-18 19:54:08 +03:00
Thomas Piccirello
0d55599e02 Add "Use proxy only for torrents" option to webui 2018-02-17 21:25:42 -05:00
Luís Pereira
ea1b0b26b1 Don't implicitly cast iterator to const_iterator 
It prevents detachments:
To illustrate:

QMap<QString, QString> map;
/* code compiles and works fine but find() returns the non-const
   QMap::iterator that detaches!
*/
QMap<QString, QString>::const_iterator it = map.find("girish");

but also some subtle bugs:

QHash<int, int> wrong;
if (wrong.find(1) == wrong.cend()) {
    qDebug() << "Not found";
} else {
    /* find() detached the container before cend() was called, so it
       prints "Found"
    */
    qDebug() << "Found";
}

QHash<int, int> right;
if (right.constFind(1) == right.cend()) {
    qDebug() << "Not found"; // This is correct now !
} else {
    qDebug() << "Found";
}

Enforced by QT_STRICT_ITERATORS definition.
 2018-02-17 17:02:52 +00:00
Vladimir Golovnev (Glassez)
27d8dbf13b
Redesign Web API 
Normalize Web API method names.
Allow to use alternative Web UI.
Switch Web API version to standard form (i.e. "2.0").
Improve Web UI translation code.
Retranslate changed files.
Add Web API for RSS subsystem.
 2018-01-28 19:16:24 +03:00
Vladimir Golovnev (Glassez)
bb683bd393
Switch built-in Web UI html to HTML5 2018-01-23 11:08:37 +03:00
Vladimir Golovnev
56ccf28000
Merge pull request #8133 from Piccirello/webui-statistics-format 
WebUI Statistics parity with GUI
 2018-01-23 10:15:39 +03:00
Vladimir Golovnev
0a45fc9ffe
Merge pull request #7990 from Piccirello/subnet-whitelist-refactor 
Refactor ip subnet whitelist
 2018-01-23 10:03:00 +03:00
Tom Piccirello
ebea0d91af Remove default case, fix #8302 2018-01-22 02:05:41 -05:00
Thomas Piccirello
65e0aa6b82 Add default case 2018-01-18 23:30:19 -05:00
Thomas Piccirello
6d0cceca83 Use switch statement 2018-01-18 00:15:13 -05:00
Thomas Piccirello
8e9b928b61 Match webui statuses to gui, closes #7516 2018-01-18 00:15:12 -05:00
sledgehammer999
95c32221a2
Update copyright year. 2018-01-06 02:23:09 +02:00
Thomas Piccirello
9b919b6c34 Add missing units 2018-01-05 02:48:41 -05:00
Thomas Piccirello
49d3b7bf30 Right-align stat values 2018-01-05 02:48:41 -05:00
Chocobo1
ec337a8a84
Sort filename lists in .pri files 2017-12-31 11:53:45 +08:00
Thomas Piccirello
ddd6c82dd7 Use https for www.qbittorrent.org 2017-12-26 18:22:03 -05:00
Vladimir Golovnev
155dc49c5a
Merge pull request #7914 from Piccirello/webui-columns 
Webui add torrent columns to match gui
 2017-12-26 22:03:07 +03:00
sledgehammer999
94b64884f8
Merge pull request #7997 from Piccirello/webui-content-columns 
Add "Remaining" and "Availability" columns to webui Content tab
 2017-12-23 20:32:46 +02:00
Chocobo1
fb6bdbefd5
WebUI: Only prepend scheme when it is not present. Closes #8057. 2017-12-18 14:12:31 +08:00
Thomas Piccirello
0f6dff6315 Make value formatting consistent with GUI 2017-12-12 01:25:06 -05:00
Thomas Piccirello
97b4e4a3d3 Add "Remaining" and "Availability" columns to webui Content tab 2017-12-12 01:25:06 -05:00
Vladimir Golovnev (Glassez)
fcde1ba09c
Fix WebUI is not reachable via IPv6 2017-12-09 09:57:19 +03:00
Thomas Piccirello
d184bd8c82 Perform ip string validation inside setWebUiAuthSubnetWhitelist 2017-12-06 02:05:33 -05:00
Thomas Piccirello
a05562cdc5 Add Time Active column 2017-12-03 15:01:35 -05:00
Thomas Piccirello
ee37f1db3d Add Tags columns 2017-12-03 15:01:35 -05:00
sledgehammer999
2124ef261a
Merge pull request #7964 from Chocobo1/typeError 
[WebUI] Fix logout behavior
 2017-12-02 14:23:38 +02:00
Chocobo1
b234fcec9c
[WebUI] Use POST for logout command 
This is to avoid browser being smart to prefetch the link then logging
out the user.
 2017-12-02 14:32:40 +08:00
Chocobo1
1a45145c1e
[WebUI] Add check to avoid type error after logout 2017-12-02 14:32:40 +08:00
Chocobo1
c1a282aa7b
Fix missing qbt logo on login page in webUI. Closes #7953. 2017-12-02 14:31:48 +08:00
Thomas Piccirello
e1f8e6aa6f Reposition Total Size column to match gui 2017-11-26 19:37:20 -05:00
sledgehammer999
4e96a1065e
Bump API_VERSION to 16. 2017-11-22 01:14:33 +02:00
Chocobo1
27090f0cfb
Remove superfluous QString::fromUtf8() 2017-11-21 22:48:00 +08:00
Chocobo1
77f66be493
[WebUI] Fix logo missing in login page 2017-11-21 03:41:07 +08:00
Vladimir Golovnev
f41cb8089d
Merge pull request #6779 from Piccirello/disable-web-auth 
Add ip subnet whitelist for bypassing webui auth
 2017-11-20 21:52:33 +03:00
sledgehammer999
af5a02d971
Merge pull request #7673 from sledgehammer999/webui_clean_exit 
WebUI: Correctly exit depending if mainloop is running.
 2017-11-19 19:12:30 +02:00
Vladimir Golovnev (Glassez)
71bb6538db
Fix WebUI error handling 2017-11-19 19:10:04 +02:00
Mike Tzou
d821bdc9f3
Merge pull request #7669 from Chocobo1/portCheck 
[WebAPI] Improve error messages
 2017-11-10 23:41:19 +08:00
Thomas Piccirello
95bf63330e Add ip subnet whitelist for bypassing webui auth 2017-11-08 22:39:49 -05:00
sledgehammer999
ffa6f7ea34
Bump API_VERSION to 16. 2017-11-03 01:57:32 +02:00
Chocobo1
aa4107478e
[WebAPI] Improve error messages 
Also refactor to use class methods
 2017-11-02 23:01:14 +08:00
Chocobo1
fc0628d35b
Allow SMTP sender to be set. Closes #7575. 2017-10-26 17:57:32 +08:00
Mike Tzou
acdb7a27dc Merge pull request #7638 from Chocobo1/msg 
[WebUI] Improve log messages
 2017-10-24 20:19:12 +08:00
Mike Tzou
b6be5afb89 Merge pull request #7584 from Chocobo1/refactor 
[WebAPI] Refactor
 2017-10-23 19:36:28 +08:00
Chocobo1
157b809e21
[WebUI] Improve log messages 2017-10-23 16:45:41 +08:00
Mike Tzou
f74e2b0130 Merge pull request #7631 from Chocobo1/webUIaddr 
Reinitialize webUI server when "IP address" setting changed
 2017-10-23 14:11:50 +08:00
sledgehammer999
c887a162ba
Fix row height/width in webui for country flags. 
Patch by Chocobo1.
 2017-10-23 01:23:54 +03:00
sledgehammer999
52df71ad3a
Use svg icons for the country flags. 
Closes #6223.
 2017-10-23 01:23:45 +03:00
Chocobo1
d6ddc90199
Reinitialize webUI server when "IP address" setting changed 
An app restart won't be necessary from now on.
 2017-10-22 14:42:51 +08:00
Mike Tzou
9600e7f5ad Merge pull request #7573 from fmatthew5876/config_webui_ip 
Add WebUi\Address config option
 2017-10-22 14:18:08 +08:00
Matthew Fioravante
8cd243b06b Add WebUi\Address config option 2017-10-21 09:32:30 -04:00
Chocobo1
ce362f0e5e
WebAPI refactor: utilize parseBool() function 
Coding style cleanup
Rename variable
Return const reference
Add const
 2017-10-18 22:27:59 +08:00
Chocobo1
4940a77d12
[WebUI]: Print error messages upon receiving invalid header fields 2017-10-18 20:11:53 +08:00
Mike Tzou
bd07cb91bb Merge pull request #7571 from Chocobo1/webui_download 
[WebAPI] Add parameters for /command/download & /command/upload
 2017-10-15 20:32:14 +08:00
Mike Tzou
dc600d47ec Merge pull request #7570 from Chocobo1/webui_fileIdx 
[WebAPI] Add file-to-piece-index mappings in /query/propertiesFiles command
 2017-10-14 01:05:00 +08:00
Chocobo1
e78d8b9fcc
Convert tab into whitespaces 2017-10-11 20:27:19 +08:00
Chocobo1
f350977cb4
WebUI: add optional parameters for /command/download & /command/upload 
Specifically:
torrent name: string
download limit, upload limit: number in bytes, default: -1 (unlimited)
sequential download, first last piece prio: boolean true/false, default: false
 2017-10-11 20:25:11 +08:00
Eugene Shalygin
7a652c0a8c Merge pull request #7566 from evsh/themes-cbc 
Themes part 1
 2017-10-11 10:34:56 +02:00
Chocobo1
a652baadb5
Add file-to-piece-index mappings in /query/propertiesFiles command 
Also do the following cleanups:
  Use string constant QB_EXT
  Remove redundant variable
  Add const
 2017-10-11 16:24:29 +08:00
Mike Tzou
e07501252c Merge pull request #7549 from fmatthew5876/master 
Report TCPServer errorString() if webui fails to listen to port
 2017-10-11 16:22:52 +08:00
Eugene Shalygin
db35bb54e1 Make BitTorrent::TorrentState strongly-typed enum 
This is needed to forward declare this type and pass it by value.

Conversion from/to QVariant are hanled via Q_DECLARE_METATYPE, while
TorrentState::toString() function was used in webui only and as such is
moved there.
 2017-10-10 21:28:57 +02:00
Chocobo1
5185eeb7ef
Die gracefully when failed to initialize web server with qbt-nox 2017-10-09 13:50:01 +08:00
Vladimir Golovnev
083bc71315 Merge pull request #7396 from thalieht/updownratio 
Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg
 2017-10-08 21:06:55 +03:00
thalieht
525fdd6c2b Coding style, use nullptr and other minor things 2017-10-08 10:20:54 +03:00
Matthew Fioravante
05c92e652c Report TCPServer errorString() if webui fails to listen to port 2017-10-06 05:54:52 +00:00
Vladimir Golovnev
66a6674cbc Merge pull request #7490 from glassez/category-path 
Allow to set explicit save path for Category from GUI
 2017-09-29 14:25:40 +03:00
Vladimir Golovnev (Glassez)
3ec992474d
Implement TorrentCategoryDialog class 2017-09-27 21:25:22 +03:00
Mike Tzou
2eb3ec1a6e Merge pull request #7463 from Piccirello/fix-priority-context-menu-placement 
Reposition "Priority" menu option in WebUI to match gui (closes #7072)
 2017-09-24 10:28:05 +08:00
Chocobo1
c5ddbcfb5b
WebAPI: fix addPaused wrong default behavior 
Add helper function
Sort include header
 2017-09-19 17:26:01 +08:00
Chocobo1
72b0ba36ae
Refactor 
Merge statements
Use case-insensitive contains()
Add const
Use value(), this avoids inserting empty values.
Use range based for loop
 2017-09-19 14:16:39 +08:00
Chocobo1
b107c0671d
WebAPI: fix root_folder default behavior 
Bug was introduced in
6b33db3ae3
 2017-09-19 13:07:50 +08:00
sledgehammer999
b9e233601d Merge pull request #7446 from Chocobo1/utpOnly 
Add uTP only mode option
 2017-09-19 01:45:58 +03:00
Chocobo1
45a0c5558a
Add comboBox for selecting BitTorrent protocol. Closes #6316. 
Use unicode string C_UTP in place of "uTP"
 2017-09-18 01:52:57 +08:00
Thomas Piccirello
b6596f9957 Reposition "Priority" menu option in WebUI to match gui (closes #7072) 2017-09-17 05:42:46 -04:00
thalieht
6b33db3ae3 Create root folder option when adding a torrent in WebUI 2017-09-11 16:56:33 +03:00
Allan Nordhøy
5c18db240c Spelling: HTTP/HTTPS 2017-09-08 11:22:25 +02:00
Chocobo1
64d5e329c0
Sort the resource lists 
Update RCC header
 2017-08-29 13:39:02 +08:00
Chocobo1
9ef1e32327
WebAPI: fix validating wrong header field. Closes #7311. 
X-Forwarded-Host is a foreign proxy setting, it isn't the same as
qbt's local setting and thus it makes no sense to verify it.
 2017-08-20 22:40:19 +08:00
Chocobo1
65ca490b64
Wrap class & functions in anonymous namespace 
Rename vars
Cleanup class interfaces
Pass by reference whenever possible
 2017-08-19 01:57:11 +08:00
Thomas Piccirello
4846b0ec28
Use single quotes for char. 
Use case insensitive compare.
Swap conditionals
 2017-08-14 23:15:03 +08:00
Thomas Piccirello
771033a449
Add auto torrent management to webui context menu (addresses #6815) 2017-08-14 23:14:46 +08:00
Mike Tzou
0522db3f19 Merge pull request #7061 from Piccirello/webui-rename-torrent 
Rename torrent from webui context menu (addresses #6815)
 2017-08-13 23:39:35 +08:00
Vladimir Golovnev (qlassez)
cff6a64e9f
Use qUtf8Printable() for logging strings 
qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments
to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding.
Therefore qUtf8Printable() should be used for logging strings instead of
qPrintable().
 2017-08-13 16:14:57 +03:00
Thomas Piccirello
798c230634
Add option to rename torrent from WebUI 
Addresses #6815.
 2017-08-13 15:45:51 +03:00
Chocobo1
3e9311b096
Correctly handle translation 
Fixup of 07a85a1018
 2017-08-06 17:20:01 +08:00
Chocobo1
1bfb8d35cd
Move "Copy hash" menu item above "Copy magnet link" 
Fix wrong "Copy hash" icon used in webUI
Fixup of 145641ac41
 2017-08-06 17:19:55 +08:00
Tom Piccirello
07a85a1018 Set torrent location from webui context menu (addresses #6815) (#7062) 
* Add option to set torrent location from webui context menu (addresses #6815)

* Update debug messages

* Use logger

* Remove redundant curly braces

* Remove message

* Use log message from transferlistwidget

* Use QDir

* Remove unused import

* Check if newLocation is an empty string
 2017-08-06 17:04:39 +08:00
Tom Piccirello
145641ac41 Add copy options to webui context menu (addresses #6815) (#7036) 
* Add copy options to webui context menu
Add Copy Hash to gui (closes #6964)

* Use switch statement

* Use camel case, switch from signal to qaction.

* Rename variable

* Change variable name
 2017-08-06 16:35:12 +08:00
sledgehammer999
802cd89ec9
Bump API_VERSION and API_VERSION_MIN to 15. 2017-07-18 22:38:59 +03:00
Tom Piccirello
11b44407af Add Status column to webui (addresses #6815) (#7032) 
* Add Status column to webui (addresses #6815)
 2017-07-17 14:26:52 +08:00
Chocobo1
07780b48c5 Load the domain list at least once on startup. 
Fixup of 0532d546d7
 2017-07-13 00:41:30 +08:00
Chocobo1
0532d546d7
Implement HTTP host header filtering 
This filtering is required to defend against DNS rebinding attack.
 2017-07-12 17:26:13 +03:00
Chocobo1
18651c8d01
Use Qt5 connect syntax 2017-07-12 17:26:11 +03:00
Chocobo1
55e038b165
Avoid modifing request headers 2017-07-12 17:26:05 +03:00
Chocobo1
be61e8f2fd Revert back to intended fallthrough 
Partial revert a7f4ea8b18
 2017-07-10 00:36:56 +08:00
Chocobo1
448d937c15 Fix value comparison. Closes #7081. 
`category` could be 'undefined'.
Fixup of a7f4ea8b18.
 2017-07-09 22:31:14 +08:00
Mike Tzou
db2dec3d28 Merge pull request #7031 from Piccirello/fix-js-errors 
Fix various javascript errors and follow best practices
 2017-07-05 15:03:09 +08:00
Thomas Piccirello
a7f4ea8b18 Fix javascript errors and follow best practices 2017-07-01 03:28:35 -04:00
Thomas Piccirello
cd5a55d711 Skip username/password check for active sessions (closes #6860) 2017-07-01 03:26:15 -04:00
Chocobo1
cdb8f4bc61 [WebUI] relax CSRF defense. Closes #6882. 
Allow HTTP request which has neither Origin nor Referer header included
 2017-06-02 21:16:06 +08:00
Chocobo1
087856d3d8
[WebUI]: Implement CSRF defense 
Bump API version
 2017-06-01 19:37:57 +03:00
Eugene Shalygin
74cecb1b6c Replace C-style casts with C++ ones 2017-05-29 17:25:42 +02:00
Mike Tzou
20f6bf817e Merge pull request #6836 from Chocobo1/api 
[WebAPI] Get piece information/state
 2017-05-27 18:28:22 +08:00
Mike Tzou
b6080c19c2 Merge pull request #6834 from Chocobo1/cookie 
[WebUI] Make cookie parsing robust
 2017-05-26 23:56:35 +08:00