Chocobo1
7de8a4d6e0
Construct QString more efficiently
2020-03-25 12:00:11 +08:00
Chocobo1
48e7191ef7
Initialize boolean variables
2020-03-06 15:50:55 +08:00
Chocobo1
071ffd13de
Fix wrong field for translation comment
...
The `comment` field is used for disambiguation between identical
strings. Our case here should use the `extracomment` field which
meant as comment for translators.
2020-02-26 13:04:18 +08:00
Chocobo1
bf264b983a
Simplify null pointer check
2019-12-18 15:13:02 +08:00
Xegor
325f36fa4f
Add create subfolder option to RSS auto-download rules
2019-11-11 12:46:51 +01:00
Chocobo1
0d5b0b9542
Replace deprecated macro
...
Q_OS_MAC is deprecated and the replacement is Q_OS_MACOS.
2019-09-05 20:16:18 +08:00
thalieht
e26573d97f
Use FileSystemPathEdit in automated rss downloader
2019-08-20 15:34:51 +03:00
Chocobo1
7ab3479a34
Replace static_cast by qOverload
2019-07-26 22:32:18 +08:00
Chocobo1
4a90716843
Add override keyword to functions
2019-07-19 11:58:56 +08:00
Mike Tzou
1e70c52e7a
Merge pull request #10934 from Chocobo1/delete
...
Rely on Qt ownership to delete class members
2019-07-17 12:02:30 +08:00
Chocobo1
e74b984a0a
Rely on Qt ownership to delete class members
2019-07-16 18:42:26 +08:00
Prince Gupta
8267a4fef9
Incorporate GuiIconProvider inside UIThemeManager
2019-07-16 09:31:33 +05:30
Chocobo1
599bfc0735
Use Qt object ownership to handle QShortcut deletions
2019-07-13 13:24:27 +08:00
Chocobo1
3748b995ff
Avoid creating unnecessary event loops
...
The `exec()` method will create another event loop and transfer
control over there which might introduce unexpected bugs.
2019-06-17 20:44:57 +08:00
thalieht
70f8882f87
Group Qt forward declarations separately from the others
2019-06-04 17:48:55 +03:00
thalieht
9995967fbf
Remove some unused #include
2019-06-04 17:48:55 +03:00
thalieht
4370a7eb12
Forward declare in a few places
2019-06-04 17:48:55 +03:00
Chocobo1
49df1cd3c7
Use less operations when building strings
2019-05-31 14:52:08 +08:00
thalieht
70f1537d9f
Add const to almost all remaining vars and arguments that qualify
2019-02-25 17:05:15 +02:00
thalieht
8c944bd4e1
Avoid repeating the return type
2019-02-16 18:54:18 +02:00
thalieht
400792d18e
Use isEmpty() instead of size() for emptiness
2019-02-16 18:54:17 +02:00
thalieht
d8cbc9266a
Use 'auto' to avoid duplicating the type name
2019-02-16 18:54:17 +02:00
Chocobo1
f789df7edf
Add license header
2019-02-04 17:28:55 +08:00
Chocobo1
2b903fc3d1
Move Utils::Misc::isUrl() function
...
All usage of this function gets to call Net::DownloadManager eventually.
2018-12-31 20:00:15 +08:00
thalieht
1f36b8b89f
Combine qAsConst() with copyAsConst() to asConst()
2018-11-28 23:41:23 +02:00
thalieht
6b1d26d555
Convert all foreach() to range-based for()
2018-11-28 23:40:12 +02:00
Chocobo1
0217d5b4c0
Replace single-character string with character literal
...
Also remove unnecessary dynamic allocation.
2018-07-21 23:26:15 +08:00
thalieht
456270bbb1
Delete several unused #include
2018-07-03 08:38:32 +03:00
thalieht
6d4434ad66
Convert the names used in ui and c++ files from snake_case to camelCase
2018-07-03 08:38:32 +03:00
thalieht
d34ddb2e3c
Change file names and classes names to match them
2018-06-15 20:12:59 +03:00
Eugene Shalygin
04aea413ba
Merge pull request #9055 from zeule/cmake
...
Update CMake build scripts
2018-06-07 21:31:09 +02:00
Eugene Shalygin
fa770871e9
Refactor CMake build scripts
...
1. Use FeatureSummary module to show configuration results.
2. Invert option()/find_package() relationship: instead of
calling find_package(... REQUIRED) when option is set, rely on optional
find package call and PackageName_FOUND variable.
3. Refactor handling options that result in simple preprocessor defines
(actually copy the snippet from libtorrent) so that everything is done
in a single function call.
4. Populate target properties in order to get rid of
include_directories() calls.
2018-06-05 11:39:11 +02:00
Vladimir Golovnev
e61c882fee
Merge pull request #9015 from thalieht/style
...
Fix coding style
2018-06-03 14:48:04 +03:00
thalieht
356d6a6589
Fix coding style
2018-05-31 19:45:09 +03:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression
...
Revise `static` keyword usage, static is added to frequently used
instances.
2018-05-31 22:56:49 +08:00
Vladimir Golovnev (Glassez)
53b9bcaaac
Place "Use Smart Episode Filter" more correctly
2018-05-19 14:52:38 +03:00
Vladimir Golovnev (Glassez)
844f76c2ca
Make "Ignoring days" to behave like other filters
...
This prevents confusing in GUI when it shows matched RSS
articles which be really ignored by the rule.
2018-05-19 14:52:24 +03:00
thalieht
6b4455e13d
Use qt5 connect() syntax
2018-05-09 16:08:22 +03:00
thalieht
3e4099fe5b
Replace the zeroing of pointers with nullptr
2018-04-15 13:06:31 +03:00
Chocobo1
0457fd260e
Avoid temporary QString allocations
...
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
2018-03-07 20:06:00 +08:00
Stephen Dawkins
48cbccff1e
Made smart episode filter regular expression configurable
2018-02-05 19:23:11 +00:00
Stephen Dawkins
2845a791d0
Initial implementation of Smart Filter feature
2018-01-27 09:14:36 +00:00
Chocobo1
27cf98a962
Resize dialog size on high DPI monitors
2017-12-24 21:54:56 +08:00
Vladimir Golovnev (Glassez)
e75f8603b0
Fix RSS rule updated when deleting
...
Closes #8094
2017-12-23 16:25:09 +03:00
Mike Tzou
eac8838dc2
[GUI] Implement stable sort ( #7703 )
...
* NaturalCompare now returns compare result instead of "less than" result
* Change to stable sort in GUI components
* Add Utils::String::naturalLessThan() helper function
* Use Qt::CaseSensitivity type
2017-11-30 17:10:30 +08:00
Vladimir Golovnev (Glassez)
916cfcdb03
Implement Import/Export RSS rules in JSON format
2017-11-24 21:20:44 +03:00
Vladimir Golovnev (Glassez)
b8fc415870
Implement Import/Export RSS rules in legacy format
2017-11-24 16:19:16 +03:00
Vladimir Golovnev
083bc71315
Merge pull request #7396 from thalieht/updownratio
...
Properly pre-select the selected torrent's current ratio limiting options in UpDownRatioDlg
2017-10-08 21:06:55 +03:00
thalieht
525fdd6c2b
Coding style, use nullptr and other minor things
2017-10-08 10:20:54 +03:00
Vladimir Golovnev (Glassez)
3ec992474d
Implement TorrentCategoryDialog class
2017-09-27 21:25:22 +03:00
Vladimir Golovnev
f2af308e6d
Fix RSS Downloader fails to rename rule
...
Closes #7333 .
2017-08-23 16:45:14 +03:00
vit9696
d25467d3e6
Various macOS UI improvements
2017-07-15 20:49:40 +03:00
Vladimir Golovnev (Glassez)
66aeafdc63
Fix crash in ArticleListWidget
...
ArticleListWidget::handleArticleList() can be called inside
ArticleListWidget::handleArticleAboutToBeRemoved() and list widget
item can be removed at this point. Now we checking for it existence.
Closes #6896 .
2017-06-07 18:24:43 +03:00
KingLucius
dedd31ada5
Fix crash when delete RSS feed
2017-05-27 13:52:32 +02:00
Eugene Shalygin
72da2e7252
Do not use hardcoded colors in RSS feed view
2017-05-21 13:02:34 +02:00
sledgehammer999
d61fc7e820
Merge pull request #3858 from Chocobo1/screen_center
...
Fix dialogs didn't position on the correct screen
2017-05-07 22:17:55 +03:00
Vladimir Golovnev (Glassez)
76e3383650
Don't remove read articles from Unread list
...
Revert back old behavior (incorrect but, perhaps, more user-friendly),
when Unread list populates with "unread" articles only but then it can
contain "read" articles if they become "read" when Unread list is shown.
2017-05-04 20:37:05 +03:00
Vladimir Golovnev (Glassez)
2d3914c077
Prevent incorrect popullating of Unread RSS list
2017-05-04 12:39:59 +03:00
Vladimir Golovnev (Glassez)
4e37688105
Properly clear ArticleListWidget
2017-05-04 12:30:02 +03:00
Chocobo1
2258e4d5ed
Fix automatedrssdownloader position
2017-05-01 15:32:08 +08:00
Brian Kendall
eba41978b0
Added command line arguments for specifying options when adding torrents
...
Arguments include adding torrents as paused/started, skiping hash check, setting category, downloading in sequential order, downloading first and last pieces first, and skipping the 'add new torrent' dialog. Added TriStateBoolOption class for specifying options that don't have a default value when unused (e.g. add-paused). Also improved command line usage text to include more information, have better organization, and not exceed 80 columns in width. Also also added firstLastPiecePriority field to BitTorrent::AddTorrentData, and modified TorrentHandle so that if first/last piece priority should be on, it will be toggled on after the torrent's metadata has loaded.
2017-04-30 14:22:30 -04:00
Vladimir Golovnev (Glassez)
a78a1a9c64
Add invariant checking in ArticleListWidget
2017-04-27 12:31:18 +03:00
Vladimir Golovnev (Glassez)
6764de8ef0
Fix ArticleListWidget adds new articles in wrong order
2017-04-25 13:15:11 +03:00
Vladimir Golovnev (Glassez)
71814885aa
Fix ArticleListWidget doesn't clear properly
2017-04-25 13:14:55 +03:00
Vladimir Golovnev (Glassez)
abfcfb5af0
Fix possible null pointer dereference
2017-04-25 13:01:34 +03:00
zywo
51104a9fb4
Fix CMake build
2017-04-23 09:29:27 +01:00
Vladimir Golovnev (Glassez)
989a70fe60
Redesign RSS subsystem
2017-04-23 09:03:46 +03:00
Eugene Shalygin
4e1b7c3b87
Remove generated include from headers
...
Not only fixes compilation with CMake 3.8 (without messing with include
paths) but makes sources cleaner.
2017-04-17 16:31:19 +02:00
Eugene Shalygin
0bf7fa15c1
Replace wrappers in base/utils/fs.h with Profile::SpecialFolders::location()
2017-04-12 00:50:33 +02:00
sledgehammer999
aa51907387
Merge pull request #6369 from magao/issue6367
...
Use Perl-compatible regexes for RSS rules. Closes #6367 .
2017-03-08 00:04:17 +02:00
Eugene Shalygin
e64bb1de8c
Drop Qt 4 support
2017-03-05 22:24:59 +01:00
Tim Delaney
f9abd254f4
Use Perl-compatible regexes for RSS rules. Closes #6367 .
...
--HG--
branch : magao-dev
2017-02-11 16:33:18 +11:00
Tim Delaney
c0339d4f6a
Fix regex RSS matching. Closes #6337 .
...
--HG--
branch : magao-dev
2017-02-05 08:53:33 +11:00
Tim Delaney
f96eb587ff
Bugfix RSS feed list and rules editor. Closes #3782 , #6281 .
...
--HG--
branch : magao-dev
2017-01-22 15:36:27 +11:00
Tim Delaney
e4d9e9f63f
Follow project coding style. Issue #2192 .
...
--HG--
branch : magao-dev
2017-01-29 09:24:41 +11:00
sledgehammer999
f6a941defc
Merge pull request #6294 from thalieht/hotkeys
...
Add hotkeys for some things. Closes #2090
2017-02-06 22:41:30 +02:00
thalieht
2bb2d3fc89
change all existing shortcuts to use Qt::Keys
2017-01-28 19:43:16 +02:00
sledgehammer999
3b3de81cb7
Merge pull request #6181 from magao/issue6170
...
RSS episode filter improvements. Closes #800 , #2749 , #3876 , #6170 .
2017-01-26 01:02:05 +02:00
sledgehammer999
769fe17a21
Merge pull request #6179 from magao/issue6165
...
RSS use red text to indicate invalid filter. Closes #6165 .
2017-01-25 23:28:57 +02:00
sledgehammer999
354702140a
Merge pull request #6180 from magao/issue6171
...
Allow | in RSS must contain. Closes #6171 .
2017-01-25 23:27:59 +02:00
sledgehammer999
5df8ad32fe
Merge pull request #6183 from magao/issue6163
...
Save rule on enable/disable even if not selected. Closes #6163 .
2017-01-25 23:25:49 +02:00
sledgehammer999
b9b8352a31
Merge pull request #6184 from magao/issue5539
...
RSS: allow resetting rule to no category. Closes #5539 .
2017-01-25 23:20:19 +02:00
sledgehammer999
14ebf2118a
Merge pull request #6289 from evsh/cmake
...
Cmake compilation fixes
2017-01-25 23:06:21 +02:00
Eugene Shalygin
180ec7af4a
cmake: RSS target has to depend on qbt_base as it uses its includes
2017-01-21 20:12:48 +01:00
sledgehammer999
75d0414da3
Merge pull request #6275 from evsh/fix-icon-names
...
Replace icon name "open-menu" with "preferences-system"
2017-01-21 14:02:14 +02:00
sledgehammer999
c8ddd68a7a
Merge pull request #6212 from magao/issue2192
...
Follow project coding style. Issue #2192 .
2017-01-20 23:13:06 +02:00
Eugene Shalygin
a6b6009fb1
Replace icon name "open-menu" with "preferences-system"
...
Apparently, we can not use symbolic icons transparently.
2017-01-20 20:02:49 +01:00
Chocobo1
0517a3eb63
Fix rss icon too large in rss settings dialog
...
Give a name to the rss icon (in .ui file)
Add helper function: Utils::Misc::largeIconSize()
Group functions under the same #ifdef
2017-01-20 13:45:50 +08:00
sledgehammer999
c43cfbad17
Merge pull request #6182 from magao/issue6164
...
Fix tab order in RSS downloader. Closes #6164 .
2017-01-18 20:08:06 +02:00
Eugene Shalygin
9bab229108
Adjust icons names to better fit FDO scheme
...
An icon theme may use variously styled icons for various types of UI
elements. For example, Breeze theme uses monochrome icons for actions
(toolbars) and statuses, but colourful for view contents. qBittorrent
was using icon names without putting attention to categories, creating
mix of styles in UI elements (i.e. the main toolbar).
This commit fixes icon names (and move some of them to theme) to avoid
this style mixes where possible.
Unfortunately, options dialog page icons for network and speed limits
are remained monochrome because there are no Breeze or Adwaita icons to
match.
2017-01-18 18:03:33 +01:00
sledgehammer999
c384cc8c8c
Move new icons to their own theme folder.
2017-01-11 18:02:26 +02:00
Tim Delaney
70ce12372d
Follow project coding style. Issue #2192 .
...
--HG--
branch : magao-dev
2017-01-08 11:46:01 +11:00
Tim Delaney
8949a8ad75
RSS: allow resetting rule to no category. Closes #5539 .
...
--HG--
branch : magao-dev
2016-12-31 16:58:01 +11:00
Tim Delaney
2244b7cb66
RSS episode filter refactoring and logging (prep for later commits).
...
--HG--
branch : magao-dev
2016-12-31 18:01:22 +11:00
Chocobo1
a415f14fac
Rename splitter names
2016-11-17 11:12:33 +08:00
Chocobo1
7d34a89efd
Change RSS view layout to horizontal. Closes #5920 .
...
Thanks Bhaalspawn for the idea.
2016-11-10 20:59:55 +08:00
Tim Delaney
b84d9201fd
Allow | in RSS must contain. Closes #6171 .
...
--HG--
branch : magao-dev
2016-11-07 17:46:27 +11:00
Tim Delaney
32bdb73f70
RSS allow infinite range to extend beyond current season. Closes #800 , #3876 , #6170 .
...
--HG--
branch : magao-dev
2016-11-07 07:18:06 +11:00
Tim Delaney
935b30b17a
RSS use red text to indicate invalid filter. Closes #6165 .
...
--HG--
branch : magao-dev
2016-11-06 16:53:06 +11:00
Tim Delaney
e37488807b
Fix tab order in RSS downloader. Closes #6164 .
...
--HG--
branch : magao-dev
2016-11-06 15:45:44 +11:00