mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-09 08:37:27 +03:00
Code Issues Projects Releases Packages Wiki Activity
12027 commits 16 branches 245 tags 256 MiB
Commit graph

258 commits

Author SHA1 Message Date
Chocobo1
4a0b36a50b
Use std::optional to return results 2021-02-10 12:25:26 +08:00
Chocobo1
fffe5e7003
Fix potential out-of-bounds access 2021-02-10 12:25:15 +08:00
Chocobo1
1479b61214
Simplify code for checking free disk space 
`QStorageInfo::bytesAvailable()` is guaranteed to return `-1` for an
invalid path.
https://doc.qt.io/qt-5/qstorageinfo.html#bytesAvailable
 2021-01-17 11:51:33 +08:00
Chocobo1
15a249eb54
Improve detection of file extension string 2021-01-17 00:10:18 +08:00
Vladimir Golovnev (Glassez)
d0cac421bb
Change parseBool() to return optional bool value 2021-01-04 23:10:24 +03:00
Vladimir Golovnev (Glassez)
552ff0489d
Use nested namespaces definition syntax 2021-01-03 16:53:24 +03:00
Chocobo1
e022c371ff
Move parsing of TriStateBool to a static class function 2021-01-01 12:59:48 +08:00
Chocobo1
5bd6ff2285
Migrate away from deprecated std::iterator class 2020-12-31 13:28:48 +08:00
Chocobo1
d70b893852
Bump project requirement to C++17 2020-12-31 13:28:48 +08:00
Vladimir Golovnev (Glassez)
79048812e9
Fix folder name extraction functions 
It should return empty string if there is no parent folder.
 2020-12-26 14:47:06 +03:00
Vladimir Golovnev (Glassez)
1d5dc283fe
Allow to add root folder to torrent content 2020-12-23 13:07:33 +03:00
Vladimir Golovnev (Glassez)
d4a51979bb
Extract enum serialization/parsing functions 2020-12-15 10:18:39 +03:00
Vladimir Golovnev
c01d28a471
Merge pull request #13948 from FranciscoPombal/pragmatism 
Use #pragma once instead of include guards
 2020-12-14 13:51:02 +03:00
FranciscoPombal
6152b83405 Use #pragma once instead of include guards 2020-12-12 19:41:32 +00:00
Chocobo1
4d1d5d6b20
Revise Utils::Version comparison operators 2020-12-11 12:50:12 +08:00
Chocobo1
498da509db
Use Qt provided forward declaration header 2020-12-09 18:21:02 +08:00
Vladimir Golovnev (Glassez)
c41df9ffbd
Improve coding style 2020-11-17 21:02:37 +03:00
Mike Tzou
49e55d5a5d
Merge pull request #13268 from ngosang/feature/python35- 
Update minimum Python version to 3.5.0
 2020-09-14 12:03:20 +08:00
Chocobo1
307ca61c86
Code clean up 2020-08-29 19:56:05 +08:00
ngosang
71be4f03be Update minimum Python version to 3.5.0 2020-08-18 20:56:39 +02:00
Vladimir Golovnev (Glassez)
f35dbdfb8b
Fix crash on exit when compiled using MinGW 2020-07-21 13:56:07 +03:00
Chocobo1
40e432b127
Bump requirement to libtorrent 1.2 
Closes #12258.
 2020-06-26 17:17:29 +08:00
Vladimir Golovnev (Glassez)
f4efa530dc
Create header for common BitTorrent declarations 2020-05-25 20:32:35 +03:00
Vladimir Golovnev (Glassez)
1132b84548
Split TorrentHandle interface and implementation 2020-04-16 20:22:26 +03:00
Vladimir Golovnev
eb0295197c
Merge pull request #12301 from jozsefsallai/master 
Better Python path detection on Windows
 2020-04-07 22:29:26 +03:00
Chocobo1
2fa6a7f6f5
Avoid inefficient behavior 
Since the class needs to be copy-constructible, there may be many
copies of an instance. So instead of writing to the device on every
destructor call, only flush buffer on the last destructor call.
 2020-04-06 01:04:12 +08:00
Chocobo1
9f281c2d25
Avoid holding entire file in memory 
Previously we need a file buffer that is as large as the file size and
this could be a problem when user has less free memory available or
having very large data. Now with the help of `FileOutputIterator`,
we can have a much smaller, fixed size immediate file buffer and also
the code looks nice with `lt::bencode()`.
 2020-04-03 18:27:13 +08:00
József Sallai
f9564564f8 Detect python3 executable on Windows 2020-04-02 00:31:41 +03:00
Chocobo1
6c307774f1
Get library version strings at runtime 
We mostly use boost in header-only mode, so it is a non-trivial job to
get the version string at runtime.
 2020-03-16 21:27:42 +08:00
Mike Tzou
dc4e9e3779
Merge pull request #11813 from Chocobo1/python 
Drop python2 support
 2020-03-07 10:18:45 +08:00
Chocobo1
2157e500ef
Use helper functions to construct smart pointers 2020-03-05 19:32:28 +08:00
Chocobo1
baa13c044a
Drop python2 support 
Closes #11811.
 2020-02-08 12:36:45 +08:00
sledgehammer999
90308c2ae5
Merge pull request #11660 from sledgehammer999/fix_smart_delete 
Don't unnecessarily delete folder customization
 2019-12-17 20:38:25 +02:00
sledgehammer999
64e5d41a2c
Don't unnecessarily delete OS files in folders 2019-12-16 22:10:13 +02:00
sledgehammer999
8200ef6bd5
Rework the listening IP/interface selection code 
Closes #11561
 2019-12-11 09:56:45 +02:00
Chocobo1
f31ee6a225
Fix integer narrowing on x86 
The f_type is an alias to `int` on 32-bit system and the switch cases
uses `unsigned int`.

Closes #11427.
 2019-10-31 13:04:02 +08:00
Chocobo1
7276a79cef
Call Windows API directly 
We already bumped the OS requirement to Windows 7 and those functions
can be called directly without the need to load them first.
 2019-09-29 09:52:13 +08:00
Mike Tzou
d2c21ce507
Merge pull request #11195 from Chocobo1/mac 
Replace deprecated macro
 2019-09-07 11:58:23 +08:00
Chocobo1
0d5b0b9542
Replace deprecated macro 
Q_OS_MAC is deprecated and the replacement is Q_OS_MACOS.
 2019-09-05 20:16:18 +08:00
Chocobo1
9dc3b18178
Fix filename validation on non-Windows OS 
Closes #11191.
 2019-09-05 20:05:21 +08:00
Chocobo1
b5b678c58f
Replace QString::split() by faster alternatives 2019-08-08 18:57:54 +08:00
Chocobo1
e90a2c00a5
Replace QList by QVector 2019-08-05 20:56:15 +08:00
Chocobo1
0b1b3c1f84
Use numeric_limits instead of constants from C 
In C++, using numeric_limits is more idiomatic compared to using constants.
 2019-06-23 11:16:58 +08:00
Prince Gupta
ece70daaa5 Fix CMake Windows compilation 2019-06-21 18:05:19 +05:30
Chocobo1
516c968373
Support year unit in userFriendlyDuration() 2019-06-19 18:52:24 +08:00
Vladimir Golovnev (Glassez)
8e65317d61
Rename "fromNativePath" to "toUniformPath" 
Unlike "toNativePath" which name clearly reflects the function result
"fromNativePath" has no such clear meaning.
Since this function converts path into uniform format "toUniformPath"
is better name.
 2019-06-17 15:55:49 +03:00
Mike Tzou
46d445d042
Merge pull request #10792 from Chocobo1/rename2 
Remove empty leftover folders after rename properly
 2019-06-16 12:22:22 +08:00
Chocobo1
440860c4a9
Properly remove empty leftover folders after rename 
TorrentInfo::origFilePath will return the very original path from
.torrent file, not the most recent file path before the rename operation
and thus the code would not be working as we expected.
 2019-06-15 19:08:23 +08:00
silverqx
4f4f435e76
Add zlib version to GUI & stackdump 2019-06-12 08:02:24 +02:00
Mike Tzou
63b0a5b78c
Merge pull request #10775 from Chocobo1/speed 
Misc. improvements
 2019-06-09 01:57:20 +08:00
Chocobo1
431e7179ac
Remove redundant variable 2019-06-06 00:20:57 +08:00
Chocobo1
fbd5699786
Use switch statement 2019-06-06 00:15:09 +08:00
thalieht
70f8882f87 Group Qt forward declarations separately from the others 2019-06-04 17:48:55 +03:00
thalieht
9995967fbf Remove some unused #include 2019-06-04 17:48:55 +03:00
thalieht
4370a7eb12 Forward declare in a few places 2019-06-04 17:48:55 +03:00
Chocobo1
36cf689432
Fix wrong comparison result 
The QString::toInt() might overflow when the string is long.

Closes #10706.
 2019-05-29 00:03:04 +08:00
Chocobo1
e288de7ec1
Forward declare as much as possible 2019-05-19 12:06:18 +08:00
Chocobo1
401bdbf3d9
Remove unused functions 2019-05-19 12:06:18 +08:00
Chocobo1
ff707ea5af
Change splitToViews() return type to QVector 2019-05-19 12:06:18 +08:00
Chocobo1
41773a5465
Fix unsafe type narrowing 
Appending the warning below:
qBittorrent\src\base/utils/version.h(176): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
qBittorrent\src\base/utils/version.h(185): note: see reference to function template instantiation 'std::array<T,2> Utils::Version<T,2,2>::parseList<StringsList>(const StringsList &)' being compiled
        with
        [
            T=unsigned short,
            StringsList=QList<QByteArray>
        ]
 2019-04-15 20:23:26 +08:00
Chocobo1
adbd34c795
Move helper functions to Utils::Gui namespace 2019-03-05 14:55:22 +08:00
Chocobo1
6dab93f7fd
Replace deprecated QDesktopWidget class 2019-02-28 12:02:03 +08:00
thalieht
89dce36e98 Use uniform initialization on some default arguments 2019-02-25 17:05:15 +02:00
thalieht
8a19a0d4a0 Remove const in declarations' arguments that are passed by value 2019-02-25 17:05:15 +02:00
thalieht
70f1537d9f Add const to almost all remaining vars and arguments that qualify 2019-02-25 17:05:15 +02:00
thalieht
8c944bd4e1 Avoid repeating the return type 2019-02-16 18:54:18 +02:00
thalieht
d8cbc9266a Use 'auto' to avoid duplicating the type name 2019-02-16 18:54:17 +02:00
thalieht
8a3f942385 Don't use 'else' after return/break 2019-02-13 18:23:25 +02:00
Chocobo1
5cdb3b6a2d
Load WebUI certificate & key from file path 
This allow users to update certificate & key more easily, i.e. without the need to import them
into qbt.

Closes #6675, #7547, #8315, #8564.
 2019-01-28 16:33:48 +08:00
Chocobo1
48d358872f
Cleanup header inclusion 2019-01-28 14:34:13 +08:00
Chocobo1
2b903fc3d1
Move Utils::Misc::isUrl() function 
All usage of this function gets to call Net::DownloadManager eventually.
 2018-12-31 20:00:15 +08:00
Mike Tzou
3ff7d16cfc
Merge pull request #9982 from Chocobo1/fixes 
Fix TravisCI linux builds
 2018-12-10 12:33:51 +08:00
Chocobo1
f13bcbd772
Add OpenSSL version to GUI & stackdump 2018-12-08 12:46:50 +08:00
Chocobo1
de437b905b
Fix MSVC C4267 warning 
The warning was: "warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of
data"
 2018-12-08 12:19:56 +08:00
Mike Tzou
6bb4eb825b
Merge pull request #9942 from Chocobo1/pbkdf2 
Do password hashing properly
 2018-12-06 16:22:22 +08:00
Chocobo1
05d6a29416
Apply PBKDF2 when storing passwords 2018-12-05 13:28:42 +08:00
thalieht
1f36b8b89f Combine qAsConst() with copyAsConst() to asConst() 2018-11-28 23:41:23 +02:00
thalieht
6b1d26d555 Convert all foreach() to range-based for() 2018-11-28 23:40:12 +02:00
thalieht
d668a4fe6d Fix coding style for various things 2018-11-28 23:37:35 +02:00
Vladimir Golovnev
dea6b3d7e0
Merge pull request #9562 from dzmat/round_speed_labels 
Improve scaling of speed graphs
 2018-11-01 09:46:26 +03:00
silver
0b20750cd5
Recognize *.ts files as previewable 2018-10-24 16:18:35 +02:00
dzmat
fabd7e34f5 Improve scaling of speed graphs 
Make Y axis scale to fix on predetermined nice looking positions
 2018-10-21 16:45:32 +07:00
Chocobo1
acdf5363b2
Simplify #if conditions 2018-10-12 00:04:08 +08:00
Chocobo1
cff5af2e76
Add isNetworkFileSystem() detection on Windows 
This allows network mounts to be monitored correctly by polling timer.
 2018-10-12 00:03:12 +08:00
Chocobo1
25a0147f61
Add SMB2 magic number 
Closes #9671.
 2018-10-10 10:36:26 +08:00
Chocobo1
f26a5c3581
Update Python URLs 2018-09-25 11:46:40 +08:00
Chocobo1
7d808cfc99
Fix asking to install Python 
The dialog asking users to install python is borked since the last refactor, this
commit fixes it.
 2018-09-25 11:46:39 +08:00
Chocobo1
60ecc4fe8f
Move python related functions 
Also the functions are slightly changed to return full path of the found
python executable.
 2018-09-25 11:46:39 +08:00
sledgehammer999
6c0af1b078
Merge pull request #9553 from sledgehammer999/misc_fixes 
Misc fixes
 2018-09-22 20:09:54 +03:00
sledgehammer999
e8213b2c6a
Remove unused variable 2018-09-22 14:05:40 +03:00
dzmat
fc93f2eb78 Replace magic number with system define 2018-09-21 22:33:43 +07:00
Elias M. Mariani
33af699191 Support the OpenBSD filesystem 2018-08-28 13:58:09 -03:00
Chocobo1
650f585bf3
Remove static keyword overuse 2018-07-23 13:40:25 +08:00
Chocobo1
0217d5b4c0
Replace single-character string with character literal 
Also remove unnecessary dynamic allocation.
 2018-07-21 23:26:15 +08:00
thalieht
456270bbb1 Delete several unused #include 2018-07-03 08:38:32 +03:00
thalieht
eb508d67ef Fix coding style 2018-07-03 08:38:32 +03:00
Chocobo1
2528c6e39a
Fix python version detection 
Closes #9146.
 2018-07-02 00:57:08 +08:00
Chocobo1
3e6c8a05dd
Reduce queries to python version 
Instead of doing at least 2 queries for python infos, now requires only
1 query (in ideal condition), and the result is cached.
 2018-06-24 19:41:44 +08:00
Chocobo1
51e82762c5
Move related functions to Utils::Python 2018-06-24 06:21:15 +08:00
Chocobo1
5ddbf9bba9
Replace post-increment with pre-increment 
And post-decrement with pre-decrement.
 2018-06-08 08:44:06 +08:00