Chocobo1
c07cd440cd
Split args manually in runExternalProgram()
...
Need to split arguments manually because QProcess::startDetached(QString)
will strip off empty parameters.
E.g. `python.exe "1" "" "3"` will become `python.exe "1" "3"`.
Closes #8454 .
2018-04-01 18:42:42 +08:00
Mike Tzou
e90be67fec
Merge pull request #8640 from Chocobo1/guide2
...
Clarify braces usages in CODING_GUIDELINES
2018-04-01 18:16:04 +08:00
Chocobo1
37ea01bd44
Use lightweight printf instead of iostream
...
Using iostream usually adds a lot of other operators (<<, endl), whereas
*printf takes only 1 function call.
Also use qUtf8Printable whenever possible.
2018-03-31 03:21:53 +08:00
Mike Tzou
ccc91e2e52
Merge pull request #8629 from Chocobo1/guide
...
Extend Coding Guidelines to cover other languages
2018-03-30 14:31:55 +08:00
Chocobo1
d31954761f
Clarify braces usages in CODING_GUIDELINES
...
Merge "Curly braces" & "If blocks" sections into "New lines & curly braces" section.
Add note about the list is not exhaustive and style can be determine on code review.
2018-03-29 02:50:48 +08:00
Mike Tzou
aa122b062e
Merge pull request #8615 from Chocobo1/watcher
...
Improve FS watcher
2018-03-27 14:34:08 +08:00
Chocobo1
65921eaf7b
Remove QPointer wrapper
2018-03-25 15:53:31 +08:00
Chocobo1
bfbd978d3f
Move helper function to Utils::Fs
2018-03-25 13:26:03 +08:00
Chocobo1
1876dbd523
Fix typo
2018-03-25 13:26:02 +08:00
Chocobo1
ea7eb7c0ec
Add delay before processing FS changes
...
This prevents file renaming errors in monitored folder on linux, for
example: ABC.torrent.part -> ABC.torrent
2018-03-25 13:26:02 +08:00
Chocobo1
19c733ce95
Use specific name for rejected files
2018-03-25 13:26:02 +08:00
Chocobo1
2ba5dd1344
Reduce debug messages
2018-03-25 13:26:02 +08:00
Chocobo1
61eddfce90
Refactor functions in FileSystemWatcher
...
Use c++11 range-loop
Add const
Better ifdef placement
Inline functions
2018-03-25 13:26:02 +08:00
Chocobo1
0840556f77
Do cleanups in FileSystemWatcher
...
Use Qt5 connect syntax
Sort headers
Add license
Add anonymous namespace
Replace macro defines with const variables
2018-03-25 13:25:28 +08:00
Mike Tzou
f564e8a1c4
Merge pull request #8621 from Chocobo1/html5
...
Update WebUI to be more compliant with HTML5 standard
2018-03-24 22:41:31 +08:00
Chocobo1
315d9835b2
Extend Coding Guidelines to cover other languages
2018-03-23 15:21:50 +08:00
Chocobo1
ed03456999
Update WebUI to be more compliant with HTML5 standard
...
Use modern and shorter "charset" attribute.
Remove "type", "charset" attributes in script/style tags, these are redundant in HTML5.
2018-03-23 00:04:43 +08:00
Mike Tzou
e1a14007f8
Merge pull request #8618 from Piccirello/remove-css
...
Remove unused CSS from WebUI login page
2018-03-23 00:02:12 +08:00
Thomas Piccirello
a15cfae03a
Fix spacing
2018-03-21 00:04:21 -04:00
Thomas Piccirello
c2a195360a
Resolve JavaScript errors
2018-03-21 00:04:21 -04:00
Thomas Piccirello
a4f99995bb
Consolidate CSS into style.css
2018-03-21 00:04:18 -04:00
Thomas Piccirello
16616f4e0e
Remove unused CSS from WebUI login page
2018-03-20 15:25:04 -04:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern
...
Don't create temporary containers just to iterate over them
2018-03-19 13:06:01 +03:00
Vladimir Golovnev
a8dbff06a3
Merge pull request #8607 from glassez/rss
...
Process loaded RSS articles in case of parsing error
2018-03-19 09:35:30 +03:00
Vladimir Golovnev (Glassez)
d9cd5d4680
Resolve (X)HTML entities in RSS content
...
Many sites include various HTML entities in the content of RSS feeds.
The most of these entities are not declared in the underlying XML,
so the documents are considered by parser to be malformed.
This patch allows you to successfully parse such soft-malformed
RSS feeds.
Closes #8527 .
Closes #8569 .
2018-03-18 18:59:55 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them
...
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.
Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.
Found using clazy.
2018-03-18 16:22:12 +03:00
Mike Tzou
68ca95faf0
Merge pull request #8603 from Chocobo1/typo
...
Fix typo
2018-03-17 00:49:41 +08:00
Vladimir Golovnev (Glassez)
8d285c66aa
Process loaded RSS articles in case of error
...
For some reason, the RSS feed may contain malformed XML data and it may not be
successfully parsed by the XML parser. We are still trying to load as many articles
as possible until we encounter corrupted data. So we can have some articles even in
case of parsing error.
Closes #8527 .
Closes #8569 .
2018-03-16 18:29:38 +03:00
Mike Tzou
1f28122428
Merge pull request #8595 from Chocobo1/runExt
...
Add Tags parameter to "Run External Program"
2018-03-16 19:37:34 +08:00
Mike Tzou
6ec179e0f7
Merge pull request #8594 from Chocobo1/ui
...
Properly align text label
2018-03-15 13:41:23 +08:00
Chocobo1
423511765a
Fix typo
2018-03-14 23:37:08 +08:00
Vladimir Golovnev
c061d67b14
Merge pull request #8597 from Piccirello/fix
...
Use correct API method URL in WebUI
2018-03-14 15:19:00 +03:00
Thomas Piccirello
4863078744
Use correct API method URL in WebUI
...
Fix up 27d8dbf
.
Closes #8596 .
2018-03-14 03:08:46 -04:00
Chocobo1
88881de8c6
Add Tags parameter to "Run External Program"
...
Closes #8586 .
Also sort headers.
2018-03-14 10:12:32 +08:00
Chocobo1
690c439ae6
Properly align text label
2018-03-14 00:35:20 +08:00
Mike Tzou
e78b5202bc
Merge pull request #8585 from Chocobo1/lint
...
Fix compiler/clazy warnings
2018-03-13 22:36:10 +08:00
Vladimir Golovnev
c9be1d0a19
Merge pull request #8494 from paolo-sz/master
...
Fix for "Content" panel messed up
2018-03-13 16:54:05 +03:00
Vladimir Golovnev
3348eef423
Merge pull request #8488 from thalieht/fix
...
Move suffix-labels inside the corresponding spinboxes
2018-03-12 16:58:05 +03:00
Vladimir Golovnev
931af6c97e
Merge pull request #8313 from Piccirello/search-categories
...
Calculate search categories based on selected plugin
2018-03-12 14:29:51 +03:00
Vladimir Golovnev
cea2948593
Merge pull request #8556 from Piccirello/compiler-warnings
...
Fix missing initializer warning during build
2018-03-12 14:28:38 +03:00
Chocobo1
a468c84b30
Fix warnings from unused variables
2018-03-12 14:36:28 +08:00
Thomas Piccirello
7278625f53
Calculate supported categories based on selected plugin
2018-03-12 01:33:45 -04:00
Thomas Piccirello
7b3e692f68
Fix missing initializer warning
...
This issue occurs when using gcc versions < 5.
2018-03-12 01:21:21 -04:00
Chocobo1
fdb0d97b28
Remove unused function
2018-03-11 23:27:04 +08:00
Chocobo1
08a2439f46
Check directly if container is empty or not
2018-03-11 23:12:16 +08:00
Chocobo1
6767487e40
Remove unused variable
2018-03-11 22:31:17 +08:00
Chocobo1
141a2d2856
Prevent detach from containers
2018-03-11 22:25:07 +08:00
thalieht
2eea57e609
Use spinbox suffix to display time unit
2018-03-11 12:08:00 +02:00
thalieht
0b185e347b
Use spinbox suffix to display rate unit
2018-03-11 12:07:38 +02:00
thalieht
1e1db31ab5
Use unique layout names
2018-03-11 12:07:24 +02:00