mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-12-17 05:21:50 +03:00
Code Issues Projects Releases Packages Wiki Activity
5179 commits 16 branches 243 tags 246 MiB
Commit graph

4744 commits

Author SHA1 Message Date
sledgehammer999
e10e2e1719 Change the program updater's URL for Windows and Mac OS X. Closes #1954. 2014-10-12 16:42:33 +03:00
Ivan Sorokin
b995a9d75e Fix race condition in QAlertDispatcher 
It was possible that QAlertDispatcher::dispatch() could access (lock)
mutex that was destroyed by main thread. Fix this by moving mutex into a
tag.
 2014-10-12 12:25:56 +04:00
Ivan Sorokin
333978f1ff Use std::vector instead of std::deque in QAlertDispatcher 
As we never use {push,pop}_front std::vector works here perfectly.
Also reserve memory for std::vector out of lock.

This could be considered as an optimization, but in reality this is just
using right container in right place. According to my measurements total
speedup is under 0.2%.
 2014-10-12 12:25:47 +04:00
Ivan Sorokin
d89d9c2f75 Fewer calls to torrent_handle::info_hash() 2014-10-12 12:09:52 +04:00
Bruno Barbieri
698e5ef0f1 Replace deprecated sgmllib with HTMLParser/html.parser 2014-10-05 18:04:10 -03:00
Bruno Barbieri
2bdfd140cb Fix search engine encoding issues with python3 on Windows 
Closes #1996
 2014-10-05 17:03:43 -03:00
Bruno Barbieri
dc8853cd87 Fix TorrentReactor search plugin 2014-10-04 07:20:42 -03:00
Ivan Sorokin
ddd2025968 Fix heap-buffer-overrun in PropertiesWidget::displayFilesListMenu 2014-10-01 23:20:01 +04:00
paolo-sz
b47fba49cc Correctly detect python in PATH 2014-09-25 09:28:58 +02:00
sledgehammer999
8408f56d6f Fix large cache support on amd64 arch pt2. 2014-09-21 14:01:58 +03:00
sledgehammer999
97419f840a Consider queued items before deciding to 'auto-shutdown on downloads completion'. Closes #1942. 2014-09-21 13:50:32 +03:00
sledgehammer999
0650d28da7 Merge pull request #1941 from Gelmir/magnet_redirect 
Work around magnet redirection in feeds
 2014-09-21 13:36:47 +03:00
sledgehammer999
88baa710fd Merge pull request #1947 from Gelmir/x64_cache_fix 
Fix large cache support on amd64 arch
 2014-09-21 13:11:32 +03:00
masux
f1e0ef87a4 This fix qbittorrent/qBittorrent#1949 2014-09-21 09:16:59 +02:00
Nick Tiskov
65f570b816 Fix large cache support on amd64 arch 2014-09-19 17:42:40 +04:00
Nick Tiskov
a7e445c575 Work around magnet redirection in feeds 2014-09-16 00:35:46 +04:00
sledgehammer999
94043e60c7 Merge pull request #1919 from masux/master 
Fixed extratorrent.cc search engine.
 2014-09-15 17:38:06 +03:00
Martin Janco
1290d7cac4 Fixed extratorrent.cc search engine. 2014-09-15 16:29:20 +02:00
sledgehammer999
79191b3f34 Sync translations from Transifex and run lupdate. 2014-09-15 00:33:21 +03:00
lojack5
ac3efb664a fix import torrent with "Keep incomplete torrents in:" ticked 
* also had to account for "Append the label of the torrent to the save path",
  but again, this was only an issue when "Keep incomplete torrents in:" is
  selected

* A multi-file torrent with only one file (ie: a single file within a folder),
  was being treated as a single-file torrent, making it impossible to import.
  Multi-file torrent detection code was copied from libtorrent.  The
  information is available in libtorrent (under torrent_info::m_multifile),
  however it's a private member and I chose to go with copying the code that
  determines it, rather than modifying a library qBittorrent depends on.

Conflicts:
	src/torrentimportdlg.cpp
 2014-09-15 00:05:13 +03:00
sledgehammer999
59379942ac Don't display the Search Engine tab by default. 2014-09-14 22:20:58 +03:00
sledgehammer999
b6d4030cd8 WINDOWS: Search first in PATH for python. Closes #956. 2014-09-14 22:20:57 +03:00
sledgehammer999
1144555eca WINDOWS: Can now correctly detect 64bit and 32bit python installations on 64bit Windows. Closes #1148 #445 #795 #1708. 2014-09-14 22:20:56 +03:00
sledgehammer999
574abc7cdb WINDOWS: Don't create keys in the registry if python isn't found. Closes #1370. 2014-09-14 22:20:55 +03:00
sledgehammer999
0799dc293c WINDOWS: Check for python before creating the search engine tab. Prevents the creation of python specific files in the user's PC if no python is found. Closes #1370. 2014-09-14 22:20:36 +03:00
sledgehammer999
5528f60a15 SMTP: send the local hostname as FQDN. See discussion in #1845 for more info. 2014-09-13 18:00:51 +03:00
sledgehammer999
f9aee5e3ab Forward declare classes where possible in 'TransferListWidget'. 2014-09-13 16:49:16 +03:00
sledgehammer999
baf9d21072 Show stalled downloads that are uploading under the 'Active' filter. Closes #1654." 2014-09-13 16:49:11 +03:00
diger
e7f1dacd6c Fix Qt5 support 2014-09-11 08:44:25 +06:00
sledgehammer999
cc4d17fbf0 Merge pull request #1819 from diger/haiku 
Add patches for support Haiku (https://www.haiku-os.org)
 2014-09-04 14:43:52 +03:00
diger
c22190fbf7 Add patches for support Haiku (https://www.haiku-os.org) 2014-09-04 13:23:16 +06:00
sledgehammer999
2a5393cf53 SMTP: Fix edge case where nothing was sent when no authentication was needed. Relates to #1845. 2014-09-02 17:31:44 +03:00
sledgehammer999
bf0ed595c7 Don't use IPv4 addresses when the user has enabled IPv6 address in the settings. 2014-09-02 14:45:42 +03:00
sledgehammer999
a708c642ef SMTP: Fix finding the local address. 2014-09-02 14:25:54 +03:00
sledgehammer999
487ca568b8 SMTP: Send the IP of the configured Network Interface. Relates to #1845. 2014-09-01 15:07:05 +03:00
sledgehammer999
54bf386794 SMTP: Support multiline greeting from server in INIT state. Thanks to Ivanov Juriy for helping identify the problem. Relates to #1845. 2014-08-31 14:32:09 +03:00
sledgehammer999
f22f7cf17a Fix available disk space label on single file torrents. 2014-08-31 00:05:38 +03:00
sledgehammer999
45e95e6cc2 Don't translate file extensions. Closes #1907. 2014-08-30 21:54:57 +03:00
sledgehammer999
94fc2f9c3d Don't display the context menu in 'Content' and 'HTTP Sources' buttons when no torrent is selected. It prevents crashes. Closes #1906, #1900. 2014-08-30 19:52:57 +03:00
sledgehammer999
de5ad05d0a Merge pull request #1902 from YuriIvanov/issue#1650 
Add peer port column to PeerListWidget. Closes #1650.
 2014-08-30 19:27:19 +03:00
sledgehammer999
11d39ba6ef Right align numerical values in the transfer list. Partially revert 51a9a9aab. Closes #1903. 2014-08-30 18:36:20 +03:00
Ivanov Juriy
d5f372fae8 Add peer port column to PeerListWidget. Closes #1650. 2014-08-30 15:28:59 +04:00
sledgehammer999
7753bc38e9 Merge pull request #1895 from YuriIvanov/issue#1845 
add host address parameter to helo smtp request
 2014-08-28 23:18:37 +03:00
sledgehammer999
495800d6e9 Possible fix for crash in RSS code. Closes #1901. 2014-08-28 19:00:57 +03:00
sledgehammer999
611bddf485 Merge pull request #1881 from benhutchins/feature-webui-safe 
Fix Help menu links in WebUI
 2014-08-28 18:29:42 +03:00
sledgehammer999
0b8fad69fa Option to disable connections not supported by proxies. Closes #1894. 2014-08-26 00:32:10 +03:00
sledgehammer999
cd99f0ea43 Don't disable DHT/LSD/UPnP in the GUI when anonymous mode is enabled. 2014-08-25 19:22:44 +03:00
Ivanov Juriy
a7ad34418f add host address parameter to helo smtp request 2014-08-25 14:26:30 +04:00
sledgehammer999
58ad90fa9c Set 'Cancel' as the default button in the shutdown confirmation dialog. 2014-08-23 23:22:47 +03:00
sledgehammer999
7c80277c04 Sync translations from Transifex and run lupdate. 2014-08-23 22:31:49 +03:00
sledgehammer999
f6156217d0 Added 'Shutdown now' button in shutdown confirmation dialog. Closes #969. 2014-08-23 22:22:03 +03:00
sledgehammer999
634000e7a9 Split ShutdownConfirmDlg into .h/.cpp files. 2014-08-23 21:55:38 +03:00
sledgehammer999
66b375de07 Don't listen on IPv6 address by default. Prevents network connectivity problems. Closes #1880. 2014-08-23 21:55:36 +03:00
Benjamin Hutchins
89fda12597 Removed essentially useless "Visit website" iframe and changed it to a regular link. Improves fix qbittorrent/qBittorrent#1343 2014-08-15 22:29:50 -04:00
Benjamin Hutchins
9143c440a5 Removed broken "Documentation" iframe from the webui. Improves fix qbittorrent/qBittorrent#1343 2014-08-15 22:29:50 -04:00
Benjamin Hutchins
afc5601697 Removed broken Report a bug iframe from the webui. fixes qbittorrent/qBittorrent#1343 2014-08-15 22:29:50 -04:00
sledgehammer999
2b061dab0a Sync translations from Transifex and run lupdate. 2014-08-15 13:52:14 +03:00
sledgehammer999
3e734ab4f6 Add 'Open' and 'Open Containing Folder' entries in the content's right-click menu. Closes #1143. 2014-08-15 12:53:18 +03:00
sledgehammer999
efb3936ef1 Fix the adding of .torrent files via http links which was broken by 30bc5a1da6. 2014-08-15 11:33:09 +03:00
sledgehammer999
12302ee86f Sort finished torrents by completed date when sorting by queue number. 2014-08-15 02:19:25 +03:00
sledgehammer999
bef61b695f Don't mix finished/unifinished torrents when sorting by ETA. Closes #1688. 2014-08-15 02:19:21 +03:00
sledgehammer999
e294b2f456 Added 'Ratio Limit' column. Closes #936. 2014-08-14 21:05:53 +03:00
sledgehammer999
e0190d5576 Add 'Completed' column. Closes #1241. 2014-08-14 20:22:02 +03:00
sledgehammer999
fe0df04ea8 Sync translations from Transifex and run lupdate. 2014-08-10 01:28:31 +03:00
sledgehammer999
35736b8bb4 Show disk space while retrieving metadata. Closes #1693. 2014-08-09 23:10:20 +03:00
sledgehammer999
36cba3b354 When qBT is launched with a magnet don't show it in the transferlist while the metadata are being loaded in the background. 2014-08-09 22:07:49 +03:00
sledgehammer999
30bc5a1da6 Show the loaded torrents in the transferlist when qBT is launched with a torrent/magnet and the AddNewTorrentDialog is showing. Closes #1564. 2014-08-09 21:15:17 +03:00
sledgehammer999
6cb7de33f6 Don't shrink transferlist rows when scrolling horizontally. Closes #1613. 2014-08-08 23:32:54 +03:00
sledgehammer999
061d4fc721 Revert "Fix WebUI sort by size/speed for some locales (with comma as decimal point)." 
This reverts commit 87d118e87c.
 2014-08-08 03:03:57 +03:00
sledgehammer999
2729abfd32 Revert "Fix WebUI sort by ratio for some locales (with comma as decimal point)." 
This reverts commit c3942fb0b3.
 2014-08-08 03:03:40 +03:00
sledgehammer999
d44df4f985 Don't localize double numbers in the webui. Closes #1525. 2014-08-08 02:59:48 +03:00
sledgehammer999
4908ed4e78 Run lupdate. 2014-08-08 00:12:42 +03:00
sledgehammer999
9819353c9d Sync translations from Transifex. 2014-08-08 00:11:26 +03:00
sledgehammer999
80d6a5a73e Allow disabling of OS cache. This will prevent RAM increases on Windows when seeding many files. Closes #1699. 2014-08-07 23:09:58 +03:00
sledgehammer999
7763a6d2d5 Limit max cache to 1800MiB for 32bits compiled binaries and to 4GiB for other. Closes #1698. 2014-08-07 23:09:57 +03:00
sledgehammer999
97cf824c4d Fix checkbox for 'Copy .torrent files to' setting, which was broken by b70621. Closes #1748. 2014-08-06 01:08:13 +03:00
sledgehammer999
6e6d285a02 Fix compilation on MACOS. 2014-08-05 14:54:28 +03:00
sledgehammer999
15d3df380c Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file.(webui) 2014-08-05 02:34:22 +03:00
sledgehammer999
d8d95d2195 Migrate everything to use the new Preferences class and not access directly the qbittorrent.ini file. 2014-08-05 02:34:21 +03:00
sledgehammer999
da6ce859c0 Cache preferences in memory. Closes #1272, #1523, #1694. 2014-08-05 02:33:50 +03:00
sledgehammer999
d0e0b25c9e Installer correctly associates torrents and magnet links with qBittorrent under non-admin accounts. Closes #291 #527 #579 #614 #964. 2014-07-30 00:09:57 +03:00
sledgehammer999
25c923c69e Merge pull request #1470 from glassez/assoc 
Fix Windows file associations creation
 2014-07-20 20:23:01 +03:00
sledgehammer999
8f32f86453 Merge pull request #1782 from sorokin/alert-disp-qt5 
Fix alertdispatcher.cpp compilability on Qt5.
 2014-07-20 20:21:29 +03:00
sledgehammer999
6e76d5cf41 Run lupdate. 2014-07-16 00:48:12 +03:00
sledgehammer999
eb3ca94172 Sync translations from Transifex. 2014-07-16 00:44:48 +03:00
sledgehammer999
e2748ec3ac Remove deprecated feature of separate DHT port. 2014-07-16 00:17:21 +03:00
sledgehammer999
08e14cdc26 Fix possible crashes. Closes #1814. 2014-07-14 22:00:40 +03:00
Bryan Roscoe
f6a324a1bd Scan Folder dialog now remembers last location 
Also fix fs_utils spacing
 2014-07-13 19:50:57 -05:00
Bryan Roscoe
27afbaf7e7 Fix column resizing issues 2014-07-13 17:03:58 -05:00
sledgehammer999
7419e930ab Indentation fixes. 2014-07-06 23:18:37 +03:00
sledgehammer999
d6d20074be Merge pull request #1447 from BrunoReX/hibernation 
Add option to hibernate computer in Auto-Shutdown menu
 2014-07-06 23:11:29 +03:00
sledgehammer999
9a18b50751 Some fixes for commit 6dabf50781. 2014-07-06 21:39:27 +03:00
sledgehammer999
3ad1cc8289 Merge pull request #1779 from sorokin/move-storage 
Speedup and fix a bug in torrent moving.
 2014-07-06 19:19:59 +03:00
Bruno Barbieri
00e09435b2 Add option to hibernate computer in Auto-Shutdown menu 2014-07-06 06:13:36 -03:00
Ivan Sorokin
6dabf50781 Speedup and fix a bug in torrent moving. 
This commit implements a map where qbittorrent store a state of
current torrent movings. This commit speed up
torrents moving a bit and also fix a bug when qbittorrent doesn't do
cleanup action when a single torrent is moved several times without
waiting for a previous move to complete.

How it worked before.

Libtorrent has a function torrent_handle::move_storage() that allows to move a
torrent to a specific directory. This function is asynchorous. It means that
this function quits instantaneously and when the actual operation
completes the alert 'storage_moved_alert' or
'storage_moved_failed_alert' will be sent. The storage_moved_alert contains a
torrent_handle and a new path to where the torrent is moved.

During handling of storage_moved_alert, qbittorrent needs not only new path,
but also an old path to perform some of cleanup actions (like removing an old
folder if it is empty). This was achieved by storing a value named
'previous save path' in TorrentPersistentData. A previous save path is
written when move_storage() is issued and is read when
storage_moved_alert is received.

Problems.

This mechanism has two negative aspects:

1. TorrentPersistentData is very slow. As torrent_handle::move_storage() is asynchoronous,
TorrentPersistentData is responsible for more that 99.8% of time
QTorrentHandle::move_storage(). This percent could be higher when there
are lots of torrents and lower when there are few of them.

2. TorrentPersistentData stores only one previous path. But many
move_storage()'s could be issued without waiting for previous to
complete. Subsequent move_storage()'s overwrites previous save path of a
previous move.

A fix.

The fix is simple. Before issueing move_storage() the oldPath is stored in
a special map called 'torrentMoveStates'. When a storage_moved_alert
is received the map is consulted and an alert is handled.

When user moves torrent when previous moving have not yet finished, the
new location is saved in a field 'queuedPath' the same map. When
torrent moving is completed (or failed) qbittorrent attemps to perform
move again to the queued location.

Future direction.

This fix removes one slow read and one slow write to
TorrentPersistentData on torrent moving, but there is still exists
TorrentPersistentData::saveSavePath in handleStorageMovedAlert(), so
overall time for UI hang should be reduced only threefold. A speeding up
TorrentPersistentData should be addressed in a separate commit.

I don't know if I should clean up torrentMoveStates when torrent is
deleted. In any case, torrent could be deleted when corresponding alert
is in alert queue. So if we decide to clean up torrentMoveStates, then
we should not treat receiving alert from unknown torrent as a error.
 2014-06-23 11:21:24 +04:00
Ivan Sorokin
ce9da1ba1e Fix alertdispatcher.cpp compilability on Qt5. 2014-06-23 00:14:58 +04:00
Ivan Sorokin
fddd337e34 Suppress warning about signed/unsigned mismatch. 2014-06-22 19:48:21 +04:00
sledgehammer999
273725d9dc Fix file renaming. 2014-06-18 23:41:52 +03:00
sledgehammer999
c673b1a7d7 Bring mainwindow in front when notification is clicked and other windows are in front. 2014-06-18 23:22:25 +03:00
sledgehammer999
7e9b47948b Run lupdate. 2014-06-10 23:22:39 +03:00