Commit graph

14 commits

Author SHA1 Message Date
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
Luís Pereira
ea1b0b26b1 Don't implicitly cast iterator to const_iterator
It prevents detachments:
To illustrate:

QMap<QString, QString> map;
/* code compiles and works fine but find() returns the non-const
   QMap::iterator that detaches!
*/
QMap<QString, QString>::const_iterator it = map.find("girish");

but also some subtle bugs:

QHash<int, int> wrong;
if (wrong.find(1) == wrong.cend()) {
    qDebug() << "Not found";
} else {
    /* find() detached the container before cend() was called, so it
       prints "Found"
    */
    qDebug() << "Found";
}

QHash<int, int> right;
if (right.constFind(1) == right.cend()) {
    qDebug() << "Not found"; // This is correct now !
} else {
    qDebug() << "Found";
}

Enforced by QT_STRICT_ITERATORS definition.
2018-02-17 17:02:52 +00:00
Vladimir Golovnev (qlassez)
cff6a64e9f
Use qUtf8Printable() for logging strings
qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments
to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding.
Therefore qUtf8Printable() should be used for logging strings instead of
qPrintable().
2017-08-13 16:14:57 +03:00
Chocobo1
c907a2f857 Cleanup headers
Code formatting
2016-05-18 00:46:43 +08:00
Chocobo1
6ead0ae9ee Add lookup function to get PathType display names 2016-05-18 00:46:43 +08:00
Chocobo1
6ea89bf621 Improve wordings in "Auto download torrent" section 2016-05-16 14:29:59 +08:00
sledgehammer999
06be9edfe1 Remove watch folders permanently only if the user accepts the Preferences dialog. 2016-01-03 22:08:55 +02:00
sledgehammer999
9c88959651 Make it scroll horizontally when necessary. 2016-01-03 22:08:55 +02:00
sledgehammer999
429a1ba78a Method to update the watch path parameters. 2016-01-03 22:08:55 +02:00
sledgehammer999
990e33a4b1 Don't add the watch folder before the user closes the Preferences window. 2016-01-03 22:08:55 +02:00
sledgehammer999
56ca80eb78 Support loading multiple magnets/hashes/urls per .magnet file in the watched folder(one per line). Closes #217. 2016-01-03 22:08:55 +02:00
sledgehammer999
bc92f156c1 Improve the "Watch folders" UI. Closes #4300. 2016-01-03 22:08:55 +02:00
Vladimir Golovnev (Glassez)
9db93e5d8f Rename Core to Base (Closes #3733). 2015-12-06 14:27:00 +03:00
Renamed from src/core/scanfoldersmodel.cpp (Browse further)