Commit graph

192 commits

Author SHA1 Message Date
Frédéric Brière
e8f6149a6d findIncompleteFiles(): Replace dir listing with individual checks. Closes #6265.
Looking for incomplete files in a new torrent by using a pre-generated
directory listing presents several disadvantages:

  - It requires us to extract the top-level directory name (in case it
    was renamed).
  - It requires us to know whether the top-level directory was stripped.
  - In the latter case, it may result in recursively traversing the
    entire contents of all downloaded torrents.

Calling QFile::exists() individually for each file solves all these
issues.

In so doing, the handling of single-file and multiple-file torrents are
rendered pretty much identical, and can therefore be merged.
2017-04-30 09:26:58 -04:00
Vladimir Golovnev
93df0ef1d1 Move AddTorrentParams to its own header (#6712)
* Move AddTorrentParams to its own header

* fixup! Move AddTorrentParams to its own header
2017-04-29 11:49:40 +03:00
Vladimir Golovnev
70f1153413 Merge pull request #6694 from glassez/remove-temp
Remove torrent temp folder when it becomes unneeded
2017-04-29 11:44:15 +03:00
Vladimir Golovnev (Glassez)
160b7ff2d3 Remove torrent temp folder when torrent is deleted 2017-04-28 16:52:16 +03:00
Vladimir Golovnev (Glassez)
c56b4a25bc Remove torrent temp folder if it becomes unneeded 2017-04-28 12:30:48 +03:00
sledgehammer999
b71ee80ecd
Optimize P2P filter parsing too. 2017-04-26 02:33:57 +03:00
sledgehammer999
fd7e69e1e0
Add helper function for logging messages. 2017-04-26 02:33:56 +03:00
sledgehammer999
51cf6bd2a5
Optimize DAT filter parsing. Parse in memory and in place instead of copying strings around. 2017-04-26 02:33:55 +03:00
sledgehammer999
8f6e04d779
Using new IP parser provided by @evsh. It is faster and uses less memory.
Class `DATIPv4Parser` was written by Eugene Shalygin <eugene.shalygin@gmail.com> (evsh on github).
2017-04-25 04:43:30 +03:00
sledgehammer999
f53dab8ad4
Output log messages for ip filter parsing errors. 2017-04-25 04:43:29 +03:00
sledgehammer999
05ab9fc355
Optimize ip filter parsing. 2017-04-25 04:43:22 +03:00
Vladimir Golovnev (Glassez)
c799923d7d Allow strip root folder using default settings 2017-04-24 12:03:35 +03:00
Vladimir Golovnev (Glassez)
711be50e9c Fix AddTorrentData field types 2017-04-24 11:59:16 +03:00
Vladimir Golovnev (Glassez)
989a70fe60 Redesign RSS subsystem 2017-04-23 09:03:46 +03:00
sledgehammer999
ae0ec716cb
Fix inverted check when applying the IP filter. 2017-04-17 17:07:12 +03:00
sledgehammer999
c27108c97a Merge pull request #6630 from evsh/fix-6454
Start up torrents after UI was created. Fixes #6454.
2017-04-17 16:44:03 +03:00
Vladimir Golovnev (Glassez)
22178f9997 Fix strip torrent root folder 2017-04-15 17:33:20 +03:00
Vladimir Golovnev (Glassez)
6d7d566cdf Fix TorrentHandle rootPath() and contentPath() methods 2017-04-15 10:11:53 +03:00
Vladimir Golovnev (Glassez)
d413bc65ef Improve strip torrent root folder
Fix issue when you rename the "root item" in the "Add New Torrent" dialog
and uncheck "Create subfolder", it will create the subfolder with the
renamed name.
Fix PropertiesWidget first folder is expanded after app restart.
Strip root folder if torrent was added via magnet link.
Fix crash when you get name of torrent without metadata.
2017-04-15 10:11:53 +03:00
sledgehammer999
4b2d8a7941 Setting for creating subfolder on multifile torrents. Closes #588. 2017-04-15 10:11:53 +03:00
Eugene Shalygin
21a72c651f Start up torrents after UI was created. Fixes #6454.
Commit dd0537d changed torrents startup code adding alerts processing
into it. Therefore alerts were processed before UI code subscribed to
signals and therefore part of alerts was not reflected in the UI.

Thus here we do not start torrents in Session constructor, but do that
from Application::exec() after UI was constructed and is ready to process
signals.
2017-04-14 00:58:43 +02:00
Eugene Shalygin
a8d95dd8bd Save relative paths in fastresume files
Conditionally change absolute paths to relative in the fastresume data files.
The condition is specified by user via a command line parameter and
paths are relative to the profile dir.

On Windows the convertion to relative path is performed if the path and
the profile are on the same drive only.
2017-04-12 00:51:37 +02:00
Eugene Shalygin
0bf7fa15c1 Replace wrappers in base/utils/fs.h with Profile::SpecialFolders::location() 2017-04-12 00:50:33 +02:00
Eugene Shalygin
0f746ffd5a Add support for different configurations. Partially closes #465
It may be useful to have different configurations either for portable
versions or for debugging purposes. To implement this we add two
options, avaliable via command line switches
1. An option to change configuration name ("--configuration"). The name
supplied via this option is appended to
QCoreApplication::applicationName() to form "qBittorrent_<conf_name>"
name for the configuration files.
2. An option to provide a path do directory where all the settings are
stored (kind of profile directory). There is a shortcut "--portable"
which means "use directory 'profile' near the executable location".

In order to implement that we have to perform initialisation of the
profile directories before the SettingStorage and Preferences singletones
are initialised. Thus, options parsing shall be performed without defaults
read from preferences.
2017-04-12 00:50:28 +02:00
sledgehammer999
be60b3e046
Change the user-agent format in the session.cpp too. 2017-03-07 23:41:29 +02:00
sledgehammer999
147f4d76e2 Merge pull request #6445 from Chocobo1/fix
Follow http user-agent format
2017-03-07 23:38:14 +02:00
sledgehammer999
7a6da3d3ce
Merge pull request #6479 from Chocobo1/qt4
Remove remainings of Qt4
2017-03-07 23:28:56 +02:00
sledgehammer999
431658bee6
Fix race condition where there was a chance to allow all ips between reparsings of the ip filter. 2017-03-07 23:16:50 +02:00
sledgehammer999
5084c01c2b Merge pull request #5877 from dzmat/to_pull_request
locally banned IP list managment (Closes #1837 )
2017-03-07 23:14:20 +02:00
Vladimir Golovnev (Glassez)
79e8f69fb6 Remove exception-suppress macros
Remove SAFE_* macros from TorrentHandle class.
These macros using seems to be unneeded.
2017-03-07 15:04:57 +03:00
Chocobo1
fa2128cbae Replace Utils::String::fromStdString() by QString::fromStdString() 2017-03-07 19:42:44 +08:00
Chocobo1
ffdcfe9686 Replace Utils::String::toStdString() by QString::toStdString() 2017-03-06 23:58:38 +08:00
dzmat
59de1af31b implemented UI for managment of locally banned IP list (Closes #1837 ) 2017-03-06 19:40:34 +07:00
Chocobo1
2091dfaa69 Follow http user-agent format
Add version variable without the starting "v"
2017-03-06 14:42:32 +08:00
Chocobo1
cb1646be32 Prepend QBT_ for preprocessor variables 2017-03-06 13:41:58 +08:00
Eugene Shalygin
e64bb1de8c Drop Qt 4 support 2017-03-05 22:24:59 +01:00
sledgehammer999
b5f81a34cb
Use new create_torrent constructor were available. 2017-02-22 19:25:50 +02:00
sledgehammer999
4adcd03ec7 Merge pull request #6366 from Chocobo1/rand
Replace rand()
2017-02-20 01:49:27 +02:00
Chocobo1
511796f74e Replace rand() by a true uniform distribution generator 2017-02-16 12:21:26 +08:00
sledgehammer999
d045f64ebb Merge pull request #6288 from Falcosc/fix_add_torrent_queue_overflow
fix queue overload for add torrent at session start
2017-02-08 22:46:58 +02:00
falco
ee239ddd1e fix queue overload for add torrent at session start 2017-02-08 15:13:21 +00:00
sledgehammer999
25c7c297e8 Merge pull request #6317 from dzmat/public_to_private
reduce methods accessibility from public to private
2017-02-06 00:11:38 +02:00
sledgehammer999
5046c36458
Immediately update torrent_status after manipulating super seeding mode. Partially fixes #6072. 2017-02-05 22:02:33 +02:00
dzmat
b167b4174e reduce methods accessibility from public to private 2017-01-29 15:17:55 +07:00
Falco
84759d4f20 fix index overflow for torrents with invalid meta data or empty progress 2017-01-21 14:35:09 +01:00
sledgehammer999
fed325a54d Merge pull request #6140 from Chocobo1/relocateNoRemove
After files relocate, don't remove the old folder even if it is empty
2017-01-19 15:52:09 +02:00
sledgehammer999
dcab1da8ab Merge pull request #6138 from Chocobo1/stats2
Use the numbers from tracker scrape response
2017-01-19 11:49:47 +02:00
Chocobo1
a2bb947dcc After files relocate, don't remove the old folder even if it is empty. 2017-01-19 14:21:04 +08:00
Chocobo1
fa45ba102c Refactor 2017-01-19 14:21:04 +08:00
Chocobo1
72a6f7ae24 Use the numbers from tracker scrape response. Closes #5048, #6117.
Add comments
Thanks to Ian Kent for helping investigate
2017-01-19 13:17:50 +08:00
sledgehammer999
a178268b31 Merge pull request #5959 from dzmat/DRY_fix_minor
Little DRY violation fixed
2017-01-19 01:49:21 +02:00
sledgehammer999
a092cb9bda
Remove settings to exchange trackers. It wasn't used by non-libtorrent clients. Also it has a privacy risk and you might be DDoSing someone. DHT makes it obsolete anyway. 2017-01-19 01:13:55 +02:00
Eugene Shalygin
b6e64c13d8 Fetch torrent status when generating final fastresume data
This is done to get correct queue position, which has to be written into
the fastresume file. See discussion in #6154.
2017-01-18 18:59:03 +01:00
Eugene Shalygin
6cd233dd61 Add queue repair code
This is a bit adjusted code created by nxd4, who shared it in issue
disappearing).
2017-01-18 17:27:20 +01:00
Eugene Shalygin
4c13f155ff Do not remove added files unconditionally. Closes #6248
If removing of added torrents is enabled and dialog for adding torrents
is disabled, file guard was assuming that torrent is added successfully.
And that can be not the case if a user trying to add a broken torrent
file (or not a torrent file at all). Then this file gets deleted always.

Fix this by checking result of addTorrent_impl().
2017-01-18 00:04:26 +01:00
Eugene Shalygin
7b594a635e Set upper version limit for QTBUG-52633
The bug seems to be fixed in version 5.7.1.
2017-01-11 00:14:16 +01:00
sledgehammer999
4f59caf3ca Fix share ratio limiting. Broken by commit 259b5e51c4. Closes #6039 #6048. 2016-12-15 00:04:50 +02:00
Eugene Shalygin
9a123c42c3 Add a workaround for QTBUG-52633, qBt issue #5073
The QTBUG-52633 results in food of network interface changed events, libtorrent IP
rebind calls and flood in the qBt log. The work around is the check not only for
interface name, but for IP address on that interface before triggering the libtorrent rebind.
2016-12-13 17:18:58 +01:00
dzmat
abeff99ba0 minimizing the number of warnings about deprecated auto_ptr 2016-12-08 19:24:52 +07:00
sledgehammer999
0d1b70e248 Decouple dependency between Session and BandwidthScheduler during Session init. Closes #6007. 2016-12-07 01:33:48 +02:00
Chocobo1
11c2ee81c1 Fix warning C4267.
conversion from 'size_t' to 'int', possible loss of data.
2016-12-02 15:32:27 +08:00
dzmat
4b18bb29a6 DRY violation fixed 2016-11-18 23:05:47 +07:00
sledgehammer999
90bbe3379d Merge pull request #5882 from onto/pvs-studio
Fixes and improvements after check by PVS-Studio
2016-11-07 00:18:46 +02:00
thalieht
c7a04e27f4 Log: set embedded Tracker [OFF] msg type as info 2016-11-06 11:55:31 +02:00
Anton Lashkov
1233c5b67b Fix name of variable same as class member 2016-11-04 21:44:00 +04:00
sledgehammer999
259b5e51c4 Don't ever stop seeding forced torrents. Closes #5784. 2016-11-02 18:25:09 +02:00
sledgehammer999
146d4e049a Some more compiler warnings fixed. 2016-11-02 17:49:50 +02:00
sledgehammer999
9f8dfbc51c Fix warning due to stupid typo. 2016-11-01 22:24:55 +02:00
sledgehammer999
e440fc3d17 Fix setting a speed limit. 2016-11-01 17:51:57 +02:00
sledgehammer999
3081a8bb3f Add libtorrent's DHT bootstrap node to our bootstrap list. 2016-11-01 03:42:38 +02:00
sledgehammer999
660b8cdb7e Use the new API to add DHT bootstrap nodes for libtorrent 1.1.x and simplify the code a bit. 2016-11-01 03:42:33 +02:00
sledgehammer999
afe930cbee Use new libtorrent 1.1.2+ utility function to generate client ID instead. 2016-11-01 03:42:28 +02:00
sledgehammer999
e054f63746 Make sure that paths are loaded/saved using slashes as dir separators. 2016-11-01 03:42:22 +02:00
sledgehammer999
59b570cf62 Display message about libtorrent plugins for the correct case. 2016-11-01 03:42:17 +02:00
sledgehammer999
f391b24b1d Migrate last setting related to interfaces to the new system. 2016-11-01 03:42:12 +02:00
sledgehammer999
f885c6375a Use better variable names for tracker announce IP setting. 2016-11-01 03:42:01 +02:00
sledgehammer999
5cbc7b16c0 Guard the flag used for deferred session configure. 2016-11-01 03:41:45 +02:00
sledgehammer999
1757973f88 Misc fixes. 2016-11-01 03:41:40 +02:00
sledgehammer999
10cd45dc81 Fix setting limits to unlimited. 2016-11-01 03:41:35 +02:00
sledgehammer999
a5ae86512a Rename IP filtering functions and settings names. 2016-11-01 03:06:58 +02:00
sledgehammer999
b97cb7422f Export torrents added only after the setting was enabled. 2016-11-01 03:06:58 +02:00
sledgehammer999
124eddc68c Merge pull request #5342 from glassez/session
Optimize BitTorrent::Session settings applying
2016-11-01 03:02:29 +02:00
Vladimir Golovnev (Glassez)
c4e9291db4 Do not create save folder in advance
Closes #5422.
2016-06-26 16:48:11 +03:00
Vladimir Golovnev (Glassez)
b5fe749f0b Use new libtorrent-1.1 settings API 2016-06-20 08:30:02 +03:00
Vladimir Golovnev (Glassez)
b2cb473b63 Don't use Preferences in BitTorrent::Session 2016-06-20 08:30:02 +03:00
sledgehammer999
e3e7636de8 Fix parsing of eMule .DAT filters. Closes #5281. 2016-06-20 02:24:37 +03:00
Eugene Shalygin
5f2362dc89 Replace TorrentHandle::fileExtremityPieces() with TorrentInfo::filePieces() 2016-06-02 10:30:35 +02:00
Eugene Shalygin
b3378d4599 Show files in tooltips for pieces progress bars
In addition to the current tooltip, which shows color legend, if user
holds the Shift key during hovering we show another tooltip which
contains a table of contents for the piece under the moue cursor. The
table lists file sizes and names. If the cursor points to a part of a
file which spans several pieces, those pieces are highlighted.
2016-06-02 10:30:28 +02:00
sledgehammer999
5878d49f60 Fixup previous commits and allow IPv6 interface addresses too. 2016-05-27 01:37:16 +03:00
sledgehammer999
1397a951fe Merge pull request #5096 from Harekiet/kietC
Bind directly to an IP instead of using a network Interface
2016-05-26 17:36:22 -05:00
sledgehammer999
81ea07abee Rename ASM to TMM and related stuff. 2016-05-25 20:07:36 +03:00
Chocobo1
f13c604fbe Use boost:circular_buffer instead of QList.
QList has to store an additional pointer for each element which leads to bad space efficiency.
2016-05-24 10:44:42 +08:00
Vladimir Golovnev (Glassez)
a318040eaa Use new alert dispathing API 2016-05-17 07:58:38 +03:00
Eugene Shalygin
6e73fa80b8 Add option to automatically remove .torrent files upon adding
Some browsers do not download files, intended for immediate opening,
into a temporary directory, and thus a regular download directories
accumulate those unneeded files.

The option allows qBittorrent to clean after itself and delete those
files whether they were succesfully added or not (user-selectable
policy).
2016-05-09 11:52:36 +02:00
Chocobo1
a81cf1ea16 Fix "IP Filtering - Apply to trackers" wasn't being applied. Closes #5217. 2016-05-08 20:46:58 +08:00
sledgehammer999
0143799623 Don't show added torrent notification during startup. 2016-04-30 01:38:24 +03:00
Vladimir Golovnev (Glassez)
56287173b1 Fix .!qB extension is added when disabled 2016-04-25 15:30:41 +03:00
Vladimir Golovnev (Glassez)
b8c703b8b0 Use truncated torrent hash in temp path 2016-04-25 08:39:36 +03:00
Vladimir Golovnev (Glassez)
850556fdfa Use unique temp directories
Save torrent in temp_path/<torrent_hash> directory.
Closes #5154.
2016-04-25 08:39:36 +03:00
Vladimir Golovnev (Glassez)
2fb6bb00bf Fix rechecking after torrent is finished 2016-04-20 15:45:15 +03:00