mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-09 16:47:27 +03:00
Code Issues Projects Releases Packages Wiki Activity
9460 commits 16 branches 245 tags 256 MiB
Commit graph

8302 commits

Author SHA1 Message Date
Chocobo1
459cdf6071
Fix assertion fail 
When fileSize == 0, the second index could be smaller than the first index,
thus trigger the assert check in IndexInterval constructor.

Closes #10611.
 2019-05-15 10:22:21 +08:00
Evgeny Lensky
62c72091ce
Change "Add new torrent" dialog to horizontal layout 2019-05-14 11:03:56 +08:00
Chocobo1
c6f3da1097
Improve removeIf() to support set types 
We can now replace QMutable*Iterator by removeIf() which usage is more consistent with other
algorithm functions.
 2019-05-14 01:26:01 +08:00
Chocobo1
5aaf040300
Remove libtorrentfwd.h 2019-05-13 11:20:42 +08:00
Chocobo1
3955eef50d
Change to lt namespace 
Quoting from libtorrent doc:
> In the future, libtorrent will be the alias and lt the namespace name.
 2019-05-13 11:20:41 +08:00
Chocobo1
4b263f057d
Use newer libtorrent API 
This commit covers session.cpp only.
 2019-05-13 11:20:41 +08:00
Chocobo1
677a419f0b
Use upstream defined namespace 
`lt` namespace is defined since libtorrent 1.1.6 and our master branch requires >= 1.1.10,
so there is no need to add #if condition for it.
 2019-05-13 11:20:41 +08:00
Mike Tzou
6d73a7ef0a
Merge pull request #10618 from jerrymakesjelly/master 
Replace Bytes/s with KiB/s in the adding torrent dialogs in WebUI
 2019-05-12 13:50:46 +08:00
Vladimir Golovnev
af7d8f6a43
Merge pull request #10514 from Mataniko/rss-enclosure-type 
Download RSS "enclosure" element if no proper MIME type is found
 2019-05-11 13:31:46 +03:00
jerrymakesjelly
4b9f0a87cd Change the speed unit from Bytes/s to KiB/s 
Updated the adding torrent dialogs in WebUI. Closes #10017.
 2019-05-11 12:25:07 +08:00
Mike Tzou
ca0dad7356
Merge pull request #10590 from onlined/fix/close-system-tray-blank-screen 
Don't turn screen blank when closed to system tray
 2019-05-11 12:24:43 +08:00
Chocobo1
bd8d70bf60
Refactor HTTP query parsing 2019-05-09 12:41:30 +08:00
Chocobo1
69d29af097
Fix '+' char not decoded to space correctly 
Closes #10606.
 2019-05-09 11:17:41 +08:00
Matan Bareket
bd2d636bb5 Download RSS enclosure element if no proper MIME type is found 
In the case where an RSS feed doesn't have the "enclosure" element
with type "application/x-bittorrent", fallback to the last enclosure
element which has no "type" attribute.
 2019-05-08 13:46:13 -04:00
Mike Tzou
412b51fb3c
Merge pull request #10552 from CoryG89/webui-magnet-handler 
Register protocol handler in WebUI for magnet links
 2019-05-07 11:12:55 +08:00
Ekin Dursun
c0c2fe247b Don't turn screen blank when closed to system tray 
Closes #9240 and possibly #9121, as @zeule suggested here: https://github.com/qbittorrent/qBittorrent/issues/9240#issuecomment-408025722.
 2019-05-07 02:08:46 +03:00
Chocobo1
ae793b7395
Use upstream defined namespace alias 2019-05-06 20:26:15 +08:00
Chocobo1
56434fc8b9
Replace obsoleted QDateTime::fromTime_t() 2019-05-06 20:26:15 +08:00
Chocobo1
3f962ba336
Fix displaying invalid creation date 
The bug is only observed when using libtorrent 1.2.
 2019-05-06 20:26:14 +08:00
Chocobo1
3f10ac55a3
Migrate to update-to-date libtorrent functions 2019-05-06 20:26:14 +08:00
Cory
d49379789a Register protocol handler in WebUI for magnet links 2019-05-05 11:26:17 -07:00
Mike Tzou
3a3dec1707
Merge pull request #10445 from Chocobo1/crash 
Work around crashing in Qt networking library
 2019-05-03 22:54:25 +08:00
Chocobo1
8aa8b19f37
Fix "Create subfolder" option is not working in WebUI 
Closes #10392.
 2019-05-02 20:55:50 +08:00
Mike Tzou
2d7b833ae6
Merge pull request #10537 from Chocobo1/template 
Minor cleanups
 2019-05-01 23:51:23 +08:00
Chocobo1
aaed5f7fe0
Remove unused headers 2019-05-01 11:09:25 +08:00
Chocobo1
375de4f8a6
Replace QMap with QHash when sensible 2019-05-01 11:09:25 +08:00
Chocobo1
44e4a5b13a
Avoid performance penalty from type erasure 
On average the affected code path is 0.1% faster and the result binary
is 10 KB smaller.
 2019-05-01 11:09:25 +08:00
Mike Tzou
f9ac1d4cd5
Merge pull request #10518 from dzmat/more_graphs 
Add 12 hour and 24 hour speed graphs. Closes #9686
 2019-04-28 18:57:40 +08:00
dzmat
7de0f9abed Change number of time axis divisions from 5 to 6 for convenience 2019-04-22 00:15:13 +07:00
dzmat
0af17bf7e9 Add 12 hour and 24 hour speed graphs 2019-04-22 00:15:13 +07:00
Chocobo1
49b57904f9
Use a random number for WebUI cache busting 
Also fetch qbt version info via WebAPI properly.
 2019-04-18 12:31:23 +08:00
Chocobo1
d022457e0c
Use force refresh on WebUI logout 
Regardless of the cache header settings, the logout action should never be
allowed to load from cache.
 2019-04-17 20:17:26 +08:00
Chocobo1
6e1e7a45a1
Align WebUI login button to the right 2019-04-17 13:34:32 +08:00
Mike Tzou
18be4732b3
Merge pull request #10476 from Piccirello/webui-table-cell-hover 
Set title attribute for all WebUI table cells
 2019-04-17 13:13:45 +08:00
Thomas Piccirello
238ca03936 Set title attribute for all WebUI table cells 
Except the Progress Bar
 2019-04-15 22:44:28 -07:00
Mike Tzou
7db2d1b8cf
Merge pull request #10492 from Chocobo1/server 
Remove closed connections immediately
 2019-04-16 12:25:40 +08:00
Mike Tzou
c7f89f55d0
Merge pull request #10473 from Chocobo1/warning 
Fix unsafe type narrowing (MSVC C4267 warning)
 2019-04-16 12:23:30 +08:00
Chocobo1
a2a669572c
Use QSet for tracking server connections 
We don't need to maintain order between connections so QSet would be more suitable.
 2019-04-15 21:35:35 +08:00
Chocobo1
a35b6cc8dd
Remove closed connections immediately 
Previously it relied on a timer to drop dead connections but that proved to
be too slow when there is an incoming burst of connections.

Fixes #10487.
 2019-04-15 21:35:10 +08:00
Chocobo1
41773a5465
Fix unsafe type narrowing 
Appending the warning below:
qBittorrent\src\base/utils/version.h(176): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
qBittorrent\src\base/utils/version.h(185): note: see reference to function template instantiation 'std::array<T,2> Utils::Version<T,2,2>::parseList<StringsList>(const StringsList &)' being compiled
        with
        [
            T=unsigned short,
            StringsList=QList<QByteArray>
        ]
 2019-04-15 20:23:26 +08:00
CzBiX
d254a98662 Always use index.html as default page 2019-04-13 18:41:29 +08:00
Mike Tzou
19dfec1e0a
Merge pull request #10464 from thalieht/torrent-size-limit 
Increase the download request size limit from 10 to 100 MiB
 2019-04-11 10:14:49 +08:00
thalieht
2f3b7642c2 Show user friendly size in error 2019-04-10 11:39:27 +03:00
thalieht
25102b9c5d Increase the download size limit to 100 MiB 2019-04-10 11:39:27 +03:00
Mike Tzou
460b73ebda
Merge pull request #10438 from Chocobo1/timer 
Work around the crash occurred in QTimer
 2019-04-09 13:53:48 +08:00
Mike Tzou
4a02922bfb
Merge pull request #10458 from Chocobo1/post 
Correctly handle '+' sign in x-www-form-urlencoded data
 2019-04-09 13:53:12 +08:00
Chocobo1
4bf4313862
Initialize class variable via constructor 2019-04-08 23:29:14 +08:00
Chocobo1
94aeeed95f
Work around the crash occurred in QTimer 
See Qt commit:
https://code.qt.io/cgit/qt/qtbase.git/commit/src/corelib/kernel/qtimer.cpp?id=a623fe8d2a60ff333d5779f877e3b20f0e141ff1

Fixes #9985.
 2019-04-07 15:13:33 +08:00
Chocobo1
d86a984e25
Correctly handle '+' sign in x-www-form-urlencoded data 
Fixes #10451.
 2019-04-07 13:58:16 +08:00
thalieht
371a090cec Rename "Prefer encryption" to "Allow encryption" 
Because it actually prefers non-encryption but allows it if requested.
 2019-04-05 14:18:49 +03:00
Chocobo1
1ea61db1fb
Disable downloading tracker favicons by default 
Workaround for a crash in Qt networking library, source:
https://github.com/qbittorrent/qBittorrent/issues/9667#issuecomment-464445025

Closes #9667.
 2019-04-05 13:54:40 +08:00
Mike Tzou
e499317695
Merge pull request #10396 from Chocobo1/webui 
Document current WebUI browser compatibility
 2019-03-26 13:02:14 +08:00
Chocobo1
7e99ce6d7f
Document current WebUI browser compatibility 2019-03-23 12:32:20 +08:00
thalieht
3731a3ea65 Make num enter key work the same as return in searchjobwidget 2019-03-22 20:01:48 +02:00
Vladimir Golovnev
6de02b0f2a
Merge pull request #10373 from glassez/libtorrent-1.2 
Add preliminary support of libtorrent v1.2
 2019-03-19 06:08:22 +03:00
Vladimir Golovnev (Glassez)
ead078a38e
Add preliminary support of libtorrent v1.2 
libtorrent v1.2 should be built with deprecated features enabled.
 2019-03-18 15:17:03 +03:00
sledgehammer999
f403fdb2e8
Remove wrong ifdef 2019-03-17 14:15:50 +02:00
Mike Tzou
20f2c86d25
Merge pull request #10214 from AceLewis/master 
Remove autocorrect/autocapitalise in WebUI
 2019-03-17 15:05:19 +08:00
Mike Tzou
d1b0c230ed
Merge pull request #10366 from Chocobo1/logger 
Avoid performance penalty when logger is full
 2019-03-17 15:04:53 +08:00
Mike Tzou
05b6865618
Merge pull request #10365 from thalieht/adv-label-links 
Add documentation links to some advanced settings
 2019-03-15 14:34:33 +08:00
Chocobo1
b7d739ab3f
Fix build error 
Apparently the function is not available on Windows platforms.
 2019-03-15 14:29:54 +08:00
Chocobo1
cb9a160366
Utilize parent pointer appropriately 2019-03-15 14:29:07 +08:00
Chocobo1
874bc84efc
Remove excessive usage of pointer 2019-03-15 14:29:06 +08:00
Chocobo1
a3019f56b0
Clean up code 2019-03-15 14:29:06 +08:00
Chocobo1
04fd6e9d04
Avoid performance penalty when logger is full 2019-03-15 14:29:06 +08:00
thalieht
4c53447d35 Remove the max half-open connections option from GUI 
Its functionality was deprecated long ago.
 2019-03-13 21:08:40 +02:00
thalieht
bcfa62cc76 Rename "#" column to "Tier" in the tracker list 2019-03-13 21:08:40 +02:00
thalieht
cccaca0c01 Center align the section labels in advanced settings 2019-03-13 21:08:40 +02:00
thalieht
3fca49e44d Add documentation links to some advanced settings 2019-03-13 21:08:40 +02:00
Vladimir Golovnev
36f6e9b288
Merge pull request #9702 from knackebrot/master 
Fix building qbittorrent-nox on Windows
 2019-03-13 18:35:44 +03:00
Mike Tzou
c47d6b517a
Merge pull request #10355 from Chocobo1/label 
Improve AdvancedSettings::addRow()
 2019-03-11 00:25:35 +08:00
Vladimir Golovnev
928ce940c9
Merge pull request #10346 from glassez/download-manager 
Improve "Download manager"
 2019-03-10 09:13:07 +03:00
Vladimir Golovnev (Glassez)
4ee6a0ba29
Use Qt-provided HTTP redirection handling 2019-03-08 13:06:42 +03:00
Vladimir Golovnev (Glassez)
746916a963
Use DownloadHandler behind the scenes 2019-03-08 13:00:37 +03:00
sledgehammer999
c2d1af9853
Merge pull request #10338 from sledgehammer999/raise_qt5_ver 
Raise minimum Qt version to 5.9.0
 2019-03-08 00:42:26 +02:00
knackebrot
c7b451b18f Allow headless builds on Windows 
Daemonizing is disabled because no direct equivalent exists in win32.
 2019-03-07 13:59:10 +01:00
Chocobo1
f9e10616d0
Improve AdvancedSettings::addRow() 
1. Add context to connect().
2. Use QLabel in the left table cell, this allows using rich text formatting, such as HTML links.
 2019-03-07 16:22:23 +08:00
Mike Tzou
ccd8f3e0f1
Merge pull request #10340 from Chocobo1/move 
Move helper functions to Utils::Gui namespace
 2019-03-07 15:11:58 +08:00
paolo-sz
1ea7907e09 Add default tooltip "Searching..." on tab creation. 2019-03-05 20:36:49 +01:00
paolo-sz
22835c0350 Avoid crashes on torrent search 
qbittorrent closes itself without any error message when a search tab
should be notified of a status change: fixed bad pointer variable catch
in lambda code.
 2019-03-05 20:36:49 +01:00
Chocobo1
78b9eafed2
Replace deprecated qt_mac_set_dock_menu() 2019-03-05 17:17:07 +08:00
Vladimir Golovnev (Glassez)
6cb15706f5
Reduce number of DownloadManager signals 2019-03-05 11:28:29 +03:00
Chocobo1
adbd34c795
Move helper functions to Utils::Gui namespace 2019-03-05 14:55:22 +08:00
sledgehammer999
5c63ad3b95
Raise minimum Qt version to 5.9.0 2019-03-04 16:48:49 +02:00
Mike Tzou
4ce3cda676
Merge pull request #10319 from eszlari/patch-1 
Linux/Wayland: make window title bar icon work
 2019-03-03 12:40:59 +08:00
Mike Tzou
0f1fc7be9d
Merge pull request #10302 from Chocobo1/uptr 
Replace QScopedPointer with std::unqiue_ptr
 2019-03-02 12:26:14 +08:00
Peter Eszlari
9f250713d2 Linux/Wayland: make window title bar icon work 2019-02-28 22:41:08 +01:00
Chocobo1
3dd969df64
Replace deprecated QSignalMapper class 2019-02-28 12:03:08 +08:00
Chocobo1
c6ae1aa9d9
Replace deprecated QString::null 2019-02-28 12:02:03 +08:00
Chocobo1
6dab93f7fd
Replace deprecated QDesktopWidget class 2019-02-28 12:02:03 +08:00
Chocobo1
c657134344
Replace deprecated QSslSocket::setDefaultCiphers() 2019-02-28 12:01:36 +08:00
Chocobo1
168d3fbdac
Replace deprecated trUtf8() 2019-02-28 12:01:36 +08:00
Chocobo1
c33284fa8c
Add compile flag to show Qt deprecation warnings 2019-02-28 12:01:36 +08:00
Mike Tzou
46bc1d12b9
Merge pull request #10314 from thalieht/const2 
More const
 2019-02-28 11:33:35 +08:00
thalieht
77aea3c59e Add const to a few pointer arguments 2019-02-25 17:05:15 +02:00
thalieht
ce437817de Make various minor changes 2019-02-25 17:05:15 +02:00
thalieht
89dce36e98 Use uniform initialization on some default arguments 2019-02-25 17:05:15 +02:00
thalieht
8a19a0d4a0 Remove const in declarations' arguments that are passed by value 2019-02-25 17:05:15 +02:00
thalieht
70f1537d9f Add const to almost all remaining vars and arguments that qualify 2019-02-25 17:05:15 +02:00
Chocobo1
e5dca50025
Convert to use private pointer for ui object 2019-02-25 01:22:40 +08:00
Mike Tzou
bb041c0eca
Merge pull request #10292 from Chocobo1/rmInvalid 
Load torrent from data directly
 2019-02-21 23:18:02 +08:00
Mike Tzou
1c14a08390
Merge pull request #10296 from thalieht/clang-tidy 
Some suggestions from Clang-tidy
 2019-02-21 23:17:29 +08:00
Chocobo1
5c0d9b7eab
Load torrent from data directly 2019-02-20 00:14:41 +08:00
Chocobo1
5e3fddf456
Replace QScopedPointer with std::unqiue_ptr 
These 2 types are very similar and we should prefer the one from C++
standard library, this reduces the number of types in our code base.

Also see:
https://stackoverflow.com/questions/40346393/should-i-use-qscopedpointer-or-stdunique-ptr#comment67966940_40346991
 2019-02-18 16:06:40 +08:00
Chocobo1
8fe1ff87f1
Limit DownloadHandler max redirection to 20 
Closes #10219.
 2019-02-17 22:02:48 +08:00
thalieht
86df25a3e9 Remove some unused stuff 2019-02-16 18:54:18 +02:00
thalieht
8c944bd4e1 Avoid repeating the return type 2019-02-16 18:54:18 +02:00
thalieht
9959a901fe Replace deprecated header 'signal.h' with 'csignal' 2019-02-16 18:54:17 +02:00
thalieht
92a290895b Convert vars into refs to avoid copy construction from const refs 2019-02-16 18:54:17 +02:00
thalieht
400792d18e Use isEmpty() instead of size() for emptiness 2019-02-16 18:54:17 +02:00
thalieht
d8cbc9266a Use 'auto' to avoid duplicating the type name 2019-02-16 18:54:17 +02:00
thalieht
947c7e1d64 Convert to range-based for loop 2019-02-16 16:53:26 +02:00
Chocobo1
409557ef30
Clean up code 2019-02-15 19:47:06 +08:00
thalieht
8a3f942385 Don't use 'else' after return/break 2019-02-13 18:23:25 +02:00
Chocobo1
313a95bdd1
Log DownloadManager SSL errors 2019-02-13 20:09:08 +08:00
Mike Tzou
78ab0e4ba9
Merge pull request #10220 from thalieht/const 
Add const to many vars and arguments
 2019-02-13 12:11:00 +08:00
thalieht
445adb0ab4 Convert pass-by-value arguments to const refs where applicable 2019-02-12 02:45:55 +02:00
thalieht
ca3ce87e06 Add const to many vars and arguments 
Also remove const in declarations' arguments that are passed by value
 2019-02-11 20:19:41 +02:00
Mike Tzou
12aea82031
Merge pull request #10273 from Chocobo1/fix 
Fix wrong arg placeholder
 2019-02-10 13:31:09 +08:00
Chocobo1
79d7ba8205
Fix wrong arg placeholder 2019-02-09 21:26:45 +08:00
Vladimir Golovnev
0413a05246
Merge pull request #10242 from glassez/ordered-recheck 
Force recheck multiple torrents one by one. Closes #9120
 2019-02-08 08:19:30 +03:00
Mike Tzou
efed3fc78c
Merge pull request #10256 from Chocobo1/license 
Add license header
 2019-02-08 12:07:08 +08:00
Mike Tzou
c540e57f55
Merge pull request #10227 from Chocobo1/login 
Prevent login credential appearing in URL
 2019-02-07 13:16:24 +08:00
Mike Tzou
6f0a66ce26
Merge pull request #10255 from Chocobo1/algorithm 
Make use of std algorithms and C++14 features
 2019-02-07 10:45:40 +08:00
Chocobo1
364a837dbd
Revise comments about C++14 2019-02-05 13:35:54 +08:00
Chocobo1
6d29a3af60
Make use of std algorithms 2019-02-05 13:35:54 +08:00
Chocobo1
f789df7edf
Add license header 2019-02-04 17:28:55 +08:00
Vladimir Golovnev
e9f3e20e67
Merge pull request #10243 from glassez/content-menu 
Close context menu when torrent content model is reset. Closes #9522
 2019-02-02 21:13:41 +03:00
AceLewis
bfdd674054 Remove autocorrect/autocapitalise from filepaths on WebUI 2019-02-02 13:50:02 +01:00
Chocobo1
4483b72bfd
Move JavaScript code to its own file 2019-02-02 15:00:53 +08:00
Chocobo1
8096e49c24
Display warning when Javascript is disabled 2019-02-02 14:55:08 +08:00
Vladimir Golovnev (Glassez)
5a86c4ac52
Close context menu when content model is reset 
Closes #9522.
 2019-02-01 18:44:26 +03:00
Vladimir Golovnev (Glassez)
61925f74fd
Force recheck multiple torrents one by one 
Closes #9120.
 2019-02-01 18:15:54 +03:00
Chocobo1
32474b05c5
Remove mootools lib from login page 2019-02-01 13:38:14 +08:00
Chocobo1
814eef1e56
Fix wrong arg placehoder 2019-02-01 13:38:14 +08:00
Chocobo1
0738b3860b
Prevent login credential appearing in URL 
Closes #10221.
 2019-02-01 13:38:12 +08:00
Mike Tzou
40eb8a1f4a
Merge pull request #10175 from Chocobo1/cert 
Load WebUI certificate & key from file path
 2019-02-01 13:37:13 +08:00
Mike Tzou
0facdf3dfb
Merge pull request #10190 from Piccirello/webui-sorted-icon 
Fix direction of Web UI sorted column icon
 2019-02-01 13:20:54 +08:00
Vladimir Golovnev
5c00d89d57
Merge pull request #10231 from glassez/properties 
Improve Properties widget
 2019-01-31 12:03:46 +03:00
Mike Tzou
899b0c1104
Merge pull request #10096 from Piccirello/webui-libtorrent-version 
Match WebUI About page to GUI
 2019-01-31 13:14:46 +08:00
Chocobo1
52de31ac79
Add migration code for WebUI https related change 2019-01-29 12:52:42 +08:00
Vladimir Golovnev (Glassez)
c631dbdaa1
Improve Properties widget 
Drop redundant dependencies.
Refresh after BitTorrent session refreshing  (instead of using timer).
 2019-01-28 12:42:12 +03:00
Chocobo1
5cdb3b6a2d
Load WebUI certificate & key from file path 
This allow users to update certificate & key more easily, i.e. without the need to import them
into qbt.

Closes #6675, #7547, #8315, #8564.
 2019-01-28 16:33:48 +08:00
Chocobo1
48d358872f
Cleanup header inclusion 2019-01-28 14:34:13 +08:00
Vladimir Golovnev
5b82b681cb
Merge pull request #10225 from glassez/http-request 
Separate URL components before percent-decoding. Closes #9116
 2019-01-28 08:46:41 +03:00
sledgehammer999
bb3ad8acd3
Merge pull request #10191 from sledgehammer999/drop_google 
Don't query Google for tracker favicons
 2019-01-27 22:19:56 +02:00
sledgehammer999
6fdc02f947
Merge pull request #10201 from sledgehammer999/dead_code 
Remove leftover tracker authentication code
 2019-01-27 22:19:21 +02:00
Vladimir Golovnev (Glassez)
b0446380c6
Separate URL components before percent-decoding 
Allow special characters in query string parameters.
Closes #9116.
 2019-01-27 15:33:19 +03:00
Mike Tzou
fc534e88a3
Merge pull request #10155 from Chocobo1/exception 
Remove exception handling
 2019-01-23 13:44:34 +08:00
sledgehammer999
4a414d50f1
Remove leftover tracker authentication code 2019-01-23 02:38:46 +02:00