Commit graph

147 commits

Author SHA1 Message Date
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
2018-04-11 17:01:43 +03:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern
Don't create temporary containers just to iterate over them
2018-03-19 13:06:01 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.

Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.

Found using clazy.
2018-03-18 16:22:12 +03:00
Chocobo1
423511765a
Fix typo 2018-03-14 23:37:08 +08:00
Chocobo1
0457fd260e
Avoid temporary QString allocations
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
2018-03-07 20:06:00 +08:00
thalieht
525fdd6c2b Coding style, use nullptr and other minor things 2017-10-08 10:20:54 +03:00
Chocobo1
551ffb88ab
Define QT_USE_QSTRINGBUILDER.
The old defines are deprecated.
QT_USE_QSTRINGBUILDER also supports QByteArray which we use extensively
in WebUI.
2017-08-29 13:37:29 +08:00
Vladimir Golovnev (qlassez)
cff6a64e9f
Use qUtf8Printable() for logging strings
qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments
to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding.
Therefore qUtf8Printable() should be used for logging strings instead of
qPrintable().
2017-08-13 16:14:57 +03:00
sledgehammer999
d3ccbe4f86
Fix format-truncation warning. 2017-06-01 01:09:25 +03:00
Eugene Shalygin
74cecb1b6c Replace C-style casts with C++ ones 2017-05-29 17:25:42 +02:00
Chocobo1
42c17ea5ce Fix argument name differ in definition & declaration 2017-05-09 14:12:36 +08:00
sledgehammer999
0a5bb6685f Merge pull request #6654 from Chocobo1/persistence
Webui server fixes
2017-04-30 16:34:23 +03:00
Eugene Shalygin
c4e16aa820 cmake: set warning and error options
The set is far from perfect, but guards against common errors with GCC.
2017-04-29 13:30:28 +02:00
Vladimir Golovnev (Glassez)
989a70fe60 Redesign RSS subsystem 2017-04-23 09:03:46 +03:00
Chocobo1
617f19e599 Revise Utils::Gzip::decompress
Rename from uncompress to decompress
Change signature
Use proper casting
Use larger buffer for the output of inflate()
Reserve 1 MBytes for output buffer
Change function signature
2017-04-20 22:26:35 +08:00
Eugene Shalygin
0bf7fa15c1 Replace wrappers in base/utils/fs.h with Profile::SpecialFolders::location() 2017-04-12 00:50:33 +02:00
Chocobo1
2091dfaa69 Follow http user-agent format
Add version variable without the starting "v"
2017-03-06 14:42:32 +08:00
Chocobo1
cb1646be32 Prepend QBT_ for preprocessor variables 2017-03-06 13:41:58 +08:00
Eugene Shalygin
e64bb1de8c Drop Qt 4 support 2017-03-05 22:24:59 +01:00
sledgehammer999
ba03fb30f3 Merge pull request #5987 from Chocobo1/temp_dir
Put temp files in .qBittorrent directory
2017-01-19 01:33:57 +02:00
Chocobo1
ab187f06da Fix unused variable warnings 2016-12-07 01:31:39 +08:00
Chocobo1
cffa729ac5 Put temp files in .qBittorrent directory. Closes #4462. 2016-12-01 01:39:27 +08:00
sledgehammer999
6053390bf5 Unify and simplify setting to use proxy for torrents only. 2016-11-01 03:41:51 +02:00
sledgehammer999
1757973f88 Misc fixes. 2016-11-01 03:41:40 +02:00
sledgehammer999
124eddc68c Merge pull request #5342 from glassez/session
Optimize BitTorrent::Session settings applying
2016-11-01 03:02:29 +02:00
sledgehammer999
3ea81be2cc Merge pull request #5731 from thalieht/webui_port
Fix WEBUI port overflow
2016-09-13 23:54:01 +03:00
thalieht
6ec1c61b06 fix webui port overflow 2016-09-11 23:41:14 +03:00
ngosang
83d6a28030 Fix warning in geoipdatabase.cpp 2016-08-29 22:11:05 +02:00
sledgehammer999
d411d8b3a1 Merge pull request #5549 from briankendall/smtp_ssl_bug_fixes
Fixes bug where sending email could silently fail
2016-08-25 20:45:11 -05:00
SagePtr
c63da264d7 Update geoipdatabase.cpp
Updated MaxMind database limit from 10MB to 64MB. I hope it will be enough
for few years. Fix for issue #5609
2016-08-26 02:23:17 +02:00
Brian Kendall
da412571e4 Better error handling with smtp communication.
Adds log messages for a number of situations where sending an email will silently fail, in particular when attempting to create an unencrypted connection to an SMTP server that requires SSL
2016-08-25 17:57:26 -04:00
Vladimir Golovnev (Glassez)
b5fe749f0b Use new libtorrent-1.1 settings API 2016-06-20 08:30:02 +03:00
Vladimir Golovnev (Glassez)
b2cb473b63 Don't use Preferences in BitTorrent::Session 2016-06-20 08:30:02 +03:00
Vladimir Golovnev (Glassez)
c982813acb Create basic cookies management dialog 2016-04-11 19:14:28 +03:00
funkydude
268a5a95c8 Move some URLs overs to https 2016-03-14 17:01:51 +00:00
Chocobo1
f83f3b84ca Follow project coding style. Issue #2192. 2016-02-22 03:18:37 +08:00
Chocobo1
60417a598a Simplify statement 2016-02-22 03:18:35 +08:00
Chocobo1
41fe85b624 Fix malformed date header in email. Closes #4828. 2016-02-22 03:18:02 +08:00
Vladimir Golovnev (Glassez)
ea8acf3bbd Fix unitialized scalar field bugs 2016-01-15 09:44:10 +03:00
Vladimir Golovnev (Glassez)
4965704b10 Fix NetworkCookieJar::deleteCookie() behavior to match Qt5 one 2016-01-13 20:24:54 +03:00
Vladimir Golovnev (qlassez)
881108057d Use DownloadManager by DNSUpdater 2016-01-04 05:51:50 +03:00
Vladimir Golovnev (qlassez)
e378a65508 Use DownloadManager by ProgramUpdater
Closes #2023
2016-01-04 05:49:02 +03:00
Vladimir Golovnev (qlassez)
0bffa066db Make DownloadManager to save/load cookies 2015-12-22 14:02:14 +03:00
Chocobo1
d203f39f0a Update ISO 3166 country codes. Closes #3942. 2015-12-07 09:44:55 +08:00
Vladimir Golovnev (Glassez)
9db93e5d8f Rename Core to Base (Closes #3733). 2015-12-06 14:27:00 +03:00