Commit graph

7093 commits

Author SHA1 Message Date
Eugene Shalygin
64b250903f Merge pull request #7083 from tgregerson/tags
Improve tag selection context menu. Closes #7060
2017-08-03 21:06:08 +02:00
Tony Gregerson
c5e73219bf Improve checkbox interface for selecting tags in the context menu. Closes #7060 2017-08-02 19:27:00 -05:00
Vladimir Golovnev (Glassez)
5f47d3b021 Don't create subfolder inside temp folder 2017-07-29 18:04:23 +03:00
Vladimir Golovnev (Glassez)
d22b626a02 Fix temporary subfolder isn't deleted 2017-07-28 15:16:02 +03:00
Allan Nordhøy
af9c0cca23 display, URLs, esc ' 2017-07-28 02:42:35 +02:00
sledgehammer999
dcba10f01b
Sync translations from Transifex and run lupdate. 2017-07-27 19:16:30 +03:00
Mike Tzou
5bc3b0138e Merge pull request #7110 from Chocobo1/plugin_signal
Fix crash when exiting qbt with search plugin update dialog open
2017-07-21 10:40:54 +08:00
Chocobo1
e7ee59c12f Specify context parameter in connect() 2017-07-20 13:26:36 +08:00
Chocobo1
24a69a9fe7 Fix crash when exiting qbt with search plugin dialog open
Avoid emitting signal in destructor
2017-07-20 13:26:36 +08:00
vit9696
7b4316ea8f Fix main menu item location on macOS 2017-07-19 23:48:42 +03:00
vit9696
6c3ab99e3c Fix file type icons not displaying on macOS 2017-07-19 21:37:38 +03:00
sledgehammer999
802cd89ec9
Bump API_VERSION and API_VERSION_MIN to 15. 2017-07-18 22:38:59 +03:00
sledgehammer999
aa1ddc0df2
Fix typo. 2017-07-18 03:32:06 +03:00
Tom Piccirello
11b44407af Add Status column to webui (addresses #6815) (#7032)
* Add Status column to webui (addresses #6815)
2017-07-17 14:26:52 +08:00
Chocobo1
e73db85fad Use Qt5 connect syntax 2017-07-16 15:03:25 +08:00
Chocobo1
ec16525164 Fix "QObject::connect: No such slot" errors
Fixup of d25467d3e6
2017-07-16 15:03:25 +08:00
Chocobo1
1f9eb594e7 Trim whitespaces 2017-07-16 11:47:53 +08:00
vit9696
d25467d3e6 Various macOS UI improvements 2017-07-15 20:49:40 +03:00
Eugene Shalygin
c614c66535 Install required plugins into bundle
Install platform and svg plugins into bundle. Update dependencies in
Travis.
2017-07-14 17:42:02 +02:00
Mike Tzou
a6bb642200 Merge pull request #7096 from Chocobo1/fix
[WebUI] Load the domain list at least once on startup
2017-07-13 17:34:35 +08:00
Eugene Shalygin
22ea0be917 Merge pull request #7099 from evsh/set-inet-outgoing
Set interface for outgoing traffic.
2017-07-13 11:13:07 +02:00
Eugene Shalygin
934133772e Set interface for outgoing traffic.
This sets interface for outgoing traffic to the same as for ingoing
(listetning) with libtorrent 1.1.x.
2017-07-12 21:28:00 +02:00
Chocobo1
07780b48c5 Load the domain list at least once on startup.
Fixup of 0532d546d7
2017-07-13 00:41:30 +08:00
Chocobo1
0532d546d7
Implement HTTP host header filtering
This filtering is required to defend against DNS rebinding attack.
2017-07-12 17:26:13 +03:00
Chocobo1
18651c8d01
Use Qt5 connect syntax 2017-07-12 17:26:11 +03:00
Chocobo1
55e038b165
Avoid modifing request headers 2017-07-12 17:26:05 +03:00
Eugene Shalygin
23616d5dd0 Merge pull request #7064 from evsh/cachesettingvalue-enum
Implement enum support in CachedSettingValue
2017-07-11 16:03:20 +02:00
Eugene Shalygin
3aff71020f Merge pull request #7087 from LordNyriox/patch-2
Create README for "qbt-theme"
2017-07-11 11:47:02 +02:00
Mike Tzou
f345d0f136 Merge pull request #7082 from Chocobo1/js
[WebUI] Fix value comparison
2017-07-11 17:23:32 +08:00
Eugene Shalygin
d397cf60fb Merge pull request #7065 from evsh/win-svg-tray-icon
Use SVG files for monochrome tray icons. Closes #6085.
2017-07-11 10:51:37 +02:00
LordNyriox
28f336f5bd Create README for "qbt-theme" 2017-07-10 08:56:48 -07:00
Chocobo1
be61e8f2fd Revert back to intended fallthrough
Partial revert a7f4ea8b18
2017-07-10 00:36:56 +08:00
Chocobo1
448d937c15 Fix value comparison. Closes #7081.
`category` could be 'undefined'.
Fixup of a7f4ea8b18.
2017-07-09 22:31:14 +08:00
Eugene Shalygin
228f82bcdc Merge pull request #6967 from thalieht/codingStyle
Coding style for several files
2017-07-06 18:17:02 +02:00
sledgehammer999
7a478424cc
Revert "Drop python2 support.". Closes #7005.
This reverts commit 7d030b4cd9.
2017-07-06 01:07:09 +03:00
Eugene Shalygin
e66dba6a2d Use SVG files for monochrome tray icons. Closes #6085. 2017-07-05 22:00:02 +02:00
Eugene Shalygin
ff710ebd2c fixup! Implement enum support in CachedSettingValue 2017-07-05 13:41:08 +02:00
Eugene Shalygin
a22d2f0139 Implement enum support in CachedSettingValue
Enums are stored as strings, that improves configuration file
readability and maintainability. String values are obtained via
QMetaEnum, and since with Qt 5.5 QMetaEnum::fromType() includes a
static_assert, this has to be a safe method.
2017-07-05 12:41:58 +02:00
Mike Tzou
db2dec3d28 Merge pull request #7031 from Piccirello/fix-js-errors
Fix various javascript errors and follow best practices
2017-07-05 15:03:09 +08:00
Mike Tzou
726e9f0774 Merge pull request #7030 from Piccirello/failed-attempts-auth
Skip webui username/password check for active sessions
2017-07-05 15:02:24 +08:00
sledgehammer999
8e6df572a8 Merge pull request #6156 from evsh/file-icons
Use system file type specific icons in contents tab
2017-07-03 18:06:22 +03:00
Eugene Shalygin
57493c5556 Add QFileIconProvider implementation using mime database
If built-in QFileIconProvider does not seem to work, use custom
implementation which queries mime database.
2017-07-03 16:49:19 +02:00
Eugene Shalygin
30bf6e958f Use system file type specific icons in contents tab
The icon is determined via QFileIconProvider using filename extension only.
2017-07-03 16:49:14 +02:00
Eugene Shalygin
6b65f8add8 Do not show completion when text is not being edited 2017-07-03 12:57:02 +02:00
Eugene Shalygin
8318f72a9e Follow project coding style. Issue #2192. 2017-07-03 11:42:30 +02:00
Eugene Shalygin
11f5738d99 Fix build. 2017-07-03 10:36:52 +02:00
Eugene Shalygin
62be2d7400 cmake: fix build 2017-07-03 10:36:42 +02:00
Thomas Piccirello
a7f4ea8b18 Fix javascript errors and follow best practices 2017-07-01 03:28:35 -04:00
Thomas Piccirello
cd5a55d711 Skip username/password check for active sessions (closes #6860) 2017-07-01 03:26:15 -04:00
thalieht
91f528bc96 Fix coding style for several files
trackerlist
autoexpandabledialog
previewselect
shutdownconfirmdlg
torrentcontentfiltermodel
torrentcontenttreeview
peerlistsortmodel.h
2017-06-30 23:44:12 +03:00
Vladimir Golovnev
4d28f8f48d Fix RSS with normal links do not work (#7016)
Fix regression of RSS code redesign.
Closes #7003.
2017-06-30 11:16:40 +03:00
Vladimir Golovnev
3181469d87 Merge pull request #6911 from tgregerson/tags
Add a Tags system to the GUI to expand torrent organization / filtering options. Closes #13.
2017-06-26 15:57:27 +03:00
Tony Gregerson
467e516801 Add a Tags (multi-label) feature to the GUI. Closes #13.
See https://github.com/qbittorrent/qBittorrent/issues/13 for details.
2017-06-25 13:53:07 -05:00
sledgehammer999
70ae05c3de
Pad shorter python versions. Closes #6877. 2017-06-25 17:20:51 +03:00
sledgehammer999
7d030b4cd9
Drop python2 support. 2017-06-25 17:20:50 +03:00
sledgehammer999
a77e1c9f36
Use qt5 connect style for searchengine, pluginselectdlg and searchwidget. 2017-06-22 18:54:30 +03:00
sledgehammer999
dee0b63cc5
Aggregate installed/updated plugin names and use a single messagebox to inform the user. 2017-06-22 18:54:29 +03:00
sledgehammer999
c2a2d306da
Use alternative method for plugin favicon validity. Drop unnecessary code. 2017-06-22 18:54:28 +03:00
sledgehammer999
34c29b78f9
Update the backend when a new plugin favicon is downloaded. 2017-06-15 22:32:43 +03:00
sledgehammer999
8c98c8cb3f
Put copyright warning message to the search plugin dialog. 2017-06-15 22:32:42 +03:00
sledgehammer999
fc543b9db6
Display instructions when no search plugin is installed. 2017-06-15 22:32:41 +03:00
sledgehammer999
793ed7148f
Remove code that expects bundled search plugins. 2017-06-15 22:32:40 +03:00
sledgehammer999
de74f9298f
Remove all search plugins from repo. 2017-06-15 22:32:39 +03:00
sledgehammer999
4ab117d946
Remove possible double check of the same thing. 2017-06-15 22:32:38 +03:00
sledgehammer999
d88f0f36e0 Merge pull request #6889 from Chocobo1/lowercase
Convert all http header name constants to lowercase
2017-06-14 02:38:57 +03:00
sledgehammer999
fd05f5dec5 Merge pull request #6887 from Chocobo1/csrf_relax
[WebUI] relax CSRF defense. Closes #6882.
2017-06-14 02:37:33 +03:00
Eugene Shalygin
fff6640127 Merge pull request #6820 from evsh/fspathedit-visual-feedback
Add visual feedback for wrong paths in FileSystemPathEdit
2017-06-10 20:19:39 +02:00
Eugene Shalygin
574fed04fc Add visual feedback for wrong paths in FileSystemPathEdit 2017-06-10 17:09:20 +02:00
Vladimir Golovnev (Glassez)
66aeafdc63 Fix crash in ArticleListWidget
ArticleListWidget::handleArticleList() can be called inside
ArticleListWidget::handleArticleAboutToBeRemoved() and list widget
item can be removed at this point. Now we checking for it existence.
Closes #6896.
2017-06-07 18:24:43 +03:00
sledgehammer999
4a1ed9ff0e Merge pull request #6898 from Chocobo1/timeout
Fix keep alive duration was wrongly in milliseconds instead of seconds
2017-06-07 18:02:37 +03:00
Chocobo1
8419ca87f9 Fix KEEP_ALIVE_DURATION value
I intended to specify 7 seconds, which should be 7000 milliseconds
2017-06-07 21:45:47 +08:00
Mike Tzou
6f6a17341f Merge pull request #6859 from Chocobo1/cookie_select
Manage Cookies dialog improvements
2017-06-05 11:58:09 +08:00
Vladimir Golovnev
c503583046 Merge pull request #6864 from glassez/rss
Improve RSS Article handling
2017-06-02 19:47:08 +03:00
Chocobo1
45c21f62f9 [WebAPI] Convert all header name constants to lowercase
This save us another transition when some day we implements HTTP/2
(which all headers are in lowercase).
2017-06-02 21:55:16 +08:00
Chocobo1
cdb8f4bc61 [WebUI] relax CSRF defense. Closes #6882.
Allow HTTP request which has neither Origin nor Referer header included
2017-06-02 21:16:06 +08:00
sledgehammer999
b5c0d90e9c Merge pull request #6842 from Chocobo1/countPieces
[TorrentCreator] Show total number of pieces. Closes #6774.
2017-06-02 08:56:10 +03:00
Chocobo1
087856d3d8
[WebUI]: Implement CSRF defense
Bump API version
2017-06-01 19:37:57 +03:00
Vladimir Golovnev (Glassez)
4021bf68f7 Use constants for article field names in RSS::Feed 2017-06-01 16:04:11 +03:00
Vladimir Golovnev (Glassez)
02f77a05dc Improve RSS article parsing
Use QLatin1String for string literals.
Use predefined constants for article hash table keys.
2017-06-01 16:04:10 +03:00
Vladimir Golovnev (Glassez)
080dd79875 Store all RSS Article data in auto downloading job 2017-06-01 16:04:04 +03:00
Vladimir Golovnev (Glassez)
475348595c Improve RSS::Article class
Store more RSS article fields.
Don't use legacy article field names in Parser code.
2017-06-01 15:57:14 +03:00
sledgehammer999
34c7465009 Merge pull request #6871 from KingLucius/googlefavicon
Fetch Favicons via google
2017-06-01 15:12:30 +03:00
sledgehammer999
ace68d4961 Merge pull request #6874 from evsh/no-old-style-cast
Disable warnings in the bundled QtSingleAppplication and fix CMake builds in Travis
2017-06-01 15:10:18 +03:00
Eugene Shalygin
72cb868224 cmake: disable warnings for bundled QtSingleApplication 2017-06-01 10:14:09 +02:00
sledgehammer999
d3ccbe4f86
Fix format-truncation warning. 2017-06-01 01:09:25 +03:00
KingLucius
1b9882b3a3 Fetch Favicons via google 2017-05-31 22:21:25 +02:00
Mike Tzou
70d0fb741f Merge pull request #6870 from Chocobo1/ui
Fix focusing on the previously opened dialog didn't work
2017-05-31 12:26:27 +08:00
Chocobo1
4a4e3a13e6 Fix focusing on the previously opened dialog didn't work
Placing modeless dialog A on top of modeless dialog B, then open dialog B again,
the expected behavior is B on top of A.
2017-05-30 14:09:01 +08:00
Eugene Shalygin
ff80208534 Merge pull request #6868 from evsh/no-old-style-cast
Replace C-style casts with C++ ones
2017-05-29 17:47:01 +02:00
Vladimir Golovnev (Glassez)
a8bcc2ee52 Fix empty statusbar showed after app restarted 2017-05-29 18:38:17 +03:00
Eugene Shalygin
74cecb1b6c Replace C-style casts with C++ ones 2017-05-29 17:25:42 +02:00
Chocobo1
1ac7d779a7 Set expiration date for newly added cookie to +2 years from now, instead
of +99 years.

This fixes the ambiguity that users could assume the date was in the
past, but in fact it's in the future.
Ex. now date is 5/28/17, +99 years = 5/28/16, +2 years = 5/28/19
2017-05-29 14:10:47 +08:00
Chocobo1
a585b02e76 Enable alternatingRowColors for "Manage Cookie" dialog
Set editTriggers property to AllEditTriggers for easier editing.
Now a single mouse click can initiate item editing instead of double
clicking.
2017-05-29 14:10:47 +08:00
Chocobo1
d8083dd985 Allow to select & delete multiple entries in "Manage Cookies" dialog 2017-05-29 14:10:47 +08:00
Noam Gal
bd90614413 Get more RSS article data 2017-05-28 10:17:59 +03:00
Vladimir Golovnev
e3671050d1 Merge pull request #6840 from glassez/statusbar
Add show/hide statusbar option (Supersede #4029)
2017-05-27 22:22:34 +03:00
KingLucius
dedd31ada5 Fix crash when delete RSS feed 2017-05-27 13:52:32 +02:00
Eugene Shalygin
ae5932a573 Merge pull request #6848 from evsh/fix-piecebar-crash
Fix crash in download piece bar
2017-05-27 13:24:14 +02:00
Mike Tzou
20f6bf817e Merge pull request #6836 from Chocobo1/api
[WebAPI] Get piece information/state
2017-05-27 18:28:22 +08:00
Chocobo1
c618214061 [TorrentCreator] Show number of pieces. Closes #6774. 2017-05-27 16:37:08 +08:00
Eugene Shalygin
6d9eec0e71 Fix crash in download piece bar
When torrent size is smaller than the image width, bytes per pixel was
set to zero and code was crashing. Set it to -1 instead, as we do when
image is empty. This will disable highliting, but our algorithm does not
work in this case anyway.
2017-05-26 21:47:51 +02:00
Mike Tzou
b6080c19c2 Merge pull request #6834 from Chocobo1/cookie
[WebUI] Make cookie parsing robust
2017-05-26 23:56:35 +08:00
Vladimir Golovnev (Glassez)
c456b9a42c Refactor and improve StatusBar 2017-05-26 18:11:26 +03:00
Chocobo1
3933790bda Add new webUI API. Closes #6457.
Now getting piece information for a specific torrent is possible via:

* Returns an array of states (integers) of pieces in order. Defined as:
  "0=not downloaded", "1=downloading", "2=downloaded".
  GET /query/getPieceStates/<torrent_hash>

* Returns an array of hashes (strings) of pieces in order:
  GET /query/getPieceHashes/<torrent_hash>
2017-05-26 14:37:03 +08:00
takiz
0940a8a764 Add show/hide statusbar option 2017-05-25 16:35:21 +03:00
Chocobo1
f35a5c8085 [WebUI] Make cookie parsing robust
Previously cookie name such as "<any string>SID" will be mistakenly
accepted as "SID" session ID, this commit fixes it.

Use QString::isEmpty()
2017-05-25 18:45:07 +08:00
Chocobo1
712e6a0e5c Refactor out helper function Utils::String::unquote
Remove redundant include
2017-05-25 18:44:35 +08:00
Mike Tzou
1f9ccb44a3 Merge pull request #5196 from Chocobo1/creator_pr
Revamp Torrent creator
2017-05-24 17:40:10 +08:00
Mike Tzou
92decf83b8 Merge pull request #6330 from Chocobo1/rename
Fix renaming files is not case sensitive on Windows platform
2017-05-24 13:12:30 +08:00
Chocobo1
7eed1a108e Rename variables
Add myself to authors list
2017-05-24 11:54:42 +08:00
Chocobo1
7e87eeb2d4 Use QThread::requestInterruption() instead of m_abort flag 2017-05-24 11:54:42 +08:00
Chocobo1
60524348f0 Enlarge combobox to fix its contents 2017-05-24 11:54:42 +08:00
Chocobo1
9f2fe2b678 Move CachedSettingValue instances to header file 2017-05-24 11:54:42 +08:00
Chocobo1
a4141fd151 Simplify m_creatorThread initialization 2017-05-24 11:54:42 +08:00
Chocobo1
7de1aba092 Switch to modeless dialog
Don't close dialog after creating torrent
Show progress bar all the time
2017-05-24 11:54:42 +08:00
Chocobo1
d277696acc Add global.h file 2017-05-24 11:54:42 +08:00
Chocobo1
2e8c01d88c Use CachedSettingValue 2017-05-24 11:54:42 +08:00
Chocobo1
908481885c Enable drag n drop to create torrent on mainwindow 2017-05-24 11:54:42 +08:00
Chocobo1
386b93bb0f Fix the file size sum igonred files starting with a dot: ".name"
Make the computation iterative instead of recurisve to avoid stack overflow.

Enlarge read size to enable better performance.
Remove `QFile::close()` calls, QFile automatically close them in dtor.
2017-05-24 11:54:42 +08:00
Chocobo1
8efcc335de Switch to use SettingsStorage class 2017-05-24 11:54:42 +08:00
Chocobo1
009798f690 Follow header include rule 2017-05-24 11:54:42 +08:00
Chocobo1
6bab30a178 Revamp Torrent creator 2017-05-24 11:54:42 +08:00
Mike Tzou
ced52e3269 Merge pull request #6827 from naikel/webui_filter_fix
Fix slow filtering in WebUI
2017-05-24 00:02:22 +08:00
Naikel Aparicio
03b2decab6 Fix slow filtering in WebUI. Fixup 7aadf644e0. 2017-05-22 09:19:03 -04:00
Eugene Shalygin
47960b2592 Merge pull request #6818 from naikel/webui_fix
Cosmetic fixes for WebUI upload and download windows
2017-05-22 13:27:01 +02:00
Eugene Shalygin
b82edc561f Merge pull request #6821 from evsh/do-not-hardcode-rss-colors
Do not use hardcoded colors in RSS feed view
2017-05-22 10:58:02 +02:00
Eugene Shalygin
e99e88bbe7 Merge pull request #6811 from KingLucius/ETplugin
[Search engine] Remove ExtraTorrent plugin
2017-05-21 14:26:54 +02:00
Eugene Shalygin
72da2e7252 Do not use hardcoded colors in RSS feed view 2017-05-21 13:02:34 +02:00
Naikel Aparicio
9fc6de77ca Cosmetic fixes for WebUI upload and download windows 2017-05-20 16:01:24 -04:00
Chocobo1
d8c0a40b1f Add explicit error handling when filesCount() returns negative value
Fix coverity CID 162538
2017-05-20 14:01:58 +08:00
Chocobo1
562080de69 Initialize variable
Fixes coverity CID 161628
2017-05-20 11:38:39 +08:00
Mike Tzou
c3b1c57d67 Merge pull request #6807 from Chocobo1/icon
[Quick Fix] Set icon height in html instead of js
2017-05-20 11:18:02 +08:00
Mike Tzou
7f089db942 Merge pull request #6802 from Chocobo1/size
[Quick Fix] Cleanup options dialog
2017-05-20 11:17:44 +08:00
KingLucius
ebc50a7237 remove ExtraTorrent plugin 2017-05-19 16:36:56 +02:00
Mike Tzou
ce36a7ca62 Merge pull request #6498 from thalieht/trackerList
Trackerlist: Add toggle columns menu
2017-05-19 15:06:42 +08:00
Chocobo1
5529a7713c Set icon height in html instead of js
Fixup of d302e4fb92
2017-05-19 00:06:10 +08:00
Mike Tzou
b8d2fef653 Merge pull request #6805 from Chocobo1/icon
Fix icon too large. Closes #6804.
2017-05-18 23:54:40 +08:00
Chocobo1
d302e4fb92 [WebUI] Fix connection status icon too large. Closes #6804. 2017-05-18 23:07:40 +08:00
Eugene Shalygin
4b48f7b8d9 Fix build error. 2017-05-18 16:41:49 +02:00
Chocobo1
2702410572 Remove useless horizontal layout widget 2017-05-18 19:48:36 +08:00
Chocobo1
e24b565857 Remove unused row in "Share Ratio Limiting" group box 2017-05-18 18:40:40 +08:00
Chocobo1
fad3af27ca Partialy revert 7320ac1bc0
Reverts back options dialog size
Also removes unused tabstops
2017-05-18 18:12:32 +08:00
Vladimir Golovnev
927ecc7075 Merge pull request #4266 from naikel/seed_until
Share torrents until seeding time reaches an specific amount of minutes
2017-05-18 07:12:24 +03:00
Vladimir Golovnev
c4ccf6b774 Merge pull request #6714 from fbriere/issue/6708-sort-categories
Fix instances where categories where still sorted case-sensitively. Closes #6708.
2017-05-17 21:47:20 +03:00
Naikel Aparicio
9ba00d7035 Implemented share limit by seeding time 2017-05-17 14:33:17 -04:00
Chocobo1
08a6c75227 Refactors
Rename variables
Refactor to return early instead of introducing a scope
Revise dialog title & messages
Refactor code logic
2017-05-17 21:28:46 +08:00
Eugene Shalygin
f4a6242711 Merge pull request #6795 from evsh/fix-file-widget
Use new signal/slot syntax in options dialog
2017-05-17 13:34:54 +02:00
Mike Tzou
0838f64311 Merge pull request #6782 from Piccirello/strict-csp
Use less permissive Content Security Policy
2017-05-17 18:47:51 +08:00
Eugene Shalygin
8ca730f0d8 Use new signal/slot syntax in options dialog 2017-05-17 12:38:27 +02:00
Mike Tzou
d80abeb10f Merge pull request #6751 from thalieht/webuiUnitPrecision
WebUI: Increase the number of digits after the decimal point
2017-05-17 12:48:03 +08:00