Vladimir Golovnev
928ce940c9
Merge pull request #10346 from glassez/download-manager
...
Improve "Download manager"
2019-03-10 09:13:07 +03:00
Vladimir Golovnev (Glassez)
4ee6a0ba29
Use Qt-provided HTTP redirection handling
2019-03-08 13:06:42 +03:00
Vladimir Golovnev (Glassez)
746916a963
Use DownloadHandler behind the scenes
2019-03-08 13:00:37 +03:00
Vladimir Golovnev (Glassez)
6cb15706f5
Reduce number of DownloadManager signals
2019-03-05 11:28:29 +03:00
sledgehammer999
5c63ad3b95
Raise minimum Qt version to 5.9.0
2019-03-04 16:48:49 +02:00
thalieht
77aea3c59e
Add const to a few pointer arguments
2019-02-25 17:05:15 +02:00
thalieht
89dce36e98
Use uniform initialization on some default arguments
2019-02-25 17:05:15 +02:00
thalieht
70f1537d9f
Add const to almost all remaining vars and arguments that qualify
2019-02-25 17:05:15 +02:00
Mike Tzou
1c14a08390
Merge pull request #10296 from thalieht/clang-tidy
...
Some suggestions from Clang-tidy
2019-02-21 23:17:29 +08:00
Chocobo1
8fe1ff87f1
Limit DownloadHandler max redirection to 20
...
Closes #10219 .
2019-02-17 22:02:48 +08:00
thalieht
8c944bd4e1
Avoid repeating the return type
2019-02-16 18:54:18 +02:00
thalieht
d8cbc9266a
Use 'auto' to avoid duplicating the type name
2019-02-16 18:54:17 +02:00
Chocobo1
409557ef30
Clean up code
2019-02-15 19:47:06 +08:00
thalieht
8a3f942385
Don't use 'else' after return/break
2019-02-13 18:23:25 +02:00
Chocobo1
313a95bdd1
Log DownloadManager SSL errors
2019-02-13 20:09:08 +08:00
Vladimir Golovnev (Glassez)
302c99d7d5
Drop support of libtorrent < 1.1.10
2019-01-11 15:13:17 +03:00
Chocobo1
b7627db98c
Remove unused headers
2019-01-06 19:19:57 +08:00
Chocobo1
2b903fc3d1
Move Utils::Misc::isUrl() function
...
All usage of this function gets to call Net::DownloadManager eventually.
2018-12-31 20:00:15 +08:00
Chocobo1
2a84345835
Mark constructors as explicit
2018-12-26 12:04:40 +08:00
sledgehammer999
63cf216550
Use configured locale only for translating
...
Don't use other aspects of it eg for date formatting. We should depend
on the system locale for all these. The user probably likes it that way,
otherwise he would have changed it.
2018-12-17 00:13:28 +02:00
Chocobo1
a137f1493e
Use correct locale to display date
2018-12-08 12:19:56 +08:00
Mike Tzou
0ab5b8fcba
Merge pull request #9824 from thalieht/style
...
Convert all foreach() to range-based for()
2018-12-06 16:19:17 +08:00
Chocobo1
36429887dc
Fix wrong locale used in log message
2018-12-01 20:39:20 +08:00
thalieht
1f36b8b89f
Combine qAsConst() with copyAsConst() to asConst()
2018-11-28 23:41:23 +02:00
thalieht
6b1d26d555
Convert all foreach() to range-based for()
2018-11-28 23:40:12 +02:00
thalieht
d668a4fe6d
Fix coding style for various things
2018-11-28 23:37:35 +02:00
thalieht
94613c2fa2
Fix some warnings
2018-09-07 19:40:08 +03:00
Chocobo1
6f2b1823ad
Fix lupdate errors
...
I suspect lupdate isn't smart enough to figure out what tr() is suppose
to do, so just make it a static function in class.
The error was: tr() cannot be called without context
2018-08-13 01:24:34 +08:00
Chocobo1
517fc39950
Remove unnecessary dynamic allocation
...
Also remove unneeded `if ()` conditional.
2018-07-23 13:40:25 +08:00
Chocobo1
56766dc08b
Avoid binding constant reference to returned object
...
In such cases, it makes no sense doing so.
2018-07-23 13:40:25 +08:00
Chocobo1
0217d5b4c0
Replace single-character string with character literal
...
Also remove unnecessary dynamic allocation.
2018-07-21 23:26:15 +08:00
Vladimir Golovnev (Glassez)
f7c252886f
Apply proxy settings on DownloadManager creation
2018-07-13 13:18:57 +03:00
thalieht
456270bbb1
Delete several unused #include
2018-07-03 08:38:32 +03:00
Vladimir Golovnev (Glassez)
112a9bcfa2
Use new DownloadManager interface
2018-06-29 15:48:17 +03:00
Vladimir Golovnev (Glassez)
8d438e159c
Implement "Sequential downloading" feature
...
Closes #6835 .
2018-06-29 15:48:02 +03:00
Vladimir Golovnev (Glassez)
a9a6b74416
Implement DownloadRequest helper
2018-06-29 12:18:56 +03:00
Chocobo1
5ddbf9bba9
Replace post-increment with pre-increment
...
And post-decrement with pre-decrement.
2018-06-08 08:44:06 +08:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression
...
Revise `static` keyword usage, static is added to frequently used
instances.
2018-05-31 22:56:49 +08:00
Chocobo1
c22e6b4502
Cleanup header include order
...
Add missing header.
Cleanup license.
2018-05-31 22:56:25 +08:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral
...
Only changed instances that are initialized at program start.
2018-05-18 02:14:49 +08:00
Chocobo1
0a49f76c0a
Detect endianness at compile time
2018-05-15 21:02:00 +08:00
thalieht
4cfa163bbd
Use qt5 syntax for a few remaining SLOT()
2018-05-11 08:19:41 +03:00
thalieht
20ca90800d
Fix coding style
2018-05-09 17:06:22 +03:00
thalieht
6b4455e13d
Use qt5 connect() syntax
2018-05-09 16:08:22 +03:00
thalieht
3e4099fe5b
Replace the zeroing of pointers with nullptr
2018-04-15 13:06:31 +03:00
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash
...
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
2018-04-11 17:01:43 +03:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern
...
Don't create temporary containers just to iterate over them
2018-03-19 13:06:01 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them
...
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.
Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.
Found using clazy.
2018-03-18 16:22:12 +03:00
Chocobo1
423511765a
Fix typo
2018-03-14 23:37:08 +08:00
Chocobo1
0457fd260e
Avoid temporary QString allocations
...
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
2018-03-07 20:06:00 +08:00
thalieht
525fdd6c2b
Coding style, use nullptr and other minor things
2017-10-08 10:20:54 +03:00
Chocobo1
551ffb88ab
Define QT_USE_QSTRINGBUILDER.
...
The old defines are deprecated.
QT_USE_QSTRINGBUILDER also supports QByteArray which we use extensively
in WebUI.
2017-08-29 13:37:29 +08:00
Vladimir Golovnev (qlassez)
cff6a64e9f
Use qUtf8Printable() for logging strings
...
qDebug(), qInfo(), qWarning(), qCritical(), qFatal() expect %s arguments
to be UTF-8 encoded, while qPrintable() converts to local 8-bit encoding.
Therefore qUtf8Printable() should be used for logging strings instead of
qPrintable().
2017-08-13 16:14:57 +03:00
sledgehammer999
d3ccbe4f86
Fix format-truncation warning.
2017-06-01 01:09:25 +03:00
Eugene Shalygin
74cecb1b6c
Replace C-style casts with C++ ones
2017-05-29 17:25:42 +02:00
Chocobo1
42c17ea5ce
Fix argument name differ in definition & declaration
2017-05-09 14:12:36 +08:00
sledgehammer999
0a5bb6685f
Merge pull request #6654 from Chocobo1/persistence
...
Webui server fixes
2017-04-30 16:34:23 +03:00
Eugene Shalygin
c4e16aa820
cmake: set warning and error options
...
The set is far from perfect, but guards against common errors with GCC.
2017-04-29 13:30:28 +02:00
Vladimir Golovnev (Glassez)
989a70fe60
Redesign RSS subsystem
2017-04-23 09:03:46 +03:00
Chocobo1
617f19e599
Revise Utils::Gzip::decompress
...
Rename from uncompress to decompress
Change signature
Use proper casting
Use larger buffer for the output of inflate()
Reserve 1 MBytes for output buffer
Change function signature
2017-04-20 22:26:35 +08:00
Eugene Shalygin
0bf7fa15c1
Replace wrappers in base/utils/fs.h with Profile::SpecialFolders::location()
2017-04-12 00:50:33 +02:00
Chocobo1
2091dfaa69
Follow http user-agent format
...
Add version variable without the starting "v"
2017-03-06 14:42:32 +08:00
Chocobo1
cb1646be32
Prepend QBT_ for preprocessor variables
2017-03-06 13:41:58 +08:00
Eugene Shalygin
e64bb1de8c
Drop Qt 4 support
2017-03-05 22:24:59 +01:00
sledgehammer999
ba03fb30f3
Merge pull request #5987 from Chocobo1/temp_dir
...
Put temp files in .qBittorrent directory
2017-01-19 01:33:57 +02:00
Chocobo1
ab187f06da
Fix unused variable warnings
2016-12-07 01:31:39 +08:00
Chocobo1
cffa729ac5
Put temp files in .qBittorrent directory. Closes #4462 .
2016-12-01 01:39:27 +08:00
sledgehammer999
6053390bf5
Unify and simplify setting to use proxy for torrents only.
2016-11-01 03:41:51 +02:00
sledgehammer999
1757973f88
Misc fixes.
2016-11-01 03:41:40 +02:00
sledgehammer999
124eddc68c
Merge pull request #5342 from glassez/session
...
Optimize BitTorrent::Session settings applying
2016-11-01 03:02:29 +02:00
sledgehammer999
3ea81be2cc
Merge pull request #5731 from thalieht/webui_port
...
Fix WEBUI port overflow
2016-09-13 23:54:01 +03:00
thalieht
6ec1c61b06
fix webui port overflow
2016-09-11 23:41:14 +03:00
ngosang
83d6a28030
Fix warning in geoipdatabase.cpp
2016-08-29 22:11:05 +02:00
sledgehammer999
d411d8b3a1
Merge pull request #5549 from briankendall/smtp_ssl_bug_fixes
...
Fixes bug where sending email could silently fail
2016-08-25 20:45:11 -05:00
SagePtr
c63da264d7
Update geoipdatabase.cpp
...
Updated MaxMind database limit from 10MB to 64MB. I hope it will be enough
for few years. Fix for issue #5609
2016-08-26 02:23:17 +02:00
Brian Kendall
da412571e4
Better error handling with smtp communication.
...
Adds log messages for a number of situations where sending an email will silently fail, in particular when attempting to create an unencrypted connection to an SMTP server that requires SSL
2016-08-25 17:57:26 -04:00
Vladimir Golovnev (Glassez)
b5fe749f0b
Use new libtorrent-1.1 settings API
2016-06-20 08:30:02 +03:00
Vladimir Golovnev (Glassez)
b2cb473b63
Don't use Preferences in BitTorrent::Session
2016-06-20 08:30:02 +03:00
Vladimir Golovnev (Glassez)
c982813acb
Create basic cookies management dialog
2016-04-11 19:14:28 +03:00
funkydude
268a5a95c8
Move some URLs overs to https
2016-03-14 17:01:51 +00:00
Chocobo1
f83f3b84ca
Follow project coding style. Issue #2192 .
2016-02-22 03:18:37 +08:00
Chocobo1
60417a598a
Simplify statement
2016-02-22 03:18:35 +08:00
Chocobo1
41fe85b624
Fix malformed date header in email. Closes #4828 .
2016-02-22 03:18:02 +08:00
Vladimir Golovnev (Glassez)
ea8acf3bbd
Fix unitialized scalar field bugs
2016-01-15 09:44:10 +03:00
Vladimir Golovnev (Glassez)
4965704b10
Fix NetworkCookieJar::deleteCookie() behavior to match Qt5 one
2016-01-13 20:24:54 +03:00
Vladimir Golovnev (qlassez)
881108057d
Use DownloadManager by DNSUpdater
2016-01-04 05:51:50 +03:00
Vladimir Golovnev (qlassez)
e378a65508
Use DownloadManager by ProgramUpdater
...
Closes #2023
2016-01-04 05:49:02 +03:00
Vladimir Golovnev (qlassez)
0bffa066db
Make DownloadManager to save/load cookies
2015-12-22 14:02:14 +03:00
Chocobo1
d203f39f0a
Update ISO 3166 country codes. Closes #3942 .
2015-12-07 09:44:55 +08:00
Vladimir Golovnev (Glassez)
9db93e5d8f
Rename Core to Base ( Closes #3733 ).
2015-12-06 14:27:00 +03:00