Commit graph

16 commits

Author SHA1 Message Date
Luís Pereira
1a913c502b Prevent possible c++11 range-loop container detach
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.

In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.

For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.

Intended uses:

    QString s = ...;
    for (const auto &ch : qAsConst(s))
          process(ch);

    for (const auto &ch : copyAsConst(funcReturningQString()))
        process(ch);
2018-02-20 19:28:51 +00:00
thalieht
ae1634623e Coding style for many files 2017-11-20 23:29:59 +02:00
Chocobo1
4ad541d066 Fix coverity issues
torrentcontentmodel: Use a variable to store filesCount
optionsdlg: add fallthrough comment to suppress warning
speedPlotview: initialize member
misc: fix wrong type used, add spaces
2017-02-08 13:49:47 +08:00
Chocobo1
11c2ee81c1 Fix warning C4267.
conversion from 'size_t' to 'int', possible loss of data.
2016-12-02 15:32:27 +08:00
Daniel Segesdi
76580e4766 Fix 6-hour speedplot point push rate. Close #5545 2016-08-02 10:59:01 +02:00
sledgehammer999
cd4f288f67 Follow project coding style. Issue #2192. 2016-04-13 01:53:54 +03:00
Anton Lashkov
cdab0bb140 SpeedPlotView: code correction 2016-04-04 23:05:25 +04:00
Anton Lashkov
8a6866d409 SpeedPlotView: Simplify code using PointData struct 2016-04-04 23:05:25 +04:00
Anton Lashkov
b599a8e2fb SpeedPlotView: Use separate buffers for periods with reduce number of points. Fix coding style. 2016-04-04 23:05:25 +04:00
Anton Lashkov
baadf34134 SpeedPlotView: Save int's instead of double's 2016-04-04 23:05:25 +04:00
Anton Lashkov
dd9728334a SpeedPlotView: Replace QQueue by boost::circular_buffer, reduce number of points to draw, increase legend background size 2016-04-04 23:05:25 +04:00
Vladimir Golovnev (Glassez)
9db93e5d8f Rename Core to Base (Closes #3733). 2015-12-06 14:27:00 +03:00
Chocobo1
a74bac20c4 Fix Speed graph legend is illegible on dark background. Closes #4134. 2015-11-18 14:41:29 +08:00
Anton Lashkov
0d74131edd SpeedPlotView: fix render graphs with zero speed 2015-08-29 11:24:51 +04:00
sledgehammer999
0b20794672 Fixup speedwidget code. 2015-07-18 19:31:51 +03:00
Anton Lashkov
7b736b6ae3 Add speedwidget based on QGraphicsView 2015-07-18 00:54:36 +04:00